35495 2010-02-28 09:10:50 -0800 [chromium] inverted logic in per-strike renderer patch 2010-03-18 08:42:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 evan agl agl commit-queue fishd tony oldest_to_newest 194578 0 evan 2010-02-28 09:10:50 -0800 [chromium] inverted logic in per-strike renderer patch 194579 1 49699 evan 2010-02-28 09:11:34 -0800 Created attachment 49699 Patch 194746 2 fishd 2010-03-01 11:38:57 -0800 I'd like Adam Langley to review this patch. If he's happy, then LGTM. 194748 3 fishd 2010-03-01 11:39:26 -0800 Also, is there a way to write a layout test for this? 194844 4 49699 levin 2010-03-01 15:31:05 -0800 Comment on attachment 49699 Patch Needs a layout test, or explanation of why a layout test isn't needed or isn't possible. 195097 5 agl 2010-03-02 10:26:45 -0800 Am working on Chrome side changes to enable a layout test of this change. 197178 6 50223 agl 2010-03-08 08:17:13 -0800 Created attachment 50223 patch 197835 7 50223 fishd 2010-03-09 16:24:51 -0800 Comment on attachment 50223 patch > +++ b/LayoutTests/fast/text/chromium-linux-fontconfig-renderstyle.html shouldn't there be some expected results for this test for other platforms? or should the test be skipped on other platforms? if not, then perhaps the test should not be named "chromium-linux-*"? 198128 8 agl 2010-03-10 07:35:07 -0800 (In reply to comment #7) > shouldn't there be some expected results for this test for other platforms? > or should the test be skipped on other platforms? if not, then perhaps the > test should not be named "chromium-linux-*"? The Chrome special layout tests seem to have disappeared, and I obviously can't include expected results until the patch is committed. If there's a test-expectations.txt like way to tell the webkit.org builders not to run a given test I'm afraid I don't know it. (I guess I mostly don't understand your comment, sorry!) 198154 9 evan 2010-03-10 08:27:31 -0800 It's suboptimal, but there it is: $ git ls-files | grep Skipped LayoutTests/platform/gtk/Skipped LayoutTests/platform/mac-leopard/Skipped LayoutTests/platform/mac-snowleopard/Skipped LayoutTests/platform/mac-tiger/Skipped LayoutTests/platform/mac/Skipped LayoutTests/platform/qt-linux/Skipped LayoutTests/platform/qt-mac/Skipped LayoutTests/platform/qt-win/Skipped LayoutTests/platform/qt/Skipped LayoutTests/platform/win/Skipped I'm not sure how a port-specific layout test is supposed to work. 198426 10 tony 2010-03-10 17:04:25 -0800 It looks like LayoutTests/platform/chromium already exists. Can you move the test there and put the expected png and txt file there? It should then be automatically skipped by the other webkit ports. 198639 11 50506 agl 2010-03-11 08:26:18 -0800 Created attachment 50506 patch Have moved the test into platform/chromium. I haven't included any expected results partly because --new-baseline is broken (that's a different issue) but mostly because it doesn't make any sense: the results will be different for each platform, so we can't put one set in platform/chromium. Also, our baselines are still carried in our Chromium tree I think. 201318 12 50506 commit-queue 2010-03-18 08:41:57 -0700 Comment on attachment 50506 patch Clearing flags on attachment: 50506 Committed r56162: <http://trac.webkit.org/changeset/56162> 201319 13 commit-queue 2010-03-18 08:42:02 -0700 All reviewed patches have been landed. Closing bug. 49699 2010-02-28 09:11:34 -0800 2010-03-11 08:26:18 -0800 Patch bug-35495-20100228181132.patch text/plain 1316 evan ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Mjg5OGUxYS4uOTBiNjc1MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMi0yOCAgRXZhbiBNYXJ0aW4g IDxldmFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbY2hyb21pdW1dIGludmVydGVkIGxvZ2ljIGluIHBlci1zdHJpa2UgcmVu ZGVyZXIgcGF0Y2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM1NDk1CisKKyAgICAgICAgRnJvbSBhIHBhdGNoIGZyb20gUm9tYW4gVHNpc3lrIChyb21h bkB0c2lzeWsuY29tKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0Zv bnRQbGF0Zm9ybURhdGFMaW51eC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb250UGxhdGZvcm1E YXRhOjpxdWVyeVN5c3RlbUZvclJlbmRlclN0eWxlKToKKwogMjAxMC0wMi0yNiAgTGVhbmRybyBQ ZXJlaXJhICA8bGVhbmRyb0Bwcm9mdXNpb24ubW9iaT4KIAogICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0Zv bnRQbGF0Zm9ybURhdGFMaW51eC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL0ZvbnRQbGF0Zm9ybURhdGFMaW51eC5jcHAKaW5kZXggNmI0OWEyNC4uMjUwN2FjNyAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250UGxhdGZvcm1E YXRhTGludXguY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9u dFBsYXRmb3JtRGF0YUxpbnV4LmNwcApAQCAtMTk3LDcgKzE5Nyw3IEBAIEhCX0ZhY2VSZWNfKiBG b250UGxhdGZvcm1EYXRhOjpoYXJmYnV6ekZhY2UoKSBjb25zdAogCiB2b2lkIEZvbnRQbGF0Zm9y bURhdGE6OnF1ZXJ5U3lzdGVtRm9yUmVuZGVyU3R5bGUoKQogewotICAgIGlmIChtX2ZhbWlseS5s ZW5ndGgoKSkgeworICAgIGlmICghbV9mYW1pbHkubGVuZ3RoKCkpIHsKICAgICAgICAgLy8gV2Ug ZG9uJ3QgaGF2ZSBhIGZhbWlseSBmb3IgdGhpcy4gUHJvYmFibHkgYmVjYXVzZSBpdCdzIGEgd2Vi Zm9udC4gV2UKICAgICAgICAgLy8gc2V0IGFsbCB0aGUgdmFsdWVzIHRvICdubyBwcmVmZXJlbmNl JyBhbmQgdGFrZSB0aGUgZGVmYXVsdHMgcGFzc2VkCiAgICAgICAgIC8vIGluIGZyb20gWFNFVFRJ TkdTLgo= 50223 2010-03-08 08:17:13 -0800 2010-03-11 08:26:18 -0800 patch patch text/plain 2825 agl ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyODgwNGYyLi4wOTk5NzhkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMt MDggIEFkYW0gTGFuZ2xleSAgPGFnbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBGaXggaW52ZXJ0ZWQgbG9n aWMgaW4gcGVyLXN0cmlrZSByZW5kZXJlciBwYXRjaC4KKworICAgICAgICBJIHNjcmV3ZWQgdXAg aW4gcjU1MDg5IGFuZCBnb3Qgb25lIG9mIHRoZSBjb25kaXRpb25zIGJhY2t3YXJkcy4gVGhhbmtz CisgICAgICAgIHRvIFJvbWFuIFRzaXN5ayBmb3IgcG9pbnRpbmcgaXQgb3V0LgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTQ5NQorCisgICAgICAg ICogZmFzdC90ZXh0L2Nocm9taXVtLWxpbnV4LWZvbnRjb25maWctcmVuZGVyc3R5bGUuaHRtbDog QWRkZWQuCisKIDIwMTAtMDMtMDggIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9y b25oYUBjb2xsYWJvcmEuY28udWs+CiAKICAgICAgICAgTm8gcmV2aWV3LCByb2xsaW5nIG91dCBy NTU2NjIuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3RleHQvY2hyb21pdW0tbGludXgt Zm9udGNvbmZpZy1yZW5kZXJzdHlsZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2Nocm9t aXVtLWxpbnV4LWZvbnRjb25maWctcmVuZGVyc3R5bGUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwLi4xMjJiZjVlCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC90ZXh0L2Nocm9taXVtLWxpbnV4LWZvbnRjb25maWctcmVuZGVyc3R5bGUuaHRtbApAQCAt MCwwICsxLDE0IEBACis8aHRtbD4KKyAgPGhlYWQ+CisgICAgPHN0eWxlPgorICAgICAgcC5hbGlh c2VkIHsKKyAgICAgICAgZm9udC1mYW1pbHk6ICJOb25BbnRpQWxpYXNlZFNhbnMiOworICAgICAg fQorICAgIDwvc3R5bGU+CisgIDwvaGVhZD4KKyAgPGJvZHk+CisgICAgPHA+T24gQ2hyb21pdW0g TGludXggd2l0aCA8dHQ+dGVzdF9zaGVsbDwvdHQ+IGluIDx0dD4tLWxheW91dC10ZXN0PC90dD4g bW9kZSA8aT5vbmx5PC9pPiB0aGUgZm9sbG93aW5nIHRleHQgc2hvdWxkIHJlbmRlciB3aXRob3V0 IGFudGktYWxpYXNpbmc6PC9wPgorCisgICAgPHAgY2xhc3M9ImFsaWFzZWQiPlRlc3RpbmcgZm9u dGNvbmZpZyByZW5kZXIgcHJlZmVyZW5jZXMuPC9wPgorICA8L2JvZHk+Cis8L2h0bWw+CmRpZmYg LS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDkyZDc2 YTkuLjQzODVmMmEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDMtMDggIEFkYW0gTGFuZ2xleSAgPGFn bEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW2Nocm9taXVtXSBGaXggaW52ZXJ0ZWQgbG9naWMgaW4gcGVyLXN0cmlrZSByZW5k ZXJlciBwYXRjaC4KKworICAgICAgICBJIHNjcmV3ZWQgdXAgaW4gcjU1MDg5IGFuZCBnb3Qgb25l IG9mIHRoZSBjb25kaXRpb25zIGJhY2t3YXJkcy4gVGhhbmtzCisgICAgICAgIHRvIFJvbWFuIFRz aXN5ayBmb3IgcG9pbnRpbmcgaXQgb3V0LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zNTQ5NQorCisgICAgICAgIFRlc3Q6IGZhc3QvdGV4dC9jaHJv bWl1bS1saW51eC1mb250Y29uZmlnLXJlbmRlcnN0eWxlLmh0bWwKKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRQbGF0Zm9ybURhdGFMaW51eC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpGb250UGxhdGZvcm1EYXRhOjpxdWVyeVN5c3RlbUZvclJlbmRlclN0eWxlKToK KwogMjAxMC0wMy0wNCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRQbGF0Zm9ybURhdGFMaW51eC5jcHAgYi9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRQbGF0Zm9ybURhdGFMaW51eC5jcHAK aW5kZXggNmI0OWEyNC4uMjUwN2FjNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9Gb250UGxhdGZvcm1EYXRhTGludXguY3BwCisrKyBiL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udFBsYXRmb3JtRGF0YUxpbnV4LmNwcApAQCAtMTk3 LDcgKzE5Nyw3IEBAIEhCX0ZhY2VSZWNfKiBGb250UGxhdGZvcm1EYXRhOjpoYXJmYnV6ekZhY2Uo KSBjb25zdAogCiB2b2lkIEZvbnRQbGF0Zm9ybURhdGE6OnF1ZXJ5U3lzdGVtRm9yUmVuZGVyU3R5 bGUoKQogewotICAgIGlmIChtX2ZhbWlseS5sZW5ndGgoKSkgeworICAgIGlmICghbV9mYW1pbHku bGVuZ3RoKCkpIHsKICAgICAgICAgLy8gV2UgZG9uJ3QgaGF2ZSBhIGZhbWlseSBmb3IgdGhpcy4g UHJvYmFibHkgYmVjYXVzZSBpdCdzIGEgd2ViZm9udC4gV2UKICAgICAgICAgLy8gc2V0IGFsbCB0 aGUgdmFsdWVzIHRvICdubyBwcmVmZXJlbmNlJyBhbmQgdGFrZSB0aGUgZGVmYXVsdHMgcGFzc2Vk CiAgICAgICAgIC8vIGluIGZyb20gWFNFVFRJTkdTLgo= 50506 2010-03-11 08:26:18 -0800 2010-03-18 08:41:57 -0700 patch patch text/plain 2875 agl ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2MGYzNzUyLi4xMGIzYTQ2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMt MDggIEFkYW0gTGFuZ2xleSAgPGFnbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBGaXggaW52ZXJ0ZWQgbG9n aWMgaW4gcGVyLXN0cmlrZSByZW5kZXJlciBwYXRjaC4KKworICAgICAgICBJIHNjcmV3ZWQgdXAg aW4gcjU1MDg5IGFuZCBnb3Qgb25lIG9mIHRoZSBjb25kaXRpb25zIGJhY2t3YXJkcy4gVGhhbmtz CisgICAgICAgIHRvIFJvbWFuIFRzaXN5ayBmb3IgcG9pbnRpbmcgaXQgb3V0LgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTQ5NQorCisgICAgICAg ICogcGxhdGZvcm0vY2hyb21pdW0vZmFzdC90ZXh0L2Nocm9taXVtLWxpbnV4LWZvbnRjb25maWct cmVuZGVyc3R5bGUuaHRtbDogQWRkZWQuCisKIDIwMTAtMDMtMTEgIENocmlzIEZsZWl6YWNoICA8 Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vZmFzdC90ZXh0L2Nocm9taXVtLWxpbnV4LWZv bnRjb25maWctcmVuZGVyc3R5bGUuaHRtbCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVt L2Zhc3QvdGV4dC9jaHJvbWl1bS1saW51eC1mb250Y29uZmlnLXJlbmRlcnN0eWxlLmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMTIyYmY1ZQotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2Zhc3QvdGV4dC9jaHJvbWl1bS1saW51 eC1mb250Y29uZmlnLXJlbmRlcnN0eWxlLmh0bWwKQEAgLTAsMCArMSwxNCBAQAorPGh0bWw+Cisg IDxoZWFkPgorICAgIDxzdHlsZT4KKyAgICAgIHAuYWxpYXNlZCB7CisgICAgICAgIGZvbnQtZmFt aWx5OiAiTm9uQW50aUFsaWFzZWRTYW5zIjsKKyAgICAgIH0KKyAgICA8L3N0eWxlPgorICA8L2hl YWQ+CisgIDxib2R5PgorICAgIDxwPk9uIENocm9taXVtIExpbnV4IHdpdGggPHR0PnRlc3Rfc2hl bGw8L3R0PiBpbiA8dHQ+LS1sYXlvdXQtdGVzdDwvdHQ+IG1vZGUgPGk+b25seTwvaT4gdGhlIGZv bGxvd2luZyB0ZXh0IHNob3VsZCByZW5kZXIgd2l0aG91dCBhbnRpLWFsaWFzaW5nOjwvcD4KKwor ICAgIDxwIGNsYXNzPSJhbGlhc2VkIj5UZXN0aW5nIGZvbnRjb25maWcgcmVuZGVyIHByZWZlcmVu Y2VzLjwvcD4KKyAgPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VM b2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzNTJkYmRjLi5hNzE0YTk0IDEwMDY0NAotLS0g YS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEwLTAzLTA4ICBBZGFtIExhbmdsZXkgIDxhZ2xAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gRml4 IGludmVydGVkIGxvZ2ljIGluIHBlci1zdHJpa2UgcmVuZGVyZXIgcGF0Y2guCisKKyAgICAgICAg SSBzY3Jld2VkIHVwIGluIHI1NTA4OSBhbmQgZ290IG9uZSBvZiB0aGUgY29uZGl0aW9ucyBiYWNr d2FyZHMuIFRoYW5rcworICAgICAgICB0byBSb21hbiBUc2lzeWsgZm9yIHBvaW50aW5nIGl0IG91 dC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzU0 OTUKKworICAgICAgICBUZXN0OiBwbGF0Zm9ybS9jaHJvbWl1bS9mYXN0L3RleHQvY2hyb21pdW0t bGludXgtZm9udGNvbmZpZy1yZW5kZXJzdHlsZS5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9Gb250UGxhdGZvcm1EYXRhTGludXguY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Rm9udFBsYXRmb3JtRGF0YTo6cXVlcnlTeXN0ZW1Gb3JSZW5kZXJTdHlsZSk6CisKIDIw MTAtMDMtMTAgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEplcmVteSBPcmxvdy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vRm9udFBsYXRmb3JtRGF0YUxpbnV4LmNwcCBiL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udFBsYXRmb3JtRGF0YUxpbnV4LmNwcAppbmRleCA2 YjQ5YTI0Li4yNTA3YWM3IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL0ZvbnRQbGF0Zm9ybURhdGFMaW51eC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9Gb250UGxhdGZvcm1EYXRhTGludXguY3BwCkBAIC0xOTcsNyArMTk3 LDcgQEAgSEJfRmFjZVJlY18qIEZvbnRQbGF0Zm9ybURhdGE6OmhhcmZidXp6RmFjZSgpIGNvbnN0 CiAKIHZvaWQgRm9udFBsYXRmb3JtRGF0YTo6cXVlcnlTeXN0ZW1Gb3JSZW5kZXJTdHlsZSgpCiB7 Ci0gICAgaWYgKG1fZmFtaWx5Lmxlbmd0aCgpKSB7CisgICAgaWYgKCFtX2ZhbWlseS5sZW5ndGgo KSkgewogICAgICAgICAvLyBXZSBkb24ndCBoYXZlIGEgZmFtaWx5IGZvciB0aGlzLiBQcm9iYWJs eSBiZWNhdXNlIGl0J3MgYSB3ZWJmb250LiBXZQogICAgICAgICAvLyBzZXQgYWxsIHRoZSB2YWx1 ZXMgdG8gJ25vIHByZWZlcmVuY2UnIGFuZCB0YWtlIHRoZSBkZWZhdWx0cyBwYXNzZWQKICAgICAg ICAgLy8gaW4gZnJvbSBYU0VUVElOR1MuCg==