35489 2010-02-27 21:47:21 -0800 Resizing requests are triggered only for uniform content size changes 2010-03-01 14:07:54 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 zuh webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 194556 0 49693 zuh 2010-02-27 21:47:21 -0800 Created attachment 49693 Patch to trigger resizes when either of content dimensions change ChromeClient::contentsSizeChanged() currently only triggers resizing if both dimensions change, this is seems obviously wrong. 194557 1 webkit.review.bot 2010-02-27 21:51:08 -0800 Attachment 49693 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:433: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 194558 2 49694 zuh 2010-02-27 21:54:50 -0800 Created attachment 49694 Re-made patch to fix (original) style issues 194726 3 49694 gustavo 2010-03-01 10:23:49 -0800 Comment on attachment 49694 Re-made patch to fix (original) style issues Thanks for the patch! 194814 4 49694 commit-queue 2010-03-01 14:07:50 -0800 Comment on attachment 49694 Re-made patch to fix (original) style issues Clearing flags on attachment: 49694 Committed r55378: <http://trac.webkit.org/changeset/55378> 194815 5 commit-queue 2010-03-01 14:07:54 -0800 All reviewed patches have been landed. Closing bug. 49693 2010-02-27 21:47:21 -0800 2010-02-27 21:54:50 -0800 Patch to trigger resizes when either of content dimensions change fix-resize-queuing.patch text/plain 1388 zuh ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggYTRhYTIzMS4uODJjMGMxNCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wMi0yNyAg S2FsbGUgVmFobG1hbiAgPHp1aEBpa2kuZmk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUXVldWUgYSByZXNpemUgd2hlbiBlaXRoZXIgb2YgdGhlIGNv bnRlbnQgZGltZW5zaW9ucyBjaGFuZ2UKKworICAgICAgICBUaGUgY2hlY2sgZm9yIHNpemUgY2hh bmdlcyBvbmx5IHF1ZXVlZCBhIHJlc2l6ZSBpZiBib3RoIG9mIHRoZSBjb250ZW50CisgICAgICAg IGRpbWVuc2lvbnMgY2hhbmdlLCBsZWF2aW5nIHRoZSB3aWRnZXQgc2l6ZSBvdXQtb2Ytc3luYyBp ZiBlZy4gb25seSB0aGUKKyAgICAgICAgd2lkdGggY2hhbmdlcy4KKworICAgICAgICBOZWVkIGEg c2hvcnQgZGVzY3JpcHRpb24gYW5kIGJ1ZyBVUkwgKE9PUFMhKQorCisgICAgICAgICogV2ViQ29y ZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcDoKKwogMjAxMC0wMi0yMiAgWGFuIExvcGV6ICA8 eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR3VzdGF2byBOb3Jvbmhh LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRHdGsu Y3BwIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwCmluZGV4 IDc0ZjVlMDcuLjIwYTQyNDMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQv Q2hyb21lQ2xpZW50R3RrLmNwcAorKysgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9t ZUNsaWVudEd0ay5jcHAKQEAgLTQzMCw3ICs0MzAsNyBAQCB2b2lkIENocm9tZUNsaWVudDo6Y29u dGVudHNTaXplQ2hhbmdlZChGcmFtZSogZnJhbWUsIGNvbnN0IEludFNpemUmIHNpemUpIGNvbnN0 CiAgICAgLy8gb3RoZXJ3aXNlIHdlIGdldCBpbnRvIGFuIGluZmluaXRlIGxvb3AhCiAgICAgR3Rr V2lkZ2V0KiB3aWRnZXQgPSBHVEtfV0lER0VUKG1fd2ViVmlldyk7CiAgICAgaWYgKEdUS19XSURH RVRfUkVBTElaRUQod2lkZ2V0KSAmJgotICAgICAgICAod2lkZ2V0LT5yZXF1aXNpdGlvbi5oZWln aHQgIT0gc2l6ZS5oZWlnaHQoKSkgJiYKKyAgICAgICAgKHdpZGdldC0+cmVxdWlzaXRpb24uaGVp Z2h0ICE9IHNpemUuaGVpZ2h0KCkpIHx8CiAgICAgICAgICh3aWRnZXQtPnJlcXVpc2l0aW9uLndp ZHRoICE9IHNpemUud2lkdGgoKSkpCiAgICAgICAgIGd0a193aWRnZXRfcXVldWVfcmVzaXplX25v X3JlZHJhdyh3aWRnZXQpOwogfQo= 49694 2010-02-27 21:54:50 -0800 2010-03-01 14:07:50 -0800 Re-made patch to fix (original) style issues fix-resize-queuing.patch text/plain 1551 zuh ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggYTRhYTIzMS4uNDE2YjVlOSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMi0yNyAg S2FsbGUgVmFobG1hbiAgPHp1aEBpa2kuZmk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUXVldWUgYSByZXNpemUgd2hlbiBlaXRoZXIgb2YgdGhlIGNv bnRlbnQgZGltZW5zaW9ucyBjaGFuZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTM1NDg5CisKKyAgICAgICAgVGhlIGNoZWNrIGZvciBzaXplIGNoYW5n ZXMgb25seSBxdWV1ZWQgYSByZXNpemUgaWYgYm90aCBvZiB0aGUgY29udGVudAorICAgICAgICBk aW1lbnNpb25zIGNoYW5nZSwgbGVhdmluZyB0aGUgd2lkZ2V0IHNpemUgb3V0LW9mLXN5bmMgaWYg ZWcuIG9ubHkgdGhlCisgICAgICAgIHdpZHRoIGNoYW5nZXMuCisKKyAgICAgICAgKiBXZWJDb3Jl U3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwOgorCiAyMDEwLTAyLTIyICBYYW4gTG9wZXogIDx4 bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHdXN0YXZvIE5vcm9uaGEu CmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5j cHAgYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHAKaW5kZXgg NzRmNWUwNy4uZDRjY2U4YSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9D aHJvbWVDbGllbnRHdGsuY3BwCisrKyBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hyb21l Q2xpZW50R3RrLmNwcApAQCAtNDI5LDkgKzQyOSw5IEBAIHZvaWQgQ2hyb21lQ2xpZW50Ojpjb250 ZW50c1NpemVDaGFuZ2VkKEZyYW1lKiBmcmFtZSwgY29uc3QgSW50U2l6ZSYgc2l6ZSkgY29uc3QK ICAgICAvLyBXZSBuZWVkIHRvIHF1ZXVlIGEgcmVzaXplIHJlcXVlc3Qgb25seSBpZiB0aGUgc2l6 ZSBjaGFuZ2VkLAogICAgIC8vIG90aGVyd2lzZSB3ZSBnZXQgaW50byBhbiBpbmZpbml0ZSBsb29w IQogICAgIEd0a1dpZGdldCogd2lkZ2V0ID0gR1RLX1dJREdFVChtX3dlYlZpZXcpOwotICAgIGlm IChHVEtfV0lER0VUX1JFQUxJWkVEKHdpZGdldCkgJiYKLSAgICAgICAgKHdpZGdldC0+cmVxdWlz aXRpb24uaGVpZ2h0ICE9IHNpemUuaGVpZ2h0KCkpICYmCi0gICAgICAgICh3aWRnZXQtPnJlcXVp c2l0aW9uLndpZHRoICE9IHNpemUud2lkdGgoKSkpCisgICAgaWYgKEdUS19XSURHRVRfUkVBTEla RUQod2lkZ2V0KQorICAgICAgICAmJiAod2lkZ2V0LT5yZXF1aXNpdGlvbi5oZWlnaHQgIT0gc2l6 ZS5oZWlnaHQoKSkKKyAgICAgICAgfHwgKHdpZGdldC0+cmVxdWlzaXRpb24ud2lkdGggIT0gc2l6 ZS53aWR0aCgpKSkKICAgICAgICAgZ3RrX3dpZGdldF9xdWV1ZV9yZXNpemVfbm9fcmVkcmF3KHdp ZGdldCk7CiB9CiAK