35477 2010-02-27 06:27:14 -0800 Web Inspector: disable breakpoint upon Shift-click. 2010-03-01 02:12:20 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein joepeck rik timothy oldest_to_newest 194499 0 pfeldman 2010-02-27 06:27:14 -0800 - Also contains drive-by fix for line number gutter (it should have fixed width matching the maximum line number). - Removes devtools code that has been upstreamed earlier. 194501 1 49681 pfeldman 2010-02-27 06:32:43 -0800 Created attachment 49681 [PATCH] Proposed fix. 194554 2 49681 timothy 2010-02-27 21:24:48 -0800 Comment on attachment 49681 [PATCH] Proposed fix. Why shift and not option/alt? I think option/alt is the more prefered key. Is there another IDE that does this with shift? 194575 3 pfeldman 2010-02-28 07:39:37 -0800 (In reply to comment #2) > (From update of attachment 49681 [details]) > Why shift and not option/alt? I think option/alt is the more prefered key. > > Is there another IDE that does this with shift? Not exactly an IDE, but still: http://getfirebug.com/wiki/index.php/Keyboard_and_Mouse_Shortcuts 194658 4 pfeldman 2010-03-01 02:12:20 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ConsoleView.js M WebCore/inspector/front-end/SourceFrame.js M WebCore/inspector/front-end/textViewer.css M WebKit/chromium/ChangeLog M WebKit/chromium/src/js/DevTools.js Committed r55364 49681 2010-02-27 06:32:43 -0800 2010-02-28 07:40:06 -0800 [PATCH] Proposed fix. shift_click text/plain 5400 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzE2NjgyMC4uZDIxN2ZlZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxMC0wMi0yNyAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBkaXNhYmxlIGJyZWFrcG9pbnQgdXBv biBTaGlmdC1jbGljay4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzU0NzcKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZp ZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90eXBlLl9mb3Jt YXQpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU291cmNlRnJhbWUuanM6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuU291cmNlRnJhbWUucHJvdG90eXBlLl9tb3VzZURvd24pOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLlNvdXJjZUZyYW1lLnByb3RvdHlwZS5fbW91c2VNb3ZlKToKKyAg ICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL3RleHRWaWV3ZXIuY3NzOgorCisyMDEwLTAyLTI3 ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFJldmll d2VkIGJ5IFRpbW90aHkgSGF0Y2hlci4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSRUdSRVNT SU9OOiBoYW5ncyB3aGVuIHNjcm9sbGluZyBpbiBSZXNvdXJjZSBwYW5lLgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzIGIvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzCmluZGV4IDQ4OWM3ODkuLjhkMjA2YTkgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5qcworKysg Yi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMKQEAgLTUxNyw3ICs1 MTcsNyBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90eXBlID0gewogICAgICAgICB2 YXIgZm9ybWF0dGVyID0gdGhpcy5fY3VzdG9tRm9ybWF0dGVyc1t0eXBlXTsKICAgICAgICAgaWYg KCFmb3JtYXR0ZXIgfHwgIWlzUHJveHkpIHsKICAgICAgICAgICAgIGZvcm1hdHRlciA9IHRoaXMu X2Zvcm1hdHZhbHVlOwotICAgICAgICAgICAgb3V0cHV0ID0gb3V0cHV0LmRlc2NyaXB0aW9uIHx8 IG91dHB1dDsKKyAgICAgICAgICAgIG91dHB1dCA9IG91dHB1dC5kZXNjcmlwdGlvbjsKICAgICAg ICAgfQogCiAgICAgICAgIHZhciBzcGFuID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgic3BhbiIp OwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NvdXJjZUZyYW1lLmpz IGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NvdXJjZUZyYW1lLmpzCmluZGV4IDExODQz MDAuLmRiYzFhN2IgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3Vy Y2VGcmFtZS5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU291cmNlRnJhbWUu anMKQEAgLTQzNSw3ICs0MzUsNyBAQCBXZWJJbnNwZWN0b3IuU291cmNlRnJhbWUucHJvdG90eXBl ID0gewogICAgIHsKICAgICAgICAgdGhpcy5fcmVzZXRIb3ZlclRpbWVyKCk7CiAgICAgICAgIHRo aXMuX2hpZGVQb3B1cCgpOwotICAgICAgICBpZiAoZXZlbnQuYnV0dG9uICE9IDAgfHwgZXZlbnQu YWx0S2V5IHx8IGV2ZW50LmN0cmxLZXkgfHwgZXZlbnQubWV0YUtleSB8fCBldmVudC5zaGlmdEtl eSkKKyAgICAgICAgaWYgKGV2ZW50LmJ1dHRvbiAhPSAwIHx8IGV2ZW50LmFsdEtleSB8fCBldmVu dC5jdHJsS2V5IHx8IGV2ZW50Lm1ldGFLZXkpCiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAg IGlmIChldmVudC50YXJnZXQuY2xhc3NOYW1lICE9PSAid2Via2l0LWxpbmUtbnVtYmVyIikKICAg ICAgICAgICAgIHJldHVybjsKQEAgLTQ0NCw5ICs0NDQsMTIgQEAgV2ViSW5zcGVjdG9yLlNvdXJj ZUZyYW1lLnByb3RvdHlwZSA9IHsKICAgICAgICAgdmFyIGxpbmVOdW1iZXIgPSByb3cubGluZU51 bWJlcjsKIAogICAgICAgICB2YXIgYnJlYWtwb2ludCA9IHRoaXMuX3RleHRNb2RlbC5nZXRBdHRy aWJ1dGUobGluZU51bWJlciwgImJyZWFrcG9pbnQiKTsKLSAgICAgICAgaWYgKGJyZWFrcG9pbnQp Ci0gICAgICAgICAgICB0aGlzLl9yZW1vdmVCcmVha3BvaW50RGVsZWdhdGUoYnJlYWtwb2ludCk7 Ci0gICAgICAgIGVsc2UgaWYgKHRoaXMuX2FkZEJyZWFrcG9pbnREZWxlZ2F0ZSkKKyAgICAgICAg aWYgKGJyZWFrcG9pbnQpIHsKKyAgICAgICAgICAgIGlmIChldmVudC5zaGlmdEtleSkKKyAgICAg ICAgICAgICAgICBicmVha3BvaW50LmVuYWJsZWQgPSAhYnJlYWtwb2ludC5lbmFibGVkOworICAg ICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIHRoaXMuX3JlbW92ZUJyZWFrcG9pbnREZWxl Z2F0ZShicmVha3BvaW50KTsKKyAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICB0aGlzLl9hZGRC cmVha3BvaW50RGVsZWdhdGUobGluZU51bWJlciArIDEpOwogICAgICAgICBldmVudC5wcmV2ZW50 RGVmYXVsdCgpOwogICAgIH0sCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvdGV4dFZpZXdlci5jc3MgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvdGV4dFZpZXdl ci5jc3MKaW5kZXggMThlNzEyYi4uNmJhMGJlOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL3RleHRWaWV3ZXIuY3NzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC90ZXh0Vmlld2VyLmNzcwpAQCAtMTAsNyArMTAsNiBAQAogCiAudGV4dC1lZGl0b3ItbGlu ZXMgewogICAgIGJvcmRlcjogMDsKLSAgICB3aWR0aDogMTAwJTsKICAgICAtd2Via2l0LWJvcmRl ci1ob3Jpem9udGFsLXNwYWNpbmc6IDA7CiAgICAgLXdlYmtpdC1ib3JkZXItdmVydGljYWwtc3Bh Y2luZzogMDsKICAgICAtd2Via2l0LXVzZXItc2VsZWN0OiB0ZXh0OwpkaWZmIC0tZ2l0IGEvV2Vi S2l0L2Nocm9taXVtL0NoYW5nZUxvZyBiL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg YjcwYTMyYS4uZGYyNTVlYyAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwor KysgYi9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEgQEAKKzIwMTAtMDIt MjcgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hyb21pdW06IHJlbW92ZSBEZXZU b29scyBwYXJ0IHRoYXQgaGFzIGJlZW4gdXBzdHJlYW1lZC4KKworICAgICAgICAqIHNyYy9qcy9E ZXZUb29scy5qczoKKwogMjAxMC0wMi0yNiAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCmRpZmYgLS1n aXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL2pzL0RldlRvb2xzLmpzIGIvV2ViS2l0L2Nocm9taXVt L3NyYy9qcy9EZXZUb29scy5qcwppbmRleCBkY2IxODFiLi5jODcxODIwIDEwMDY0NAotLS0gYS9X ZWJLaXQvY2hyb21pdW0vc3JjL2pzL0RldlRvb2xzLmpzCisrKyBiL1dlYktpdC9jaHJvbWl1bS9z cmMvanMvRGV2VG9vbHMuanMKQEAgLTIwNiw0OSArMjA2LDYgQEAgV2ViSW5zcGVjdG9yLmxvYWRl ZCA9IGZ1bmN0aW9uKCkKIH07CiAKIAotKGZ1bmN0aW9uKCkKLXsKLQotICAgIC8qKgotICAgICAq IEhhbmRsZXMgYW4gRjMga2V5ZG93biBldmVudCB0byBmb2N1cyB0aGUgSW5zcGVjdG9yIHNlYXJj aCBib3guCi0gICAgICogQHBhcmFtIHtLZXlib2FyZEV2ZW50fSBldmVudCBFdmVudCB0byBvcHRp b25hbGx5IGhhbmRsZQotICAgICAqIEByZXR1cm4ge2Jvb2xlYW59IHdoZXRoZXIgdGhlIGV2ZW50 IGhhcyBiZWVuIGhhbmRsZWQKLSAgICAgKi8KLSAgICBmdW5jdGlvbiBoYW5kbGVGM0tleWRvd24o ZXZlbnQpIHsKLSAgICAgICAgaWYgKGV2ZW50LmtleUlkZW50aWZpZXIgPT09ICJGMyIgJiYgIWV2 ZW50LmFsdEtleSAmJiAhZXZlbnQuY3RybEtleSAmJiAhZXZlbnQuc2hpZnRLZXkgJiYgIWV2ZW50 Lm1ldGFLZXkpIHsKLSAgICAgICAgICAgIHZhciBzZWFyY2hGaWVsZCA9IGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJzZWFyY2giKTsKLSAgICAgICAgICAgIHNlYXJjaEZpZWxkLmZvY3VzKCk7Ci0g ICAgICAgICAgICBzZWFyY2hGaWVsZC5zZWxlY3QoKTsKLSAgICAgICAgICAgIGV2ZW50LnByZXZl bnREZWZhdWx0KCk7Ci0gICAgICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICAgICAgfQotICAgICAg ICByZXR1cm4gZmFsc2U7Ci0gICAgfQotCi0KLSAgICB2YXIgb2xkS2V5RG93biA9IFdlYkluc3Bl Y3Rvci5kb2N1bWVudEtleURvd247Ci0gICAgLyoqCi0gICAgICogVGhpcyBvdmVycmlkZSBhbGxv d3MgdG8gaW50ZXJjZXB0IGtleWRvd24gZXZlbnRzIHdlIHdhbnQgdG8gaGFuZGxlIGluIGEKLSAg ICAgKiBjdXN0b20gd2F5LiBTb21lIG5lc3RlZCBkb2N1bWVudHMgKGlmcmFtZXMpIGRlbGVnYXRl IGtleWRvd24gaGFuZGxpbmcgdG8KLSAgICAgKiBXZWJJbnNwZWN0b3IuZG9jdW1lbnRLZXlEb3du IChlLmcuIFNvdXJjZUZyYW1lKS4KLSAgICAgKiBAcGFyYW0ge0tleWJvYXJkRXZlbnR9IGV2ZW50 Ci0gICAgICogQG92ZXJyaWRlCi0gICAgICovCi0gICAgV2ViSW5zcGVjdG9yLmRvY3VtZW50S2V5 RG93biA9IGZ1bmN0aW9uKGV2ZW50KSB7Ci0gICAgICAgIHZhciBpc0hhbmRsZWQgPSBoYW5kbGVG M0tleWRvd24oZXZlbnQpOwotICAgICAgICBpZiAoIWlzSGFuZGxlZCkgewotICAgICAgICAgICAg Ly8gTXV0ZSByZWZyZXNoIGFjdGlvbi4KLSAgICAgICAgICAgIGlmIChldmVudC5rZXlJZGVudGlm aWVyID09PSAiRjUiKQotICAgICAgICAgICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7Ci0g ICAgICAgICAgICBlbHNlIGlmIChldmVudC5rZXlJZGVudGlmaWVyID09PSAiVSswMDUyIiAvKiAi UiIgKi8gJiYgKGV2ZW50LmN0cmxLZXkgfHwgZXZlbnQubWV0YUtleSkpCi0gICAgICAgICAgICAg ICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKLSAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAg ICAgICBvbGRLZXlEb3duLmNhbGwodGhpcywgZXZlbnQpOwotICAgICAgICB9Ci0gICAgfTsKLX0p KCk7Ci0KLQogLyoqCiAgKiBUaGlzIG92ZXJyaWRlIGlzIG5lY2Vzc2FyeSBmb3IgYWRkaW5nIHNj cmlwdCBzb3VyY2UgYXN5bmNocm9ub3VzbHkuCiAgKiBAb3ZlcnJpZGUK