<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>35462</bug_id>
          
          <creation_ts>2010-02-26 16:53:52 -0800</creation_ts>
          <short_desc>change new-run-webkit-tests to default to mac port, not chromium-mac</short_desc>
          <delta_ts>2010-02-26 20:59:41 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dirk Pranke">dpranke</reporter>
          <assigned_to name="Dirk Pranke">dpranke</assigned_to>
          <cc>cjerdonek</cc>
    
    <cc>commit-queue</cc>
    
    <cc>eric</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>194361</commentid>
    <comment_count>0</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2010-02-26 16:53:52 -0800</bug_when>
    <thetext>Right now new-run-webkit-tests defaults to the appropriate Chromium port for the platform you&apos;re running on. It should default to the appropriate Mac port for the version of the Mac you&apos;re running.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>194368</commentid>
    <comment_count>1</comment_count>
      <attachid>49667</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2010-02-26 17:10:59 -0800</bug_when>
    <thetext>Created attachment 49667
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>194395</commentid>
    <comment_count>2</comment_count>
      <attachid>49667</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-02-26 18:51:02 -0800</bug_when>
    <thetext>Comment on attachment 49667
patch

We really need to unify our port classes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>194442</commentid>
    <comment_count>3</comment_count>
      <attachid>49667</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-02-26 20:59:37 -0800</bug_when>
    <thetext>Comment on attachment 49667
patch

Clearing flags on attachment: 49667

Committed r55341: &lt;http://trac.webkit.org/changeset/55341&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>194443</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-02-26 20:59:41 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>49667</attachid>
            <date>2010-02-26 17:10:59 -0800</date>
            <delta_ts>2010-02-26 20:59:37 -0800</delta_ts>
            <desc>patch</desc>
            <filename>wk3546_change_default.diff</filename>
            <type>text/plain</type>
            <size>2239</size>
            <attacher name="Dirk Pranke">dpranke</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCA5YzM2MmEzLi4zMmJiMjMwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM
b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDIt
MjYgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlIHRoZSBkZWZhdWx0IHBvcnQg
Zm9yIG5ldy1ydW4td2Via2l0LXRlc3RzIHdoZW4gcnVubmluZyBvbgorICAgICAgICBhIE1hYyBm
cm9tICdjaHJvbWl1bS1tYWMnIHRvICdtYWMnLiBBZGQgYSAnLS1jaHJvbWl1bScgc3dpdGNoIHRv
CisgICAgICAgIHBpY2sgdXAgdGhlIGRlZmF1bHQgcGxhdGZvcm0tc3BlY2lmaWMgdmVyc2lvbiBv
ZiBjaHJvbWl1bSBpbnN0ZWFkLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD0zNTQ2MgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf
dGVzdHMvcG9ydC9mYWN0b3J5LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0
X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHk6CisKIDIwMTAtMDItMjYgIEFudG9uaW8gR29tZXMg
IDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBHdXN0YXZvIE5v
cm9uaGEuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90
ZXN0cy9wb3J0L2ZhY3RvcnkucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91
dF90ZXN0cy9wb3J0L2ZhY3RvcnkucHkKaW5kZXggNDMyZmVmNC4uYjZmNTMwZSAxMDA2NDQKLS0t
IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9mYWN0b3J5
LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv
ZmFjdG9yeS5weQpAQCAtNDQsNyArNDQsMTAgQEAgZGVmIGdldChwb3J0X25hbWU9Tm9uZSwgb3B0
aW9ucz1Ob25lKToKICAgICAgICAgZWxpZiBzeXMucGxhdGZvcm0gPT0gJ2xpbnV4Mic6CiAgICAg
ICAgICAgICBwb3J0X3RvX3VzZSA9ICdjaHJvbWl1bS1saW51eCcKICAgICAgICAgZWxpZiBzeXMu
cGxhdGZvcm0gPT0gJ2Rhcndpbic6Ci0gICAgICAgICAgICBwb3J0X3RvX3VzZSA9ICdjaHJvbWl1
bS1tYWMnCisgICAgICAgICAgICBpZiBvcHRpb25zLmNocm9taXVtOgorICAgICAgICAgICAgICAg
IHBvcnRfdG9fdXNlID0gJ2Nocm9taXVtLW1hYycKKyAgICAgICAgICAgIGVsc2U6CisgICAgICAg
ICAgICAgICAgcG9ydF90b191c2UgPSAnbWFjJwogCiAgICAgaWYgcG9ydF90b191c2UgPT0gJ3Rl
c3QnOgogICAgICAgICBpbXBvcnQgdGVzdApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0
cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weSBiL1dlYktpdFRvb2xz
L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKaW5kZXgg
MjliY2ZjNy4uMDAzYjljMyAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRw
eS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQorKysgYi9XZWJLaXRUb29scy9TY3Jp
cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CkBAIC0xNjI0LDYg
KzE2MjQsOSBAQCBkZWYgcGFyc2VfYXJncyhhcmdzPU5vbmUpOgogICAgIG9wdGlvbl9wYXJzZXIu
YWRkX29wdGlvbigiIiwgIi0tbm9zdGFydC1oZWxwZXIiLAogICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBhY3Rpb249InN0b3JlX3RydWUiLCBkZWZhdWx0PUZhbHNlLAogICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBoZWxwPSJkb24ndCBydW4gbGF5b3V0X3Rlc3RfaGVscGVyIikKKyAg
ICBvcHRpb25fcGFyc2VyLmFkZF9vcHRpb24oIiIsICItLWNocm9taXVtIiwKKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgYWN0aW9uPSJzdG9yZV90cnVlIiwgZGVmYXVsdD1GYWxzZSwKKyAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgaGVscD0idXNlIHRoZSBDaHJvbWl1bSBwb3J0IikK
ICAgICByZXR1cm4gb3B0aW9uX3BhcnNlci5wYXJzZV9hcmdzKGFyZ3MpCiAKIGlmICdfX21haW5f
XycgPT0gX19uYW1lX186Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>