<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>35454</bug_id>
          
          <creation_ts>2010-02-26 14:18:38 -0800</creation_ts>
          <short_desc>webkit-build could pass unknown arguments to autogen.sh</short_desc>
          <delta_ts>2010-03-01 16:05:45 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="arno.">a.renevier</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>commit-queue</cc>
    
    <cc>gustavo</cc>
    
    <cc>pnormand</cc>
    
    <cc>xan.lopez</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>194290</commentid>
    <comment_count>0</comment_count>
    <who name="arno.">a.renevier</who>
    <bug_when>2010-02-26 14:18:38 -0800</bug_when>
    <thetext>Hi,
currently, webkit-build parses argument it knows about, and reformats them to pass them to autogen.sh.
But there is no way to pass arguments to autogen.sh if webkit-build does not know about them.
For example, we may want, occasionally, to call autogen.sh with --enable-gtk-doc argument.

Maybe we can just pass unknown arguments to autogen.sh, in the same way qt passes unknown arguments to qmake.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>194296</commentid>
    <comment_count>1</comment_count>
      <attachid>49643</attachid>
    <who name="arno.">a.renevier</who>
    <bug_when>2010-02-26 14:22:40 -0800</bug_when>
    <thetext>Created attachment 49643
patch v1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>194480</commentid>
    <comment_count>2</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-02-27 01:58:18 -0800</bug_when>
    <thetext>Adding some GTK folks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>194482</commentid>
    <comment_count>3</comment_count>
      <attachid>49643</attachid>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2010-02-27 02:38:47 -0800</bug_when>
    <thetext>Comment on attachment 49643
patch v1

Makes sense to me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>194484</commentid>
    <comment_count>4</comment_count>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2010-02-27 02:42:33 -0800</bug_when>
    <thetext>*** Bug 35244 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>194856</commentid>
    <comment_count>5</comment_count>
      <attachid>49643</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-03-01 16:05:40 -0800</bug_when>
    <thetext>Comment on attachment 49643
patch v1

Clearing flags on attachment: 49643

Committed r55384: &lt;http://trac.webkit.org/changeset/55384&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>194857</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-03-01 16:05:45 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>49643</attachid>
            <date>2010-02-26 14:22:40 -0800</date>
            <delta_ts>2010-03-01 16:05:40 -0800</delta_ts>
            <desc>patch v1</desc>
            <filename>bug-35454-20100226232238.patch</filename>
            <type>text/plain</type>
            <size>905</size>
            <attacher name="arno.">a.renevier</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCBjMTI1MWVkLi45MTdkNjU2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM
b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDIt
MjYgIEFybm8gUmVuZXZpZXIgIDxhcm5vQHJlbmV2aWVyLm5ldD4KKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICB3ZWJraXQtYnVpbGQgY291bGQgcGFzcyB1
bmtub3duIGFyZ3VtZW50cyB0byBhdXRvZ2VuLnNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTQ1NAorCisgICAgICAgICogU2NyaXB0cy9idWlsZC13
ZWJraXQ6CisKIDIwMTAtMDItMjQgIEFybm8gUmVuZXZpZXIgIDxhcm5vQHJlbmV2aWVyLm5ldD4K
IAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1dlYktp
dFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13
ZWJraXQKaW5kZXggY2Y1YWFhZC4uZWQ1ZTM2OCAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2Ny
aXB0cy9idWlsZC13ZWJraXQKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQK
QEAgLTI1Nyw2ICsyNTcsNyBAQCBteSBAb3B0aW9ucyA9ICgpOwogCiAjIGVuYWJsZSBhdXRvdG9v
bCBvcHRpb25zIGFjY29yZGluZ2x5CiBpZiAoaXNHdGsoKSkgeworICAgIEBvcHRpb25zID0gQEFS
R1Y7CiAgICAgZm9yZWFjaCAoQGZlYXR1cmVzKSB7CiAgICAgICAgIHB1c2ggQG9wdGlvbnMsIGF1
dG90b29sc0ZsYWcoJHskXy0+e3ZhbHVlfX0sICRfLT57b3B0aW9ufSk7CiAgICAgfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>