35429 2010-02-26 05:40:55 -0800 Fail to build on 64-bit sparc 2010-03-18 23:29:31 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 aurelien webkit-unassigned commit-queue oldest_to_newest 194066 0 aurelien 2010-02-26 05:40:55 -0800 webkit fails to build on 64-bit sparc. It needs a small tweak in the Platform.h file: --- a/src/3rdparty/webkit/JavaScriptCore/wtf/Platform.h +++ b/src/3rdparty/webkit/JavaScriptCore/wtf/Platform.h @@ -740,7 +740,7 @@ #endif #if !defined(WTF_USE_JSVALUE64) && !defined(WTF_USE_JSVALUE32) && !defined(WTF_USE_JSVALUE32_64) -#if (PLATFORM(X86_64) && (PLATFORM(UNIX) || PLATFORM(WIN_OS))) || PLATFORM(IA64) || PLATFORM(ALPHA) +#if (PLATFORM(X86_64) && (PLATFORM(UNIX) || PLATFORM(WIN_OS))) || PLATFORM(IA64) || PLATFORM(ALPHA) || PLATFORM(SPARC64) #define WTF_USE_JSVALUE64 1 #elif PLATFORM(ARM) || PLATFORM(PPC64) #define WTF_USE_JSVALUE32 1 194411 1 ap 2010-02-26 19:36:02 -0800 See also: bug 35326. Would you be willing to submit a patch for review, as documented in <http://webkit.org/coding/contributing.html>? 201551 2 51090 tcallawa 2010-03-18 14:10:33 -0700 Created attachment 51090 Proposed patch to fix compilation on sparc64 201723 3 51090 commit-queue 2010-03-18 23:29:27 -0700 Comment on attachment 51090 Proposed patch to fix compilation on sparc64 Clearing flags on attachment: 51090 Committed r56215: <http://trac.webkit.org/changeset/56215> 201724 4 commit-queue 2010-03-18 23:29:31 -0700 All reviewed patches have been landed. Closing bug. 51090 2010-03-18 14:10:33 -0700 2010-03-18 23:29:27 -0700 Proposed patch to fix compilation on sparc64 webkit-fix-sparc64.patch text/plain 1163 tcallawa SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU2MTg5KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDMtMTggIFRvbSBDYWxs YXdheSAgPHRjYWxsYXdhQHJlZGhhdC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQnVnIDM1NDI5OiBGaXggY29tcGlsZSBvbiBTUEFSQzY0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTQyOQorCisg ICAgICAgICogd3RmL1BsYXRmb3JtLmg6IFNldCBXVEZfVVNFX0pTVkFMVUU2NCBmb3IgU1BBUkM2 NAorCiAyMDEwLTAzLTE4ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0 Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCShyZXZp c2lvbiA1NjE1OCkKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNv cHkpCkBAIC04NjAsNyArODYwLDEwIEBACiAjZW5kaWYKIAogI2lmICFkZWZpbmVkKFdURl9VU0Vf SlNWQUxVRTY0KSAmJiAhZGVmaW5lZChXVEZfVVNFX0pTVkFMVUUzMikgJiYgIWRlZmluZWQoV1RG X1VTRV9KU1ZBTFVFMzJfNjQpCi0jaWYgKENQVShYODZfNjQpICYmIChPUyhVTklYKSB8fCBPUyhX SU5ET1dTKSkpIHx8IENQVShJQTY0KSB8fCBDUFUoQUxQSEEpCisjaWYgKENQVShYODZfNjQpICYm IChPUyhVTklYKSB8fCBPUyhXSU5ET1dTKSkpIFwKKyAgICB8fCBDUFUoSUE2NCkgIFwKKyAgICB8 fCBDUFUoQUxQSEEpIFwKKyAgICB8fCBDUFUoU1BBUkM2NCkKICNkZWZpbmUgV1RGX1VTRV9KU1ZB TFVFNjQgMQogI2VsaWYgQ1BVKEFSTSkgfHwgQ1BVKFBQQzY0KSB8fCBDUFUoTUlQUykKICNkZWZp bmUgV1RGX1VTRV9KU1ZBTFVFMzIgMQo=