35428 2010-02-26 05:11:29 -0800 [Qt] LayoutTestController.numberOfPages should have default parameters 2010-02-26 06:50:22 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED Qt P3 Normal --- 1 ossy webkit-unassigned diegohcg tonikitoo oldest_to_newest 194062 0 ossy 2010-02-26 05:11:29 -0800 This bug was revealed by http://trac.webkit.org/changeset/55275 http://build.webkit.org/results/Qt%20Linux%20Release/r55275%20%287849%29/results.html Our LayoutTestController.numberOfPages hasn't got default parameters as the platform independent LayoutTestController.numberOfPages. 194067 1 49577 ossy 2010-02-26 05:45:16 -0800 Created attachment 49577 proposed patch 194074 2 ossy 2010-02-26 06:50:22 -0800 Landed in http://trac.webkit.org/changeset/55280 . 49577 2010-02-26 05:45:16 -0800 2010-02-26 05:59:08 -0800 proposed patch page.patch text/plain 5357 ossy ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxYmJhNDI4Li45OTgwZmY5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDIt MjYgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIExheW91dFRlc3RDb250cm9s bGVyLm51bWJlck9mUGFnZXMoKSBzaG91bGQgaGF2ZSBkZWZhdWx0IHBhcmFtZXRlcnMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1NDI4CisKKyAgICAg ICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOiBwcmludGluZy9jc3MyLjEgdW5za2lwcGVkLgorCiAy MDEwLTAyLTI2ICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vcXQvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKaW5k ZXggODRhNzE1MC4uMjAyZTcxZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQv U2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCkBAIC01MDk3LDEy ICs1MDk3LDMgQEAgaHR0cC90ZXN0cy9sb2FkaW5nLzMwNy1hZnRlci0zMDMtYWZ0ZXItcG9zdC5o dG1sCiAKICMgRHVtcFJlbmRlclRyZWUgY29kZSB0byBlbmFibGUgSmF2YSBpcyBjdXJyZW50bHkg YSBuby1vcAogamF2YQotCi0jIFdpZHRoIGFuZCBoZWlnaHQgb2YgbGF5b3V0VGVzdENvbnRyb2xs ZXIubnVtYmVyT2ZQYWdlcyBzaG91bGQgYmUgb3B0aW9uYWwuCi1wcmludGluZy9jc3MyLjEvcGFn ZS1icmVhay1hZnRlci0wMDAuaHRtbAotcHJpbnRpbmcvY3NzMi4xL3BhZ2UtYnJlYWstYWZ0ZXIt MDAxLmh0bWwKLXByaW50aW5nL2NzczIuMS9wYWdlLWJyZWFrLWFmdGVyLTAwMy5odG1sCi1wcmlu dGluZy9jc3MyLjEvcGFnZS1icmVhay1hZnRlci0wMDQuaHRtbAotcHJpbnRpbmcvY3NzMi4xL3Bh Z2UtYnJlYWstYmVmb3JlLTAwMC5odG1sCi1wcmludGluZy9jc3MyLjEvcGFnZS1icmVhay1iZWZv cmUtMDAxLmh0bWwKLXByaW50aW5nL2NzczIuMS9wYWdlLWJyZWFrLWJlZm9yZS0wMDIuaHRtbApk aWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9n CmluZGV4IDJiNzY1ZGYuLjRjNGVmNGYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxv ZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wMi0y NiAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gTGF5b3V0VGVzdENvbnRyb2xs ZXIubnVtYmVyT2ZQYWdlcygpIHNob3VsZCBoYXZlIGRlZmF1bHQgcGFyYW1ldGVycworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzU0MjgKKworICAgICAg ICAqIER1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwOiBtYXhWaWV3V2lkdGgg YW5kIG1heFZpZXdIZWlnaHQgbW92ZWQgdG8KKyAgICAgICAgTGF5b3V0VGVzdENvbnRyb2xsZXIg dG8gY29udmVyZ2UgdG8gcGxhdGZvcm0gaW5kZXBlbmRlbnQgaW1wbGVtZW50YXRpb24uCisgICAg ICAgIChXZWJDb3JlOjpEdW1wUmVuZGVyVHJlZTo6RHVtcFJlbmRlclRyZWUpOgorICAgICAgICAo V2ViQ29yZTo6RHVtcFJlbmRlclRyZWU6Om9wZW4pOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVl L3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQuY3BwOiBJbml0aWFsaXphdGlvbiBvZiBtYXhWaWV3 V2lkdGggYW5kIG1heFZpZXdIZWlnaHQgYWRkZWQuCisgICAgICAgICogRHVtcFJlbmRlclRyZWUv cXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5oOgorICAgICAgICAgLSBEZWZhdWx0IHBhcmFtZXRl cnMgZm9yIExheW91dFRlc3RDb250cm9sbGVyLm51bWJlck9mUGFnZXMoKSBhZGRlZC4KKyAgICAg ICAgIC0gbWF4Vmlld1dpZHRoIGFuZCBtYXhWaWV3SGVpZ2h0IG1lbWJlcnMgYWRkZWQuCisKIDIw MTAtMDItMjYgIEphbWV5IEhpY2tzICA8amFtZXkuaGlja3NAbm9raWEuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IExhc3psbyBHb21ib3MuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1w UmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZVF0LmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5k ZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwCmluZGV4IGUxNmY5YmYuLjNlY2E3MmUgMTAw NjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQu Y3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQu Y3BwCkBAIC04NCwxMCArODQsNiBAQCBleHRlcm4gYm9vbCBxdF9kcnRfaGFzRG9jdW1lbnRFbGVt ZW50KFFXZWJGcmFtZSogcUZyYW1lKTsKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi0vLyBDaG9v c2Ugc29tZSBkZWZhdWx0IHZhbHVlcy4KLWNvbnN0IHVuc2lnbmVkIGludCBtYXhWaWV3V2lkdGgg PSA4MDA7Ci1jb25zdCB1bnNpZ25lZCBpbnQgbWF4Vmlld0hlaWdodCA9IDYwMDsKLQogTmV0d29y a0FjY2Vzc01hbmFnZXI6Ok5ldHdvcmtBY2Nlc3NNYW5hZ2VyKFFPYmplY3QqIHBhcmVudCkKICAg ICA6IFFOZXR3b3JrQWNjZXNzTWFuYWdlcihwYXJlbnQpCiB7CkBAIC0zMjEsNyArMzE3LDcgQEAg RHVtcFJlbmRlclRyZWU6OkR1bXBSZW5kZXJUcmVlKCkKIAogICAgIC8vIGNyZWF0ZSBvdXIgcHJp bWFyeSB0ZXN0aW5nIHBhZ2Uvdmlldy4KICAgICBtX21haW5WaWV3ID0gbmV3IFFXZWJWaWV3KDAp OwotICAgIG1fbWFpblZpZXctPnJlc2l6ZShRU2l6ZShtYXhWaWV3V2lkdGgsIG1heFZpZXdIZWln aHQpKTsKKyAgICBtX21haW5WaWV3LT5yZXNpemUoUVNpemUoTGF5b3V0VGVzdENvbnRyb2xsZXI6 Om1heFZpZXdXaWR0aCwgTGF5b3V0VGVzdENvbnRyb2xsZXI6Om1heFZpZXdIZWlnaHQpKTsKICAg ICBtX3BhZ2UgPSBuZXcgV2ViUGFnZShtX21haW5WaWV3LCB0aGlzKTsKICAgICBtX21haW5WaWV3 LT5zZXRQYWdlKG1fcGFnZSk7CiAgICAgbV9tYWluVmlldy0+c2V0Q29udGV4dE1lbnVQb2xpY3ko UXQ6Ok5vQ29udGV4dE1lbnUpOwpAQCAtNDMyLDggKzQyOCw4IEBAIHZvaWQgRHVtcFJlbmRlclRy ZWU6Om9wZW4oY29uc3QgUVVybCYgdXJsKQogCiAgICAgLy8gVzNDIFNWRyB0ZXN0cyBleHBlY3Qg dG8gYmUgNDgweDM2MAogICAgIGJvb2wgaXNXM0NUZXN0ID0gdXJsLnRvU3RyaW5nKCkuY29udGFp bnMoInN2Zy9XM0MtU1ZHLTEuMSIpOwotICAgIGludCB3aWR0aCA9IGlzVzNDVGVzdCA/IDQ4MCA6 IG1heFZpZXdXaWR0aDsKLSAgICBpbnQgaGVpZ2h0ID0gaXNXM0NUZXN0ID8gMzYwIDogbWF4Vmll d0hlaWdodDsKKyAgICBpbnQgd2lkdGggPSBpc1czQ1Rlc3QgPyA0ODAgOiBMYXlvdXRUZXN0Q29u dHJvbGxlcjo6bWF4Vmlld1dpZHRoOworICAgIGludCBoZWlnaHQgPSBpc1czQ1Rlc3QgPyAzNjAg OiBMYXlvdXRUZXN0Q29udHJvbGxlcjo6bWF4Vmlld0hlaWdodDsKICAgICBtX21haW5WaWV3LT5y ZXNpemUoUVNpemUod2lkdGgsIGhlaWdodCkpOwogICAgIG1fcGFnZS0+c2V0UHJlZmVycmVkQ29u dGVudHNTaXplKFFTaXplKCkpOwogICAgIG1fcGFnZS0+c2V0Vmlld3BvcnRTaXplKFFTaXplKHdp ZHRoLCBoZWlnaHQpKTsKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0 L0xheW91dFRlc3RDb250cm9sbGVyUXQuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUv cXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5jcHAKaW5kZXggYTI2YmMzZC4uMDBjMTgyZSAxMDA2 NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xs ZXJRdC5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENv bnRyb2xsZXJRdC5jcHAKQEAgLTUwMCwzICs1MDAsNiBAQCBpbnQgTGF5b3V0VGVzdENvbnRyb2xs ZXI6Om51bWJlck9mUGFnZXMoZmxvYXQgd2lkdGgsIGZsb2F0IGhlaWdodCkKIHsKICAgICByZXR1 cm4gcXRfZHJ0X251bWJlck9mUGFnZXMobV9kcnQtPndlYlBhZ2UoKS0+bWFpbkZyYW1lKCksIHdp ZHRoLCBoZWlnaHQpOwogfQorCitjb25zdCB1bnNpZ25lZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6 bWF4Vmlld1dpZHRoID0gODAwOworY29uc3QgdW5zaWduZWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6 Om1heFZpZXdIZWlnaHQgPSA2MDA7CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVy VHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmggYi9XZWJLaXRUb29scy9EdW1wUmVuZGVy VHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmgKaW5kZXggZDczNzk0ZS4uMTJhZTcyYiAx MDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRy b2xsZXJRdC5oCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0xheW91dFRlc3RD b250cm9sbGVyUXQuaApAQCAtNzAsNiArNzAsOSBAQCBwdWJsaWM6CiAKICAgICB2b2lkIHJlc2V0 KCk7CiAKKyAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgaW50IG1heFZpZXdXaWR0aDsKKyAgICBz dGF0aWMgY29uc3QgdW5zaWduZWQgaW50IG1heFZpZXdIZWlnaHQ7CisKIHByb3RlY3RlZDoKICAg ICB2b2lkIHRpbWVyRXZlbnQoUVRpbWVyRXZlbnQqKTsKIApAQCAtMTUzLDcgKzE1Niw3IEBAIHB1 YmxpYyBzbG90czoKICAgICB2b2lkIHNldERvbWFpblJlbGF4YXRpb25Gb3JiaWRkZW5Gb3JVUkxT Y2hlbWUoYm9vbCBmb3JiaWRkZW4sIGNvbnN0IFFTdHJpbmcmIHNjaGVtZSk7CiAgICAgaW50IHdv cmtlclRocmVhZENvdW50KCk7CiAgICAgaW50IHBhZ2VOdW1iZXJGb3JFbGVtZW50QnlJZChjb25z dCBRU3RyaW5nJiBpZCwgZmxvYXQgd2lkdGggPSAwLCBmbG9hdCBoZWlnaHQgPSAwKTsKLSAgICBp bnQgbnVtYmVyT2ZQYWdlcyhmbG9hdCB3aWR0aCwgZmxvYXQgaGVpZ2h0KTsKKyAgICBpbnQgbnVt YmVyT2ZQYWdlcyhmbG9hdCB3aWR0aCA9IG1heFZpZXdXaWR0aCwgZmxvYXQgaGVpZ2h0ID0gbWF4 Vmlld0hlaWdodCk7CiAKIHByaXZhdGUgc2xvdHM6CiAgICAgdm9pZCBwcm9jZXNzV29yaygpOwo=