35420 2010-02-25 22:15:13 -0800 [chromium] Remove deprecated cookie methods 2010-02-25 22:50:55 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fishd fishd jorlow oldest_to_newest 193997 0 fishd 2010-02-25 22:15:13 -0800 [chromium] Remove deprecated cookie methods 193998 1 49564 fishd 2010-02-25 22:16:10 -0800 Created attachment 49564 v1 patch 193999 2 fishd 2010-02-25 22:17:19 -0800 http://codereview.chromium.org/660166 needs to land before this should be committed. 194003 3 49564 levin 2010-02-25 22:31:27 -0800 Comment on attachment 49564 v1 patch > Index: WebKit/chromium/ChangeLog > +2010-02-25 Darin Fisher <darin@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Remove deprecated cookie methods. Please add a bug link here. 194005 4 fishd 2010-02-25 22:50:55 -0800 Landed as http://trac.webkit.org/changeset/55269 49564 2010-02-25 22:16:10 -0800 2010-02-25 22:31:27 -0800 v1 patch cook_1.txt text/plain 5456 fishd SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA1NTI2OCkKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wMi0yNSAgRGFy aW4gRmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBkZXByZWNhdGVkIGNvb2tpZSBtZXRob2Rz LgorCisgICAgICAgICogcHVibGljL1dlYkZyYW1lQ2xpZW50Lmg6CisgICAgICAgICogcHVibGlj L1dlYktpdENsaWVudC5oOgorICAgICAgICAqIHNyYy9DaHJvbWl1bUJyaWRnZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpDaHJvbWl1bUJyaWRnZTo6c2V0Q29va2llcyk6CisgICAgICAgIChXZWJD b3JlOjpDaHJvbWl1bUJyaWRnZTo6Y29va2llcyk6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWl1 bUJyaWRnZTo6Y29va2llUmVxdWVzdEhlYWRlckZpZWxkVmFsdWUpOgorICAgICAgICAoV2ViQ29y ZTo6Q2hyb21pdW1CcmlkZ2U6OnJhd0Nvb2tpZXMpOgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21p dW1CcmlkZ2U6OmRlbGV0ZUNvb2tpZSk6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWl1bUJyaWRn ZTo6Y29va2llc0VuYWJsZWQpOgorCiAyMDEwLTAyLTI1ICBKYW1lcyBIYXdraW5zICA8amhhd2tp bnNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KSW5k ZXg6IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWVDbGllbnQuaA0KPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0K LS0tIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWVDbGllbnQuaAkocmV2aXNpb24gNTUy NjgpCisrKyBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lQ2xpZW50LmgJKHdvcmtpbmcg Y29weSkKQEAgLTc4LDcgKzc4LDggQEAgcHVibGljOgogICAgIAogICAgIC8vIFNlcnZpY2VzIC0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQogCi0gICAgLy8gQSBmcmFtZSBzcGVjaWZpYyBjb29raWUgamFyLiAgTWF5IHJldHVybiBudWxs LgorICAgIC8vIEEgZnJhbWUgc3BlY2lmaWMgY29va2llIGphci4gIE1heSByZXR1cm4gbnVsbCwg aW4gd2hpY2ggY2FzZQorICAgIC8vIFdlYktpdENsaWVudDo6Y29va2llSmFyKCkgd2lsbCBiZSBj YWxsZWQgdG8gYWNjZXNzIGNvb2tpZXMuCiAgICAgdmlydHVhbCBXZWJDb29raWVKYXIqIGNvb2tp ZUphcigpIHsgcmV0dXJuIDA7IH0KIAogCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YktpdENsaWVudC5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJL aXRDbGllbnQuaAkocmV2aXNpb24gNTUyNjgpCisrKyBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YktpdENsaWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw3ICszNiw2IEBACiAjaW5jbHVkZSAi V2ViTG9jYWxpemVkU3RyaW5nLmgiCiAjaW5jbHVkZSAiV2ViU3RyaW5nLmgiCiAjaW5jbHVkZSAi V2ViVVJMLmgiCi0jaW5jbHVkZSAiV2ViVmVjdG9yLmgiCiAKICNpbmNsdWRlIDx0aW1lLmg+CiAK QEAgLTU5LDggKzU4LDYgQEAgY2xhc3MgV2ViU29ja2V0U3RyZWFtSGFuZGxlOwogY2xhc3MgV2Vi U3RvcmFnZU5hbWVzcGFjZTsKIGNsYXNzIFdlYlRoZW1lRW5naW5lOwogY2xhc3MgV2ViVVJMTG9h ZGVyOwotc3RydWN0IFdlYkNvb2tpZTsKLXRlbXBsYXRlIDx0eXBlbmFtZSBUPiBjbGFzcyBXZWJW ZWN0b3I7CiAKIGNsYXNzIFdlYktpdENsaWVudCB7CiBwdWJsaWM6CkBAIC0xODEsMTMgKzE3OCw2 IEBAIHB1YmxpYzoKIAogICAgIC8vIE5ldHdvcmsgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCi0gICAgLy8gVGhlc2UgY29va2ll IG1ldGhvZHMgYXJlIERFUFJFQ0FURUQgaW4gZmF2b3Igb2YgY29va2llSmFyIGFjY2Vzc29yLgot ICAgIHZpcnR1YWwgdm9pZCBzZXRDb29raWVzKGNvbnN0IFdlYlVSTCYsIGNvbnN0IFdlYlVSTCYg Zmlyc3RQYXJ0eUZvckNvb2tpZXMsIGNvbnN0IFdlYlN0cmluZyYgY29va2llcykgeyB9Ci0gICAg dmlydHVhbCBXZWJTdHJpbmcgY29va2llcyhjb25zdCBXZWJVUkwmLCBjb25zdCBXZWJVUkwmIGZp cnN0UGFydHlGb3JDb29raWVzKSB7IHJldHVybiBXZWJTdHJpbmcoKTsgfQotICAgIHZpcnR1YWwg Ym9vbCByYXdDb29raWVzKGNvbnN0IFdlYlVSTCYsIGNvbnN0IFdlYlVSTCYgZmlyc3RQYXJ0eUZv ckNvb2tpZXMsIFdlYlZlY3RvcjxXZWJDb29raWU+KikgeyByZXR1cm4gZmFsc2U7IH0KLSAgICB2 aXJ0dWFsIHZvaWQgZGVsZXRlQ29va2llKGNvbnN0IFdlYlVSTCYsIGNvbnN0IFdlYlN0cmluZyYg Y29va2llTmFtZSkgeyB9Ci0gICAgdmlydHVhbCBib29sIGNvb2tpZXNFbmFibGVkKGNvbnN0IFdl YlVSTCYsIGNvbnN0IFdlYlVSTCYgZmlyc3RQYXJ0eUZvckNvb2tpZXMpIHsgcmV0dXJuIHRydWU7 IH0KLQogICAgIC8vIEEgc3VnZ2VzdGlvbiB0byBwcmVmZXRjaCBJUCBpbmZvcm1hdGlvbiBmb3Ig dGhlIGdpdmVuIGhvc3RuYW1lLgogICAgIHZpcnR1YWwgdm9pZCBwcmVmZXRjaEhvc3ROYW1lKGNv bnN0IFdlYlN0cmluZyYpIHsgfQogCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9taXVt QnJpZGdlLmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21pdW1C cmlkZ2UuY3BwCShyZXZpc2lvbiA1NTI2OCkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21p dW1CcmlkZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xOTMsOCArMTkzLDYgQEAgdm9pZCBDaHJv bWl1bUJyaWRnZTo6c2V0Q29va2llcyhjb25zdCBEbwogICAgIFdlYkNvb2tpZUphciogY29va2ll SmFyID0gZ2V0Q29va2llSmFyKGRvY3VtZW50KTsKICAgICBpZiAoY29va2llSmFyKQogICAgICAg ICBjb29raWVKYXItPnNldENvb2tpZSh1cmwsIGRvY3VtZW50LT5maXJzdFBhcnR5Rm9yQ29va2ll cygpLCB2YWx1ZSk7Ci0gICAgZWxzZQotICAgICAgICB3ZWJLaXRDbGllbnQoKS0+c2V0Q29va2ll cyh1cmwsIGRvY3VtZW50LT5maXJzdFBhcnR5Rm9yQ29va2llcygpLCB2YWx1ZSk7IC8vIERFUFJF Q0FURUQKIH0KIAogU3RyaW5nIENocm9taXVtQnJpZGdlOjpjb29raWVzKGNvbnN0IERvY3VtZW50 KiBkb2N1bWVudCwgY29uc3QgS1VSTCYgdXJsKQpAQCAtMjAzLDggKzIwMSw2IEBAIFN0cmluZyBD aHJvbWl1bUJyaWRnZTo6Y29va2llcyhjb25zdCBEb2MKICAgICBXZWJDb29raWVKYXIqIGNvb2tp ZUphciA9IGdldENvb2tpZUphcihkb2N1bWVudCk7CiAgICAgaWYgKGNvb2tpZUphcikKICAgICAg ICAgcmVzdWx0ID0gY29va2llSmFyLT5jb29raWVzKHVybCwgZG9jdW1lbnQtPmZpcnN0UGFydHlG b3JDb29raWVzKCkpOwotICAgIGVsc2UKLSAgICAgICAgcmVzdWx0ID0gd2ViS2l0Q2xpZW50KCkt PmNvb2tpZXModXJsLCBkb2N1bWVudC0+Zmlyc3RQYXJ0eUZvckNvb2tpZXMoKSk7IC8vIERFUFJF Q0FURUQKICAgICByZXR1cm4gcmVzdWx0OwogfQogCkBAIC0yMTUsMTAgKzIxMSw2IEBAIFN0cmlu ZyBDaHJvbWl1bUJyaWRnZTo6Y29va2llUmVxdWVzdEhlYWQKICAgICBXZWJDb29raWVKYXIqIGNv b2tpZUphciA9IGdldENvb2tpZUphcihkb2N1bWVudCk7CiAgICAgaWYgKGNvb2tpZUphcikKICAg ICAgICAgcmVzdWx0ID0gY29va2llSmFyLT5jb29raWVSZXF1ZXN0SGVhZGVyRmllbGRWYWx1ZSh1 cmwsIGRvY3VtZW50LT5maXJzdFBhcnR5Rm9yQ29va2llcygpKTsKLSAgICBlbHNlIHsKLSAgICAg ICAgLy8gRklYTUU6IFRoaXMgZG9lcyBub3QgcmV0dXJuIGh0dHAtb25seSBjb29raWVzCi0gICAg ICAgIHJlc3VsdCA9IHdlYktpdENsaWVudCgpLT5jb29raWVzKHVybCwgZG9jdW1lbnQtPmZpcnN0 UGFydHlGb3JDb29raWVzKCkpOyAvLyBERVBSRUNBVEVECi0gICAgfQogICAgIHJldHVybiByZXN1 bHQ7CiB9CiAKQEAgLTIzMCw4ICsyMjIsNiBAQCBib29sIENocm9taXVtQnJpZGdlOjpyYXdDb29r aWVzKGNvbnN0IERvCiAgICAgV2ViQ29va2llSmFyKiBjb29raWVKYXIgPSBnZXRDb29raWVKYXIo ZG9jdW1lbnQpOwogICAgIGlmIChjb29raWVKYXIpCiAgICAgICAgIGNvb2tpZUphci0+cmF3Q29v a2llcyh1cmwsIGRvY3VtZW50LT5maXJzdFBhcnR5Rm9yQ29va2llcygpLCB3ZWJDb29raWVzKTsK LSAgICBlbHNlCi0gICAgICAgIHdlYktpdENsaWVudCgpLT5yYXdDb29raWVzKHVybCwgZG9jdW1l bnQtPmZpcnN0UGFydHlGb3JDb29raWVzKCksICZ3ZWJDb29raWVzKTsgLy8gREVQUkVDQVRFRAog CiAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IHdlYkNvb2tpZXMuc2l6ZSgpOyArK2kpIHsK ICAgICAgICAgY29uc3QgV2ViQ29va2llJiB3ZWJDb29raWUgPSB3ZWJDb29raWVzW2ldOwpAQCAt MjUzLDggKzI0Myw2IEBAIHZvaWQgQ2hyb21pdW1CcmlkZ2U6OmRlbGV0ZUNvb2tpZShjb25zdCAK ICAgICBXZWJDb29raWVKYXIqIGNvb2tpZUphciA9IGdldENvb2tpZUphcihkb2N1bWVudCk7CiAg ICAgaWYgKGNvb2tpZUphcikKICAgICAgICAgY29va2llSmFyLT5kZWxldGVDb29raWUodXJsLCBj b29raWVOYW1lKTsKLSAgICBlbHNlCi0gICAgICAgIHdlYktpdENsaWVudCgpLT5kZWxldGVDb29r aWUodXJsLCBjb29raWVOYW1lKTsgLy8gREVQUkVDQVRFRAogfQogCiBib29sIENocm9taXVtQnJp ZGdlOjpjb29raWVzRW5hYmxlZChjb25zdCBEb2N1bWVudCogZG9jdW1lbnQpCkBAIC0yNjMsOCAr MjUxLDYgQEAgYm9vbCBDaHJvbWl1bUJyaWRnZTo6Y29va2llc0VuYWJsZWQoY29ucwogICAgIFdl YkNvb2tpZUphciogY29va2llSmFyID0gZ2V0Q29va2llSmFyKGRvY3VtZW50KTsKICAgICBpZiAo Y29va2llSmFyKQogICAgICAgICByZXN1bHQgPSBjb29raWVKYXItPmNvb2tpZXNFbmFibGVkKGRv Y3VtZW50LT5jb29raWVVUkwoKSwgZG9jdW1lbnQtPmZpcnN0UGFydHlGb3JDb29raWVzKCkpOwot ICAgIGVsc2UKLSAgICAgICAgcmVzdWx0ID0gd2ViS2l0Q2xpZW50KCktPmNvb2tpZXNFbmFibGVk KGRvY3VtZW50LT5jb29raWVVUkwoKSwgZG9jdW1lbnQtPmZpcnN0UGFydHlGb3JDb29raWVzKCkp OyAvLyBERVBSRUNBVEVECiAgICAgcmV0dXJuIHJlc3VsdDsKIH0KIAo=