35409 2010-02-25 16:51:45 -0800 Multiple repaints on apple.com 2010-02-25 17:06:42 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 oliver webkit-unassigned webkit.review.bot oldest_to_newest 193938 0 oliver 2010-02-25 16:51:45 -0800 Multiple repaints on apple.com 193942 1 49549 oliver 2010-02-25 16:57:06 -0800 Created attachment 49549 Patch 193943 2 webkit.review.bot 2010-02-25 16:59:34 -0800 Attachment 49549 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/graphics/transforms/AffineTransform.h:126: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 193946 3 oliver 2010-02-25 17:06:42 -0800 Committed r55266: <http://trac.webkit.org/changeset/55266> 49549 2010-02-25 16:57:06 -0800 2010-02-25 17:04:05 -0800 Patch bug-35409-20100225165704.patch text/plain 3624 oliver ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YWU3MDc1NS4uYTY4YWM5YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxMC0wMi0yNSAgT2xpdmVyIEh1bnQg IDxvbGl2ZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE11bHRpcGxlIHJlcGFpbnRzIG9uIGFwcGxlLmNvbQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzU0MDkKKworICAgICAgICBhcHBs ZS5jb20gd2FzIHRyaWdnZXJpbmcgdGhlIGZhc3Qgc2NhbGluZyBwYXRoIGZvciBiYWNrZ3JvdW5k IGltYWdlcyBkdWUgdG8KKyAgICAgICAgcmVwZWF0ZWQgcmVwYWludHMgYXMgbW9yZSBjb250ZW50 IGNhbWUgaW4uICBUaGlzIG9jY3VyZWQgZHVlIHRvIGEgdHdvIHByb2JsZW1zCisgICAgICAgIGlu IHRoZSBsb2dpYyB0byBkZXRlY3Qgc2NhbGluZy4gIFRoZSBmaXJzdCBpcyB0aGF0IHRoZSBtYWlu IGNvbnRleHQgaXMgZmxpcHBlZAorICAgICAgICBvbiBtYWMgc28gZmFpbHMgdGhlIGlkZW50aXR5 IG9yIHRyYW5zbGF0aW9uIGNoZWNrLiAgV2Ugd29yayBhcm91bmQgdGhpcyBieSBhZGRpbmcKKyAg ICAgICAgYW4gZnVuY3Rpb24gdGhhdCBhbGxvd3MgdGhlIHNjYWxpbmcgZm9yIGEgZmxpcHBlZCBD VE0uICBUaGUgb3RoZXIgcHJvYmxlbSB3YXMgdGhhdAorICAgICAgICB3ZSB3ZXJlIGxvb2tpbmcg YXQgdGhlIGRlc3RpbmF0aW9uIHJlY3Qgc2l6ZSBpbnN0ZWFkIG9mIHRoZSBkZXN0aW5hdGlvbiB0 aWxlIHNpemUKKyAgICAgICAgd2hlbiBkZWNpZGluZyBpZiB0aGUgc2l6ZSB3ZSB3ZXJlIGRyYXdu IGF0IHdvdWxkIGNhdXNlIHNjYWxpbmcuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90 cmFuc2Zvcm1zL0FmZmluZVRyYW5zZm9ybS5oOgorICAgICAgICAoV2ViQ29yZTo6QWZmaW5lVHJh bnNmb3JtOjppc0lkZW50aXR5T3JUcmFuc2xhdGlvbk9yRmxpcHBlZCk6CisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ckJveE1vZGVsU2NhbGVPYnNlcnZlcjo6c2hvdWxkUGFpbnRCYWNrZ3JvdW5kQXRMb3dRdWFsaXR5 KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveE1vZGVsT2JqZWN0OjpwYWludEZpbGxMYXll ckV4dGVuZGVkKToKKwogMjAxMC0wMi0yNSAgSmlhbiBMaSAgPGppYW5saUBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRG1pdHJ5IFRpdG92LgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zvcm1zL0FmZmluZVRyYW5zZm9ybS5oIGIvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zvcm1zL0FmZmluZVRyYW5zZm9ybS5oCmluZGV4IDAw NjMxYzIuLjQ1YTE5ZDcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdHJh bnNmb3Jtcy9BZmZpbmVUcmFuc2Zvcm0uaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3RyYW5zZm9ybXMvQWZmaW5lVHJhbnNmb3JtLmgKQEAgLTEyMCw2ICsxMjAsMTEgQEAgcHVibGlj OgogICAgIHsKICAgICAgICAgcmV0dXJuIG1fdHJhbnNmb3JtWzBdID09IDEgJiYgbV90cmFuc2Zv cm1bMV0gPT0gMCAmJiBtX3RyYW5zZm9ybVsyXSA9PSAwICYmIG1fdHJhbnNmb3JtWzNdID09IDE7 CiAgICAgfQorICAgIAorICAgIGJvb2wgaXNJZGVudGl0eU9yVHJhbnNsYXRpb25PckZsaXBwZWQo KSBjb25zdAorICAgIHsKKyAgICAgICAgcmV0dXJuIG1fdHJhbnNmb3JtWzBdID09IDEgJiYgbV90 cmFuc2Zvcm1bMV0gPT0gMCAmJiBtX3RyYW5zZm9ybVsyXSA9PSAwICYmIChtX3RyYW5zZm9ybVsz XSA9PSAxIHx8IG1fdHJhbnNmb3JtWzNdID09IC0xKTsKKyAgICB9CiAKICAgICBib29sIG9wZXJh dG9yPT0gKGNvbnN0IEFmZmluZVRyYW5zZm9ybSYgbTIpIGNvbnN0CiAgICAgewpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwIGIvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwCmluZGV4IDI0MDg3OTYuLjFhZTQ3NzUg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcAor KysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAKQEAgLTEzMSw3 ICsxMzEsNyBAQCBib29sIFJlbmRlckJveE1vZGVsU2NhbGVPYnNlcnZlcjo6c2hvdWxkUGFpbnRC YWNrZ3JvdW5kQXRMb3dRdWFsaXR5KEdyYXBoaWNzQ29udAogICAgICAgICBkYXRhID0gZ0JveE1v ZGVsT2JqZWN0cy0+Z2V0KG9iamVjdCk7CiAKICAgICBjb25zdCBBZmZpbmVUcmFuc2Zvcm0mIGN1 cnJlbnRUcmFuc2Zvcm0gPSBjb250ZXh0LT5nZXRDVE0oKTsKLSAgICBib29sIGNvbnRleHRJc1Nj YWxlZCA9ICFjdXJyZW50VHJhbnNmb3JtLmlzSWRlbnRpdHlPclRyYW5zbGF0aW9uKCk7CisgICAg Ym9vbCBjb250ZXh0SXNTY2FsZWQgPSAhY3VycmVudFRyYW5zZm9ybS5pc0lkZW50aXR5T3JUcmFu c2xhdGlvbk9yRmxpcHBlZCgpOwogICAgIGlmICghY29udGV4dElzU2NhbGVkICYmIGltYWdlU2l6 ZSA9PSBzaXplKSB7CiAgICAgICAgIC8vIFRoZXJlIGlzIG5vIHNjYWxlIGluIGVmZmVjdC4gIElm IHdlIGhhZCBhIHNjYWxlIGluIGVmZmVjdCBiZWZvcmUsIHdlIGNhbiBqdXN0IGRlbGV0ZSB0aGlz IGRhdGEuCiAgICAgICAgIGlmIChkYXRhKSB7CkBAIC02MDYsNyArNjA2LDcgQEAgdm9pZCBSZW5k ZXJCb3hNb2RlbE9iamVjdDo6cGFpbnRGaWxsTGF5ZXJFeHRlbmRlZChjb25zdCBQYWludEluZm8m IHBhaW50SW5mbywgY28KICAgICAgICAgICAgIENvbXBvc2l0ZU9wZXJhdG9yIGNvbXBvc2l0ZU9w ID0gb3AgPT0gQ29tcG9zaXRlU291cmNlT3ZlciA/IGJnTGF5ZXItPmNvbXBvc2l0ZSgpIDogb3A7 CiAgICAgICAgICAgICBSZW5kZXJPYmplY3QqIGNsaWVudEZvckJhY2tncm91bmRJbWFnZSA9IGJh Y2tncm91bmRPYmplY3QgPyBiYWNrZ3JvdW5kT2JqZWN0IDogdGhpczsKICAgICAgICAgICAgIElt YWdlKiBpbWFnZSA9IGJnLT5pbWFnZShjbGllbnRGb3JCYWNrZ3JvdW5kSW1hZ2UsIHRpbGVTaXpl KTsKLSAgICAgICAgICAgIGJvb2wgdXNlTG93UXVhbGl0eVNjYWxpbmcgPSBSZW5kZXJCb3hNb2Rl bFNjYWxlT2JzZXJ2ZXI6OnNob3VsZFBhaW50QmFja2dyb3VuZEF0TG93UXVhbGl0eShjb250ZXh0 LCB0aGlzLCBpbWFnZSwgZGVzdFJlY3Quc2l6ZSgpKTsKKyAgICAgICAgICAgIGJvb2wgdXNlTG93 UXVhbGl0eVNjYWxpbmcgPSBSZW5kZXJCb3hNb2RlbFNjYWxlT2JzZXJ2ZXI6OnNob3VsZFBhaW50 QmFja2dyb3VuZEF0TG93UXVhbGl0eShjb250ZXh0LCB0aGlzLCBpbWFnZSwgdGlsZVNpemUpOwog ICAgICAgICAgICAgY29udGV4dC0+ZHJhd1RpbGVkSW1hZ2UoaW1hZ2UsIHN0eWxlKCktPmNvbG9y U3BhY2UoKSwgZGVzdFJlY3QsIHBoYXNlLCB0aWxlU2l6ZSwgY29tcG9zaXRlT3AsIHVzZUxvd1F1 YWxpdHlTY2FsaW5nKTsKICAgICAgICAgfQogICAgIH0K