35402 2010-02-25 13:21:48 -0800 [GTK] Make webkit_web_view_grab_focus to active focus controller. 2010-04-20 13:24:28 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC All CLOSED FIXED Gtk P2 Normal --- 18662 1 tonikitoo tonikitoo gustavo hausmann jdiggs xan.lopez oldest_to_newest 193864 0 tonikitoo 2010-02-25 13:21:48 -0800 When programatically setting focus to an element in an inner document, calling "hasFocus()" from this document returns FALSE, because document's FocusController is not activated. ps: It does not happen if |document| is the main document. Making webkit_web_view_grab_focus to actually activate the FocusController, fixes the issue. patch coming, including API unit test. * sample failing pseudo html/JS code: <html> <script> function _focus_() { var innerDoc = document.defaultView.frames[0].document; innerDoc.getElementById("link").focus(); if (innerDoc.hasFocus()) dump("has focus"); } </script> <body onload="_focus_()"> <iframe src=iframe.html/> </body> </html> ********* iframe.html ********* <html> <body> <a id="link" href="http://abc.def">test</a> </body> </html> 193868 1 49529 tonikitoo 2010-02-25 13:40:27 -0800 Created attachment 49529 proposed patch 194086 2 49529 xan.lopez 2010-02-26 07:28:36 -0800 Comment on attachment 49529 proposed patch >+ The code below is an wordaround: if the node has focus, a scroll typo in 'wordaround' >+ action is performed and afterward it is checked if the adjustment >+ has to be different from 0. >+ */ It would be nicer to not duplicate so much code between the tests by using common setup/teardown methods like in other testfiles, but you can do it in a follow-up if you feel like it. 194087 3 49529 xan.lopez 2010-02-26 07:29:21 -0800 Comment on attachment 49529 proposed patch >+ g_object_connect(G_OBJECT(view), >+ "signal::notify::progress", idle_quit_loop_cb, NULL, >+ NULL); Bah, this was cut in the previous comment. You can just use g_signal_connect here. 194262 4 tonikitoo 2010-02-26 13:27:10 -0800 fixed: r55300 and r55305 thx xan and kov 211513 5 49529 tonikitoo 2010-04-11 19:58:46 -0700 Comment on attachment 49529 proposed patch Clearing flags on attachment: 49529 Committed r55300: <http://trac.webkit.org/changeset/55300> 49529 2010-02-25 13:40:27 -0800 2010-04-11 19:58:46 -0700 proposed patch 0001--GTK-Make-webkit_web_view_grab_focus-to-active-focu.patch text/plain 7167 tonikitoo RnJvbSA3YTVjMWFhNzE1OTM5Y2U2MTNiZTEzMWEwM2JhNjczNjY1NDIxY2I4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogVGh1LCAyNSBGZWIgMjAxMCAxNzowMzozMyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtH VEtdIE1ha2Ugd2Via2l0X3dlYl92aWV3X2dyYWJfZm9jdXMgdG8gYWN0aXZlIGZvY3VzIGNvbnRy b2xsZXIuCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzU0MDIKClJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpQYXRjaCBieSBBbnRvbmlvIEdvbWVzIDx0b25pa2l0 b29Ad2Via2l0Lm9yZz4KCldoZW4gcHJvZ3JhbWF0aWNhbGx5IHNldHRpbmcgZm9jdXMgdG8gYW4g ZWxlbWVudCBpbiBhbiBpbm5lciBkb2N1bWVudCwKY2FsbGluZyAiaGFzRm9jdXMoKSIgZnJvbSB0 aGlzIGRvY3VtZW50IHJldHVybnMgRkFMU0UsIGJlY2F1c2UKZG9jdW1lbnQncyBGb2N1c0NvbnRy b2xsZXIgaXMgbm90IGFjdGl2YXRlZC4gSXQgZG9lcyBub3QgaGFwcGVuCmlmIHxkb2N1bWVudHwg aXMgdGhlIG1haW4gZG9jdW1lbnQuCgpNYWtpbmcgd2Via2l0X3dlYl92aWV3X2dyYWJfZm9jdXMg dG8gYWN0dWFsbHkgYWN0aXZhdGUgdGhlIEZvY3VzQ29udHJvbGxlciwKZml4ZXMgdGhlIGlzc3Vl LgoKKiB0ZXN0cy90ZXN0d2Vidmlldy5jOgooc2VydmVyX2NhbGxiYWNrKToKKHRlc3Rfd2Via2l0 X3dlYl92aWV3X2dyYWJfZm9jdXMpOgoqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoKKHdlYmtp dF93ZWJfdmlld19ncmFiX2ZvY3VzKToKLS0tCiBXZWJLaXQvZ3RrL0NoYW5nZUxvZyAgICAgICAg ICAgICAgICB8ICAgMjIgKysrKysrKysrKysrCiBXZWJLaXQvZ3RrL3Rlc3RzL3Rlc3R3ZWJ2aWV3 LmMgICAgICB8ICAgNjIgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLQogV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgfCAgICAyICsKIDMgZmlsZXMgY2hhbmdlZCwg ODQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3Rr L0NoYW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IGFhYzIzYTQuLjlhODBmNzYg MTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTAtMDItMjMgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0 b29Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAg ICAgICAgUGF0Y2ggYnkgQW50b25pbyBHb21lcyA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgW0dUS10gTWFrZSB3ZWJraXRfd2ViX3ZpZXdfZ3JhYl9mb2N1cyB0byBhY3RpdmUgZm9j dXMgY29udHJvbGxlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM1NDAyCisKKyAgICAgICAgV2hlbiBwcm9ncmFtYXRpY2FsbHkgc2V0dGluZyBmb2N1 cyB0byBhbiBlbGVtZW50IGluIGFuIGlubmVyIGRvY3VtZW50LAorICAgICAgICBjYWxsaW5nICJo YXNGb2N1cygpIiBmcm9tIHRoaXMgZG9jdW1lbnQgcmV0dXJucyBGQUxTRSwgYmVjYXVzZQorICAg ICAgICBkb2N1bWVudCdzIEZvY3VzQ29udHJvbGxlciBpcyBub3QgYWN0aXZhdGVkLiBJdCBkb2Vz IG5vdCBoYXBwZW4KKyAgICAgICAgaWYgfGRvY3VtZW50fCBpcyB0aGUgbWFpbiBkb2N1bWVudC4K KworICAgICAgICBNYWtpbmcgd2Via2l0X3dlYl92aWV3X2dyYWJfZm9jdXMgdG8gYWN0dWFsbHkg YWN0aXZhdGUgdGhlIEZvY3VzQ29udHJvbGxlciwKKyAgICAgICAgZml4ZXMgdGhlIGlzc3VlLgor CisgICAgICAgICogdGVzdHMvdGVzdHdlYnZpZXcuYzoKKyAgICAgICAgKHNlcnZlcl9jYWxsYmFj ayk6CisgICAgICAgICh0ZXN0X3dlYmtpdF93ZWJfdmlld19ncmFiX2ZvY3VzKToKKyAgICAgICAg KiB3ZWJraXQvd2Via2l0d2Vidmlldy5jcHA6CisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfZ3Jh Yl9mb2N1cyk6CisKIDIwMTAtMDItMjQgIEtyenlzenRvZiBLb3RsZW5nYSA8cG9jZWtAdXNlcnMu c2YubmV0PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9yb25oYSBTaWx2YS4KZGlm ZiAtLWdpdCBhL1dlYktpdC9ndGsvdGVzdHMvdGVzdHdlYnZpZXcuYyBiL1dlYktpdC9ndGsvdGVz dHMvdGVzdHdlYnZpZXcuYwppbmRleCBjZWFjOGEwLi5hMzZlMWY1IDEwMDY0NAotLS0gYS9XZWJL aXQvZ3RrL3Rlc3RzL3Rlc3R3ZWJ2aWV3LmMKKysrIGIvV2ViS2l0L2d0ay90ZXN0cy90ZXN0d2Vi dmlldy5jCkBAIC01OCwxMCArNTgsMTAgQEAgc2VydmVyX2NhbGxiYWNrKFNvdXBTZXJ2ZXIqIHNl cnZlciwgU291cE1lc3NhZ2UqIG1zZywKIAogICAgICAgICBzb3VwX21lc3NhZ2VfYm9keV9hcHBl bmQobXNnLT5yZXNwb25zZV9ib2R5LCBTT1VQX01FTU9SWV9UQUtFLCBjb250ZW50cywgbGVuZ3Ro KTsKICAgICB9IGVsc2UgaWYgKGdfc3RyX2VxdWFsKHBhdGgsICIvYmlnZGl2Lmh0bWwiKSkgewot ICAgICAgICBjaGFyKiBjb250ZW50cyA9IGdfc3RyZHVwKCI8aHRtbD48Ym9keT48ZGl2IHN0eWxl PVwiYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47IGhlaWdodDogMTIwMHB4O1wiPjwvZGl2PjwvYm9k eT48L2h0bWw+Iik7CisgICAgICAgIGNoYXIqIGNvbnRlbnRzID0gZ19zdHJkdXAoIjxodG1sPjxi b2R5PjxhIGlkPVwibGlua1wiIGhyZWY9XCJodHRwOi8vYWJjLmRlZlwiPnRlc3Q8L2E+PGRpdiBz dHlsZT1cImJhY2tncm91bmQtY29sb3I6IGdyZWVuOyBoZWlnaHQ6IDEyMDBweDtcIj48L2Rpdj48 L2JvZHk+PC9odG1sPiIpOwogICAgICAgICBzb3VwX21lc3NhZ2VfYm9keV9hcHBlbmQobXNnLT5y ZXNwb25zZV9ib2R5LCBTT1VQX01FTU9SWV9UQUtFLCBjb250ZW50cywgc3RybGVuKGNvbnRlbnRz KSk7CiAgICAgfSBlbHNlIGlmIChnX3N0cl9lcXVhbChwYXRoLCAiL2lmcmFtZS5odG1sIikpIHsK LSAgICAgICAgY2hhciogY29udGVudHMgPSBnX3N0cmR1cCgiPGh0bWw+PGJvZHk+PGRpdiBzdHls ZT1cImJhY2tncm91bmQtY29sb3I6IGdyZWVuOyBoZWlnaHQ6IDUwcHg7XCI+PC9kaXY+PGlmcmFt ZSBzcmM9XCJiaWdkaXYuaHRtbFwiPjwvaWZyYW1lPjwvYm9keT48L2h0bWw+Iik7CisgICAgICAg IGNoYXIqIGNvbnRlbnRzID0gZ19zdHJkdXAoIjxodG1sPjxib2R5IGlkPVwic29tZS1jb250ZW50 XCI+PGRpdiBzdHlsZT1cImJhY2tncm91bmQtY29sb3I6IGdyZWVuOyBoZWlnaHQ6IDUwcHg7XCI+ PC9kaXY+PGlmcmFtZSBzcmM9XCJiaWdkaXYuaHRtbFwiPjwvaWZyYW1lPjwvYm9keT48L2h0bWw+ Iik7CiAgICAgICAgIHNvdXBfbWVzc2FnZV9ib2R5X2FwcGVuZChtc2ctPnJlc3BvbnNlX2JvZHks IFNPVVBfTUVNT1JZX1RBS0UsIGNvbnRlbnRzLCBzdHJsZW4oY29udGVudHMpKTsKICAgICB9IGVs c2UgewogICAgICAgICBjaGFyKiBjb250ZW50cyA9IGdfc3RyZHVwKCI8aHRtbD48Ym9keT50ZXN0 PC9ib2R5PjwvaHRtbD4iKTsKQEAgLTEzNyw2ICsxMzcsNjMgQEAgc3RhdGljIGdib29sZWFuIG1h cF9ldmVudF9jYihHdGtXaWRnZXQgKndpZGdldCwgR2RrRXZlbnQqIGV2ZW50LCBncG9pbnRlciBk YXRhKQogICAgIHJldHVybiBGQUxTRTsKIH0KIAorc3RhdGljIHZvaWQgdGVzdF93ZWJraXRfd2Vi X3ZpZXdfZ3JhYl9mb2N1cygpCit7CisgICAgY2hhciogdXJpID0gZ19zdHJjb25jYXQoYmFzZV91 cmksICJpZnJhbWUuaHRtbCIsIE5VTEwpOworICAgIEd0a1dpZGdldCogd2luZG93ID0gZ3RrX3dp bmRvd19uZXcoR1RLX1dJTkRPV19QT1BVUCk7CisgICAgR3RrV2lkZ2V0KiBzY3JvbGxlZF93aW5k b3cgPSBndGtfc2Nyb2xsZWRfd2luZG93X25ldyhOVUxMLCBOVUxMKTsKKyAgICBXZWJLaXRXZWJW aWV3KiB2aWV3ID0gV0VCS0lUX1dFQl9WSUVXKHdlYmtpdF93ZWJfdmlld19uZXcoKSk7CisgICAg R3RrQWRqdXN0bWVudCogYWRqdXN0bWVudDsKKworICAgIGd0a193aW5kb3dfc2V0X2RlZmF1bHRf c2l6ZShHVEtfV0lORE9XKHdpbmRvdyksIDQwMCwgMjAwKTsKKworICAgIGd0a19jb250YWluZXJf YWRkKEdUS19DT05UQUlORVIod2luZG93KSwgc2Nyb2xsZWRfd2luZG93KTsKKyAgICBndGtfY29u dGFpbmVyX2FkZChHVEtfQ09OVEFJTkVSKHNjcm9sbGVkX3dpbmRvdyksIEdUS19XSURHRVQodmll dykpOworCisgICAgZ3RrX3Njcm9sbGVkX3dpbmRvd19zZXRfcG9saWN5KEdUS19TQ1JPTExFRF9X SU5ET1coc2Nyb2xsZWRfd2luZG93KSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgR1RLX1BPTElDWV9BVVRPTUFUSUMsIEdUS19QT0xJQ1lfQVVUT01BVElDKTsKKworICAgIGxv b3AgPSBnX21haW5fbG9vcF9uZXcoTlVMTCwgVFJVRSk7CisKKyAgICBnX29iamVjdF9jb25uZWN0 KEdfT0JKRUNUKHZpZXcpLAorICAgICAgICAgICAgICAgICAgICAgInNpZ25hbDo6bm90aWZ5Ojpw cm9ncmVzcyIsIGlkbGVfcXVpdF9sb29wX2NiLCBOVUxMLAorICAgICAgICAgICAgICAgICAgICAg TlVMTCk7CisKKyAgICAvKiBXYWl0IGZvciB3aW5kb3cgdG8gc2hvdyB1cCAqLworICAgIGd0a193 aWRnZXRfc2hvd19hbGwod2luZG93KTsKKyAgICBnX3NpZ25hbF9jb25uZWN0KHdpbmRvdywgIm1h cC1ldmVudCIsCisgICAgICAgICAgICAgICAgICAgICBHX0NBTExCQUNLKG1hcF9ldmVudF9jYiks IGxvb3ApOworICAgIGdfbWFpbl9sb29wX3J1bihsb29wKTsKKworICAgIC8qIExvYWQgYSBwYWdl IHdpdGggYSBiaWcgZGl2IHRoYXQgd2lsbCBjYXVzZSBzY3JvbGxiYXJzIHRvIGFwcGVhciAqLwor ICAgIHdlYmtpdF93ZWJfdmlld19sb2FkX3VyaSh2aWV3LCB1cmkpOworICAgIGdfbWFpbl9sb29w X3J1bihsb29wKTsKKworICAgIGFkanVzdG1lbnQgPSBndGtfc2Nyb2xsZWRfd2luZG93X2dldF92 YWRqdXN0bWVudChHVEtfU0NST0xMRURfV0lORE9XKHNjcm9sbGVkX3dpbmRvdykpOworICAgIGdf YXNzZXJ0X2NtcGZsb2F0KGd0a19hZGp1c3RtZW50X2dldF92YWx1ZShhZGp1c3RtZW50KSwgPT0s IDAuMCk7CisKKyAgICAvKiBTaW5jZSB3ZWJraXRfd2ViX3ZpZXdfZXhlY3V0ZV9zY3JpcHQgZG9l cyBub3QgcmV0dXJuIGEgdmFsdWUsCisgICAgICAgaXQgaXMgaW1wb3NzaWJsZSB0byBrbm93IGlm IGFuIGlubmVyIGRvY3VtZW50IGhhcyBmb2N1cyBhZnRlcgorICAgICAgIGEgbm9kZSBvZiBpdCB3 YXMgZm9jdXNlZCB2aWEgLmZvY3VzKCkgbWV0aG9kLgorICAgICAgIFRoZSBjb2RlIGJlbG93IGlz IGFuIHdvcmRhcm91bmQ6IGlmIHRoZSBub2RlIGhhcyBmb2N1cywgYSBzY3JvbGwKKyAgICAgICBh Y3Rpb24gaXMgcGVyZm9ybWVkIGFuZCBhZnRlcndhcmQgaXQgaXMgY2hlY2tlZCBpZiB0aGUgYWRq dXN0bWVudAorICAgICAgIGhhcyB0byBiZSBkaWZmZXJlbnQgZnJvbSAwLgorICAgICovCisgICAg Y2hhciBzY3JpcHRbXSA9ICJ2YXIgaW5uZXJEb2MgPSBkb2N1bWVudC5kZWZhdWx0Vmlldy5mcmFt ZXNbMF0uZG9jdW1lbnQ7IFwKKyAgICAgICAgICAgICAgICAgICAgIGlubmVyRG9jLmdldEVsZW1l bnRCeUlkKFwibGlua1wiKS5mb2N1cygpOyAgICAgICAgICAgICAgXAorICAgICAgICAgICAgICAg ICAgICAgaWYgKGlubmVyRG9jLmhhc0ZvY3VzKCkpICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBcCisgICAgICAgICAgICAgICAgICAgICAgICB3aW5kb3cuc2Nyb2xsQnkoMCwgMTAwKTsi OworCisgICAgLyogRm9jdXMgYW4gZWxlbWVudCB1c2luZyBKYXZhU2NyaXB0ICovCisgICAgd2Vi a2l0X3dlYl92aWV3X2V4ZWN1dGVfc2NyaXB0KHZpZXcsIHNjcmlwdCk7CisKKyAgICAvKiBNYWtl IHN1cmUgdGhlIFNjcm9sbGVkV2luZG93IG5vdGljZWQgdGhlIHNjcm9sbCAqLworICAgIGdfYXNz ZXJ0X2NtcGZsb2F0KGd0a19hZGp1c3RtZW50X2dldF92YWx1ZShhZGp1c3RtZW50KSwgIT0sIDAu MCk7CisKKyAgICBnX2ZyZWUodXJpKTsKKyAgICBndGtfd2lkZ2V0X2Rlc3Ryb3kod2luZG93KTsK K30KKwogc3RhdGljIHZvaWQgZG9fdGVzdF93ZWJraXRfd2ViX3ZpZXdfYWRqdXN0bWVudHMoZ2Jv b2xlYW4gd2l0aF9wYWdlX2NhY2hlKQogewogICAgIGNoYXIqIGVmZmVjdGl2ZV91cmkgPSBnX3N0 cmNvbmNhdChiYXNlX3VyaSwgImJpZ2Rpdi5odG1sIiwgTlVMTCk7CkBAIC0yNTEsNiArMzA4LDcg QEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQogICAgIGdfdGVzdF9idWdfYmFzZSgi aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvIik7CiAgICAgZ190ZXN0X2FkZF9mdW5jKCIvd2Via2l0 L3dlYnZpZXcvaWNvbi11cmkiLCB0ZXN0X3dlYmtpdF93ZWJfdmlld19pY29uX3VyaSk7CiAgICAg Z190ZXN0X2FkZF9mdW5jKCIvd2Via2l0L3dlYnZpZXcvYWRqdXN0bWVudHMiLCB0ZXN0X3dlYmtp dF93ZWJfdmlld19hZGp1c3RtZW50cyk7CisgICAgZ190ZXN0X2FkZF9mdW5jKCIvd2Via2l0L3dl YnZpZXcvZ3JhYl9mb2N1cyIsIHRlc3Rfd2Via2l0X3dlYl92aWV3X2dyYWJfZm9jdXMpOwogCiAg ICAgcmV0dXJuIGdfdGVzdF9ydW4gKCk7CiB9CmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtp dC93ZWJraXR3ZWJ2aWV3LmNwcCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3Bw CmluZGV4IDE2Yzk0NzcuLjNlYjM1NTUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dl YmtpdHdlYnZpZXcuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3Bw CkBAIC02NDAsNiArNjQwLDggQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X2dyYWJfZm9j dXMoR3RrV2lkZ2V0KiB3aWRnZXQpCiAgICAgICAgIFdlYktpdFdlYlZpZXcqIHdlYlZpZXcgPSBX RUJLSVRfV0VCX1ZJRVcod2lkZ2V0KTsKICAgICAgICAgRm9jdXNDb250cm9sbGVyKiBmb2N1c0Nv bnRyb2xsZXIgPSBjb3JlKHdlYlZpZXcpLT5mb2N1c0NvbnRyb2xsZXIoKTsKIAorICAgICAgICBm b2N1c0NvbnRyb2xsZXItPnNldEFjdGl2ZSh0cnVlKTsKKwogICAgICAgICBpZiAoZm9jdXNDb250 cm9sbGVyLT5mb2N1c2VkRnJhbWUoKSkKICAgICAgICAgICAgIGZvY3VzQ29udHJvbGxlci0+c2V0 Rm9jdXNlZCh0cnVlKTsKICAgICAgICAgZWxzZQotLSAKMS42LjAuNAoK