35398 2010-02-25 12:10:48 -0800 Race condition in JSPropertyNameIterator and Structure destruction 2010-02-25 14:15:38 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 oliver webkit-unassigned oldest_to_newest 193823 0 oliver 2010-02-25 12:10:48 -0800 Race condition in JSPropertyNameIterator and Structure destruction 193829 1 49516 oliver 2010-02-25 12:21:53 -0800 Created attachment 49516 Patch 193836 2 49516 mjs 2010-02-25 12:28:53 -0800 Comment on attachment 49516 Patch r=me 193848 3 49516 darin 2010-02-25 12:45:50 -0800 Comment on attachment 49516 Patch > + void setCachedStructure(Structure* structure) How about PassRefPtr for this argument? 193880 4 oliver 2010-02-25 14:15:38 -0800 Committed r55256: <http://trac.webkit.org/changeset/55256> 49516 2010-02-25 12:21:53 -0800 2010-02-25 12:45:50 -0800 Patch bug-35398-20100225122151.patch text/plain 6642 oliver ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA1OGVlZWU4Li4xYWVjYjUyIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsNDAg QEAKKzIwMTAtMDItMjUgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSYWNlIGNvbmRpdGlvbiBp biBKU1Byb3BlcnR5TmFtZUl0ZXJhdG9yIGFuZCBTdHJ1Y3R1cmUgZGVzdHJ1Y3Rpb24KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1Mzk4CisKKyAgICAg ICAgSlNQcm9wZXJ0eU5hbWVJdGVyYXRvciBhbmQgU3RydWN0dXJlIGhhdmUgYSBjeWNsaWMgZGVw ZW5kZW5jeSB0aGF0IHRoZXkKKyAgICAgICAgbWFuYWdlIGJ5IGNsZWFyaW5nIHRoZSBhcHByb3By aWF0ZSByZWZlcmVuY2UgaW4gZWFjaCBvdGhlciBkdXJpbmcgdGhlaXIKKyAgICAgICAgZGVzdHJ1 Y3Rpb24uICBIb3dldmVyIGlmIHRoZSBTdHJ1Y3R1cmUgaXMgZGVzdHJveWVkIHdoaWxlIHRoZSAK KyAgICAgICAgSlNQcm9wZXJ0eU5hbWVJdGVyYXRvciBpcyBkZWFkIGJ1dCBub3QgeWV0IGZpbmFs aXplZCB0aGUgU3RydWN0dXJlcworICAgICAgICBXZWFrR0NQdHIgd2lsbCByZXR1cm4gbnVsbCwg YW5kIHNvIHByZXZlbnQgU3RydWN0dXJlIGZyb20gY2xlYXJpbmcKKyAgICAgICAgdGhlIG1fY2Fj aGVkU3RydWN0dXJlIHBvaW50ZXIgb2YgdGhlIGl0ZXJhdG9yLiAgV2hlbiB0aGUgaXRlcmF0b3Ig aXMKKyAgICAgICAgdGhlbiBmaW5hbGlzZWQgdGhlIG1fY2FjaGVkU3RydWN0dXJlIGlzIGludmFs aWQsIGFuZCB0aGUgYXR0ZW1wdCB0bworICAgICAgICBjbGVhciB0aGUgc3RydWN0dXJlcyBiYWNr IHJlZmVyZW5jZSBmYWlscy4KKworICAgICAgICBUbyBmaXggdGhpcyB3ZSBzaW1wbHkgbWFrZSBK U1Byb3BlcnR5TmFtZUl0ZXJhdG9yIGtlZXAgdGhlIFN0cnVjdHVyZQorICAgICAgICBhbGl2ZSwg dXNpbmcgdGhlIHdlYWsgcG9pbnRlciB0byBicmVhayB0aGUgcmVmIGN5Y2xlLgorCisgICAgICAg ICogcnVudGltZS9KU1Byb3BlcnR5TmFtZUl0ZXJhdG9yLmNwcDoKKyAgICAgICAgKEpTQzo6SlNQ cm9wZXJ0eU5hbWVJdGVyYXRvcjo6fkpTUHJvcGVydHlOYW1lSXRlcmF0b3IpOgorICAgICAgICAg IFRoZSBpdGVyYXRvciBub3cga2VlcHMgbV9jYWNoZWRTdHJ1Y3R1cmUgYWxpdmUgaXRzZWxmLCBz byBubyBsb25nZXIgbmVlZHMKKyAgICAgICAgICB0byBjaGVjayBmb3IgaXQgYmVpbmcgY2xlYXJl ZAorICAgICAgICAqIHJ1bnRpbWUvSlNQcm9wZXJ0eU5hbWVJdGVyYXRvci5oOgorICAgICAgICAo SlNDOjpKU1Byb3BlcnR5TmFtZUl0ZXJhdG9yOjpzZXRDYWNoZWRTdHJ1Y3R1cmUpOgorICAgICAg ICAgIEFkZCBhbiBhc3NlcnRpb24gdG8gZW5zdXJlIGNvcnJlY3QgdXNhZ2UKKyAgICAgICAgKEpT Qzo6SlNQcm9wZXJ0eU5hbWVJdGVyYXRvcjo6Y2FjaGVkU3RydWN0dXJlKToKKyAgICAgICAgICBB ZGQgLmdldCgpCisgICAgICAgICogcnVudGltZS9TdHJ1Y3R1cmUuY3BwOgorICAgICAgICAoSlND OjpTdHJ1Y3R1cmU6On5TdHJ1Y3R1cmUpOgorICAgICAgICAgIEFkZCBhbiBhc3NlcnRpb24gdGhh dCBvdXIgaXRlcmF0b3IgaXNuJ3QgYWxyZWFkeSBkZWFkLCBhbmQgcmVtb3ZlCisgICAgICAgICAg dGhlIG5vdyB1bm5lY2Vzc2FyeSBhdHRlbXB0IHRvIGNsZWFyIHRoZSByZWYgaW4gdGhlIGl0ZXJh dG9yCisgICAgICAgICogcnVudGltZS9XZWFrR0NQdHIuaDoKKyAgICAgICAgKEpTQzo6V2Vha0dD UHRyOjpoYXNEZWFkT2JqZWN0KToKKyAgICAgICAgICBBbiBhc3NlcnQtb25seSBmdW5jdGlvbiB0 byBhbGxvdyB1cyB0byBhc3NlcnQgY29ycmVjdCBiZWhhdmlvdXIKKyAgICAgICAgICBpbiB0aGUg U3RydWN0dXJlIGRlc3RydWN0b3IKKwogMjAxMC0wMi0yNSAgSm9jaGVuIEVpc2luZ2VyICA8am9j aGVuQGNocm9taXVtLm9yZz4KICAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmVyZW15IE9ybG93Lgpk aWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1Byb3BlcnR5TmFtZUl0ZXJhdG9y LmNwcCBiL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNQcm9wZXJ0eU5hbWVJdGVyYXRvci5jcHAK aW5kZXggYTVkNGRhMC4uMmU4NWE5YiAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9KU1Byb3BlcnR5TmFtZUl0ZXJhdG9yLmNwcAorKysgYi9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTUHJvcGVydHlOYW1lSXRlcmF0b3IuY3BwCkBAIC00OSw4ICs0OSw3IEBAIGlubGluZSBKU1By b3BlcnR5TmFtZUl0ZXJhdG9yOjpKU1Byb3BlcnR5TmFtZUl0ZXJhdG9yKEV4ZWNTdGF0ZSogZXhl YywgUHJvcGVydHlOCiAKIEpTUHJvcGVydHlOYW1lSXRlcmF0b3I6On5KU1Byb3BlcnR5TmFtZUl0 ZXJhdG9yKCkKIHsKLSAgICBpZiAobV9jYWNoZWRTdHJ1Y3R1cmUpCi0gICAgICAgIG1fY2FjaGVk U3RydWN0dXJlLT5jbGVhckVudW1lcmF0aW9uQ2FjaGUodGhpcyk7CisgICAgbV9jYWNoZWRTdHJ1 Y3R1cmUtPmNsZWFyRW51bWVyYXRpb25DYWNoZSh0aGlzKTsKIH0KIAogSlNQcm9wZXJ0eU5hbWVJ dGVyYXRvciogSlNQcm9wZXJ0eU5hbWVJdGVyYXRvcjo6Y3JlYXRlKEV4ZWNTdGF0ZSogZXhlYywg SlNPYmplY3QqIG8pCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTUHJvcGVy dHlOYW1lSXRlcmF0b3IuaCBiL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNQcm9wZXJ0eU5hbWVJ dGVyYXRvci5oCmluZGV4IDNmNTMzYTAuLjAxNzAwYWMgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvSlNQcm9wZXJ0eU5hbWVJdGVyYXRvci5oCisrKyBiL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSlNQcm9wZXJ0eU5hbWVJdGVyYXRvci5oCkBAIC02Nyw4ICs2NywxMyBAQCBuYW1l c3BhY2UgSlNDIHsKICAgICAgICAgSlNWYWx1ZSBnZXQoRXhlY1N0YXRlKiwgSlNPYmplY3QqLCBz aXplX3QgaSk7CiAgICAgICAgIHNpemVfdCBzaXplKCkgeyByZXR1cm4gbV9qc1N0cmluZ3NTaXpl OyB9CiAKLSAgICAgICAgdm9pZCBzZXRDYWNoZWRTdHJ1Y3R1cmUoU3RydWN0dXJlKiBzdHJ1Y3R1 cmUpIHsgbV9jYWNoZWRTdHJ1Y3R1cmUgPSBzdHJ1Y3R1cmU7IH0KLSAgICAgICAgU3RydWN0dXJl KiBjYWNoZWRTdHJ1Y3R1cmUoKSB7IHJldHVybiBtX2NhY2hlZFN0cnVjdHVyZTsgfQorICAgICAg ICB2b2lkIHNldENhY2hlZFN0cnVjdHVyZShTdHJ1Y3R1cmUqIHN0cnVjdHVyZSkKKyAgICAgICAg eworICAgICAgICAgICAgQVNTRVJUKCFtX2NhY2hlZFN0cnVjdHVyZSk7CisgICAgICAgICAgICBB U1NFUlQoc3RydWN0dXJlKTsKKyAgICAgICAgICAgIG1fY2FjaGVkU3RydWN0dXJlID0gc3RydWN0 dXJlOworICAgICAgICB9CisgICAgICAgIFN0cnVjdHVyZSogY2FjaGVkU3RydWN0dXJlKCkgeyBy ZXR1cm4gbV9jYWNoZWRTdHJ1Y3R1cmUuZ2V0KCk7IH0KIAogICAgICAgICB2b2lkIHNldENhY2hl ZFByb3RvdHlwZUNoYWluKE5vbk51bGxQYXNzUmVmUHRyPFN0cnVjdHVyZUNoYWluPiBjYWNoZWRQ cm90b3R5cGVDaGFpbikgeyBtX2NhY2hlZFByb3RvdHlwZUNoYWluID0gY2FjaGVkUHJvdG90eXBl Q2hhaW47IH0KICAgICAgICAgU3RydWN0dXJlQ2hhaW4qIGNhY2hlZFByb3RvdHlwZUNoYWluKCkg eyByZXR1cm4gbV9jYWNoZWRQcm90b3R5cGVDaGFpbi5nZXQoKTsgfQpAQCAtNzYsNyArODEsNyBA QCBuYW1lc3BhY2UgSlNDIHsKICAgICBwcml2YXRlOgogICAgICAgICBKU1Byb3BlcnR5TmFtZUl0 ZXJhdG9yKEV4ZWNTdGF0ZSosIFByb3BlcnR5TmFtZUFycmF5RGF0YSogcHJvcGVydHlOYW1lQXJy YXlEYXRhLCBzaXplX3QgbnVtQ2FjaGVhYmxlU2xvdCk7CiAKLSAgICAgICAgU3RydWN0dXJlKiBt X2NhY2hlZFN0cnVjdHVyZTsKKyAgICAgICAgUmVmUHRyPFN0cnVjdHVyZT4gbV9jYWNoZWRTdHJ1 Y3R1cmU7CiAgICAgICAgIFJlZlB0cjxTdHJ1Y3R1cmVDaGFpbj4gbV9jYWNoZWRQcm90b3R5cGVD aGFpbjsKICAgICAgICAgdWludDMyX3QgbV9udW1DYWNoZWFibGVTbG90czsKICAgICAgICAgdWlu dDMyX3QgbV9qc1N0cmluZ3NTaXplOwpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9TdHJ1Y3R1cmUuY3BwIGIvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmUuY3BwCmlu ZGV4IGViZjhhNGMuLjZmMjNjN2QgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv U3RydWN0dXJlLmNwcAorKysgYi9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5jcHAK QEAgLTI2NSw5ICsyNjUsNyBAQCBTdHJ1Y3R1cmU6On5TdHJ1Y3R1cmUoKQogICAgICAgICBtX3By ZXZpb3VzLT50cmFuc2l0aW9uVGFibGVSZW1vdmUobWFrZV9wYWlyKG1fbmFtZUluUHJldmlvdXMu Z2V0KCksIG1fYXR0cmlidXRlc0luUHJldmlvdXMpLCBtX3NwZWNpZmljVmFsdWVJblByZXZpb3Vz KTsKIAogICAgIH0KLSAgICAKLSAgICBpZiAobV9lbnVtZXJhdGlvbkNhY2hlKQotICAgICAgICBt X2VudW1lcmF0aW9uQ2FjaGUtPnNldENhY2hlZFN0cnVjdHVyZSgwKTsKKyAgICBBU1NFUlQoIW1f ZW51bWVyYXRpb25DYWNoZS5oYXNEZWFkT2JqZWN0KCkpOwogCiAgICAgaWYgKG1fcHJvcGVydHlU YWJsZSkgewogICAgICAgICB1bnNpZ25lZCBlbnRyeUNvdW50ID0gbV9wcm9wZXJ0eVRhYmxlLT5r ZXlDb3VudCArIG1fcHJvcGVydHlUYWJsZS0+ZGVsZXRlZFNlbnRpbmVsQ291bnQ7CmRpZmYgLS1n aXQgYS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1dlYWtHQ1B0ci5oIGIvSmF2YVNjcmlwdENvcmUv cnVudGltZS9XZWFrR0NQdHIuaAppbmRleCAzZWQ0NjQ1Li41ZjU4Mzc0IDEwMDY0NAotLS0gYS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL1dlYWtHQ1B0ci5oCisrKyBiL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvV2Vha0dDUHRyLmgKQEAgLTY1LDYgKzY1LDEwIEBAIHB1YmxpYzoKIAogICAgIFdlYWtH Q1B0ciYgb3BlcmF0b3I9KFQqKTsKIAorI2lmICFBU1NFUlRfRElTQUJMRUQKKyAgICBib29sIGhh c0RlYWRPYmplY3QoKSBjb25zdCB7IHJldHVybiAhIW1fcHRyOyB9CisjZW5kaWYKKwogcHJpdmF0 ZToKICAgICB2b2lkIGFzc2lnbihUKiBwdHIpCiAgICAgewpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDUxOGM5NTMuLmMwYTI2 MDkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMi0yNSAgT2xpdmVyIEh1bnQgIDxvbGl2 ZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJhY2UgY29uZGl0aW9uIGluIEpTUHJvcGVydHlOYW1lSXRlcmF0b3IgYW5kIFN0cnVj dHVyZSBkZXN0cnVjdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzUzOTgKKworICAgICAgICBBZGQgdGVzdCB0byBlbnN1cmUgdGhhdCB0aGlzIHJh Y2UgY29uZGl0aW9uIGRvZXNuJ3Qgb2NjdXIuCisKKyAgICAgICAgKiBmYXN0L2pzL3NjcmlwdC10 ZXN0cy9mb3ItaW4tY2FjaGVkLmpzOgorICAgICAgICAoY2FjaGVDbGVhcmluZyk6CisKIDIwMTAt MDItMjUgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogZXZhbHVhdGUtb24taG92ZXIgZG9lcyBub3Qgd29yayBvbiBIVE1MIGZp bGVzLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvZm9yLWlu LWNhY2hlZC5qcyBiL0xheW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0LXRlc3RzL2Zvci1pbi1jYWNo ZWQuanMKaW5kZXggYzg2ZDYyYy4uOGExYTE0YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFz dC9qcy9zY3JpcHQtdGVzdHMvZm9yLWluLWNhY2hlZC5qcworKysgYi9MYXlvdXRUZXN0cy9mYXN0 L2pzL3NjcmlwdC10ZXN0cy9mb3ItaW4tY2FjaGVkLmpzCkBAIC02NCw1ICs2NCwxMyBAQCBzaG91 bGRCZSgiZm9ySW41KHtnZXQgZm9vKCkgeyByZXR1cm4gJ2NhbGxlZCBnZXR0ZXInfSB9KSIsICJb J2ZvbycsICdjYWxsZWQgZ2V0dAogc2hvdWxkQmUoImZvckluNSh7c2V0IGZvbygpIHsgfSB9KSIs ICJbJ2ZvbycsIHVuZGVmaW5lZF0iKTsKIHNob3VsZEJlKCJmb3JJbjUoe2dldCBmb28oKSB7IHJl dHVybiAnY2FsbGVkIGdldHRlcid9LCBzZXQgZm9vKCkgeyB9fSkiLCAiWydmb28nLCAnY2FsbGVk IGdldHRlciddIik7CiAKK2Z1bmN0aW9uIGNhY2hlQ2xlYXJpbmcoKSB7CisgICAgZm9yKHZhciBq PTA7IGogPCAxMDsgaisrKXsKKyAgICAgICAgdmFyIG8gPSB7YToxLGI6MixjOjMsZDo0LGU6NX0K KyAgICAgICAgdHJ5IHtmb3IgKGkgaW4gbykgeyBkZWxldGUgby5hOyBvID0gbnVsbDsgdGhyb3cg IiIgfTt9ZmluYWxseXtjb250aW51ZX0KKyAgICB9Cit9CisKK2NhY2hlQ2xlYXJpbmcoKQogCiB2 YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsK