3537 2005-06-14 18:33:03 -0700 object.constructor returns incorrect object 2005-11-02 08:48:01 -0800 1 1 1 Unclassified WebKit JavaScriptCore 412 Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 david eric paul vicki oldest_to_newest 12049 0 david 2005-06-14 18:33:03 -0700 A growing trend (IMO) in JavaScript is to use objects for namespaces. However, when an object constructor is an attribute of an object, the Function.toString() method thinks its an internal function. For example, this code: var Foo = {}; Foo.Bar = function () { this.bar = 1; }; var f = new Foo.Bar(); document.write(Function.toString.call(f.constructor)); Outputs "(Internal Function)" in Safari and "function () { this.bar = 1; }" in Firefox. Can Safari be updated to output the same string as Firefox? 12050 1 david 2005-06-14 18:40:43 -0700 Actually, looking more closly at it, I realize that the problem is not the stringification of the constructor of an object created in a class that uses objects for namespaces. The problem is that Function.constructor() returns the wrong function object! var Foo = {}; Foo.Bar = function () { this.bar = 1; }; var f = new Foo.Bar(); document.write(Function.toString.call(f.constructor)); Again, this outputs "(Internal Function)" because the return value of f.constructor is not the actual constructor function. I have no idea what function it's returning. Thanks! 12051 2 david 2005-06-14 18:41:41 -0700 > Function.constructor() returns the wrong function object! Uh, make that the constructor attribute of the object has the wrong object. 12054 3 david 2005-06-14 18:53:36 -0700 Here's a simpler test case: var Foo = { Bar: function () {}}; var f = new Foo.Bar(); document.write(f.constructor == Foo.Bar); This code outputs true in Firefox, but false in Safari. It should output true. 12064 4 joost 2005-06-14 23:23:06 -0700 I'll add the testcase in the comment below as a real testcase, please do so next time you post a bug :). And i will confirm it, since the behavior IS different from firefox and some will have to look in to it. 12066 5 2347 joost 2005-06-14 23:24:32 -0700 Created attachment 2347 testcase 20671 6 4069 eric 2005-09-27 11:25:58 -0700 Created attachment 4069 Test case showing broken nameless function support. 20674 7 eric 2005-09-27 12:41:47 -0700 *** Bug 4042 has been marked as a duplicate of this bug. *** 20681 8 4071 eric 2005-09-27 14:26:08 -0700 Created attachment 4071 A small patch to fix this. 20682 9 mjs 2005-09-27 15:46:08 -0700 I suggested to Eric that he also test the case of the Function constructor. 20683 10 4071 mjs 2005-09-27 15:57:44 -0700 Comment on attachment 4071 A small patch to fix this. r=me Make sure to make the test case also cover the new Function() case. 23529 11 david 2005-11-02 08:48:01 -0800 Shouldn't the first example in the test case also evaluate to true? 2347 2005-06-14 23:24:32 -0700 2005-09-27 11:25:58 -0700 testcase testcase-javascript-constructors.html text/html 231 joost PGh0bWw+CjxoZWFkPgoJPHRpdGxlPlRlc3RjYXNlIGZvciBiZyAzNTM3PC90aXRsZT4KPC9oZWFk PgoKPGJvZHk+CjxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KCXZhciBGb28gPSB7IEJh cjogZnVuY3Rpb24gKCkge319OwogIAkJdmFyIGYgPSBuZXcgRm9vLkJhcigpOwoJCWRvY3VtZW50 LndyaXRlKGYuY29uc3RydWN0b3IgPT0gRm9vLkJhcik7Cjwvc2NyaXB0Pgo8L2JvZHk+CjwvaHRt bD4K 4069 2005-09-27 11:25:58 -0700 2005-09-27 11:25:58 -0700 Test case showing broken nameless function support. testcase-javascript-constructors.html text/html 716 eric PGh0bWw+CjxoZWFkPgoJPHRpdGxlPlRlc3RjYXNlIGZvciBidWcgMzUzNzwvdGl0bGU+CjwvaGVh ZD4KCjxib2R5PgpUaGlzIHRlc3QgY2FzZSBzaG93cyBob3cgaHR0cDovL2J1Z3ppbGxhLm9wZW5k YXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTM3IGZhaWxzIHRvIGR1ZSBicm9rZW4gbmFtZWxl c3MgZnVuY3Rpb24gc3VwcG9ydC4KPGJyPjxicj4KPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3Jp cHQiPgoJdmFyIEZvbyA9IHsgQmFyOiBmdW5jdGlvbiAoKSB7fX07Cgl2YXIgZiA9IG5ldyBGb28u QmFyKCk7Cglkb2N1bWVudC53cml0ZSgiZi5jb25zdHJ1Y3RvciA9PSBGb28uQmFyIDogIiArIChm LmNvbnN0cnVjdG9yID09IEZvby5CYXIpICsgIjxicj4iKTsKCWRvY3VtZW50LndyaXRlKCJmLmNv bnN0cnVjdG9yOiAiICsgZi5jb25zdHJ1Y3RvciArICI8YnI+Iik7CgkKCWRvY3VtZW50LndyaXRl KCI8YnI+Iik7CgkKCWZ1bmN0aW9uIEYoKSB7fTsKCXZhciBGb28yID0geyBCYXI6IEZ9OwogIAl2 YXIgZjIgPSBuZXcgRm9vMi5CYXIoKTsKCWRvY3VtZW50LndyaXRlKCJmMi5jb25zdHJ1Y3RvciA9 PSBGb28yLkJhciA6ICIgKyAoZjIuY29uc3RydWN0b3IgPT0gRm9vMi5CYXIpICsgIjxicj4iKTsK CWRvY3VtZW50LndyaXRlKCJmMi5jb25zdHJ1Y3RvcjogIiArIGYyLmNvbnN0cnVjdG9yICsgIjxi cj4iKTsKPC9zY3JpcHQ+CjwvYm9keT4KPC9odG1sPgo= 4071 2005-09-27 14:26:08 -0700 2005-09-27 15:57:44 -0700 A small patch to fix this. fix.patch text/plain 845 eric SW5kZXg6IGtqcy9ub2Rlcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L0phdmFT Y3JpcHRDb3JlL2tqcy9ub2Rlcy5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuODIKZGlmZiAt cCAtdSAtcjEuODIga2pzL25vZGVzLmNwcAotLS0ga2pzL25vZGVzLmNwcAkyNCBTZXAgMjAwNSAy MjozNDoxMyAtMDAwMAkxLjgyCisrKyBranMvbm9kZXMuY3BwCTI3IFNlcCAyMDA1IDIxOjI1OjU5 IC0wMDAwCkBAIC0yMzQ1LDcgKzIzNDUsOCBAQCBWYWx1ZUltcCAqRnVuY0V4cHJOb2RlOjpldmFs dWF0ZShFeGVjU3RhCiAKICAgRnVuY3Rpb25JbXAgKmZpbXAgPSBuZXcgRGVjbGFyZWRGdW5jdGlv bkltcChleGVjLCBpZGVudCwgYm9keS5nZXQoKSwgY29udGV4dC0+c2NvcGVDaGFpbigpKTsKICAg VmFsdWVJbXAgKnJldChmaW1wKTsKLSAgVmFsdWVJbXAgKnByb3RvID0gZXhlYy0+bGV4aWNhbElu dGVycHJldGVyKCktPmJ1aWx0aW5PYmplY3QoKS0+Y29uc3RydWN0KGV4ZWMsIExpc3Q6OmVtcHR5 KCkpOworICBPYmplY3RJbXAgKnByb3RvID0gZXhlYy0+bGV4aWNhbEludGVycHJldGVyKCktPmJ1 aWx0aW5PYmplY3QoKS0+Y29uc3RydWN0KGV4ZWMsIExpc3Q6OmVtcHR5KCkpOworICBwcm90by0+ cHV0KGV4ZWMsIGNvbnN0cnVjdG9yUHJvcGVydHlOYW1lLCByZXQsIFJlYWRPbmx5fERvbnREZWxl dGV8RG9udEVudW0pOwogICBmaW1wLT5wdXQoZXhlYywgcHJvdG90eXBlUHJvcGVydHlOYW1lLCBw cm90bywgSW50ZXJuYWx8RG9udERlbGV0ZSk7CiAKICAgaW50IHBsZW4gPSAwOwo=