35355 2010-02-24 13:12:11 -0800 [Gtk] use geoclue_position_get_position_async to get geolocation position. 2010-02-26 17:00:11 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 35191 0 a.renevier webkit-unassigned commit-queue gustavo oldest_to_newest 193475 0 a.renevier 2010-02-24 13:12:11 -0800 Hi, this bug is splitted from bug 35191 193487 1 49429 a.renevier 2010-02-24 13:29:14 -0800 Created attachment 49429 patch v1.4 193831 2 49517 dpranke 2010-02-25 12:24:30 -0800 Created attachment 49517 ignore - patch for a different bug 193834 3 49517 dpranke 2010-02-25 12:25:30 -0800 Comment on attachment 49517 ignore - patch for a different bug whoops - attached patch to wrong bug. 194181 4 49429 gustavo 2010-02-26 11:31:59 -0800 Comment on attachment 49429 patch v1.4 > + No new tests, behaviour depends on system. Not quite true for this one, but we'll add tests when adding the new auth API, hopefully, thanks! 194364 5 49429 commit-queue 2010-02-26 17:00:06 -0800 Comment on attachment 49429 patch v1.4 Clearing flags on attachment: 49429 Committed r55325: <http://trac.webkit.org/changeset/55325> 194365 6 commit-queue 2010-02-26 17:00:11 -0800 All reviewed patches have been landed. Closing bug. 49429 2010-02-24 13:29:14 -0800 2010-02-26 17:00:06 -0800 patch v1.4 35355.patch text/plain 4719 a.renevier ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MmY5YWE4NC4uM2JkZTcyMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wMi0yNCAgQXJubyBSZW5ldmll ciAgPGFybm9AcmVuZXZpZXIubmV0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtHdGtdIHVzZSBnZW9jbHVlX3Bvc2l0aW9uX2dldF9wb3NpdGlvbl9h c3luYyB0byBnZXQgZ2VvbG9jYXRpb24gcG9zaXRpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTM1NQorCisgICAgICAgIE5vIG5ldyB0ZXN0cywg YmVoYXZpb3VyIGRlcGVuZHMgb24gc3lzdGVtLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL0dl b2xvY2F0aW9uU2VydmljZUd0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHZW9sb2NhdGlvblNl cnZpY2VHdGs6OnN0YXJ0VXBkYXRpbmcpOgorICAgICAgICAoV2ViQ29yZTo6R2VvbG9jYXRpb25T ZXJ2aWNlR3RrOjpnZXRfcG9zaXRpb24pOgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9HZW9sb2Nh dGlvblNlcnZpY2VHdGsuaDoKKwogMjAxMC0wMi0yMyAgRXZhbiBNYXJ0aW4gIDxldmFuQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBKZXJlbXkgT3Jsb3cuCmRpZmYgLS1naXQg YS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9HZW9sb2NhdGlvblNlcnZpY2VHdGsuY3BwIGIvV2ViQ29y ZS9wbGF0Zm9ybS9ndGsvR2VvbG9jYXRpb25TZXJ2aWNlR3RrLmNwcAppbmRleCBlZGI4ZDEwLi5m OTYxZWJiIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9HZW9sb2NhdGlvblNlcnZp Y2VHdGsuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0dlb2xvY2F0aW9uU2VydmljZUd0 ay5jcHAKQEAgLTExMywxMiArMTEzLDEzIEBAIGJvb2wgR2VvbG9jYXRpb25TZXJ2aWNlR3RrOjpz dGFydFVwZGF0aW5nKFBvc2l0aW9uT3B0aW9ucyogb3B0aW9ucykKICAgICAgICAgcmV0dXJuIGZh bHNlOwogICAgIH0KIAorICAgIG1fZ2VvY2x1ZUNsaWVudCA9IGNsaWVudDsKKworICAgIGdlb2Ns dWVfcG9zaXRpb25fZ2V0X3Bvc2l0aW9uX2FzeW5jKG1fZ2VvY2x1ZVBvc2l0aW9uLCAoR2VvY2x1 ZVBvc2l0aW9uQ2FsbGJhY2spZ2V0UG9zaXRpb25DYWxsYmFjaywgdGhpcyk7CisKICAgICBnX3Np Z25hbF9jb25uZWN0KEdfT0JKRUNUKG1fZ2VvY2x1ZVBvc2l0aW9uKSwgInBvc2l0aW9uLWNoYW5n ZWQiLAogICAgICAgICAgICAgICAgICAgICAgR19DQUxMQkFDSyhwb3NpdGlvbl9jaGFuZ2VkKSwg dGhpcyk7CiAKLSAgICBtX2dlb2NsdWVDbGllbnQgPSBjbGllbnQ7Ci0gICAgdXBkYXRlTG9jYXRp b25JbmZvcm1hdGlvbigpOwotCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKQEAgLTE1NiwyOCArMTU3 LDYgQEAgUG9zaXRpb25FcnJvciogR2VvbG9jYXRpb25TZXJ2aWNlR3RrOjpsYXN0RXJyb3IoKSBj b25zdAogICAgIHJldHVybiBtX2xhc3RFcnJvci5nZXQoKTsKIH0KIAotdm9pZCBHZW9sb2NhdGlv blNlcnZpY2VHdGs6OnVwZGF0ZUxvY2F0aW9uSW5mb3JtYXRpb24oKQotewotICAgIEFTU0VSVCht X2dlb2NsdWVQb3NpdGlvbik7Ci0KLSAgICBHT3duUHRyPEdFcnJvcj4gZXJyb3I7Ci0gICAgR093 blB0cjxHZW9jbHVlQWNjdXJhY3k+IGFjY3VyYWN5OwotCi0gICAgR2VvY2x1ZVBvc2l0aW9uRmll bGRzIGZpZWxkcyA9IGdlb2NsdWVfcG9zaXRpb25fZ2V0X3Bvc2l0aW9uKG1fZ2VvY2x1ZVBvc2l0 aW9uLCAmbV90aW1lc3RhbXAsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICZtX2xhdGl0dWRlLCAmbV9sb25naXR1ZGUsCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICZtX2FsdGl0dWRlLCAmYWNjdXJhY3kub3V0UHRyKCksCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZlcnJvci5v dXRQdHIoKSk7Ci0gICAgaWYgKGVycm9yKSB7Ci0gICAgICAgIHNldEVycm9yKFBvc2l0aW9uRXJy b3I6OlBPU0lUSU9OX1VOQVZBSUxBQkxFLCBlcnJvci0+bWVzc2FnZSk7Ci0gICAgICAgIHJldHVy bjsKLSAgICB9IGVsc2UgaWYgKCEoZmllbGRzICYgR0VPQ0xVRV9QT1NJVElPTl9GSUVMRFNfTEFU SVRVREUgJiYgZmllbGRzICYgR0VPQ0xVRV9QT1NJVElPTl9GSUVMRFNfTE9OR0lUVURFKSkgewot ICAgICAgICBzZXRFcnJvcihQb3NpdGlvbkVycm9yOjpQT1NJVElPTl9VTkFWQUlMQUJMRSwgIlBv c2l0aW9uIGNvdWxkIG5vdCBiZSBkZXRlcm1pbmVkLiIpOwotICAgICAgICByZXR1cm47Ci0gICAg fQotCi0KLX0KLQogdm9pZCBHZW9sb2NhdGlvblNlcnZpY2VHdGs6OnVwZGF0ZVBvc2l0aW9uKCkK IHsKICAgICBtX2xhc3RFcnJvciA9IDA7CkBAIC0xODksNiArMTY4LDI0IEBAIHZvaWQgR2VvbG9j YXRpb25TZXJ2aWNlR3RrOjp1cGRhdGVQb3NpdGlvbigpCiAgICAgcG9zaXRpb25DaGFuZ2VkKCk7 CiB9CiAKK3ZvaWQgR2VvbG9jYXRpb25TZXJ2aWNlR3RrOjpnZXRQb3NpdGlvbkNhbGxiYWNrKEdl b2NsdWVQb3NpdGlvbiAqcG9zaXRpb24sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBHZW9jbHVlUG9zaXRpb25GaWVsZHMgZmllbGRzLAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW50IHRpbWVzdGFtcCwKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRvdWJsZSBsYXRp dHVkZSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRv dWJsZSBsb25naXR1ZGUsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBkb3VibGUgYWx0aXR1ZGUsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBHZW9jbHVlQWNjdXJhY3kqIGFjY3VyYWN5LAorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgR0Vycm9yKiBlcnJvciwKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEdlb2xvY2F0aW9uU2Vy dmljZUd0ayogdGhhdCkKK3sKKyAgICBpZiAoZXJyb3IpIHsKKyAgICAgICAgdGhhdC0+c2V0RXJy b3IoUG9zaXRpb25FcnJvcjo6UE9TSVRJT05fVU5BVkFJTEFCTEUsIGVycm9yLT5tZXNzYWdlKTsK KyAgICAgICAgZ19lcnJvcl9mcmVlKGVycm9yKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKyAg ICBwb3NpdGlvbl9jaGFuZ2VkKHBvc2l0aW9uLCBmaWVsZHMsIHRpbWVzdGFtcCwgbGF0aXR1ZGUs IGxvbmdpdHVkZSwgYWx0aXR1ZGUsIGFjY3VyYWN5LCB0aGF0KTsKK30KKwogdm9pZCBHZW9sb2Nh dGlvblNlcnZpY2VHdGs6OnBvc2l0aW9uX2NoYW5nZWQoR2VvY2x1ZVBvc2l0aW9uKiwgR2VvY2x1 ZVBvc2l0aW9uRmllbGRzIGZpZWxkcywgaW50IHRpbWVzdGFtcCwgZG91YmxlIGxhdGl0dWRlLCBk b3VibGUgbG9uZ2l0dWRlLCBkb3VibGUgYWx0aXR1ZGUsIEdlb2NsdWVBY2N1cmFjeSogYWNjdXJh Y3ksIEdlb2xvY2F0aW9uU2VydmljZUd0ayogdGhhdCkKIHsKICAgICBpZiAoIShmaWVsZHMgJiBH RU9DTFVFX1BPU0lUSU9OX0ZJRUxEU19MQVRJVFVERSAmJiBmaWVsZHMgJiBHRU9DTFVFX1BPU0lU SU9OX0ZJRUxEU19MT05HSVRVREUpKSB7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2d0 ay9HZW9sb2NhdGlvblNlcnZpY2VHdGsuaCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0dlb2xvY2F0 aW9uU2VydmljZUd0ay5oCmluZGV4IGExOThkYzAuLmMxMjMwMTcgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcGxhdGZvcm0vZ3RrL0dlb2xvY2F0aW9uU2VydmljZUd0ay5oCisrKyBiL1dlYkNvcmUvcGxh dGZvcm0vZ3RrL0dlb2xvY2F0aW9uU2VydmljZUd0ay5oCkBAIC00NiwxMSArNDYsMTEgQEAgbmFt ZXNwYWNlIFdlYkNvcmUgewogICAgIHByaXZhdGU6CiAgICAgICAgIEdlb2xvY2F0aW9uU2Vydmlj ZUd0ayhHZW9sb2NhdGlvblNlcnZpY2VDbGllbnQqKTsKIAotICAgICAgICB2b2lkIHVwZGF0ZUxv Y2F0aW9uSW5mb3JtYXRpb24oKTsKICAgICAgICAgdm9pZCBzZXRFcnJvcihQb3NpdGlvbkVycm9y OjpFcnJvckNvZGUsIGNvbnN0IGNoYXIqIG1lc3NhZ2UpOwogICAgICAgICB2b2lkIHVwZGF0ZVBv c2l0aW9uKCk7CiAKICAgICAgICAgc3RhdGljIHZvaWQgcG9zaXRpb25fY2hhbmdlZChHZW9jbHVl UG9zaXRpb24qLCBHZW9jbHVlUG9zaXRpb25GaWVsZHMsIGludCwgZG91YmxlLCBkb3VibGUsIGRv dWJsZSwgR2VvY2x1ZUFjY3VyYWN5KiwgR2VvbG9jYXRpb25TZXJ2aWNlR3RrKik7CisgICAgICAg IHN0YXRpYyB2b2lkIGdldFBvc2l0aW9uQ2FsbGJhY2soR2VvY2x1ZVBvc2l0aW9uKiwgR2VvY2x1 ZVBvc2l0aW9uRmllbGRzLCBpbnQsIGRvdWJsZSwgZG91YmxlLCBkb3VibGUsIEdlb2NsdWVBY2N1 cmFjeSosIEdFcnJvciosIEdlb2xvY2F0aW9uU2VydmljZUd0ayopOwogCiAgICAgcHJpdmF0ZToK ICAgICAgICAgUmVmUHRyPEdlb3Bvc2l0aW9uPiBtX2xhc3RQb3NpdGlvbjsK 49517 2010-02-25 12:24:30 -0800 2010-02-25 12:25:30 -0800 ignore - patch for a different bug bug-35355-20100225122429.patch text/plain 2233 dpranke ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1ZWJmMjA3Li42Njk0OGNkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDIt MjUgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdCB3aGV0aGVyIG9yIG5vdCB3ZSBw cmVzZXJ2ZSB0aGUgaGFzaCBmcmFnbWVudHMgZm9yICJhYm91dDpibGFuayIgVVJMcy4KKyAgICAg ICAgKE5vdGUgdGhhdCBjdXJyZW50bHkgV2ViS2l0IHBhc3NlcyB0aGlzIGJ1dCBDaHJvbWl1bSBk b2Vzbid0KS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzUzNTUKKworICAgICAgICAqIGZhc3QvbG9hZGVyL2Fib3V0LWJsYW5rLWhhc2gta2VwdC1l eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvbG9hZGVyL2Fib3V0LWJsYW5rLWhh c2gta2VwdC5odG1sOiBBZGRlZC4KKwogMjAxMC0wMi0yNCAgRGFuIEJlcm5zdGVpbiAgPG1pdHpA YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZGVycyBDYXJsc3Nvbi4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL2Fib3V0LWJsYW5rLWhhc2gta2VwdC1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9hYm91dC1ibGFuay1oYXNoLWtlcHQt ZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjFjZDBmMzkK LS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9hYm91dC1ibGFuay1o YXNoLWtlcHQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMyBAQAorVGhpcyB0ZXN0IHRlc3RzIHBh cnNpbmcgb2YgaGFzaCBmcmFnbWVudHMgaW4gYWJvdXQ6YmxhbmsgVVJMcy4gSWYgeW91IHNldCB0 aGUgaGFzaCBmcmFnbWVudCwgU2FmYXJpIHByZXNlcnZlcyBpdCwgYnV0IEZpcmVmb3ggYW5kIENo cm9tZSBpZ25vcmUgaXQsIHdoaWNoIHdlIGNvbnNpZGVyIGEgYnVnLiBTZWUgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1Mzk5LgorCitQQVNTCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2xvYWRlci9hYm91dC1ibGFuay1oYXNoLWtlcHQuaHRtbCBiL0xheW91 dFRlc3RzL2Zhc3QvbG9hZGVyL2Fib3V0LWJsYW5rLWhhc2gta2VwdC5odG1sCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjZhNDQ1MTEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L2xvYWRlci9hYm91dC1ibGFuay1oYXNoLWtlcHQuaHRtbApAQCAtMCwwICsx LDIzIEBACis8cD4KK1RoaXMgdGVzdCB0ZXN0cyBwYXJzaW5nIG9mIGhhc2ggZnJhZ21lbnRzIGlu IGFib3V0OmJsYW5rIFVSTHMuIElmIHlvdQorc2V0IHRoZSBoYXNoIGZyYWdtZW50LCBTYWZhcmkg cHJlc2VydmVzIGl0LCBidXQgRmlyZWZveCBhbmQgQ2hyb21lIGlnbm9yZSBpdCwKK3doaWNoIHdl IGNvbnNpZGVyIGEgYnVnLgorU2VlIDxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zNTM5OSI+CitodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzUzOTk8L2E+LgorPC9wPgorPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENv bnRyb2xsZXIpIHsKKyAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworfQorCitm dW5jdGlvbiBvbmxvYWRfY2FsbGJhY2soKSB7CisgIHZhciBvbGRfaGFzaCA9IGlubmVyLmxvY2F0 aW9uLmhhc2g7CisgIGlubmVyLmxvY2F0aW9uLmhhc2ggPSAiaGFzaC1yZWYiOworICB2YXIgbmV3 X2hhc2ggPSBpbm5lci5sb2NhdGlvbi5oYXNoOworICB2YXIgYyA9IGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJjb250ZW50Iik7CisgIGMuaW5uZXJIVE1MID0gKG5ld19oYXNoID09ICIjaGFzaC1y ZWYiKSA/ICJQQVNTIiA6ICJGQUlMIjsKK30KKzwvc2NyaXB0PgorPGRpdiBpZD0iY29udGVudCI+ Tm8gY2FsbGJhY2s8L2Rpdj4KKzxpZnJhbWUgc3R5bGU9ImRpc3BsYXk6bm9uZSIgbmFtZT1pbm5l ciBpZD1pbm5lciBvbmxvYWQ9Im9ubG9hZF9jYWxsYmFjaygpIgorc3JjPSJhYm91dDpibGFuayI+ PC9pZnJhbWU+Cg==