35352 2010-02-24 11:33:22 -0800 [Qt] QtLauncher has a border when running on QGraphicsView mode 2010-02-24 21:08:04 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 jesus webkit-unassigned commit-queue kenneth oldest_to_newest 193434 0 jesus 2010-02-24 11:33:22 -0800 QtLauncher has a frame of 2 pixels when running on QGraphicsView mode. This should be removed. Patch is coming. 193437 1 49417 jesus 2010-02-24 11:43:16 -0800 Created attachment 49417 Remove frame border 193439 2 49417 commit-queue 2010-02-24 11:46:45 -0800 Comment on attachment 49417 Remove frame border Rejecting patch 49417 from review queue. jesus.palencia@openbossa.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your reviewer rights. 193441 3 kenneth 2010-02-24 11:48:58 -0800 Hmm, you are not supposed to set r+ but r? The patch looks good though. 193442 4 jesus 2010-02-24 11:50:51 -0800 Sorry for the confusion... It should be r? and cq?. 193622 5 49417 commit-queue 2010-02-24 21:08:00 -0800 Comment on attachment 49417 Remove frame border Clearing flags on attachment: 49417 Committed r55218: <http://trac.webkit.org/changeset/55218> 193623 6 commit-queue 2010-02-24 21:08:04 -0800 All reviewed patches have been landed. Closing bug. 49417 2010-02-24 11:43:16 -0800 2010-02-24 21:08:00 -0800 Remove frame border 0001-Fix-2-pixels-frame-on-each-border-of-QtLauncher.patch text/plain 1853 jesus RnJvbSA0YTYwYjc0ODk1ODc2NjI2NWZjNWFiOWMxZTRjYzViM2EwN2Y0ZDc3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZXN1cyBTYW5jaGV6LVBhbGVuY2lhIDxqZXN1cy5wYWxlbmNp YUBvcGVuYm9zc2Eub3JnPgpEYXRlOiBXZWQsIDI0IEZlYiAyMDEwIDE2OjQwOjM2IC0wMzAwClN1 YmplY3Q6IFtQQVRDSF0gRml4IDItcGl4ZWxzIGZyYW1lIG9uIGVhY2ggYm9yZGVyIG9mIFF0TGF1 bmNoZXIgd2hlbiBydW5uaW5nIG9uIFFHcmFwaGljc1ZpZXcgbW9kZS4KCltRdF0gUXRMYXVuY2hl ciBoYXMgYSBib3JkZXIgd2hlbiBydW5uaW5nIG9uIFFHcmFwaGljc1ZpZXcgbW9kZQpodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzUzNTIKClJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgoKKiBRdExhdW5jaGVyL3dlYnZpZXcuY3BwOgooV2ViVmlld0dyYXBoaWNzQmFz ZWQ6OldlYlZpZXdHcmFwaGljc0Jhc2VkKToKLS0tCiBXZWJLaXRUb29scy9DaGFuZ2VMb2cgICAg ICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysKIFdlYktpdFRvb2xzL1F0TGF1bmNoZXIvd2Vi dmlldy5jcHAgfCAgICAxICsKIDIgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgMCBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cgYi9XZWJLaXRU b29scy9DaGFuZ2VMb2cKaW5kZXggNzk4NjQ1Yi4uYzQyNTU2OCAxMDA2NDQKLS0tIGEvV2ViS2l0 VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEwLTAyLTI0ICBKZXN1cyBTYW5jaGV6LVBhbGVuY2lhICA8amVzdXMucGFsZW5jaWFA b3BlbmJvc3NhLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbUXRdIFF0TGF1bmNoZXIgaGFzIGEgYm9yZGVyIHdoZW4gcnVubmluZyBvbiBRR3Jh cGhpY3NWaWV3IG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM1MzUyCisKKyAgICAgICAgRml4IDItcGl4ZWxzIGZyYW1lIG9uIGVhY2ggYm9yZGVy IG9mIFF0TGF1bmNoZXIgd2hlbiBydW5uaW5nIG9uIFFHcmFwaGljc1ZpZXcgbW9kZS4KKworICAg ICAgICAqIFF0TGF1bmNoZXIvd2Vidmlldy5jcHA6CisgICAgICAgIChXZWJWaWV3R3JhcGhpY3NC YXNlZDo6V2ViVmlld0dyYXBoaWNzQmFzZWQpOgorCiAyMDEwLTAyLTIzICBBZGFtIFJvYmVuICA8 YXJvYmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIGNvbW1pdC1sb2ctZWRpdG9yIGZpbmQg anVzdC1hZGRlZCBDaGFuZ2VMb2cgZmlsZXMKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1F0TGF1 bmNoZXIvd2Vidmlldy5jcHAgYi9XZWJLaXRUb29scy9RdExhdW5jaGVyL3dlYnZpZXcuY3BwCmlu ZGV4IDMxMWQ3OWIuLmU4MTgwODYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1F0TGF1bmNoZXIv d2Vidmlldy5jcHAKKysrIGIvV2ViS2l0VG9vbHMvUXRMYXVuY2hlci93ZWJ2aWV3LmNwcApAQCAt NDUsNiArNDUsNyBAQCBXZWJWaWV3R3JhcGhpY3NCYXNlZDo6V2ViVmlld0dyYXBoaWNzQmFzZWQo UVdpZGdldCogcGFyZW50KQogICAgIHNldFNjZW5lKG5ldyBRR3JhcGhpY3NTY2VuZSh0aGlzKSk7 CiAgICAgc2NlbmUoKS0+YWRkSXRlbShtX2l0ZW0pOwogCisgICAgc2V0RnJhbWVTaGFwZShRRnJh bWU6Ok5vRnJhbWUpOwogICAgIHNldEhvcml6b250YWxTY3JvbGxCYXJQb2xpY3koUXQ6OlNjcm9s bEJhckFsd2F5c09mZik7CiAgICAgc2V0VmVydGljYWxTY3JvbGxCYXJQb2xpY3koUXQ6OlNjcm9s bEJhckFsd2F5c09mZik7CiAKLS0gCjEuNi42Cgo=