3534 2005-06-14 13:47:10 -0700 CSSMutableStyleDeclarationImpl::item is unimplemented 2005-07-08 21:20:56 -0700 1 1 1 Unclassified WebKit DOM 412 Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 dwood darin oldest_to_newest 11917 0 dwood 2005-06-14 13:47:10 -0700 CSSMutableStyleDeclarationImpl::item (in css_valueimpl.cpp) is not defined. This is called by [DOMCSSStyleDeclaration item:] in WebKit (DOM-CSS.mm). 12071 1 joost 2005-06-14 23:35:41 -0700 Could you please point out to why this is a problem and what it breaks? Maybe even attach a testcase? :) 12133 2 dwood 2005-06-15 10:04:03 -0700 The webkit method -[DOMCSSStyleDeclaration item:] calls CSSStyleDeclarationImpl::item... - (DOMStyleSheet *)item:(unsigned long)index { return [DOMStyleSheet _DOMStyleSheetWithImpl:[self _styleSheetListImpl]->item(index)]; } This is the implementation of CSSStyleDeclarationImpl::item; notice that the index is unused and that an empty string is returned. DOMString CSSStyleDeclarationImpl::item( unsigned long /*index*/ ) { // ### //return m_lstValues->at(index); return DOMString(); } So for instance, if you were trying to process a DOMElement's style attribute (say, to make some modifications or output the style), by looping though each item (simplified snippet below), you'd find that the "item" method returns an empty string, so you couldn't process the style item. DOMCSSStyleDeclaration *style = [self style]; NSLog(@"style = %@", style); int length = [style length]; id item = [style item:0]; 12208 3 joost 2005-06-16 00:16:47 -0700 we're getting there, if you'd please make a testcase out of your small example which behaves incorrect and for example works in firefox, then we have a case here :) 12275 4 joost 2005-06-16 14:04:39 -0700 hyatt AlthA: he's pointed out the function does not contain an impl hyatt AlthA: thats enough to confirm it's a bug hyatt AlthA: even without a testcase confirmed. 12426 5 2430 andersca 2005-06-17 06:47:31 -0700 Created attachment 2430 Test case Here's a test case that shows that item returns an empty string 12437 6 2437 andersca 2005-06-17 07:38:41 -0700 Created attachment 2437 Return the correct property string Here's a patch that makes ::item return the correct property string. I do know that m_values[i] is O(n), but I don't really think that it matters much here because the number of style rules is usually rather small and I'd guess that ::item is seldomly used. 12513 7 2437 darin 2005-06-17 16:06:46 -0700 Comment on attachment 2437 Return the correct property string Looks fine. If it was me I would have formatted the CSSMutableStyleDeclarationImpl::item function a little tighter, more like CSSComputedStyleDeclarationImpl::item, but that's such a nit. Lets land this sucker. 12638 8 joost 2005-06-19 23:14:20 -0700 Reporter, i'll let you do the honors of verifying this one, since you know how well embedded i am in the code *ugh*. 13799 9 joost 2005-07-03 08:05:44 -0700 Dan, please verify this one if it has been fixed for you. 14138 10 dwood 2005-07-07 11:12:00 -0700 (In reply to comment #9) > Dan, please verify this one if it has been fixed for you. Well, something is definitely implemented, but I don't know if what is implemented is correct. I wrote a little test code that gets a computed style, and then outputs the items in the DOMCSSStyleDeclaration.... DOMCSSStyleDeclaration *style = [[self DOMDocument] getComputedStyle:(DOMElement *) node :@""]; NSMutableString *string = [NSMutableString string]; int i; for (i = 0 ; i < [style length] ; i++ ) { [string appendString:[style item:i]]; [string appendString:@" "]; } NSLog(@"items (%d) = %@", [style length], string); What results is this: 2005-07-07 10:59:21.369 Sandvox[21119] items (99) = rgba(0, 0, 0, 0) none repeat scroll 0 0 auto auto separate 0px 0px 0px 0px rgba(0, 0, 0, 0) rgba(0, 0, 0, 0) rgba(0, 0, 0, 0) rgba(0, 0, 0, 0) none none none none 0px 0px 0px 0px auto stretch normal 0 1 single 1 horizontal start top none rgb(0, 0, 0) auto dashboard-region( ltr inline show none Futura 40.128px normal normal normal 0px auto normal after-white-space -1% normal none outside disc 0px 0px 0px 0px auto 6px infinite scroll -1px -1px 0px 0px space 1 2 none visible auto auto auto auto auto auto auto static auto auto center none none 0px rgb(255, 255, 255) 0px 1px 1px uppercase auto normal read-write baseline visible normal 2 0px 0px break-word normal Wow, this doesn't look right. Or maybe it is. It's hard to tell because the "cssText" method is not implemented either (new bug #3893), so I don't have anything to compare it to. But it seems like it's only the "value" of a property. I can't find any documentation on what this is *supposed* to return, but it doesn't look like it's anything useful. So I'd like it if somebody who is more famiiar with what this is supposed to do can verify the bug, please. 14264 11 andersca 2005-07-08 21:20:56 -0700 The problem is that CSSComputedStyleDeclarationImpl::item() isn't implemented. I've uploaded a patch for bug 3983 that implements it, so I'll just close this bug. 2430 2005-06-17 06:47:31 -0700 2005-06-17 06:47:31 -0700 Test case css-style-declaration-item.html text/html 1074 andersca PGh0bWw+CjxoZWFkPgo8c3R5bGU+Ci5vbmUge2Rpc3BsYXk6IGJsb2NrO30KLnR3byB7ZGlzcGxh eTogaW5saW5lO30KLnRocmVlIHtkaXNwbGF5OiBsaXN0LWl0ZW07IGxpc3Qtc3R5bGUtdHlwZTog c3F1YXJlOyBtYXJnaW4tbGVmdDogM2VtO30KLmZvdXIge2Rpc3BsYXk6IG5vbmU7IGNvbG9yOiBy ZWQ7fQpJIHtkaXNwbGF5OiBibG9jazt9Cjwvc3R5bGU+CjwvaGVhZD4KPGJvZHkgb25sb2FkPSJ0 ZXN0KCk7Ij4KPHNjcmlwdD4KZnVuY3Rpb24gdGVzdCgpIHsKCXQgPSBkb2N1bWVudC5jcmVhdGVU ZXh0Tm9kZShkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgnc3R5bGUnKS5pdGVtKDApLmZp cnN0Q2hpbGQubm9kZVZhbHVlKTsKCWRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdkb2NTdHlsZScp LmFwcGVuZENoaWxkKHQpOwoKCXN0eWxlU2hlZXQgPSBkb2N1bWVudC5zdHlsZVNoZWV0cy5pdGVt KDApCgkKCXMgPSAiIgoJZm9yIChpID0gMDsgaSA8IHN0eWxlU2hlZXQuY3NzUnVsZXMubGVuZ3Ro OyBpKyspIHsKCQlydWxlID0gc3R5bGVTaGVldC5jc3NSdWxlcy5pdGVtKGkpOwoKCQlzd2l0Y2gg KHJ1bGUudHlwZSkgewoJCWNhc2UgQ1NTUnVsZS5TVFlMRV9SVUxFOgkJCgkJCXMgKz0gcnVsZS5z ZWxlY3RvclRleHQgKyAnIHsnOwoJCQkKCQkJc3R5bGUgPSBydWxlLnN0eWxlOwoJCQlmb3IgKGog PSAwOyBqIDwgc3R5bGUubGVuZ3RoOyBqKyspIHsKCQkJCXMgKz0gc3R5bGUuaXRlbShqKSArICc6 ICcgKyBzdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKHN0eWxlLml0ZW0oaikpKyAnOyAnOwoJCQl9CgkJ CXMgKz0gJ30gXG4nOwoJCX0KCX0KCQoJdCA9IGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKHMpOwoJ ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3NlcmlhbGl6ZWRTdHlsZScpLmFwcGVuZENoaWxkKHQp Owp9Cjwvc2NyaXB0PgoKPGRpdj5TdHlsZSBhcyBzcGVjaWZpZWQgaW4gdGhlIGRvY3VtZW50PC9k aXY+CjxwcmUgaWQ9ImRvY1N0eWxlIjwvcHJlPgo8ZGl2PlNlcmlhbGl6ZWQgc3R5bGU8L2Rpdj4K PHByZSBpZD0ic2VyaWFsaXplZFN0eWxlIj48L3ByZT4KPC9ib2R5Pgo8L2h0bWw+ 2437 2005-06-17 07:38:41 -0700 2005-06-17 16:06:46 -0700 Return the correct property string css-style-declaration-item.diff text/plain 4640 andersca SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9D aGFuZ2VMb2csdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNDI2NwpkaWZmIC11IC1yMS40MjY3IENo YW5nZUxvZwotLS0gQ2hhbmdlTG9nCTIwMDUvMDYvMTcgMDI6MTM6MDcJMS40MjY3CisrKyBDaGFu Z2VMb2cJMjAwNS8wNi8xNyAxMzo1MDozMwpAQCAtMSwzICsxLDEzIEBACisyMDA1LTA2LTE3ICBB bmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBtYWMuY29tPgorCisJRml4IGZvciBodHRwOi8vYnVn emlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTM1MzQKKwkKKyAgICAgICAgVGVz dCBjYXNlcyBhZGRlZDogZmFzdC9kb20vY3NzLXN0eWxlLWRlY2xhcmF0aW9uLWl0ZW0uaHRtbCAK KworICAgICAgICAqIGtodG1sL2Nzcy9jc3NfdmFsdWVpbXBsLmNwcDoKKyAgICAgICAgKERPTTo6 Q1NTTXV0YWJsZVN0eWxlRGVjbGFyYXRpb25JbXBsOjppdGVtKToKKwlSZXR1cm4gdGhlIHByb3Bl cnR5IG5hbWUgb2YgdGhlIGdpdmVuIHN0eWxlIGRlY2xhcmF0aW9uIGl0ZW0uCisKIDIwMDUtMDYt MTYgIEp1c3RpbiBHYXJjaWEgIDxqdXN0aW4uZ2FyY2lhQGFwcGxlLmNvbT4KIAogCUFkZGVkIGEg ZmV3IGRlYnVnZ2luZyBtZXRob2RzIHRvIGhpZ2hsaWdodCBTZWxlY3Rpb25zLCBWaXNpYmxlUG9z aXRpb25zIGFuZCBOb2RlcyBpbiB0aGUgRE9NIHRyZWUuCkluZGV4OiBraHRtbC9jc3MvY3NzX3Zh bHVlaW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYkNvcmUva2h0bWwv Y3NzL2Nzc192YWx1ZWltcGwuY3BwLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjcwCmRpZmYgLXUg LXIxLjcwIGNzc192YWx1ZWltcGwuY3BwCi0tLSBjc3NfdmFsdWVpbXBsLmNwcAkyMDA1LzA1LzEy IDE3OjExOjIwCTEuNzAKKysrIGNzc192YWx1ZWltcGwuY3BwCTIwMDUvMDYvMTcgMTM6NTA6MzQK QEAgLTUxMiwxMSArNTEyLDE1IEBACiAgICAgcmV0dXJuIG1fdmFsdWVzLmNvdW50KCk7CiB9CiAK LURPTVN0cmluZyBDU1NNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbkltcGw6Oml0ZW0oIHVuc2lnbmVk IGxvbmcgLyppbmRleCovICkgY29uc3QKK0RPTVN0cmluZyBDU1NNdXRhYmxlU3R5bGVEZWNsYXJh dGlvbkltcGw6Oml0ZW0odW5zaWduZWQgbG9uZyBpKSBjb25zdAogewotICAgIC8vICMjIwotICAg IC8vcmV0dXJuIG1fbHN0VmFsdWVzLT5hdChpbmRleCk7Ci0gICAgcmV0dXJuIERPTVN0cmluZygp OworICAgIGlmIChpID49IG1fdmFsdWVzLmNvdW50KCkpCisgICAgICAgIHJldHVybiBET01TdHJp bmcoKTsKKyAgICAKKyAgICBDU1NQcm9wZXJ0eSBwcm9wID0gbV92YWx1ZXNbaV07CisgICAgCisg ICAgcmV0dXJuIGdldFByb3BlcnR5TmFtZShwcm9wLmlkKCkpOwogfQogCiBDU1NSdWxlSW1wbCAq Q1NTU3R5bGVEZWNsYXJhdGlvbkltcGw6OnBhcmVudFJ1bGUoKSBjb25zdAoKLS0tIC9kZXYvbnVs bAkyMDA1LTA2LTE3IDE2OjM1OjAxLjAwMDAwMDAwMCArMDIwMAorKysgbGF5b3V0LXRlc3RzL2Zh c3QvZG9tL2Nzcy1zdHlsZS1kZWNsYXJhdGlvbi1pdGVtLmh0bWwJMjAwNS0wNi0xNyAxNTo1MDo1 NS4wMDAwMDAwMDAgKzAyMDAKQEAgLTAsMCArMSw0NSBAQAorPGh0bWw+Cis8aGVhZD4KKzxzdHls ZT4KKy5vbmUge2Rpc3BsYXk6IGJsb2NrO30KKy50d28ge2Rpc3BsYXk6IGlubGluZTt9CisudGhy ZWUge2Rpc3BsYXk6IGxpc3QtaXRlbTsgbGlzdC1zdHlsZS10eXBlOiBzcXVhcmU7IG1hcmdpbi1s ZWZ0OiAzZW07fQorLmZvdXIge2Rpc3BsYXk6IG5vbmU7IGNvbG9yOiByZWQ7fQorSSB7ZGlzcGxh eTogYmxvY2s7fQorPC9zdHlsZT4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0idGVzdCgpOyI+Cis8 c2NyaXB0PgorZnVuY3Rpb24gdGVzdCgpIHsKKwl0ID0gZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUo ZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ3N0eWxlJykuaXRlbSgwKS5maXJzdENoaWxk Lm5vZGVWYWx1ZSk7CisJZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2RvY1N0eWxlJykuYXBwZW5k Q2hpbGQodCk7CisKKwlzdHlsZVNoZWV0ID0gZG9jdW1lbnQuc3R5bGVTaGVldHMuaXRlbSgwKQor CQorCXMgPSAiIgorCWZvciAoaSA9IDA7IGkgPCBzdHlsZVNoZWV0LmNzc1J1bGVzLmxlbmd0aDsg aSsrKSB7CisJCXJ1bGUgPSBzdHlsZVNoZWV0LmNzc1J1bGVzLml0ZW0oaSk7CisKKwkJc3dpdGNo IChydWxlLnR5cGUpIHsKKwkJY2FzZSBDU1NSdWxlLlNUWUxFX1JVTEU6CQkKKwkJCXMgKz0gcnVs ZS5zZWxlY3RvclRleHQgKyAnIHsnOworCQkJCisJCQlzdHlsZSA9IHJ1bGUuc3R5bGU7CisJCQlm b3IgKGogPSAwOyBqIDwgc3R5bGUubGVuZ3RoOyBqKyspIHsKKwkJCQlzICs9IHN0eWxlLml0ZW0o aikgKyAnOiAnICsgc3R5bGUuZ2V0UHJvcGVydHlWYWx1ZShzdHlsZS5pdGVtKGopKSsgJzsgJzsK KwkJCX0KKwkJCXMgKz0gJ30gXG4nOworCQl9CisJfQorCQorCXQgPSBkb2N1bWVudC5jcmVhdGVU ZXh0Tm9kZShzKTsKKwlkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnc2VyaWFsaXplZFN0eWxlJyku YXBwZW5kQ2hpbGQodCk7Cit9Cis8L3NjcmlwdD4KKworPGRpdj5TdHlsZSBhcyBzcGVjaWZpZWQg aW4gdGhlIGRvY3VtZW50PC9kaXY+Cis8cHJlIGlkPSJkb2NTdHlsZSI8L3ByZT4KKzxkaXY+U2Vy aWFsaXplZCBzdHlsZTwvZGl2PgorPHByZSBpZD0ic2VyaWFsaXplZFN0eWxlIj48L3ByZT4KKzwv Ym9keT4KKzwvaHRtbD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCi0tLSAvZGV2L251bGwJ MjAwNS0wNi0xNyAxNjozNTowMS4wMDAwMDAwMDAgKzAyMDAKKysrIGxheW91dC10ZXN0cy9mYXN0 L2RvbS9jc3Mtc3R5bGUtZGVjbGFyYXRpb24taXRlbS1leHBlY3RlZC50eHQJMjAwNS0wNi0xNyAx NjozNDowNi4wMDAwMDAwMDAgKzAyMDAKQEAgLTAsMCArMSwyNyBAQAorbGF5ZXIgYXQgKDAsMCkg c2l6ZSA4MDB4NjAwCisgIFJlbmRlckNhbnZhcyBhdCAoMCwwKSBzaXplIDgwMHg2MDAKK2xheWVy IGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJCbG9jayB7SFRNTH0gYXQgKDAsMCkgc2l6 ZSA4MDB4NjAwCisgICAgUmVuZGVyQm9keSB7Qk9EWX0gYXQgKDgsOCkgc2l6ZSA3ODR4NTc5Cisg ICAgICBSZW5kZXJCbG9jayB7RElWfSBhdCAoMCwwKSBzaXplIDc4NHgxOAorICAgICAgICBSZW5k ZXJUZXh0IHtURVhUfSBhdCAoMCwwKSBzaXplIDIxNHgxOAorICAgICAgICAgIHRleHQgcnVuIGF0 ICgwLDApIHdpZHRoIDIxNDogIlN0eWxlIGFzIHNwZWNpZmllZCBpbiB0aGUgZG9jdW1lbnQiCisg ICAgICBSZW5kZXJCbG9jayB7UFJFfSBhdCAoMCwzMSkgc2l6ZSA3ODR4OTAKKyAgICAgICAgUmVu ZGVyVGV4dCB7VEVYVH0gYXQgKDAsMTUpIHNpemUgNTY4eDc1CisgICAgICAgICAgdGV4dCBydW4g YXQgKDAsMTUpIHdpZHRoIDE3NjogIi5vbmUge2Rpc3BsYXk6IGJsb2NrO30iCisgICAgICAgICAg dGV4dCBydW4gYXQgKDAsMzApIHdpZHRoIDE4NDogIi50d28ge2Rpc3BsYXk6IGlubGluZTt9Igor ICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDQ1KSB3aWR0aCA1MzY6ICIudGhyZWUge2Rpc3BsYXk6 IGxpc3QtaXRlbTsgbGlzdC1zdHlsZS10eXBlOiBzcXVhcmU7IG1hcmdpbi1sZWZ0OiAzIgorICAg ICAgICAgIHRleHQgcnVuIGF0ICg1MzYsNDUpIHdpZHRoIDMyOiAiZW07fSIKKyAgICAgICAgICB0 ZXh0IHJ1biBhdCAoMCw2MCkgd2lkdGggMjcyOiAiLmZvdXIge2Rpc3BsYXk6IG5vbmU7IGNvbG9y OiByZWQ7fSIKKyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCw3NSkgd2lkdGggMTUyOiAiSSB7ZGlz cGxheTogYmxvY2s7fSIKKyAgICAgIFJlbmRlckJsb2NrIHtESVZ9IGF0ICgwLDEzNCkgc2l6ZSA3 ODR4MTgKKyAgICAgICAgUmVuZGVyVGV4dCB7VEVYVH0gYXQgKDAsMCkgc2l6ZSA5NXgxOAorICAg ICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRoIDk1OiAiU2VyaWFsaXplZCBzdHlsZSIKKyAg ICAgIFJlbmRlckJsb2NrIHtQUkV9IGF0ICgwLDE2NSkgc2l6ZSA3ODR4NzUKKyAgICAgICAgUmVu ZGVyVGV4dCB7VEVYVH0gYXQgKDAsMCkgc2l6ZSA1ODR4NzUKKyAgICAgICAgICB0ZXh0IHJ1biBh dCAoMCwwKSB3aWR0aCAxOTI6ICIub25lIHtkaXNwbGF5OiBibG9jazsgfSAiCisgICAgICAgICAg dGV4dCBydW4gYXQgKDAsMTUpIHdpZHRoIDIwMDogIi50d28ge2Rpc3BsYXk6IGlubGluZTsgfSAi CisgICAgICAgICAgdGV4dCBydW4gYXQgKDAsMzApIHdpZHRoIDUzNjogIi50aHJlZSB7ZGlzcGxh eTogbGlzdC1pdGVtOyBsaXN0LXN0eWxlLXR5cGU6IHNxdWFyZTsgbWFyZ2luLWxlZnQ6IDMiCisg ICAgICAgICAgdGV4dCBydW4gYXQgKDUzNiwzMCkgd2lkdGggNDg6ICJlbTsgfSAiCisgICAgICAg ICAgdGV4dCBydW4gYXQgKDAsNDUpIHdpZHRoIDI4ODogIi5mb3VyIHtkaXNwbGF5OiBub25lOyBj b2xvcjogcmVkOyB9ICIKKyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCw2MCkgd2lkdGggMTY4OiAi SSB7ZGlzcGxheTogYmxvY2s7IH0gIgo=