35337 2010-02-24 03:37:56 -0800 [Qt] Faster cut-off for rectangle fill without shadow 2010-02-24 08:20:37 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Normal --- 1 ariya.hidayat ariya.hidayat webkit.review.bot oldest_to_newest 193291 0 ariya.hidayat 2010-02-24 03:37:56 -0800 This is similar issue like in bug 35267 but for rectangle fill instead. Will upload a patch. 193295 1 49375 ariya.hidayat 2010-02-24 03:40:42 -0800 Created attachment 49375 Patch 193296 2 webkit.review.bot 2010-02-24 03:43:09 -0800 Attachment 49375 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 193297 3 49376 ariya.hidayat 2010-02-24 03:45:26 -0800 Created attachment 49376 Patch 193366 4 49376 ariya.hidayat 2010-02-24 08:20:33 -0800 Comment on attachment 49376 Patch Clearing flags on attachment: 49376 Committed r55193: <http://trac.webkit.org/changeset/55193> 193367 5 ariya.hidayat 2010-02-24 08:20:37 -0800 All reviewed patches have been landed. Closing bug. 49375 2010-02-24 03:40:42 -0800 2010-02-24 03:45:23 -0800 Patch bug-35337-20100224034016.patch text/plain 1983 ariya.hidayat G1sxbWRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nG1tt ChtbMW1pbmRleCAyYzM5NzlhLi4yNDFjMjdjIDEwMDY0NBtbbQobWzFtLS0tIGEvV2ViQ29yZS9D aGFuZ2VMb2cbW20KG1sxbSsrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nG1ttChtbMzZtQEAgLTEsMyAr MSwxMiBAQBtbbQobWzMybSsbW20bWzMybTIwMTAtMDItMjQgIEFyaXlhIEhpZGF5YXQgIDxhcml5 YS5oaWRheWF0QGdtYWlsLmNvbT4bW20KG1szMm0rG1ttChtbMzJtKxtbbRtbMzJtICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4bW20KG1szMm0rG1ttChtbMzJtKxtbbRtbMzJtICAg ICAgICBbUXRdIEZhc3RlciBjdXQtb2ZmIGZvciByZWN0YW5nbGUgZmlsbCB3aXRob3V0IHNoYWRv dy4bW20KG1szMm0rG1ttG1szMm0gICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zNTMzNxtbbQobWzMybSsbW20KG1szMm0rG1ttG1szMm0gICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwOhtbbQobWzMybSsbW20KIDIw MTAtMDItMjMgIEdlb2ZmIEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4bW20KIBtbbQogICAgICAg ICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4bW20KG1sxbWRpZmYgLS1naXQgYS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dFF0LmNwcCBiL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwG1ttChtbMW1pbmRleCA0MjA0Y2Ji Li5kMWM1NWRiIDEwMDY0NBtbbQobWzFtLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9x dC9HcmFwaGljc0NvbnRleHRRdC5jcHAbW20KG1sxbSsrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwG1ttChtbMzZtQEAgLTYxNiw3ICs2MTYsOCBA QCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6ZmlsbFJlY3QoY29uc3QgRmxvYXRSZWN0JiByZWN0KRtb bQogICAgIFFQYWludGVyKiBwID0gbV9kYXRhLT5wKCk7G1ttCiAbW20KICAgICBpZiAobV9jb21t b24tPnN0YXRlLmZpbGxQYXR0ZXJuIHx8IG1fY29tbW9uLT5zdGF0ZS5maWxsR3JhZGllbnQgfHwg ZmlsbENvbG9yKCkuYWxwaGEoKSkgextbbQobWzMxbS0gICAgICAgIGRyYXdCb3JkZXJsZXNzUmVj dFNoYWRvdyh0aGlzLCBwLCByZWN0KTsbW20KG1szMm0rG1ttG1szMm0gICAgICAgIGlmIChtX2Nv bW1vbi0+c3RhdGUuc2hhZG93Q29sb3IuaXNWYWxpZCgpKRtbbQobWzMybSsbW20bWzMybSAgICAg ICAgICAgIGRyYXdCb3JkZXJsZXNzUmVjdFNoYWRvdyh0aGlzLCBwLCByZWN0KTsbW20KICAgICAg ICAgaWYgKG1fY29tbW9uLT5zdGF0ZS5maWxsUGF0dGVybikgextbbQogICAgICAgICAgICAgQWZm aW5lVHJhbnNmb3JtIGFmZmluZTsbW20KICAgICAgICAgICAgIHAtPmZpbGxSZWN0KHJlY3QsIFFC cnVzaChtX2NvbW1vbi0+c3RhdGUuZmlsbFBhdHRlcm4tPmNyZWF0ZVBsYXRmb3JtUGF0dGVybihh ZmZpbmUpKSk7G1ttChtbMzZtQEAgLTYzOCw3ICs2MzksOCBAQCB2b2lkIEdyYXBoaWNzQ29udGV4 dDo6ZmlsbFJlY3QoY29uc3QgRmxvYXRSZWN0JiByZWN0LCBjb25zdCBDb2xvciYgYywgQ29sb3JT cGFjZRtbbQogG1ttCiAgICAgbV9kYXRhLT5zb2xpZENvbG9yLnNldENvbG9yKGMpOxtbbQogICAg IFFQYWludGVyKiBwID0gbV9kYXRhLT5wKCk7G1ttChtbMzFtLSAgICBkcmF3Qm9yZGVybGVzc1Jl Y3RTaGFkb3codGhpcywgcCwgcmVjdCk7G1ttChtbMzJtKxtbbRtbMzJtICAgIGlmIChtX2NvbW1v bi0+c3RhdGUuc2hhZG93Q29sb3IuaXNWYWxpZCgpKRtbbQobWzMybSsbW20bWzMybSAgICAgICAg ZHJhd0JvcmRlcmxlc3NSZWN0U2hhZG93KHRoaXMsIHAsIHJlY3QpOxtbbQogICAgIHAtPmZpbGxS ZWN0KHJlY3QsIG1fZGF0YS0+c29saWRDb2xvcik7G1ttCiB9G1ttCiAbW20K 49376 2010-02-24 03:45:26 -0800 2010-02-24 08:20:33 -0800 Patch bug-35337-20100224034500.patch text/plain 1666 ariya.hidayat ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MmMzOTc5YS4uMjQxYzI3YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wMi0yNCAgQXJpeWEgSGlkYXlh dCAgPGFyaXlhLmhpZGF5YXRAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRmFzdGVyIGN1dC1vZmYgZm9yIHJlY3RhbmdsZSBm aWxsIHdpdGhvdXQgc2hhZG93LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzUzMzcKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBo aWNzQ29udGV4dFF0LmNwcDoKKwogMjAxMC0wMi0yMyAgR2VvZmYgR2FyZW4gIDxnZ2FyZW5AYXBw bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAgYi9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dFF0LmNwcAppbmRleCA0MjA0 Y2JiLi5kMWM1NWRiIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dy YXBoaWNzQ29udGV4dFF0LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dy YXBoaWNzQ29udGV4dFF0LmNwcApAQCAtNjE2LDcgKzYxNiw4IEBAIHZvaWQgR3JhcGhpY3NDb250 ZXh0OjpmaWxsUmVjdChjb25zdCBGbG9hdFJlY3QmIHJlY3QpCiAgICAgUVBhaW50ZXIqIHAgPSBt X2RhdGEtPnAoKTsKIAogICAgIGlmIChtX2NvbW1vbi0+c3RhdGUuZmlsbFBhdHRlcm4gfHwgbV9j b21tb24tPnN0YXRlLmZpbGxHcmFkaWVudCB8fCBmaWxsQ29sb3IoKS5hbHBoYSgpKSB7Ci0gICAg ICAgIGRyYXdCb3JkZXJsZXNzUmVjdFNoYWRvdyh0aGlzLCBwLCByZWN0KTsKKyAgICAgICAgaWYg KG1fY29tbW9uLT5zdGF0ZS5zaGFkb3dDb2xvci5pc1ZhbGlkKCkpCisgICAgICAgICAgICBkcmF3 Qm9yZGVybGVzc1JlY3RTaGFkb3codGhpcywgcCwgcmVjdCk7CiAgICAgICAgIGlmIChtX2NvbW1v bi0+c3RhdGUuZmlsbFBhdHRlcm4pIHsKICAgICAgICAgICAgIEFmZmluZVRyYW5zZm9ybSBhZmZp bmU7CiAgICAgICAgICAgICBwLT5maWxsUmVjdChyZWN0LCBRQnJ1c2gobV9jb21tb24tPnN0YXRl LmZpbGxQYXR0ZXJuLT5jcmVhdGVQbGF0Zm9ybVBhdHRlcm4oYWZmaW5lKSkpOwpAQCAtNjM4LDcg KzYzOSw4IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpmaWxsUmVjdChjb25zdCBGbG9hdFJlY3Qm IHJlY3QsIGNvbnN0IENvbG9yJiBjLCBDb2xvclNwYWNlCiAKICAgICBtX2RhdGEtPnNvbGlkQ29s b3Iuc2V0Q29sb3IoYyk7CiAgICAgUVBhaW50ZXIqIHAgPSBtX2RhdGEtPnAoKTsKLSAgICBkcmF3 Qm9yZGVybGVzc1JlY3RTaGFkb3codGhpcywgcCwgcmVjdCk7CisgICAgaWYgKG1fY29tbW9uLT5z dGF0ZS5zaGFkb3dDb2xvci5pc1ZhbGlkKCkpCisgICAgICAgIGRyYXdCb3JkZXJsZXNzUmVjdFNo YWRvdyh0aGlzLCBwLCByZWN0KTsKICAgICBwLT5maWxsUmVjdChyZWN0LCBtX2RhdGEtPnNvbGlk Q29sb3IpOwogfQogCg==