35326 2010-02-23 19:57:48 -0800 [SPARC] _atomic_word not always an int and WTF_USE_JSVALUE32 needs defining for 64 bit sparc linux 2011-08-10 16:21:29 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Linux NEW P2 Normal --- 1 dgilmore webkit-unassigned barraclough oldest_to_newest 193221 0 49353 dgilmore 2010-02-23 19:57:48 -0800 Created attachment 49353 patch fixing sparc64 builds 64 bit sparc defones _atomic_word as a long due to hardware capabilities. additionally WTF_USE_JSVALUE32 needs to also be defined. 193881 1 ap 2010-02-25 14:21:08 -0800 Would you be willing to submit a patch for review, as documented in <http://webkit.org/coding/contributing.html>? 193894 2 dgilmore 2010-02-25 15:24:48 -0800 honestly i dont have the time to, its an issue i have fixed at least half a dozen times as the fedora sparc port maintainer. I figured i should submit it upstream for someone to pick up. I have tested it on x86_64 i686 ppc ppc64 sparc and sparc64 194414 3 ap 2010-02-26 19:39:31 -0800 See also: bug 35461, bug 35429. Someone who has access to sparc will need to figure out whether all these three patches are necessary, and make sure that they don't conflict. We are very willing to take patches like these to take the pressure off port maintainers, but someone will need to follow the process and submit them for review. 449468 4 barraclough 2011-08-10 16:21:12 -0700 The platform changes look redundant now, but the use of _Atomic_word is likely valid. 49353 2010-02-23 19:57:48 -0800 2010-06-10 21:03:17 -0700 patch fixing sparc64 builds webkit-1.1.15.4-atomic-word.patch text/plain 4913 dgilmore LS0tIHdlYmtpdC0xLjEuMTUuNC9KYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nLmgub3JpZwky MDEwLTAyLTIzIDIzOjA5OjMxLjAwMDAwMDAwMCArMDAwMAorKysgd2Via2l0LTEuMS4xNS40L0ph dmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmcuaAkyMDEwLTAyLTIzIDIzOjE3OjMyLjAwMDAwMDAw MCArMDAwMApAQCAtMjE1LDMwICsyMTUsMzAgQEAKICNkZWZpbmUgV1RGX1VTRV9MT0NLRlJFRV9U SFJFQURTQUZFU0hBUkVEIDEKIAogI2lmIENPTVBJTEVSKE1JTkdXKSB8fCBDT01QSUxFUihNU1ZD NykgfHwgUExBVEZPUk0oV0lOQ0UpCi1pbmxpbmUgaW50IGF0b21pY0luY3JlbWVudChpbnQqIGFk ZGVuZCkgeyByZXR1cm4gSW50ZXJsb2NrZWRJbmNyZW1lbnQocmVpbnRlcnByZXRfY2FzdDxsb25n Kj4oYWRkZW5kKSk7IH0KLWlubGluZSBpbnQgYXRvbWljRGVjcmVtZW50KGludCogYWRkZW5kKSB7 IHJldHVybiBJbnRlcmxvY2tlZERlY3JlbWVudChyZWludGVycHJldF9jYXN0PGxvbmcqPihhZGRl bmQpKTsgfQoraW5saW5lIF9BdG9taWNfd29yZCBhdG9taWNJbmNyZW1lbnQoX0F0b21pY193b3Jk KiBhZGRlbmQpIHsgcmV0dXJuIEludGVybG9ja2VkSW5jcmVtZW50KHJlaW50ZXJwcmV0X2Nhc3Q8 bG9uZyo+KGFkZGVuZCkpOyB9CitpbmxpbmUgX0F0b21pY193b3JkIGF0b21pY0RlY3JlbWVudChf QXRvbWljX3dvcmQqIGFkZGVuZCkgeyByZXR1cm4gSW50ZXJsb2NrZWREZWNyZW1lbnQocmVpbnRl cnByZXRfY2FzdDxsb25nKj4oYWRkZW5kKSk7IH0KICNlbHNlCi1pbmxpbmUgaW50IGF0b21pY0lu Y3JlbWVudChpbnQgdm9sYXRpbGUqIGFkZGVuZCkgeyByZXR1cm4gSW50ZXJsb2NrZWRJbmNyZW1l bnQocmVpbnRlcnByZXRfY2FzdDxsb25nIHZvbGF0aWxlKj4oYWRkZW5kKSk7IH0KLWlubGluZSBp bnQgYXRvbWljRGVjcmVtZW50KGludCB2b2xhdGlsZSogYWRkZW5kKSB7IHJldHVybiBJbnRlcmxv Y2tlZERlY3JlbWVudChyZWludGVycHJldF9jYXN0PGxvbmcgdm9sYXRpbGUqPihhZGRlbmQpKTsg fQoraW5saW5lIF9BdG9taWNfd29yZCBhdG9taWNJbmNyZW1lbnQoX0F0b21pY193b3JkIHZvbGF0 aWxlKiBhZGRlbmQpIHsgcmV0dXJuIEludGVybG9ja2VkSW5jcmVtZW50KHJlaW50ZXJwcmV0X2Nh c3Q8bG9uZyB2b2xhdGlsZSo+KGFkZGVuZCkpOyB9CitpbmxpbmUgX0F0b21pY193b3JkIGF0b21p Y0RlY3JlbWVudChfQXRvbWljX3dvcmQgdm9sYXRpbGUqIGFkZGVuZCkgeyByZXR1cm4gSW50ZXJs b2NrZWREZWNyZW1lbnQocmVpbnRlcnByZXRfY2FzdDxsb25nIHZvbGF0aWxlKj4oYWRkZW5kKSk7 IH0KICNlbmRpZgogCiAjZWxpZiBQTEFURk9STShEQVJXSU4pCiAjZGVmaW5lIFdURl9VU0VfTE9D S0ZSRUVfVEhSRUFEU0FGRVNIQVJFRCAxCiAKLWlubGluZSBpbnQgYXRvbWljSW5jcmVtZW50KGlu dCB2b2xhdGlsZSogYWRkZW5kKSB7IHJldHVybiBPU0F0b21pY0luY3JlbWVudDMyQmFycmllcihj b25zdF9jYXN0PGludCo+KGFkZGVuZCkpOyB9Ci1pbmxpbmUgaW50IGF0b21pY0RlY3JlbWVudChp bnQgdm9sYXRpbGUqIGFkZGVuZCkgeyByZXR1cm4gT1NBdG9taWNEZWNyZW1lbnQzMkJhcnJpZXIo Y29uc3RfY2FzdDxpbnQqPihhZGRlbmQpKTsgfQoraW5saW5lIF9BdG9taWNfd29yZCBhdG9taWNJ bmNyZW1lbnQoX0F0b21pY193b3JkIHZvbGF0aWxlKiBhZGRlbmQpIHsgcmV0dXJuIE9TQXRvbWlj SW5jcmVtZW50MzJCYXJyaWVyKGNvbnN0X2Nhc3Q8aW50Kj4oYWRkZW5kKSk7IH0KK2lubGluZSBf QXRvbWljX3dvcmQgYXRvbWljRGVjcmVtZW50KF9BdG9taWNfd29yZCB2b2xhdGlsZSogYWRkZW5k KSB7IHJldHVybiBPU0F0b21pY0RlY3JlbWVudDMyQmFycmllcihjb25zdF9jYXN0PGludCo+KGFk ZGVuZCkpOyB9CiAKLSNlbGlmIENPTVBJTEVSKEdDQykgJiYgIVBMQVRGT1JNKFNQQVJDNjQpIC8v IHNpemVvZihfQXRvbWljX3dvcmQpICE9IHNpemVvZihpbnQpIG9uIHNwYXJjNjQgZ2NjCisjZWxp ZiBDT01QSUxFUihHQ0MpCiAjZGVmaW5lIFdURl9VU0VfTE9DS0ZSRUVfVEhSRUFEU0FGRVNIQVJF RCAxCiAKLWlubGluZSBpbnQgYXRvbWljSW5jcmVtZW50KGludCB2b2xhdGlsZSogYWRkZW5kKSB7 IHJldHVybiBfX2dudV9jeHg6Ol9fZXhjaGFuZ2VfYW5kX2FkZChhZGRlbmQsIDEpICsgMTsgfQot aW5saW5lIGludCBhdG9taWNEZWNyZW1lbnQoaW50IHZvbGF0aWxlKiBhZGRlbmQpIHsgcmV0dXJu IF9fZ251X2N4eDo6X19leGNoYW5nZV9hbmRfYWRkKGFkZGVuZCwgLTEpIC0gMTsgfQoraW5saW5l IF9BdG9taWNfd29yZCBhdG9taWNJbmNyZW1lbnQoX0F0b21pY193b3JkIHZvbGF0aWxlKiBhZGRl bmQpIHsgcmV0dXJuIF9fZ251X2N4eDo6X19leGNoYW5nZV9hbmRfYWRkKGFkZGVuZCwgMSkgKyAx OyB9CitpbmxpbmUgX0F0b21pY193b3JkIGF0b21pY0RlY3JlbWVudChfQXRvbWljX3dvcmQgdm9s YXRpbGUqIGFkZGVuZCkgeyByZXR1cm4gX19nbnVfY3h4OjpfX2V4Y2hhbmdlX2FuZF9hZGQoYWRk ZW5kLCAtMSkgLSAxOyB9CiAKICNlbmRpZgogCiBjbGFzcyBUaHJlYWRTYWZlU2hhcmVkQmFzZSA6 IHB1YmxpYyBOb25jb3B5YWJsZSB7CiBwdWJsaWM6Ci0gICAgVGhyZWFkU2FmZVNoYXJlZEJhc2Uo aW50IGluaXRpYWxSZWZDb3VudCA9IDEpCisgICAgVGhyZWFkU2FmZVNoYXJlZEJhc2UoX0F0b21p Y193b3JkIGluaXRpYWxSZWZDb3VudCA9IDEpCiAgICAgICAgIDogbV9yZWZDb3VudChpbml0aWFs UmVmQ291bnQpCiAgICAgewogICAgIH0KQEAgLTI1OCwxMiArMjU4LDEyIEBACiAgICAgICAgIHJl dHVybiByZWZDb3VudCgpID09IDE7CiAgICAgfQogCi0gICAgaW50IHJlZkNvdW50KCkgY29uc3QK KyAgICBfQXRvbWljX3dvcmQgcmVmQ291bnQoKSBjb25zdAogICAgIHsKICNpZiAhVVNFKExPQ0tG UkVFX1RIUkVBRFNBRkVTSEFSRUQpCiAgICAgICAgIE11dGV4TG9ja2VyIGxvY2tlcihtX211dGV4 KTsKICNlbmRpZgotICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8aW50IGNvbnN0IHZvbGF0aWxl ICY+KG1fcmVmQ291bnQpOworICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8X0F0b21pY193b3Jk IGNvbnN0IHZvbGF0aWxlICY+KG1fcmVmQ291bnQpOwogICAgIH0KIAogcHJvdGVjdGVkOgpAQCAt Mjc0LDcgKzI3NCw3IEBACiAgICAgICAgIGlmIChhdG9taWNEZWNyZW1lbnQoJm1fcmVmQ291bnQp IDw9IDApCiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICNlbHNlCi0gICAgICAgIGludCByZWZD b3VudDsKKyAgICAgICAgX0F0b21pY193b3JkIHJlZkNvdW50OwogICAgICAgICB7CiAgICAgICAg ICAgICBNdXRleExvY2tlciBsb2NrZXIobV9tdXRleCk7CiAgICAgICAgICAgICAtLW1fcmVmQ291 bnQ7CkBAIC0yOTAsNyArMjkwLDcgQEAKICAgICB0ZW1wbGF0ZTxjbGFzcyBUPgogICAgIGZyaWVu ZCBjbGFzcyBDcm9zc1RocmVhZFJlZkNvdW50ZWQ7CiAKLSAgICBpbnQgbV9yZWZDb3VudDsKKyAg ICBfQXRvbWljX3dvcmQgbV9yZWZDb3VudDsKICNpZiAhVVNFKExPQ0tGUkVFX1RIUkVBRFNBRkVT SEFSRUQpCiAgICAgbXV0YWJsZSBNdXRleCBtX211dGV4OwogI2VuZGlmCkBAIC0yOTgsNyArMjk4 LDcgQEAKIAogdGVtcGxhdGU8Y2xhc3MgVD4gY2xhc3MgVGhyZWFkU2FmZVNoYXJlZCA6IHB1Ymxp YyBUaHJlYWRTYWZlU2hhcmVkQmFzZSB7CiBwdWJsaWM6Ci0gICAgVGhyZWFkU2FmZVNoYXJlZChp bnQgaW5pdGlhbFJlZkNvdW50ID0gMSkKKyAgICBUaHJlYWRTYWZlU2hhcmVkKF9BdG9taWNfd29y ZCBpbml0aWFsUmVmQ291bnQgPSAxKQogICAgICAgICA6IFRocmVhZFNhZmVTaGFyZWRCYXNlKGlu aXRpYWxSZWZDb3VudCkKICAgICB7CiAgICAgfQotLS0gd2Via2l0LTEuMS4xNS40L0phdmFTY3Jp cHRDb3JlL3d0Zi9QbGF0Zm9ybS5oLm9yaWcJMjAxMC0wMi0yMyAyMzo1ODo1OS4wMDAwMDAwMDAg KzAwMDAKKysrIHdlYmtpdC0xLjEuMTUuNC9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAky MDEwLTAyLTI0IDAwOjIxOjQ0LjAwMDAwMDAwMCArMDAwMApAQCAtMzAxLDggKzMwMSwxMiBAQAog I2lmIGRlZmluZWQoX19zcGFyY19fKSAmJiBkZWZpbmVkKF9fYXJjaDY0X18pIHx8IGRlZmluZWQg KF9fc3BhcmN2OSkKICNkZWZpbmUgV1RGX1BMQVRGT1JNX1NQQVJDNjQgMQogI2RlZmluZSBXVEZf UExBVEZPUk1fQklHX0VORElBTiAxCisjZWxpZiBkZWZpbmVkKF9fc3BhcmNfXykgLypQTEFURk9S TShTUEFSQykgKi8KKyNkZWZpbmUgV1RGX1BMQVRGT1JNX1NQQVJDIDEKKyNkZWZpbmUgV1RGX1BM QVRGT1JNX0JJR19FTkRJQU4gMQogI2VuZGlmCiAKKwogLyogUExBVEZPUk0oV0lOQ0UpICYmIFBM QVRGT1JNKFFUKQogICAgV2UgY2FuIG5vdCBkZXRlcm1pbmUgdGhlIGVuZGlhbmVzcyBhdCBjb21w aWxlIHRpbWUuIEZvcgogICAgUXQgZm9yIFdpbmRvd3MgQ0UgdGhlIGVuZGlhbmVzcyBpcyBzcGVj aWZpZWQgaW4gdGhlCkBAIC02MzIsNyArNjM2LDcgQEAKICNpZiAhZGVmaW5lZChXVEZfVVNFX0pT VkFMVUU2NCkgJiYgIWRlZmluZWQoV1RGX1VTRV9KU1ZBTFVFMzIpICYmICFkZWZpbmVkKFdURl9V U0VfSlNWQUxVRTMyXzY0KQogI2lmIFBMQVRGT1JNKFg4Nl82NCkgJiYgKFBMQVRGT1JNKERBUldJ TikgfHwgUExBVEZPUk0oTElOVVgpKQogI2RlZmluZSBXVEZfVVNFX0pTVkFMVUU2NCAxCi0jZWxp ZiBQTEFURk9STShBUk0pIHx8IFBMQVRGT1JNKFBQQzY0KQorI2VsaWYgUExBVEZPUk0oQVJNKSB8 fCBQTEFURk9STShQUEM2NCkgfHwgUExBVEZPUk0oU1BBUkM2NCkKICNkZWZpbmUgV1RGX1VTRV9K U1ZBTFVFMzIgMQogI2VsaWYgUExBVEZPUk0oV0lOX09TKSAmJiBDT01QSUxFUihNSU5HVykKIC8q IFVzaW5nIEpTVkFMVUUzMl82NCBjYXVzZXMgcGFkZGluZy9hbGlnbmVtZW50IGlzc3VlcyBmb3Ig SklUU3R1YkFyZwo=