35321 2010-02-23 17:04:46 -0800 layout test dashboard json generator pulls the wrong webkit svn revision 2010-02-24 14:48:24 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke commit-queue ojan oldest_to_newest 193182 0 dpranke 2010-02-23 17:04:46 -0800 layout test dashboard json generator pulls the wrong webkit svn revision 193183 1 49344 dpranke 2010-02-23 17:06:17 -0800 Created attachment 49344 Patch 193185 2 dpranke 2010-02-23 17:07:29 -0800 Ojan, can you take a look at this and make sure it looks right? 193195 3 49344 ojan 2010-02-23 17:32:47 -0800 Comment on attachment 49344 Patch Looks right to me. Nit: You might want to add to the ChangeLog description that we need to do this because Chromium doens't checkout the WebKit directory, just the subdirectories. That way it's in the revision history why we're getting the WebCore revision. 193196 4 dpranke 2010-02-23 17:35:38 -0800 will do. 193453 5 49344 eric 2010-02-24 12:24:16 -0800 Comment on attachment 49344 Patch This could easily be moved to the (unit tested) scm.py module and suddenly support both git and svn repositories. But this change as-is looks OK for now too. cq- for ojan's nit. 193527 6 dpranke 2010-02-24 14:48:17 -0800 Fix committed as r55202. Closing bug. 49344 2010-02-23 17:06:17 -0800 2010-02-24 12:24:16 -0800 Patch bug-35321-20100223170616.patch text/plain 1522 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAxOTFmODJjLi4zN2IwMzRlIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDIt MjMgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hlY2sgdGhlIHByb3BlciBkaXJlY3Rv cnkgZm9yIGEgV2ViS2l0IFNWTiB2ZXJzaW9uIChoYXZlIHRvIGxvb2sKKyAgICAgICAgaW4gV2Vi S2l0L1dlYkNvcmUpLgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM1MzIxCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9s YXlvdXRfcGFja2FnZS9qc29uX3Jlc3VsdHNfZ2VuZXJhdG9yLnB5OgorCiAyMDEwLTAyLTIzICBK ZXN1cyBTYW5jaGV6LVBhbGVuY2lhICA8amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KZGlmZiAtLWdp dCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNr YWdlL2pzb25fcmVzdWx0c19nZW5lcmF0b3IucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9qc29uX3Jlc3VsdHNfZ2VuZXJhdG9yLnB5 CmluZGV4IDg0YmUwZTEuLjk4MzBmNjYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL2pzb25fcmVzdWx0c19nZW5lcmF0 b3IucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5 b3V0X3BhY2thZ2UvanNvbl9yZXN1bHRzX2dlbmVyYXRvci5weQpAQCAtMzA3LDcgKzMwNyw3IEBA IGNsYXNzIEpTT05SZXN1bHRzR2VuZXJhdG9yKG9iamVjdCk6CiAgICAgICAgICMgVGhlc2UgbmV4 dCB0d28gYnJhbmNoZXMgdGVzdCB0byBzZWUgd2hpY2ggc291cmNlIHJlcG9zIHdlIGNhbgogICAg ICAgICAjIHB1bGwgcmV2aXNpb25zIGZyb20uCiAgICAgICAgIGlmIGhhc2F0dHIoc2VsZi5fcG9y dCwgJ3BhdGhfZnJvbV93ZWJraXRfYmFzZScpOgotICAgICAgICAgICAgcGF0aF90b193ZWJraXQg PSBzZWxmLl9wb3J0LnBhdGhfZnJvbV93ZWJraXRfYmFzZSgpCisgICAgICAgICAgICBwYXRoX3Rv X3dlYmtpdCA9IHNlbGYuX3BvcnQucGF0aF9mcm9tX3dlYmtpdF9iYXNlKCdXZWJDb3JlJykKICAg ICAgICAgICAgIHNlbGYuX2luc2VydF9pdGVtX2ludG9fcmF3X2xpc3QocmVzdWx0c19mb3JfYnVp bGRlciwKICAgICAgICAgICAgICAgICBzZWxmLl9nZXRfc3ZuX3JldmlzaW9uKHBhdGhfdG9fd2Vi a2l0KSwKICAgICAgICAgICAgICAgICBzZWxmLldFQktJVF9TVk4pCg==