35302 2010-02-23 09:48:14 -0800 Worker error events do not have their message, filename, and lineno fields properly set 2011-11-14 15:27:27 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED INVALID P2 Normal --- 1 atwilson levin ap caseq chocoros dimich jianli levin omerkling yurys oldest_to_newest 192991 0 atwilson 2010-02-23 09:48:14 -0800 If you get an error from trying to load a non-existent script, the resulting ErrorEvent does not have its message, filename, or lineno fields set - I expected that at least the message field would be set. Fail case: put this in a file and load it up in a browser - note that there's no message field, which makes it hard for developers to figure out why their worker script isn't loading. <body> <script> var worker = new Worker("foobar.js"); worker.onerror = function(event) { var a = ""; for (x in event) { a += x + ": " + event[x] + "\n"; } alert(a); } </script> </body> 421349 1 97306 omerkling 2011-06-15 09:11:44 -0700 Created attachment 97306 SharedWorker or Worker js to demonstrate ErrorEvent bug 421352 2 omerkling 2011-06-15 09:14:08 -0700 ErrorEvents created inside the WorkerGlobal scope also do not have their properties defined. It appears that instead the paramater passed to onerror is the message itself, not an ErrorEvent. Attached files that demonstrate this issue. Expected output to console from running errors.html: Message recieved from worker1: Uncaught Error: Test Error (or similar message) Message recieved from worker2: Uncaught Error: Test Error (or similar message) Uncaught Error: Test Error Actual: Message recieved from worker1: No Error Message:Uncaught Error: Test Error Message recieved from worker2: No Error Message:Uncaught Error: Test Error Uncaught Error: Test Error The 'No Error Message' indicates that error.message was undefined, and 'Uncaught Error: Test Error' was the string value of error. 421353 3 97307 omerkling 2011-06-15 09:14:31 -0700 Created attachment 97307 Page to demonstrate worker ErrorEvent problems 421708 4 levin 2011-06-15 19:26:18 -0700 Two issues: 1. The onerror is fired for both Workers and Window in the same was (using JSErrorHandler). For Window it should give three arguements: Message, URL, Line Number. For a Web Worker, I think it should be giving a ErrorEvent. Firefox gives the ErrorEvent and the current situation results in people having to write ugly code to detect the type of the first argument (like this http://cggallant.blogspot.com/2010/08/deeper-look-at-html-5-web-workers.html). 2. The 2nd and 3rd parameter are not set. (The URL is typically undefined and the line number is 0.) 421719 5 levin 2011-06-15 19:48:35 -0700 (In reply to comment #4) > Two issues: > 1. The onerror is fired for both Workers and Window in the same was (using JSErrorHandler). For Window it should give three arguements: Message, URL, Line Number. For a Web Worker, I think it should be giving a ErrorEvent. Firefox gives the ErrorEvent and the current situation results in people having to write ugly code to detect the type of the first argument (like this http://cggallant.blogspot.com/2010/08/deeper-look-at-html-5-web-workers.html). Ok, Firefox is simply wrong and perhaps the spec should be made more clear but WebKit is behaving correctly with respect to #1 (and the examples in this bug are incorrect actually). See https://bugs.webkit.org/show_bug.cgi?id=36375#c6 > > 2. The 2nd and 3rd parameter are not set. (The URL is typically undefined and the line number is 0.) This one is still an issue. 421729 6 levin 2011-06-15 20:29:56 -0700 (In reply to comment #5) > Ok, Firefox is simply wrong and perhaps the spec should be made more clear but WebKit is behaving correctly with respect to #1 (and the examples in this bug are incorrect actually). Just verified that Opera also does what Safari does (except that it sets the url and line number correctly), so Firefox seems to be in the minority. I filed https://bugzilla.mozilla.org/show_bug.cgi?id=664650 for Firefox. 422809 7 levin 2011-06-17 12:03:14 -0700 #2 works in v8 but not with JavaScriptCore, but it turns out to be a generic problem with using throw, so I filed https://bugs.webkit.org/show_bug.cgi?id=62897. Overall this bug is based on the onerror getting an ErrorEvent which isn't right. The spec has been clarified on this point. I filed bug https://bugs.webkit.org/show_bug.cgi?id=62898 about expanding test coverage for onerror. 97306 2011-06-15 09:11:44 -0700 2011-06-15 09:11:44 -0700 SharedWorker or Worker js to demonstrate ErrorEvent bug error-worker.js application/javascript 307 omerkling dmFyIG1zZyA9ICJObyBlcnJvciI7CnZhciBwb3J0ID0gc2VsZjsKCnNlbGYub25lcnJvciA9IGZ1 bmN0aW9uKGVycm9yRXZlbnQpIHsKICBtc2cgPSBlcnJvckV2ZW50Lm1lc3NhZ2UgfHwgIk5vIEVy cm9yIE1lc3NhZ2U6IiArIGVycm9yRXZlbnQ7IAogIHBvcnQucG9zdE1lc3NhZ2UobXNnKTsKfQoK c2VsZi5vbmNvbm5lY3QgPSBmdW5jdGlvbihldmVudCkgewogIHBvcnQgPSBldmVudC5wb3J0c1sw XTsKfQoKc2V0VGltZW91dCgKICBmdW5jdGlvbigpIHsKICAgIHRocm93IG5ldyBFcnJvcigiVGVz dCBFcnJvciIpOwogIH0sCiAgMCk7Cg== 97307 2011-06-15 09:14:31 -0700 2011-06-15 09:14:31 -0700 Page to demonstrate worker ErrorEvent problems errors.html text/html 409 omerkling PEhUTUw+CjxCT0RZPgo8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIgbGFuZ3VhZ2U9Imph dmFzY3JpcHQiPgogdmFyIHdvcmtlcjEgPSBuZXcgU2hhcmVkV29ya2VyKCJlcnJvci13b3JrZXIu anMiKTsKIAogd29ya2VyMS5wb3J0Lm9ubWVzc2FnZSA9IGZ1bmN0aW9uKCl7CiAgIGNvbnNvbGUu bG9nKCJNZXNzYWdlIHJlY2lldmVkIGZyb20gd29ya2VyMTogIiArIGV2ZW50LmRhdGEpOwogfSAg CiAgCiB2YXIgd29ya2VyMiA9IG5ldyBXb3JrZXIoImVycm9yLXdvcmtlci5qcyIpOwogIAogd29y a2VyMi5vbm1lc3NhZ2UgPSBmdW5jdGlvbigpewogICBjb25zb2xlLmxvZygiTWVzc2FnZSByZWNp ZXZlZCBmcm9tIHdvcmtlcjI6ICIgKyBldmVudC5kYXRhKTsKIH0KIAo8L3NjcmlwdD4KPC9CT0RZ Pgo8L0hUTUw+Cg==