35275 2010-02-22 17:19:46 -0800 Remove DRT hack that turns off hardware acceleration with older QuickTimes 2010-05-11 00:14:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser eric oldest_to_newest 192720 0 simon.fraser 2010-02-22 17:19:46 -0800 http://trac.webkit.org/changeset/55100 Should this quicktime hack be removed now or re-written? http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm#L434 192725 1 49250 simon.fraser 2010-02-22 17:38:25 -0800 Created attachment 49250 Patch 192771 2 simon.fraser 2010-02-22 20:29:24 -0800 http://trac.webkit.org/changeset/55118 223791 3 eric 2010-05-11 00:14:33 -0700 I'm glad to see this go. I wonder i we shouldn't turn this check into an ASSERT instead of just removing it though. 49250 2010-02-22 17:38:25 -0800 2010-02-22 17:43:40 -0800 Patch bug-35275-20100222173824.patch text/plain 2264 simon.fraser ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlYzJiZjZiLi40MzM1Y2ExIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDIt MjIgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIERSVCBoYWNrIHRoYXQg dHVybnMgb2ZmIGhhcmR3YXJlIGFjY2VsZXJhdGlvbiB3aXRoIG9sZGVyIFF1aWNrVGltZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1Mjc1CisgICAg ICAgIAorICAgICAgICBOb3cgdGhhdCBXZWJLaXQgZG9lcyBhIHZlcnNpb24gY2hlY2sgdG8gYXZv aWQgYSBRdWlja1RpbWUtcmVsYXRlZAorICAgICAgICBjcmFzaCAocjU1MTAwKSwgRHVtcFJlbmRl clRyZWUgZG9lcyBub3QgbmVlZCB0by4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL21hYy9E dW1wUmVuZGVyVHJlZS5tbToKKyAgICAgICAgKHJlc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRWYWx1 ZXMpOgorCiAyMDEwLTAyLTIyICBUb3IgQXJuZSBWZXN0YsO4ICA8dG9yLmFybmUudmVzdGJvQG5v a2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNl bi4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVy VHJlZS5tbSBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5t bQppbmRleCBjN2RkZjIxLi5mNDk0YjAxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVu ZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW0KKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRl clRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCkBAIC00MzAsMjAgKzQzMCw3IEBAIHN0YXRpYyB2 b2lkIHJlc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRWYWx1ZXMoKQogICAgIC8vIFRoZSBiYWNrL2Zv cndhcmQgY2FjaGUgaXMgY2F1c2luZyBwcm9ibGVtcyBkdWUgdG8gbGF5b3V0cyBkdXJpbmcgdHJh bnNpdGlvbiBmcm9tIG9uZSBwYWdlIHRvIGFub3RoZXIuCiAgICAgLy8gU28sIHR1cm4gaXQgb2Zm IGZvciBub3csIGJ1dCB3ZSBtaWdodCB3YW50IHRvIHR1cm4gaXQgYmFjayBvbiBzb21lIGRheS4K ICAgICBbcHJlZmVyZW5jZXMgc2V0VXNlc1BhZ2VDYWNoZTpOT107Ci0KLSNpZiBkZWZpbmVkKEJV SUxESU5HX09OX0xFT1BBUkQpCi0gICAgLy8gRGlzYWJsZSBoYXJkd2FyZSBjb21wb3NpdGl0aW5n IHRvIGF2b2lkIHRpbWVvdXRzIGFuZCBjcmFzaGVzIGZyb20gYnVnZ3kgQ29yZVZpZGVvIHRlYXJk b3duIGNvZGUuCi0gICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTI4ODQ1IGFuZCByZGFyOi8vcHJvYmxlbS83MjI4ODM2Ci0gICAgU0ludDMyIHF0VmVyc2lvbjsK LSAgICBPU0VyciBlcnIgPSBHZXN0YWx0KGdlc3RhbHRRdWlja1RpbWVWZXJzaW9uLCAmcXRWZXJz aW9uKTsKLSAgICBhc3NlcnQoZXJyID09IG5vRXJyKTsKLSAgICAvLyBCdWcgNzIyODgzNiBleGlz dHMgaW4gYXQgbGVhc3QgNy42LjMgdGhyb3VnaCA3LjYuNCwgaG9wZWZ1bGx5IGl0IHdpbGwgYmUg Zml4ZWQgaW4gNy42LjUuCi0gICAgLy8gRklYTUU6IE9uY2Ugd2Uga25vdyB0aGUgZXhhY3QgdmVy c2lvbnMgb2YgUXVpY2tUaW1lIGFmZmVjdGVkLCB3ZSBjYW4gdXBkYXRlIHRoaXMgY2hlY2suCi0g ICAgaWYgKHF0VmVyc2lvbiA8PSAweDA3NjQ4MDAwKSAvLyA3LjYuNCwgZmluYWwgcmVsZWFzZSAo MHg4KS4gIFNlZSBodHRwOi8vZGV2ZWxvcGVyLmFwcGxlLmNvbS9tYWMvbGlicmFyeS90ZWNobgot ICAgICAgICBbcHJlZmVyZW5jZXMgc2V0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0VuYWJsZWQ6Tk9d OwotICAgIGVsc2UKLSNlbmRpZgotICAgICAgICBbcHJlZmVyZW5jZXMgc2V0QWNjZWxlcmF0ZWRD b21wb3NpdGluZ0VuYWJsZWQ6WUVTXTsKKyAgICBbcHJlZmVyZW5jZXMgc2V0QWNjZWxlcmF0ZWRD b21wb3NpdGluZ0VuYWJsZWQ6WUVTXTsKIAogICAgIFtbTlNIVFRQQ29va2llU3RvcmFnZSBzaGFy ZWRIVFRQQ29va2llU3RvcmFnZV0gc2V0Q29va2llQWNjZXB0UG9saWN5Ok5TSFRUUENvb2tpZUFj Y2VwdFBvbGljeU9ubHlGcm9tTWFpbkRvY3VtZW50RG9tYWluXTsKIAo=