35267 2010-02-22 15:44:16 -0800 [Qt] Faster cut-off for rectangle drawing without shadow 2010-02-23 06:17:51 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Other All RESOLVED FIXED Qt P2 Normal --- 1 ariya.hidayat ariya.hidayat oldest_to_newest 192674 0 ariya.hidayat 2010-02-22 15:44:16 -0800 GraphicsContext::drawRect always checks and allocates some local variables for the shadow properties. Since most of the cases, we have rectangle drawing without shadow, we should have a faster code path for the common case. Will upload a patch. 192733 1 49251 ariya.hidayat 2010-02-22 18:08:16 -0800 Created attachment 49251 patch 192907 2 49251 ariya.hidayat 2010-02-23 06:17:46 -0800 Comment on attachment 49251 patch Clearing flags on attachment: 49251 Committed r55148: <http://trac.webkit.org/changeset/55148> 192908 3 ariya.hidayat 2010-02-23 06:17:51 -0800 All reviewed patches have been landed. Closing bug. 49251 2010-02-22 18:08:16 -0800 2010-02-23 06:17:46 -0800 patch qtwebkit-drawrect-noshadow.diff text/plain 1905 ariya.hidayat ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2U0NzA0Ny4uODdiNWFlNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMi0yMiAgQXJpeWEgSGlkYXlh dCAgPGFyaXlhLmhpZGF5YXRAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRmFzdGVyIGN1dC1vZmYgZm9yIHJlY3RhbmdsZSBk cmF3aW5nIHdpdGhvdXQgc2hhZG93LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzUyNjcKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dy YXBoaWNzQ29udGV4dFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6 ZHJhd1JlY3QpOgorCiAyMDEwLTAyLTIyICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZv Lm5vcm9uaGFAY29sbGFib3JhLmNvLnVrPgogCiAgICAgICAgIEJ1aWxkIGZpeCBmb3IgbWFrZSBk aXN0Y2hlY2suCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBo aWNzQ29udGV4dFF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3ND b250ZXh0UXQuY3BwCmluZGV4IDhiY2RhMmUuLjQyMDRjYmIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwCisrKyBiL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwCkBAIC0zMTIsMTQgKzMx MiwxNiBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6ZHJhd1JlY3QoY29uc3QgSW50UmVjdCYgcmVj dCkKICAgICBjb25zdCBib29sIGFudGlBbGlhcyA9IHAtPnRlc3RSZW5kZXJIaW50KFFQYWludGVy OjpBbnRpYWxpYXNpbmcpOwogICAgIHAtPnNldFJlbmRlckhpbnQoUVBhaW50ZXI6OkFudGlhbGlh c2luZywgbV9kYXRhLT5hbnRpQWxpYXNpbmdGb3JSZWN0c0FuZExpbmVzKTsKIAotICAgIEludFNp emUgc2hhZG93U2l6ZTsKLSAgICBpbnQgc2hhZG93Qmx1cjsKLSAgICBDb2xvciBzaGFkb3dDb2xv cjsKLSAgICBpZiAoZ2V0U2hhZG93KHNoYWRvd1NpemUsIHNoYWRvd0JsdXIsIHNoYWRvd0NvbG9y KSkgewotICAgICAgICBJbnRSZWN0IHNoYWRvd1JlY3QgPSByZWN0OwotICAgICAgICBzaGFkb3dS ZWN0Lm1vdmUoc2hhZG93U2l6ZS53aWR0aCgpLCBzaGFkb3dTaXplLmhlaWdodCgpKTsKLSAgICAg ICAgc2hhZG93UmVjdC5pbmZsYXRlKHN0YXRpY19jYXN0PGludD4ocC0+cGVuKCkud2lkdGhGKCkp KTsKLSAgICAgICAgcC0+ZmlsbFJlY3Qoc2hhZG93UmVjdCwgUUNvbG9yKHNoYWRvd0NvbG9yKSk7 CisgICAgaWYgKG1fY29tbW9uLT5zdGF0ZS5zaGFkb3dDb2xvci5pc1ZhbGlkKCkpIHsKKyAgICAg ICAgSW50U2l6ZSBzaGFkb3dTaXplOworICAgICAgICBpbnQgc2hhZG93Qmx1cjsKKyAgICAgICAg Q29sb3Igc2hhZG93Q29sb3I7CisgICAgICAgIGlmIChnZXRTaGFkb3coc2hhZG93U2l6ZSwgc2hh ZG93Qmx1ciwgc2hhZG93Q29sb3IpKSB7CisgICAgICAgICAgICBJbnRSZWN0IHNoYWRvd1JlY3Qg PSByZWN0OworICAgICAgICAgICAgc2hhZG93UmVjdC5tb3ZlKHNoYWRvd1NpemUud2lkdGgoKSwg c2hhZG93U2l6ZS5oZWlnaHQoKSk7CisgICAgICAgICAgICBzaGFkb3dSZWN0LmluZmxhdGUoc3Rh dGljX2Nhc3Q8aW50PihwLT5wZW4oKS53aWR0aEYoKSkpOworICAgICAgICAgICAgcC0+ZmlsbFJl Y3Qoc2hhZG93UmVjdCwgUUNvbG9yKHNoYWRvd0NvbG9yKSk7CisgICAgICAgIH0KICAgICB9CiAK ICAgICBwLT5kcmF3UmVjdChyZWN0KTsK