35256 2010-02-22 12:38:28 -0800 HTMLSelectElement::setSelectedIndexByUser() can trigger unnecessary JS when there is no change to the selected index 2010-02-22 14:43:42 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sullivan sullivan eric oldest_to_newest 192561 0 sullivan 2010-02-22 12:38:28 -0800 This is a followup to <http://trac.webkit.org/changeset/51602>. With that patch, HTMLSelectElement::setSelectedIndexByUser() is now triggered by Safari's forms autofill code. Some pages run JS that resets various form elements when the selected Country changes. As of 51602, that JS was being run even when there is no change to a pop-up element, which does no good and causes trouble for autofill. 192567 1 49235 sullivan 2010-02-22 12:46:45 -0800 Created attachment 49235 Patch to bail out of setSelectedIndexByUser when the new index matches the old one 192578 2 sullivan 2010-02-22 13:04:56 -0800 Fixed in <http://trac.webkit.org/changeset/55101> 192613 3 49235 eric 2010-02-22 14:06:42 -0800 Comment on attachment 49235 Patch to bail out of setSelectedIndexByUser when the new index matches the old one Can't we write a manual test? One which would simply alert() on the change? 192614 4 eric 2010-02-22 14:06:57 -0800 :( for lack of testing. 192645 5 sullivan 2010-02-22 14:43:42 -0800 A manual test would have to be dependent on a particular client, since setSelectedIndexByUser() is not called if the user brings up the pop-up menu and then dismisses it with the initially-selected item still selected. So that's more in the realm of testing the browser than testing WebCore, I think. 49235 2010-02-22 12:46:45 -0800 2010-02-22 14:06:42 -0800 Patch to bail out of setSelectedIndexByUser when the new index matches the old one 35256.txt text/plain 1377 sullivan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NTA5OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDItMjIgIEpvaG4gU3VsbGl2YW4gIDxzdWxsaXZhbkBhcHBs ZS5jb20+CisgICAgICAgIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzUyNTYKKyAg ICAgICAgSFRNTFNlbGVjdEVsZW1lbnQ6OnNldFNlbGVjdGVkSW5kZXhCeVVzZXIoKSBjYW4gdHJp Z2dlciB1bm5lY2Vzc2FyeSBKUyB3aGVuIHRoZXJlIGlzIG5vIGNoYW5nZSB0byB0aGUgc2VsZWN0 ZWQgaW5kZXgKKworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSB0aGlzIGNvZGUgcGF0aCBp cyBub3QgdXNlZCBmb3IgSlMtaW5pdGlhdGVkIGNoYW5nZXMuCisKKyAgICAgICAgKiBodG1sL0hU TUxTZWxlY3RFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxTZWxlY3RFbGVtZW50 OjpzZXRTZWxlY3RlZEluZGV4QnlVc2VyKToKKyAgICAgICAgQmFpbCBvdXQgaWYgdGhlIHRvLWJl LXNlbGVjdGVkIGluZGV4IG1hdGNoZXMgdGhlIGFscmVhZHktc2VsZWN0ZWQgaW5kZXguCisKIDIw MTAtMDItMjIgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RF bGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQu Y3BwCShyZXZpc2lvbiA1NTAzNCkKKysrIFdlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTg3LDYgKzg3LDkgQEAgdm9pZCBIVE1MU2VsZWN0RWxlbWVu dDo6c2V0U2VsZWN0ZWRJbmRleAogCiB2b2lkIEhUTUxTZWxlY3RFbGVtZW50OjpzZXRTZWxlY3Rl ZEluZGV4QnlVc2VyKGludCBvcHRpb25JbmRleCwgYm9vbCBkZXNlbGVjdCwgYm9vbCBmaXJlT25D aGFuZ2VOb3cpCiB7CisgICAgaWYgKG9wdGlvbkluZGV4ID09IHNlbGVjdGVkSW5kZXgoKSkKKyAg ICAgICAgcmV0dXJuOworICAgIAogICAgIFNlbGVjdEVsZW1lbnQ6OnNldFNlbGVjdGVkSW5kZXgo bV9kYXRhLCB0aGlzLCBvcHRpb25JbmRleCwgZGVzZWxlY3QsIGZpcmVPbkNoYW5nZU5vdywgdHJ1 ZSk7CiB9CiAK