35242 2010-02-22 08:55:46 -0800 Settings::setGeolocationEnabled and Settings::geolocationEnabled are redundant 2010-02-23 06:05:58 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 steveblock webkit-unassigned bulach commit-queue joth sam steveblock oldest_to_newest 192477 0 steveblock 2010-02-22 08:55:46 -0800 Settings::setGeolocationEnabled and Settings::geolocationEnabled were added in http://trac.webkit.org/changeset/51660 They are not used in WebCore as an alternative method to enable Geolocation at runtime was added in http://trac.webkit.org/changeset/53406 These methods should be removed. 192484 1 sam 2010-02-22 09:23:43 -0800 Isn't the RuntimeEnabled stuff v8/chromium specific? 192496 2 steveblock 2010-02-22 09:55:37 -0800 > Isn't the RuntimeEnabled stuff v8/chromium specific? Yes, RuntimeEnabledFeatures is currently used only by the V8 bindings. 192852 3 joth 2010-02-23 02:33:28 -0800 FYI all usage of Settings::setGeolocationEnabled and WebSettings::setGeolocationEnabled were removed from Chromium in http://src.chromium.org/viewvc/chrome?view=rev&revision=39707 so from our side it's now fine to go ahead remove these methods from WebKit (Note they're not wired up to actually do anything anyway, as https://bugs.webkit.org/show_bug.cgi?id=33467 shows this was abandoned in favour of RuntimeEnabledFeatures) 192858 4 49271 steveblock 2010-02-23 02:55:54 -0800 Created attachment 49271 Patch 192881 5 49271 jorlow 2010-02-23 04:49:02 -0800 Comment on attachment 49271 Patch assuming this really is dead code... r=me Have you svn blamed these lines to see who added them and why? 192896 6 49271 steveblock 2010-02-23 05:44:07 -0800 Comment on attachment 49271 Patch > Have you svn blamed these lines to see who added them and why? Yes, they were added by joth in http://trac.webkit.org/changeset/51660 as mentioned above 192902 7 49271 commit-queue 2010-02-23 06:05:53 -0800 Comment on attachment 49271 Patch Clearing flags on attachment: 49271 Committed r55147: <http://trac.webkit.org/changeset/55147> 192903 8 commit-queue 2010-02-23 06:05:58 -0800 All reviewed patches have been landed. Closing bug. 49271 2010-02-23 02:55:54 -0800 2010-02-23 06:05:53 -0800 Patch bug-35242-20100223105552.patch text/plain 4584 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NTEzNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDItMjMgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlbW92ZXMgcmVkdW5kYW50IFNldHRpbmdzOjpzZXRHZW9sb2NhdGlvbkVuYWJsZWQgYW5kIFNl dHRpbmdzOjpnZW9sb2NhdGlvbkVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM1MjQyCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCByZW1vdmlu ZyBkZWFkIGNvZGUgb25seS4KKworICAgICAgICAqIHBhZ2UvU2V0dGluZ3MuY3BwOgorICAgICAg ICAqIHBhZ2UvU2V0dGluZ3MuaDoKKwogMjAxMC0wMi0yMyAgU3RldmUgQmxvY2sgIDxzdGV2ZWJs b2NrQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4 OiBXZWJDb3JlL3BhZ2UvU2V0dGluZ3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9T ZXR0aW5ncy5jcHAJKHJldmlzaW9uIDU1MTM2KQorKysgV2ViQ29yZS9wYWdlL1NldHRpbmdzLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTIzLDcgKzEyMyw2IEBAIFNldHRpbmdzOjpTZXR0aW5ncyhQ YWdlKiBwYWdlKQogICAgICwgbV9zaG93UmVwYWludENvdW50ZXIoZmFsc2UpCiAgICAgLCBtX2V4 cGVyaW1lbnRhbE5vdGlmaWNhdGlvbnNFbmFibGVkKGZhbHNlKQogICAgICwgbV93ZWJHTEVuYWJs ZWQoZmFsc2UpCi0gICAgLCBtX2dlb2xvY2F0aW9uRW5hYmxlZCh0cnVlKQogICAgICwgbV9sb2Fk RGVmZXJyaW5nRW5hYmxlZCh0cnVlKQogewogICAgIC8vIEEgRnJhbWUgbWF5IG5vdCBoYXZlIGJl ZW4gY3JlYXRlZCB5ZXQsIHNvIHdlIGluaXRpYWxpemUgdGhlIEF0b21pY1N0cmluZyAKQEAgLTU2 NCwxMSArNTYzLDYgQEAgdm9pZCBTZXR0aW5nczo6c2V0V2ViR0xFbmFibGVkKGJvb2wgZW5hYgog ICAgIG1fd2ViR0xFbmFibGVkID0gZW5hYmxlZDsKIH0KIAotdm9pZCBTZXR0aW5nczo6c2V0R2Vv bG9jYXRpb25FbmFibGVkKGJvb2wgZW5hYmxlZCkKLXsKLSAgICBtX2dlb2xvY2F0aW9uRW5hYmxl ZCA9IGVuYWJsZWQ7Ci19Ci0KIHZvaWQgU2V0dGluZ3M6OnNldExvYWREZWZlcnJpbmdFbmFibGVk KGJvb2wgZW5hYmxlZCkKIHsKICAgICBtX2xvYWREZWZlcnJpbmdFbmFibGVkID0gZW5hYmxlZDsK SW5kZXg6IFdlYkNvcmUvcGFnZS9TZXR0aW5ncy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFn ZS9TZXR0aW5ncy5oCShyZXZpc2lvbiA1NTEzNikKKysrIFdlYkNvcmUvcGFnZS9TZXR0aW5ncy5o CSh3b3JraW5nIGNvcHkpCkBAIC0yODQsOSArMjg0LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog ICAgICAgICB2b2lkIHNldFdlYkdMRW5hYmxlZChib29sKTsKICAgICAgICAgYm9vbCB3ZWJHTEVu YWJsZWQoKSBjb25zdCB7IHJldHVybiBtX3dlYkdMRW5hYmxlZDsgfQogCi0gICAgICAgIHZvaWQg c2V0R2VvbG9jYXRpb25FbmFibGVkKGJvb2wpOwotICAgICAgICBib29sIGdlb2xvY2F0aW9uRW5h YmxlZCgpIGNvbnN0IHsgcmV0dXJuIG1fZ2VvbG9jYXRpb25FbmFibGVkOyB9Ci0KICAgICAgICAg dm9pZCBzZXRMb2FkRGVmZXJyaW5nRW5hYmxlZChib29sKTsKICAgICAgICAgYm9vbCBsb2FkRGVm ZXJyaW5nRW5hYmxlZCgpIGNvbnN0IHsgcmV0dXJuIG1fbG9hZERlZmVycmluZ0VuYWJsZWQ7IH0K IApAQCAtMzYyLDcgKzM1OSw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgYm9vbCBt X3Nob3dSZXBhaW50Q291bnRlciA6IDE7CiAgICAgICAgIGJvb2wgbV9leHBlcmltZW50YWxOb3Rp ZmljYXRpb25zRW5hYmxlZCA6IDE7CiAgICAgICAgIGJvb2wgbV93ZWJHTEVuYWJsZWQgOiAxOwot ICAgICAgICBib29sIG1fZ2VvbG9jYXRpb25FbmFibGVkIDogMTsKICAgICAgICAgYm9vbCBtX2xv YWREZWZlcnJpbmdFbmFibGVkIDogMTsKIAogI2lmIFVTRShTQUZBUklfVEhFTUUpCkluZGV4OiBX ZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHJldmlzaW9uIDU1MTM2KQorKysgV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEwLTAyLTIzICBTdGV2ZSBCbG9jayAg PHN0ZXZlYmxvY2tAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSZW1vdmVzIHJlZHVuZGFudCBTZXR0aW5nczo6c2V0R2VvbG9jYXRp b25FbmFibGVkIGFuZCBTZXR0aW5nczo6Z2VvbG9jYXRpb25FbmFibGVkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTI0MgorCisgICAgICAgIFRoaXMg cmVtb3ZlcyBDaHJvbWl1bSdzIFdlYlNldHRpbmdzOjpzZXRHZW9sb2NhdGlvbkVuYWJsZWQKKwor ICAgICAgICAqIHB1YmxpYy9XZWJTZXR0aW5ncy5oOgorICAgICAgICAqIHNyYy9XZWJTZXR0aW5n c0ltcGwuY3BwOgorICAgICAgICAqIHNyYy9XZWJTZXR0aW5nc0ltcGwuaDoKKwogMjAxMC0wMi0y MyAgU3RldmUgQmxvY2sgIDxzdGV2ZWJsb2NrQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNldHRp bmdzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZXR0aW5ncy5o CShyZXZpc2lvbiA1NTEzNikKKysrIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU2V0dGluZ3Mu aAkod29ya2luZyBjb3B5KQpAQCAtODIsNyArODIsNiBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2 b2lkIHNldFRleHREaXJlY3Rpb25TdWJtZW51SW5jbHVzaW9uQmVoYXZpb3JOZXZlckluY2x1ZGVk KCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXRPZmZsaW5lV2ViQXBwbGljYXRpb25DYWNoZUVu YWJsZWQoYm9vbCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXRFeHBlcmltZW50YWxXZWJHTEVu YWJsZWQoYm9vbCkgPSAwOwotICAgIHZpcnR1YWwgdm9pZCBzZXRHZW9sb2NhdGlvbkVuYWJsZWQo Ym9vbCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXRTaG93RGVidWdCb3JkZXJzKGJvb2wpID0g MDsKIAogcHJvdGVjdGVkOgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZXR0aW5nc0lt cGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBs LmNwcAkocmV2aXNpb24gNTUxMzYpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdz SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI2NCw5ICsyNjQsNCBAQCB2b2lkIFdlYlNldHRp bmdzSW1wbDo6c2V0U2hvd0RlYnVnQm9yZGVyCiAgICAgbV9zZXR0aW5ncy0+c2V0U2hvd0RlYnVn Qm9yZGVycyhzaG93KTsKIH0KIAotdm9pZCBXZWJTZXR0aW5nc0ltcGw6OnNldEdlb2xvY2F0aW9u RW5hYmxlZChib29sIGVuYWJsZWQpCi17Ci0gICAgbV9zZXR0aW5ncy0+c2V0R2VvbG9jYXRpb25F bmFibGVkKGVuYWJsZWQpOwotfQotCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKSW5kZXg6IFdlYktp dC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL3NyYy9XZWJTZXR0aW5nc0ltcGwuaAkocmV2aXNpb24gNTUxMzYpCisrKyBXZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5oCSh3b3JraW5nIGNvcHkpCkBAIC04NCw3ICs4 NCw2IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgc2V0VGV4dERpcmVjdGlvblN1Ym1lbnVJ bmNsdXNpb25CZWhhdmlvck5ldmVySW5jbHVkZWQoKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0T2Zm bGluZVdlYkFwcGxpY2F0aW9uQ2FjaGVFbmFibGVkKGJvb2wpOwogICAgIHZpcnR1YWwgdm9pZCBz ZXRFeHBlcmltZW50YWxXZWJHTEVuYWJsZWQoYm9vbCk7Ci0gICAgdmlydHVhbCB2b2lkIHNldEdl b2xvY2F0aW9uRW5hYmxlZChib29sKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0U2hvd0RlYnVnQm9y ZGVycyhib29sKTsKIAogcHJpdmF0ZToK