35230 2010-02-22 00:38:42 -0800 Build fix for PluginView 2010-02-23 00:59:01 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 skyul webkit-unassigned commit-queue oldest_to_newest 192374 0 skyul 2010-02-22 00:38:42 -0800 PluginView::keepAlive(NPP) is duplicated in PluginView.cpp and PluginViewNone.cpp, so it causes a link error. 192376 1 49191 skyul 2010-02-22 00:42:21 -0800 Created attachment 49191 Patch Remove the duplicated symbol. 192461 2 49191 commit-queue 2010-02-22 07:46:32 -0800 Comment on attachment 49191 Patch Rejecting patch 49191 from commit-queue. Failed to run "['WebKitTools/Scripts/build-webkit', '--debug']" exit_code: 1 Last 500 characters of output: ility_version 1 -current_version 533.1 -o /Users/eseidel/Projects/CommitQueue/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore Undefined symbols: "__ZN7WebCore10PluginView9keepAliveEP4_NPP", referenced from: __NPN_Evaluate in NP_jsobject.o ld: symbol(s) not found collect2: ld returned 1 exit status ** BUILD FAILED ** The following build commands failed: WebCore: Ld /Users/eseidel/Projects/CommitQueue/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore normal i386 (1 failure) Full output: http://webkit-commit-queue.appspot.com/results/298800 192468 3 49191 laszlo.gombos 2010-02-22 08:22:21 -0800 Comment on attachment 49191 Patch This patch breaks MAC 64 bit as PluginViewNone.cpp is used for that build. 192472 4 49219 laszlo.gombos 2010-02-22 08:43:56 -0800 Created attachment 49219 hope this works This might not need a review but I'd like to the commit-bot to be involved in this. 192643 5 49219 eric 2010-02-22 14:42:12 -0800 Comment on attachment 49219 hope this works You can always just cq+ patches and they'll go through the queue. The r+ part is only about setting the actual text of the "Reviewed by" line. Obviously the standard committer practices of what patches are allowed to be committed, etc. should be followed for any patch with the commit-queue the same as if you were committing it manually yourself. :) 192819 6 49219 commit-queue 2010-02-23 00:58:57 -0800 Comment on attachment 49219 hope this works Clearing flags on attachment: 49219 Committed r55128: <http://trac.webkit.org/changeset/55128> 192820 7 commit-queue 2010-02-23 00:59:01 -0800 All reviewed patches have been landed. Closing bug. 49191 2010-02-22 00:42:21 -0800 2010-02-22 08:43:56 -0800 Patch PluginViewNone.patch text/plain 911 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NTA3MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDItMjIgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBCdWlsZCBmaXggZm9yIFBsdWdpblZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM1MjMwCisKKyAgICAgICAgUmVtb3ZlIHRoZSBkdXBsaWNhdGVk IHN5bWJvbCwgUGx1Z2luVmlldzo6a2VlcEFsaXZlKE5QUCkuCisKKyAgICAgICAgKiBwbHVnaW5z L1BsdWdpblZpZXdOb25lLmNwcDoKKwogMjAxMC0wMi0yMSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxk bWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIu CkluZGV4OiBXZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlld05vbmUuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3Tm9uZS5jcHAJKHJldmlzaW9uIDU1MDY3KQorKysg V2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXdOb25lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTIw LDggKzEyMCw0IEBAIHZvaWQgUGx1Z2luVmlldzo6cmVzdGFydCgpCiB7CiB9CiAKLXZvaWQgUGx1 Z2luVmlldzo6a2VlcEFsaXZlKE5QUCkKLXsKLX0KLQogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo= 49219 2010-02-22 08:43:56 -0800 2010-02-23 00:58:57 -0800 hope this works 35230.oatch text/plain 1944 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NTA4NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDItMjIgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEJ1aWxkIGZpeCBmb3IgUGx1Z2luVmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzUyMzAKKworICAgICAgICBObyBuZXcgdGVzdHMsIGJ1 aWxkIGZpeCBvbmx5LgorCisgICAgICAgICogcGx1Z2lucy9QbHVnaW5WaWV3LmNwcDoKKyAgICAg ICAgKiBwbHVnaW5zL1BsdWdpblZpZXcuaDoKKyAgICAgICAgKiBwbHVnaW5zL1BsdWdpblZpZXdO b25lLmNwcDoKKwogMjAxMC0wMi0yMiAgU3RldmUgQmxvY2sgIDxzdGV2ZWJsb2NrQGdvb2dsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTmF0ZSBDaGFwaW4uCkluZGV4OiBXZWJDb3JlL3Bs dWdpbnMvUGx1Z2luVmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbHVnaW5zL1BsdWdp blZpZXcuY3BwCShyZXZpc2lvbiA1NTA4NCkKKysrIFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTI4OSw2ICsxMjg5LDcgQEAgdm9pZCBQbHVnaW5WaWV3 OjprZWVwQWxpdmUoKQogICAgIG1fbGlmZVN1cHBvcnRUaW1lci5zdGFydE9uZVNob3QoMCk7CiB9 CiAKKyNpZiBFTkFCTEUoTkVUU0NBUEVfUExVR0lOX0FQSSkKIHZvaWQgUGx1Z2luVmlldzo6a2Vl cEFsaXZlKE5QUCBpbnN0YW5jZSkKIHsKICAgICBQbHVnaW5WaWV3KiB2aWV3ID0gaW5zdGFuY2VN YXAoKS5nZXQoaW5zdGFuY2UpOwpAQCAtMTI5Nyw1ICsxMjk4LDYgQEAgdm9pZCBQbHVnaW5WaWV3 OjprZWVwQWxpdmUoTlBQIGluc3RhbmNlKQogCiAgICAgdmlldy0+a2VlcEFsaXZlKCk7CiB9Cisj ZW5kaWYKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRleDogV2ViQ29yZS9wbHVnaW5zL1Bs dWdpblZpZXcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5oCShy ZXZpc2lvbiA1NTA4NCkKKysrIFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3LmgJKHdvcmtpbmcg Y29weSkKQEAgLTIxMiw3ICsyMTIsOSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAgICAg Ym9vbCBzdGFydCgpOwogCisjaWYgRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCiAgICAgICAg IHN0YXRpYyB2b2lkIGtlZXBBbGl2ZShOUFApOworI2VuZGlmCiAgICAgICAgIHZvaWQga2VlcEFs aXZlKCk7CiAKICAgICBwcml2YXRlOgpJbmRleDogV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXdO b25lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlld05vbmUuY3Bw CShyZXZpc2lvbiA1NTA4NCkKKysrIFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3Tm9uZS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTEyMCw4ICsxMjAsMTAgQEAgdm9pZCBQbHVnaW5WaWV3OjpyZXN0 YXJ0KCkKIHsKIH0KIAorI2lmIEVOQUJMRShORVRTQ0FQRV9QTFVHSU5fQVBJKQogdm9pZCBQbHVn aW5WaWV3OjprZWVwQWxpdmUoTlBQKQogewogfQorI2VuZGlmCiAKIH0gLy8gbmFtZXNwYWNlIFdl YkNvcmUK