35228 2010-02-21 23:29:59 -0800 [Gtk] Implement layoutTestController.numberOfPages 2010-02-23 04:43:41 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 hamaji webkit-unassigned eric gustavo hayato webkit.review.bot xan.lopez yuzo oldest_to_newest 192358 0 hamaji 2010-02-21 23:29:59 -0800 This was added in Bug 34699. 192359 1 49184 hamaji 2010-02-21 23:30:58 -0800 Created attachment 49184 Patch v1 192361 2 webkit.review.bot 2010-02-21 23:36:20 -0800 Attachment 49184 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:59: webkit_web_frame_number_of_pages is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit/gtk/webkit/webkitwebframe.cpp:879: Use 0 instead of NULL. [readability/null] [5] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 192372 3 hamaji 2010-02-22 00:08:01 -0800 > Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 > WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:59: > webkit_web_frame_number_of_pages is incorrectly named. Don't use underscores in > your identifier names. [readability/naming] [4] > WebKit/gtk/webkit/webkitwebframe.cpp:879: Use 0 instead of NULL. > [readability/null] [5] > Total errors found: 2 in 7 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. Ah, I forgot to fix this false alarms. Filed Bug 35229 and submitted a patch. 192642 4 49184 eric 2010-02-22 14:39:46 -0800 Comment on attachment 49184 Patch v1 Hot damn! 192878 5 49184 hamaji 2010-02-23 04:43:32 -0800 Comment on attachment 49184 Patch v1 Clearing flags on attachment: 49184 Committed r55144: <http://trac.webkit.org/changeset/55144> 192879 6 hamaji 2010-02-23 04:43:41 -0800 All reviewed patches have been landed. Closing bug. 49184 2010-02-21 23:30:58 -0800 2010-02-23 04:43:32 -0800 Patch v1 bug-35228-20100222163057.patch text/plain 5131 hamaji ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyYjU5NGM0Li4zZTI4YTVkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDIt MjEgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR3RrXSBJbXBsZW1lbnQgbGF5 b3V0VGVzdENvbnRyb2xsZXIubnVtYmVyT2ZQYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzUyMjgKKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9T a2lwcGVkOgorCiAyMDEwLTAyLTA3ICBZdXpvIEZ1amlzaGltYSAgPHl1em9AZ29vZ2xlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBw ZWQKaW5kZXggNWM5YjZiYi4uMzY1ODc5OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vZ3RrL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKQEAg LTU4NTEsOSArNTg1MSw2IEBAIGh0dHAvdGVzdHMvaW5jcmVtZW50YWwvc3BsaXQtaGV4LWVudGl0 aWVzLnBsCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjcxNwog ZmFzdC9mcmFtZXMvZmxhdHRlbmluZy8KIAotIyBJbXBsZW1lbnQgTGF5b3V0VGVzdENvbnRyb2xs ZXI6Om51bWJlck9mUGFnZXMoKS4KLXByaW50aW5nL251bWJlck9mUGFnZXMuaHRtbAotCiAjIENy YXNoZXMgb24gcmVsZWFzZS9kZWJ1ZyBib3RzLCBzZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTM1MDgwCiBmYXN0L2Nzcy9mb250LWZhY2Utb3BlbnR5cGUuaHRtbAog CmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9n CmluZGV4IDQzZDJkMjAuLjNlY2Q3OWEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDItMjEg IFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR3RrXSBJbXBsZW1lbnQgbGF5b3V0 VGVzdENvbnRyb2xsZXIubnVtYmVyT2ZQYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzUyMjgKKworICAgICAgICAqIHdlYmtpdC93ZWJraXRwcml2 YXRlLmg6CisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYmZyYW1lLmNwcDoKKyAgICAgICAgKHdl YmtpdF93ZWJfZnJhbWVfbnVtYmVyX29mX3BhZ2VzKToKKwogMjAxMC0wMi0xOCAgRGllZ28gRXNj YWxhbnRlIFVycmVsbyAgPGRlc2NhbGFudGVAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBHdXN0YXZvIE5vcm9uaGEgU2lsdmEuCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtp dC93ZWJraXRwcml2YXRlLmggYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRwcml2YXRlLmgKaW5k ZXggNDRiNGQwYy4uMDQ2ZjMzZSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0 cHJpdmF0ZS5oCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHByaXZhdGUuaApAQCAtMzAx LDYgKzMwMSw5IEBAIGV4dGVybiAiQyIgewogICAgIFdFQktJVF9BUEkgaW50CiAgICAgd2Via2l0 X3dlYl9mcmFtZV9wYWdlX251bWJlcl9mb3JfZWxlbWVudF9ieV9pZChXZWJLaXRXZWJGcmFtZSog ZnJhbWUsIGNvbnN0IGdjaGFyKiBpZCwgZmxvYXQgcGFnZVdpZHRoLCBmbG9hdCBwYWdlSGVpZ2h0 KTsKIAorICAgIFdFQktJVF9BUEkgaW50CisgICAgd2Via2l0X3dlYl9mcmFtZV9udW1iZXJfb2Zf cGFnZXMoV2ViS2l0V2ViRnJhbWUqIGZyYW1lLCBmbG9hdCBwYWdlV2lkdGgsIGZsb2F0IHBhZ2VI ZWlnaHQpOworCiAgICAgV0VCS0lUX0FQSSBndWludAogICAgIHdlYmtpdF93ZWJfZnJhbWVfZ2V0 X3BlbmRpbmdfdW5sb2FkX2V2ZW50X2NvdW50KFdlYktpdFdlYkZyYW1lKiBmcmFtZSk7CiAKZGlm ZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmZyYW1lLmNwcCBiL1dlYktpdC9n dGsvd2Via2l0L3dlYmtpdHdlYmZyYW1lLmNwcAppbmRleCBmYmQyNDZkLi41NDBkZjI5IDEwMDY0 NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJmcmFtZS5jcHAKKysrIGIvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0d2ViZnJhbWUuY3BwCkBAIC04NjcsNiArODY3LDI1IEBAIGludCB3 ZWJraXRfd2ViX2ZyYW1lX3BhZ2VfbnVtYmVyX2Zvcl9lbGVtZW50X2J5X2lkKFdlYktpdFdlYkZy YW1lKiBmcmFtZSwgY29uc3QKIH0KIAogLyoqCisgKiB3ZWJraXRfd2ViX2ZyYW1lX251bWJlcl9v Zl9wYWdlcworICogQGZyYW1lOiBhICNXZWJLaXRXZWJGcmFtZQorICogQHBhZ2VXaWR0aDogd2lk dGggb2YgYSBwYWdlCisgKiBAcGFnZUhlaWdodDogaGVpZ2h0IG9mIGEgcGFnZQorICoKKyAqIFJl dHVybiB2YWx1ZTogVGhlIG51bWJlciBvZiBwYWdlcyB0byBiZSBwcmludGVkLgorICovCitpbnQg d2Via2l0X3dlYl9mcmFtZV9udW1iZXJfb2ZfcGFnZXMoV2ViS2l0V2ViRnJhbWUqIGZyYW1lLCBm bG9hdCBwYWdlV2lkdGgsIGZsb2F0IHBhZ2VIZWlnaHQpCit7CisgICAgZ19yZXR1cm5fdmFsX2lm X2ZhaWwoV0VCS0lUX0lTX1dFQl9GUkFNRShmcmFtZSksIE5VTEwpOworCisgICAgRnJhbWUqIGNv cmVGcmFtZSA9IGNvcmUoZnJhbWUpOworICAgIGlmICghY29yZUZyYW1lKQorICAgICAgICByZXR1 cm4gLTE7CisKKyAgICByZXR1cm4gUHJpbnRDb250ZXh0OjpudW1iZXJPZlBhZ2VzKGNvcmVGcmFt ZSwgRmxvYXRTaXplKHBhZ2VXaWR0aCwgcGFnZUhlaWdodCkpOworfQorCisvKioKICAqIHdlYmtp dF93ZWJfZnJhbWVfZ2V0X3BlbmRpbmdfdW5sb2FkX2V2ZW50X2NvdW50OgogICogQGZyYW1lOiBh ICNXZWJLaXRXZWJGcmFtZQogICoKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBi L1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCBlOTNmZmRhLi4yZmQ0ZmViIDEwMDY0NAotLS0g YS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTAtMDItMjEgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbR3RrXSBJbXBsZW1lbnQgbGF5b3V0VGVzdENvbnRyb2xsZXIubnVtYmVyT2ZQYWdlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzUyMjgKKworICAg ICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9MYXlvdXRUZXN0Q29udHJvbGxlckd0ay5jcHA6Cisg ICAgICAgIChMYXlvdXRUZXN0Q29udHJvbGxlcjo6bnVtYmVyT2ZQYWdlcyk6CisKIDIwMTAtMDIt MjAgIENocmlzIEplcmRvbmVrICA8Y2plcmRvbmVrQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJU cmVlL2d0ay9MYXlvdXRUZXN0Q29udHJvbGxlckd0ay5jcHAgYi9XZWJLaXRUb29scy9EdW1wUmVu ZGVyVHJlZS9ndGsvTGF5b3V0VGVzdENvbnRyb2xsZXJHdGsuY3BwCmluZGV4IDY2OGI4NTIuLjU2 OGVlOGQgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9MYXlvdXRU ZXN0Q29udHJvbGxlckd0ay5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3Rr L0xheW91dFRlc3RDb250cm9sbGVyR3RrLmNwcApAQCAtNTYsNiArNTYsNyBAQCB1bnNpZ25lZCBp bnQgd2Via2l0X3dvcmtlcl90aHJlYWRfY291bnQodm9pZCk7CiB2b2lkIHdlYmtpdF93aGl0ZV9s aXN0X2FjY2Vzc19mcm9tX29yaWdpbihjb25zdCBnY2hhciogc291cmNlT3JpZ2luLCBjb25zdCBn Y2hhciogZGVzdGluYXRpb25Qcm90b2NvbCwgY29uc3QgZ2NoYXIqIGRlc3RpbmF0aW9uSG9zdCwg Ym9vbCBhbGxvd0Rlc3RpbmF0aW9uU3ViZG9tYWlucyk7CiBnY2hhciogd2Via2l0X3dlYl9mcmFt ZV9jb3VudGVyX3ZhbHVlX2Zvcl9lbGVtZW50X2J5X2lkKFdlYktpdFdlYkZyYW1lKiBmcmFtZSwg Y29uc3QgZ2NoYXIqIGlkKTsKIGludCB3ZWJraXRfd2ViX2ZyYW1lX3BhZ2VfbnVtYmVyX2Zvcl9l bGVtZW50X2J5X2lkKFdlYktpdFdlYkZyYW1lKiBmcmFtZSwgY29uc3QgZ2NoYXIqIGlkLCBmbG9h dCBwYWdlV2lkdGgsIGZsb2F0IHBhZ2VIZWlnaHQpOworaW50IHdlYmtpdF93ZWJfZnJhbWVfbnVt YmVyX29mX3BhZ2VzKFdlYktpdFdlYkZyYW1lKiBmcmFtZSwgZmxvYXQgcGFnZVdpZHRoLCBmbG9h dCBwYWdlSGVpZ2h0KTsKIHZvaWQgd2Via2l0X3dlYl9pbnNwZWN0b3JfZXhlY3V0ZV9zY3JpcHQo V2ViS2l0V2ViSW5zcGVjdG9yKiBpbnNwZWN0b3IsIGxvbmcgY2FsbElkLCBjb25zdCBnY2hhciog c2NyaXB0KTsKIH0KIApAQCAtMTQ5LDEwICsxNTAsOSBAQCBpbnQgTGF5b3V0VGVzdENvbnRyb2xs ZXI6OnBhZ2VOdW1iZXJGb3JFbGVtZW50QnlJZChKU1N0cmluZ1JlZiBpZCwgZmxvYXQgcGFnZVdp ZAogICAgIHJldHVybiBwYWdlTnVtYmVyOwogfQogCi1pbnQgTGF5b3V0VGVzdENvbnRyb2xsZXI6 Om51bWJlck9mUGFnZXMoZmxvYXQsIGZsb2F0KQoraW50IExheW91dFRlc3RDb250cm9sbGVyOjpu dW1iZXJPZlBhZ2VzKGZsb2F0IHBhZ2VXaWR0aCwgZmxvYXQgcGFnZUhlaWdodCkKIHsKLSAgICAv LyBGSVhNRTogaW1wbGVtZW50Ci0gICAgcmV0dXJuIC0xOworICAgIHJldHVybiB3ZWJraXRfd2Vi X2ZyYW1lX251bWJlcl9vZl9wYWdlcyhtYWluRnJhbWUsIHBhZ2VXaWR0aCwgcGFnZUhlaWdodCk7 CiB9CiAKIHNpemVfdCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6d2ViSGlzdG9yeUl0ZW1Db3VudCgp Cg==