35227 2010-02-21 21:03:07 -0800 REGRESSION (51566): HTTPHeaderMap::add(const char*, const String&) does not work 2010-02-21 22:13:02 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 yutak webkit-unassigned commit-queue darin jens oldest_to_newest 192348 0 yutak 2010-02-21 21:03:07 -0800 When I call HTTPHeaderMap::add(const char*, const String&) (for example, headerMap.add("Field-Name", String("field value"))), the field value is not recorded in the hash map, and I only get a null string by looking up the header field. When I use HTTPHeaderMap::add(const AtomicString&, const String&), everything works as expected. This is due to a bug in HashMapTranslatorAdapter::translate(), which does not save the mapped value. 192349 1 49183 yutak 2010-02-21 21:06:19 -0800 Created attachment 49183 HashMapTranslatorAdapter::translate() needs to set the mapped value. 192350 2 49183 darin 2010-02-21 21:16:34 -0800 Comment on attachment 49183 HashMapTranslatorAdapter::translate() needs to set the mapped value. Yes, this bug was introduced by <http://trac.webkit.org/changeset/51566>. How did you notice this bug? Does this have any effect on existing code, or only on the new code you are writing? Can you construct a test case, either manual or automated? r=me 192353 3 yutak 2010-02-21 21:34:19 -0800 (In reply to comment #2) > (From update of attachment 49183 [details]) > Yes, this bug was introduced by <http://trac.webkit.org/changeset/51566>. > > How did you notice this bug? Does this have any effect on existing code, or > only on the new code you are writing? Can you construct a test case, either > manual or automated? > > r=me I found this bug when I was writing new code using HTTPHeaderMap. I don't know about any affected code of this bug. To test this manually, try to call HTTPHeaderMap::add(const char*, const String&) and confirm the value is stored correctly. AFAIK there's no automatic test for this bug yet. A patch I'm writing now includes the code path that calls the above function, so this bug will be covered by the layout tests when my patch is committed. 192356 4 49183 commit-queue 2010-02-21 22:12:58 -0800 Comment on attachment 49183 HashMapTranslatorAdapter::translate() needs to set the mapped value. Clearing flags on attachment: 49183 Committed r55068: <http://trac.webkit.org/changeset/55068> 192357 5 commit-queue 2010-02-21 22:13:02 -0800 All reviewed patches have been landed. Closing bug. 49183 2010-02-21 21:06:19 -0800 2010-02-21 22:12:57 -0800 HashMapTranslatorAdapter::translate() needs to set the mapped value. bug-35227-20100222140617.patch text/plain 1368 yutak ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAzZDFhOTI1Li42YTIzOGU0IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTAtMDItMjEgIFl1dGEgS2l0YW11cmEgIDx5dXRha0BjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSGFzaE1hcFRyYW5z bGF0b3JBZGFwdGVyOjp0cmFuc2xhdGUoKSBuZWVkcyB0byBzZXQgdGhlIG1hcHBlZCB2YWx1ZS4K KworICAgICAgICBIVFRQSGVhZGVyTWFwOjphZGQoY29uc3QgY2hhciosIGNvbnN0IFN0cmluZyYp IGRvZXMgbm90IHdvcmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM1MjI3CisKKyAgICAgICAgKiB3dGYvSGFzaE1hcC5oOgorICAgICAgICAoV1RGOjpI YXNoTWFwVHJhbnNsYXRvckFkYXB0ZXI6OnRyYW5zbGF0ZSk6CisKIDIwMTAtMDItMTkgIE9saXZl ciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSUyA9IEdhdmluIEJhcnJhY2xv dWdoLgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvd3RmL0hhc2hNYXAuaCBiL0phdmFTY3Jp cHRDb3JlL3d0Zi9IYXNoTWFwLmgKaW5kZXggZDYzYThkNC4uMDkwOTRkMSAxMDA2NDQKLS0tIGEv SmF2YVNjcmlwdENvcmUvd3RmL0hhc2hNYXAuaAorKysgYi9KYXZhU2NyaXB0Q29yZS93dGYvSGFz aE1hcC5oCkBAIC0xMzMsOSArMTMzLDEwIEBAIG5hbWVzcGFjZSBXVEYgewogCiAgICAgICAgIHN0 YXRpYyB1bnNpZ25lZCBoYXNoKGNvbnN0IFQmIGtleSkgeyByZXR1cm4gVHJhbnNsYXRvcjo6aGFz aChrZXkpOyB9CiAgICAgICAgIHN0YXRpYyBib29sIGVxdWFsKGNvbnN0IEtleVR5cGUmIGEsIGNv bnN0IFQmIGIpIHsgcmV0dXJuIFRyYW5zbGF0b3I6OmVxdWFsKGEsIGIpOyB9Ci0gICAgICAgIHN0 YXRpYyB2b2lkIHRyYW5zbGF0ZShWYWx1ZVR5cGUmIGxvY2F0aW9uLCBjb25zdCBUJiBrZXksIGNv bnN0IE1hcHBlZFR5cGUmLCB1bnNpZ25lZCBoYXNoQ29kZSkKKyAgICAgICAgc3RhdGljIHZvaWQg dHJhbnNsYXRlKFZhbHVlVHlwZSYgbG9jYXRpb24sIGNvbnN0IFQmIGtleSwgY29uc3QgTWFwcGVk VHlwZSYgbWFwcGVkLCB1bnNpZ25lZCBoYXNoQ29kZSkKICAgICAgICAgewogICAgICAgICAgICAg VHJhbnNsYXRvcjo6dHJhbnNsYXRlKGxvY2F0aW9uLmZpcnN0LCBrZXksIGhhc2hDb2RlKTsKKyAg ICAgICAgICAgIGxvY2F0aW9uLnNlY29uZCA9IG1hcHBlZDsKICAgICAgICAgfQogICAgIH07CiAK