35221 2010-02-21 15:50:53 -0800 Remove auto_ptr usage in JavaScriptCore 2010-02-22 21:04:10 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jchaffraix jchaffraix oldest_to_newest 192314 0 jchaffraix 2010-02-21 15:50:53 -0800 Now that PassOwnPtr / OwnPtr can replace auto_ptr, we can make this switch. Patch forthcoming. 192317 1 49176 jchaffraix 2010-02-21 15:54:47 -0800 Created attachment 49176 Proposed fix: change some signatures, remove <memory> and auto_ptr reference 192778 2 jchaffraix 2010-02-22 21:04:10 -0800 Landed in r55120. 49176 2010-02-21 15:54:47 -0800 2010-02-21 16:07:00 -0800 Proposed fix: change some signatures, remove <memory> and auto_ptr reference auto_ptr_JSC_removal.diff text/plain 5879 jchaffraix ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAyMmNlMThjLi5lM2VhNzE2IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTAtMDItMjEgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3Zl IGF1dG9fcHRyIHVzYWdlIGluIEphdmFTY3JpcHRDb3JlLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzUyMjEKKworICAgICAgICAqIHBhcnNlci9Ob2Rl cy5oOiBSZW1vdmVkIG5vdyB1bm5lZWRlZCBhZG9wdCBtZXRob2QuCisgICAgICAgICogcGFyc2Vy L1BhcnNlci5jcHA6IFJlbW92ZWQgPG1lbW9yeT4gaW5jbHVkZSBhcyBpdCBpcyBub3QgcmVxdWly ZWQgYW55bW9yZS4KKyAgICAgICAgKiB3dGYvT3duUHRyLmg6IFJlbW92ZWQgdGhlIGNvbnN0cnVj dG9yIGZyb20gYXV0b19wdHIuCisgICAgICAgICogd3RmL1ZlY3RvclRyYWl0cy5oOiBSZW1vdmVk IGEgdGVtcGxhdGUgc3BlY2lhbGl6YXRpb24gZm9yIGF1dG9fcHRyLgorICAgICAgICAqIHd0Zi91 bmljb2RlL0NvbGxhdG9yLmg6IE1hZGUgdXNlckRlZmF1bHQgcmV0dXJuIGEgUGFzc093blB0ci4K KyAgICAgICAgKiB3dGYvdW5pY29kZS9Db2xsYXRvckRlZmF1bHQuY3BwOgorICAgICAgICAoV1RG OjpDb2xsYXRvcjo6dXNlckRlZmF1bHQpOiBDaGFuZ2VkIHRoZSBtZXRob2QgdG8gbWF0Y2ggdGhl IG5leHQgc2lnbmF0dXJlLgorICAgICAgICAqIHd0Zi91bmljb2RlL2ljdS9Db2xsYXRvcklDVS5j cHA6CisgICAgICAgIChXVEY6OkNvbGxhdG9yOjp1c2VyRGVmYXVsdCk6IERpdHRvLgorCiAyMDEw LTAyLTE5ICBNYWNpZWogU3RhY2hvd2lhayAgPG1qc0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIv Tm9kZXMuaCBiL0phdmFTY3JpcHRDb3JlL3BhcnNlci9Ob2Rlcy5oCmluZGV4IGMyMTZlYTguLjc4 NTIxNjUgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3BhcnNlci9Ob2Rlcy5oCisrKyBiL0ph dmFTY3JpcHRDb3JlL3BhcnNlci9Ob2Rlcy5oCkBAIC0xMzg1LDEyICsxMzg1LDYgQEAgbmFtZXNw YWNlIEpTQyB7CiAKICAgICAgICAgdXNpbmcgUGFyc2VyQXJlbmFSZWZDb3VudGVkOjpvcGVyYXRv ciBuZXc7CiAKLSAgICAgICAgdm9pZCBhZG9wdERhdGEoc3RkOjphdXRvX3B0cjxTY29wZU5vZGVE YXRhPiBkYXRhKQotICAgICAgICB7Ci0gICAgICAgICAgICBBU1NFUlQoIWRhdGEtPm1fYXJlbmEu Y29udGFpbnModGhpcykpOwotICAgICAgICAgICAgQVNTRVJUKCFtX2RhdGEpOwotICAgICAgICAg ICAgbV9kYXRhLmFkb3B0KGRhdGEpOwotICAgICAgICB9CiAgICAgICAgIFNjb3BlTm9kZURhdGEq IGRhdGEoKSBjb25zdCB7IHJldHVybiBtX2RhdGEuZ2V0KCk7IH0KICAgICAgICAgdm9pZCBkZXN0 cm95RGF0YSgpIHsgbV9kYXRhLmNsZWFyKCk7IH0KIApkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENv cmUvcGFyc2VyL1BhcnNlci5jcHAgYi9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcApp bmRleCBlZjk5OTg4Li4wMzlmYzQ2IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIv UGFyc2VyLmNwcAorKysgYi9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcApAQCAtMjcs OSArMjcsNiBAQAogI2luY2x1ZGUgIkxleGVyLmgiCiAjaW5jbHVkZSA8d3RmL0hhc2hTZXQuaD4K ICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+Ci0jaW5jbHVkZSA8bWVtb3J5PgotCi11c2luZyBzdGQ6 OmF1dG9fcHRyOwogCiAjaWZuZGVmIHl5cGFyc2UKIGV4dGVybiBpbnQganNjeXlwYXJzZSh2b2lk Kik7CmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvT3duUHRyLmggYi9KYXZhU2NyaXB0 Q29yZS93dGYvT3duUHRyLmgKaW5kZXggYjdlNjJiMS4uYWYxNjg0YiAxMDA2NDQKLS0tIGEvSmF2 YVNjcmlwdENvcmUvd3RmL093blB0ci5oCisrKyBiL0phdmFTY3JpcHRDb3JlL3d0Zi9Pd25QdHIu aApAQCAtNDAsNyArNDAsNiBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICAgICAgdHlwZWRlZiBWYWx1 ZVR5cGUqIFB0clR5cGU7CiAKICAgICAgICAgZXhwbGljaXQgT3duUHRyKFB0clR5cGUgcHRyID0g MCkgOiBtX3B0cihwdHIpIHsgfQotICAgICAgICBPd25QdHIoc3RkOjphdXRvX3B0cjxWYWx1ZVR5 cGU+IGF1dG9QdHIpIDogbV9wdHIoYXV0b1B0ci5yZWxlYXNlKCkpIHsgfQogICAgICAgICAvLyBT ZWUgY29tbWVudCBpbiBQYXNzT3duUHRyLmggZm9yIHdoeSB0aGlzIHRha2VzIGEgY29uc3QgcmVm ZXJlbmNlLgogICAgICAgICB0ZW1wbGF0ZSA8dHlwZW5hbWUgVT4gT3duUHRyKGNvbnN0IFBhc3NP d25QdHI8VT4mIG8pOwogCkBAIC01OCw4ICs1Nyw2IEBAIG5hbWVzcGFjZSBXVEYgewogICAgICAg ICAvLyBGSVhNRTogVGhpcyBzaG91bGQgYmUgcmVuYW1lZCB0byBhZG9wdC4gCiAgICAgICAgIHZv aWQgc2V0KFB0clR5cGUgcHRyKSB7IEFTU0VSVCghcHRyIHx8IG1fcHRyICE9IHB0cik7IGRlbGV0 ZU93bmVkUHRyKG1fcHRyKTsgbV9wdHIgPSBwdHI7IH0KIAotICAgICAgICB2b2lkIGFkb3B0KHN0 ZDo6YXV0b19wdHI8VmFsdWVUeXBlPiBhdXRvUHRyKSB7IEFTU0VSVCghYXV0b1B0ci5nZXQoKSB8 fCBtX3B0ciAhPSBhdXRvUHRyLmdldCgpKTsgZGVsZXRlT3duZWRQdHIobV9wdHIpOyBtX3B0ciA9 IGF1dG9QdHIucmVsZWFzZSgpOyB9Ci0KICAgICAgICAgdm9pZCBjbGVhcigpIHsgZGVsZXRlT3du ZWRQdHIobV9wdHIpOyBtX3B0ciA9IDA7IH0KIAogICAgICAgICBWYWx1ZVR5cGUmIG9wZXJhdG9y KigpIGNvbnN0IHsgQVNTRVJUKG1fcHRyKTsgcmV0dXJuICptX3B0cjsgfQpkaWZmIC0tZ2l0IGEv SmF2YVNjcmlwdENvcmUvd3RmL1ZlY3RvclRyYWl0cy5oIGIvSmF2YVNjcmlwdENvcmUvd3RmL1Zl Y3RvclRyYWl0cy5oCmluZGV4IGJmNzc4NzguLjNmMzNiMjkgMTAwNjQ0Ci0tLSBhL0phdmFTY3Jp cHRDb3JlL3d0Zi9WZWN0b3JUcmFpdHMuaAorKysgYi9KYXZhU2NyaXB0Q29yZS93dGYvVmVjdG9y VHJhaXRzLmgKQEAgLTgwLDkgKzgwLDYgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgdGVtcGxhdGU8 dHlwZW5hbWUgUD4KICAgICBzdHJ1Y3QgVmVjdG9yVHJhaXRzPE93blB0cjxQPiA+IDogU2ltcGxl Q2xhc3NWZWN0b3JUcmFpdHMgeyB9OwogCi0gICAgdGVtcGxhdGU8dHlwZW5hbWUgUD4KLSAgICBz dHJ1Y3QgVmVjdG9yVHJhaXRzPHN0ZDo6YXV0b19wdHI8UD4gPiA6IFNpbXBsZUNsYXNzVmVjdG9y VHJhaXRzIHsgfTsKLQogICAgIHRlbXBsYXRlPHR5cGVuYW1lIEZpcnN0LCB0eXBlbmFtZSBTZWNv bmQ+CiAgICAgc3RydWN0IFZlY3RvclRyYWl0czxwYWlyPEZpcnN0LCBTZWNvbmQ+ID4KICAgICB7 CmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvdW5pY29kZS9Db2xsYXRvci5oIGIvSmF2 YVNjcmlwdENvcmUvd3RmL3VuaWNvZGUvQ29sbGF0b3IuaAppbmRleCA1MWU4YTA2Li5mZTZhODA5 IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvdW5pY29kZS9Db2xsYXRvci5oCisrKyBi L0phdmFTY3JpcHRDb3JlL3d0Zi91bmljb2RlL0NvbGxhdG9yLmgKQEAgLTI5LDggKzI5LDggQEAK ICNpZm5kZWYgV1RGX0NvbGxhdG9yX2gKICNkZWZpbmUgV1RGX0NvbGxhdG9yX2gKIAotI2luY2x1 ZGUgPG1lbW9yeT4KICNpbmNsdWRlIDx3dGYvTm9uY29weWFibGUuaD4KKyNpbmNsdWRlIDx3dGYv UGFzc093blB0ci5oPgogI2luY2x1ZGUgPHd0Zi91bmljb2RlL1VuaWNvZGUuaD4KIAogI2lmIFVT RShJQ1VfVU5JQ09ERSkgJiYgIVVDT05GSUdfTk9fQ09MTEFUSU9OCkBAIC00Nyw3ICs0Nyw3IEBA IG5hbWVzcGFjZSBXVEYgewogICAgICAgICB+Q29sbGF0b3IoKTsKICAgICAgICAgdm9pZCBzZXRP cmRlckxvd2VyRmlyc3QoYm9vbCk7CiAKLSAgICAgICAgc3RhdGljIHN0ZDo6YXV0b19wdHI8Q29s bGF0b3I+IHVzZXJEZWZhdWx0KCk7CisgICAgICAgIHN0YXRpYyBQYXNzT3duUHRyPENvbGxhdG9y PiB1c2VyRGVmYXVsdCgpOwogCiAgICAgICAgIFJlc3VsdCBjb2xsYXRlKGNvbnN0IDo6VUNoYXIq LCBzaXplX3QsIGNvbnN0IDo6VUNoYXIqLCBzaXplX3QpIGNvbnN0OwogCmRpZmYgLS1naXQgYS9K YXZhU2NyaXB0Q29yZS93dGYvdW5pY29kZS9Db2xsYXRvckRlZmF1bHQuY3BwIGIvSmF2YVNjcmlw dENvcmUvd3RmL3VuaWNvZGUvQ29sbGF0b3JEZWZhdWx0LmNwcAppbmRleCBlZGRiZTUzLi40ZTA1 NDMyIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvdW5pY29kZS9Db2xsYXRvckRlZmF1 bHQuY3BwCisrKyBiL0phdmFTY3JpcHRDb3JlL3d0Zi91bmljb2RlL0NvbGxhdG9yRGVmYXVsdC5j cHAKQEAgLTQ1LDkgKzQ1LDkgQEAgdm9pZCBDb2xsYXRvcjo6c2V0T3JkZXJMb3dlckZpcnN0KGJv b2wpCiB7CiB9CiAKLXN0ZDo6YXV0b19wdHI8Q29sbGF0b3I+IENvbGxhdG9yOjp1c2VyRGVmYXVs dCgpCitQYXNzT3duUHRyPENvbGxhdG9yPiBDb2xsYXRvcjo6dXNlckRlZmF1bHQoKQogewotICAg IHJldHVybiBzdGQ6OmF1dG9fcHRyPENvbGxhdG9yPihuZXcgQ29sbGF0b3IoMCkpOworICAgIHJl dHVybiBuZXcgQ29sbGF0b3IoMCk7CiB9CiAKIC8vIEEgZGVmYXVsdCBpbXBsZW1lbnRhdGlvbiBm b3IgcGxhdGZvcm1zIHRoYXQgbGFjayBVbmljb2RlLWF3YXJlIGNvbGxhdGlvbi4KZGlmZiAtLWdp dCBhL0phdmFTY3JpcHRDb3JlL3d0Zi91bmljb2RlL2ljdS9Db2xsYXRvcklDVS5jcHAgYi9KYXZh U2NyaXB0Q29yZS93dGYvdW5pY29kZS9pY3UvQ29sbGF0b3JJQ1UuY3BwCmluZGV4IGExNzUzYTQu LmVjYWI1YmQgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi91bmljb2RlL2ljdS9Db2xs YXRvcklDVS5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL3VuaWNvZGUvaWN1L0NvbGxhdG9y SUNVLmNwcApAQCAtNTcsNyArNTcsNyBAQCBDb2xsYXRvcjo6Q29sbGF0b3IoY29uc3QgY2hhciog bG9jYWxlKQogewogfQogCi1zdGQ6OmF1dG9fcHRyPENvbGxhdG9yPiBDb2xsYXRvcjo6dXNlckRl ZmF1bHQoKQorUGFzc093blB0cjxDb2xsYXRvcj4gQ29sbGF0b3I6OnVzZXJEZWZhdWx0KCkKIHsK ICNpZiBPUyhEQVJXSU4pICYmIFBMQVRGT1JNKENGKQogICAgIC8vIE1hYyBPUyBYIGRvZXNuJ3Qg c2V0IFVOSVggbG9jYWxlIHRvIG1hdGNoIHVzZXItc2VsZWN0ZWQgb25lLCBzbyBJQ1UgZGVmYXVs dCBkb2Vzbid0IHdvcmsuCkBAIC03MSwxMSArNzEsMTEgQEAgc3RkOjphdXRvX3B0cjxDb2xsYXRv cj4gQ29sbGF0b3I6OnVzZXJEZWZhdWx0KCkKICAgICBjaGFyIGJ1ZlsyNTZdOwogICAgIGlmIChj b2xsYXRpb25PcmRlcikgewogICAgICAgICBDRlN0cmluZ0dldENTdHJpbmcoY29sbGF0aW9uT3Jk ZXIsIGJ1Ziwgc2l6ZW9mKGJ1ZiksIGtDRlN0cmluZ0VuY29kaW5nQVNDSUkpOwotICAgICAgICBy ZXR1cm4gc3RkOjphdXRvX3B0cjxDb2xsYXRvcj4obmV3IENvbGxhdG9yKGJ1ZikpOworICAgICAg ICByZXR1cm4gbmV3IENvbGxhdG9yKGJ1Zik7CiAgICAgfSBlbHNlCi0gICAgICAgIHJldHVybiBz dGQ6OmF1dG9fcHRyPENvbGxhdG9yPihuZXcgQ29sbGF0b3IoIiIpKTsKKyAgICAgICAgcmV0dXJu IG5ldyBDb2xsYXRvcigiIik7CiAjZWxzZQotICAgIHJldHVybiBzdGQ6OmF1dG9fcHRyPENvbGxh dG9yPihuZXcgQ29sbGF0b3IoMCkpOworICAgIHJldHVybiBuZXcgQ29sbGF0b3IoMCk7CiAjZW5k aWYKIH0KIAo=