35215 2010-02-21 11:55:56 -0800 plugInViewWithArguments: API sends wrong parameter for WebPlugInBaseURLKey 2022-07-01 11:35:07 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Mac OS X 10.6 RESOLVED WONTFIX InRadar P2 Normal --- 1 kdecker kdecker ap eric oldest_to_newest 192281 0 kdecker 2010-02-21 11:55:56 -0800 The plugInViewWithArguments: API sends dictionary of plugin arguments. One of the parameters is WebPlugInBaseURLKey, which is a key that represents the base URL of the document containing the plug-in's view. Instead what we're actually getting is the source URL of the plug-in resource. 192282 1 kdecker 2010-02-21 11:56:11 -0800 <rdar://problem/7673157> 192283 2 49159 kdecker 2010-02-21 11:59:57 -0800 Created attachment 49159 proposed fix 196794 3 eric 2010-03-05 16:32:37 -0800 http://trac.webkit.org/changeset/55063 216109 4 ap 2010-04-22 15:36:21 -0700 Had to roll out the fix in <http://trac.webkit.org/changeset/58120>. <rdar://problem/7896604> 1879873 5 ap 2022-07-01 11:35:07 -0700 Mass closing plug-in bugs, as plug-in support has been removed from WebKit. Please comment and/or reopen if this still affects WebKit in some way. 49159 2010-02-21 11:59:57 -0800 2010-06-11 11:32:36 -0700 proposed fix patch.txt text/plain 4214 kdecker SW5kZXg6IG1hYy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5tbQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBtYWMvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQubW0JKHJldmlz aW9uIDU1MDYyKQorKysgbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50Lm1t CSh3b3JraW5nIGNvcHkpCkBAIC0xNTI0LDggKzE1MjQsMTEgQEAKIAogICAgIFdlYlZpZXcgKndl YlZpZXcgPSBnZXRXZWJWaWV3KG1fd2ViRnJhbWUuZ2V0KCkpOwogICAgIFNFTCBzZWxlY3RvciA9 IEBzZWxlY3Rvcih3ZWJWaWV3OnBsdWdJblZpZXdXaXRoQXJndW1lbnRzOik7Ci0gICAgTlNVUkwg KlVSTCA9IHVybDsKIAorICAgIERvY3VtZW50KiBkb2N1bWVudCA9IGNvcmUobV93ZWJGcmFtZS5n ZXQoKSktPmRvY3VtZW50KCk7CisgICAgTlNVUkwgKmJhc2VVUkwgPSBkb2N1bWVudC0+YmFzZVVS TCgpOworICAgIE5TVVJMICpwbHVnaW5VUkwgPSB1cmw7CisgICAgCiAgICAgaWYgKFtbd2ViVmll dyBVSURlbGVnYXRlXSByZXNwb25kc1RvU2VsZWN0b3I6c2VsZWN0b3JdKSB7CiAgICAgICAgIE5T TXV0YWJsZURpY3Rpb25hcnkgKmF0dHJpYnV0ZXMgPSBbW05TTXV0YWJsZURpY3Rpb25hcnkgYWxs b2NdIGluaXRXaXRoT2JqZWN0czpraXQocGFyYW1WYWx1ZXMpIGZvcktleXM6a2l0KHBhcmFtTmFt ZXMpXTsKICAgICAgICAgTlNEaWN0aW9uYXJ5ICphcmd1bWVudHMgPSBbW05TRGljdGlvbmFyeSBh bGxvY10gaW5pdFdpdGhPYmplY3RzQW5kS2V5czoKQEAgLTE1MzMsNyArMTUzNiw3IEBACiAgICAg ICAgICAgICBbTlNOdW1iZXIgbnVtYmVyV2l0aEludDpsb2FkTWFudWFsbHkgPyBXZWJQbHVnSW5N b2RlRnVsbCA6IFdlYlBsdWdJbk1vZGVFbWJlZF0sIFdlYlBsdWdJbk1vZGVLZXksCiAgICAgICAg ICAgICBbTlNOdW1iZXIgbnVtYmVyV2l0aEJvb2w6IWxvYWRNYW51YWxseV0sIFdlYlBsdWdJblNo b3VsZExvYWRNYWluUmVzb3VyY2VLZXksCiAgICAgICAgICAgICBraXQoZWxlbWVudCksIFdlYlBs dWdJbkNvbnRhaW5pbmdFbGVtZW50S2V5LAotICAgICAgICAgICAgVVJMLCBXZWJQbHVnSW5CYXNl VVJMS2V5LCAvLyBVUkwgbWlnaHQgYmUgbmlsLCBzbyBhZGQgaXQgbGFzdAorICAgICAgICAgICAg YmFzZVVSTCwgV2ViUGx1Z0luQmFzZVVSTEtleSwKICAgICAgICAgICAgIG5pbF07CiAKICAgICAg ICAgTlNWaWV3ICp2aWV3ID0gQ2FsbFVJRGVsZWdhdGUod2ViVmlldywgc2VsZWN0b3IsIGFyZ3Vt ZW50cyk7CkBAIC0xNTU1LDcgKzE1NTgsNyBAQAogICAgICAgICBwbHVnaW5QYWNrYWdlID0gW3dl YlZpZXcgX3BsdWdpbkZvck1JTUVUeXBlOm1pbWVUeXBlXTsKICAgICB9CiAgICAgCi0gICAgTlNT dHJpbmcgKmV4dGVuc2lvbiA9IFtbVVJMIHBhdGhdIHBhdGhFeHRlbnNpb25dOworICAgIE5TU3Ry aW5nICpleHRlbnNpb24gPSBbW3BsdWdpblVSTCBwYXRoXSBwYXRoRXh0ZW5zaW9uXTsKICNpZiBF TkFCTEUoUExVR0lOX1BST1hZX0ZPUl9WSURFTykKICAgICAvLyBkb24ndCBhbGxvdyBwcm94eSBw bHVnLWluIHNlbGVjdGlvbiBieSBmaWxlIGV4dGVuc2lvbgogICAgIGlmIChlbGVtZW50LT5oYXNU YWdOYW1lKHZpZGVvVGFnKSB8fCBlbGVtZW50LT5oYXNUYWdOYW1lKGF1ZGlvVGFnKSkKQEAgLTE1 NzMsOCArMTU3Niw2IEBACiAKICAgICBOU1ZpZXcgKnZpZXcgPSBuaWw7CiAKLSAgICBEb2N1bWVu dCogZG9jdW1lbnQgPSBjb3JlKG1fd2ViRnJhbWUuZ2V0KCkpLT5kb2N1bWVudCgpOwotICAgIE5T VVJMICpiYXNlVVJMID0gZG9jdW1lbnQtPmJhc2VVUkwoKTsKICAgICBpZiAocGx1Z2luUGFja2Fn ZSkgewogICAgICAgICBpZiAoW3BsdWdpblBhY2thZ2UgaXNLaW5kT2ZDbGFzczpbV2ViUGx1Z2lu UGFja2FnZSBjbGFzc11dKQogICAgICAgICAgICAgdmlldyA9IHBsdWdpblZpZXcobV93ZWJGcmFt ZS5nZXQoKSwgKFdlYlBsdWdpblBhY2thZ2UgKilwbHVnaW5QYWNrYWdlLCBraXQocGFyYW1OYW1l cyksIGtpdChwYXJhbVZhbHVlcyksIGJhc2VVUkwsIGtpdChlbGVtZW50KSwgbG9hZE1hbnVhbGx5 KTsKQEAgLTE1ODQsNyArMTU4NSw3IEBACiAgICAgICAgICAgICBXZWJCYXNlTmV0c2NhcGVQbHVn aW5WaWV3ICpwbHVnaW5WaWV3ID0gW1tbTkVUU0NBUEVfUExVR0lOX1ZJRVcgYWxsb2NdCiAgICAg ICAgICAgICAgICAgaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAsIHNpemUud2lkdGgoKSwg c2l6ZS5oZWlnaHQoKSkKICAgICAgICAgICAgICAgICBwbHVnaW5QYWNrYWdlOihXZWJOZXRzY2Fw ZVBsdWdpblBhY2thZ2UgKilwbHVnaW5QYWNrYWdlCi0gICAgICAgICAgICAgICAgVVJMOlVSTAor ICAgICAgICAgICAgICAgIFVSTDpwbHVnaW5VUkwKICAgICAgICAgICAgICAgICBiYXNlVVJMOmJh c2VVUkwKICAgICAgICAgICAgICAgICBNSU1FVHlwZTpNSU1FVHlwZQogICAgICAgICAgICAgICAg IGF0dHJpYnV0ZUtleXM6a2l0KHBhcmFtTmFtZXMpCkBAIC0xNjA2LDcgKzE2MDcsNyBAQAogICAg ICAgICBpZiAoIXBsdWdpblBhZ2VVUkwucHJvdG9jb2xJbkhUVFBGYW1pbHkoKSkKICAgICAgICAg ICAgIHBsdWdpblBhZ2VVUkwgPSBLVVJMKCk7CiAgICAgICAgIE5TRXJyb3IgKmVycm9yID0gW1tO U0Vycm9yIGFsbG9jXSBfaW5pdFdpdGhQbHVnaW5FcnJvckNvZGU6ZXJyb3JDb2RlCi0gICAgICAg ICAgICBjb250ZW50VVJMOlVSTCBwbHVnaW5QYWdlVVJMOnBsdWdpblBhZ2VVUkwgcGx1Z2luTmFt ZTpbcGx1Z2luUGFja2FnZSBuYW1lXSBNSU1FVHlwZTpNSU1FVHlwZV07CisgICAgICAgICAgICBj b250ZW50VVJMOnBsdWdpblVSTCBwbHVnaW5QYWdlVVJMOnBsdWdpblBhZ2VVUkwgcGx1Z2luTmFt ZTpbcGx1Z2luUGFja2FnZSBuYW1lXSBNSU1FVHlwZTpNSU1FVHlwZV07CiAgICAgICAgIFdlYk51 bGxQbHVnaW5WaWV3ICpudWxsVmlldyA9IFtbW1dlYk51bGxQbHVnaW5WaWV3IGFsbG9jXSBpbml0 V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgc2l6ZS53aWR0aCgpLCBzaXplLmhlaWdodCgpKQog ICAgICAgICAgICAgZXJyb3I6ZXJyb3IgRE9NRWxlbWVudDpraXQoZWxlbWVudCldIGF1dG9yZWxl YXNlXTsKICAgICAgICAgdmlldyA9IG51bGxWaWV3OwpJbmRleDogbWFjL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBtYWMvQ2hhbmdlTG9nCShyZXZpc2lvbiA1NTA2MikKKysrIG1hYy9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wMi0yMSAgS2V2aW4gRGVj a2VyICA8a2RlY2tlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTM1MjE1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NjczMTU3PgorICAgICAgICAKKyAgICAg ICAgVGhlIHBsdWdJblZpZXdXaXRoQXJndW1lbnRzOiBBUEkgcGFzc2VzIGEgZGljdGlvbmFyeSBv ZiBwbHVnaW4gYXJndW1lbnRzLiBPbmUgb2YgdGhlIHBhcmFtZXRlcnMKKyAgICAgICAgaXMgV2Vi UGx1Z0luQmFzZVVSTEtleSwgd2hpY2ggaXMgYSBrZXkgdGhhdCByZXByZXNlbnRzIHRoZSBiYXNl IFVSTCBvZiB0aGUgZG9jdW1lbnQgY29udGFpbmluZworICAgICAgICB0aGUgcGx1Zy1pbidzIHZp ZXcuIEluc3RlYWQgb2Ygc2VuZGluZyB0aGUgYmFzZSBVUkwsIGNvZGUgaW4gIFdlYkZyYW1lTG9h ZGVyQ2xpZW50OjpjcmVhdGVQbHVnaW4KKyAgICAgICAgd291bGQgaW5jb3JyZWN0bHkgcGFzcyB0 aGUgc291cmNlIFVSTCBvZiB0aGUgcGx1Zy1pbiByZXNvdXJjZS4KKworICAgICAgICAqIFdlYkNv cmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50Lm1tOgorICAgICAgICAoV2ViRnJhbWVMb2Fk ZXJDbGllbnQ6OmNyZWF0ZVBsdWdpbik6IFdoZW4gYnVpbGRpbmcgdGhlIHBsdWctaW4gYXJndW1l bnRzIGRpY3Rpb25hcnksIHBhc3MgdGhlCisgICAgICAgIHJlYWwgYmFzZSBVUkwgZm9yIHRoZSBX ZWJQbHVnSW5CYXNlVVJMS2V5IGtleS4KKwogMjAxMC0wMi0xOSAgTWFjaWVqIFN0YWNob3dpYWsg IDxtanNAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgo=