35208 2010-02-21 00:47:44 -0800 webkit-patch upload fails to upload large patches but does not report an error 2012-02-03 11:41:37 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED DUPLICATE 72863 P2 Normal --- 1 mjs webkit-unassigned abarth dbates enne eric simon.fraser oldest_to_newest 192250 0 mjs 2010-02-21 00:47:44 -0800 If a patch is over the 2M patch limit on bugs.webkit.org, webkit-patch upload will fail to upload it but will not report an error. Instead it appears to succeed. https://bugs.webkit.org/show_bug.cgi?id=35206 has an example of such a patch. 388211 1 enne 2011-04-18 18:58:36 -0700 *** Bug 58857 has been marked as a duplicate of this bug. *** 388216 2 eric 2011-04-18 19:03:57 -0700 Sad times. We should look at the bugzilla error code I guess. I think we have similar trouble with misspelled CCs. 388235 3 eric 2011-04-18 19:19:54 -0700 This is very similar to bug 31760. I suspect that the two places we need to check (and yell loudly) are: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/steps/createbug.py#L52 http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/steps/postdiff.py#L48 Possibly even returning or at least checking the result of browser.submit() here: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py#L483 548901 4 eric 2012-02-03 11:41:37 -0800 Duping this against bug 72863 since there has been more activity there. *** This bug has been marked as a duplicate of bug 72863 ***