35207 2010-02-20 23:16:11 -0800 all xhtml documents fail to render when XHTMLMP enabled 2010-03-10 13:52:26 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Critical --- 0 charles.wei webkit-unassigned commit-queue laszlo.gombos oldest_to_newest 192241 0 charles.wei 2010-02-20 23:16:11 -0800 For webkit portings which use XMLTokenizerLibxml2, When XHTMLMP is enabled, all the XHTML documents fail to render, including all the test cases in LayoutTests/dom/xhtml. 192248 1 49145 charles.wei 2010-02-21 00:01:23 -0800 Created attachment 49145 fix patch When the XHTMLMP is enabled, the author added one member function to class Document to decide if the document is of XHTMLMP type, and they later on in the tokenizer, it validates if the right Doctype is declared for xhtml-mp document. The right MIME type for XHTMLMP is "application/vnd.wap.xhtml+xml", while in the new member function isXHTMLMPDocument() of Document, it returns true for both "application/vnd.wap.xhtml+xml" and "application/xhtml+xml". In the Tokenizer, it trys to validate that the XHTMLDocument contains the right DTD declaration and public ID ("//WAPFORUM/DTD XHTML Mobile 1.0"), sure it fails for all the XHTML (non-MP) documents. Ths fix for this bug is only documents with MIME type "application/wap.vnd.xhtml+xml" will be treated as XHTMLMP documents; MIME type "application/xhtml+xml" is for XHTML documents. 192264 2 49145 staikos 2010-02-21 07:00:38 -0800 Comment on attachment 49145 fix patch Why does this touch WML? 192634 3 49145 eric 2010-02-22 14:28:30 -0800 Comment on attachment 49145 fix patch Like george, I don't understand why this channges WML. Not that the change is wrong, it just needs more explanation. It looks like this was always backwards: #if !ENABLE(XHTMLMP) 1256 || (extId == "-//WAPFORUM//DTD XHTML Mobile 1.0//EN") 1257 #endif ? Or if that should be enabled for all ports, just remove the #if. 192801 4 charles.wei 2010-02-22 23:51:34 -0800 Thanks, George, and Eric, for the review. The change for WML is a clean-up of the code. That piece of code is actually identical for both XHTMLMP, WML and XHTML, I just cleaned it up by removing the XHTMLMP and WML to remove the redundent code. 1255 #if !ENABLE(XHTMLMP) 1256 || (extId == "-//WAPFORUM//DTD XHTML Mobile 1.0//EN") 1257 #endif should only be enabled for XHTMLMP, while the original code makes it avaiable only if XHTMLMP is disabled, that is wrong . I hope this makes it clear and you will re-consider and take the patch . If you have other comments, I would be glad to work on that. 193600 5 laszlo.gombos 2010-02-24 19:14:59 -0800 It looks to me that this impacts not only XMLTokenizerLibxml2 but also XMLTokenizerQt.cpp. Charles, would you consider making the same changes for the Qt port as well together with this patch ? 198321 6 49145 commit-queue 2010-03-10 13:52:22 -0800 Comment on attachment 49145 fix patch Clearing flags on attachment: 49145 Committed r55802: <http://trac.webkit.org/changeset/55802> 198322 7 commit-queue 2010-03-10 13:52:26 -0800 All reviewed patches have been landed. Closing bug. 49145 2010-02-21 00:01:23 -0800 2010-03-10 13:52:22 -0800 fix patch 35207.patch text/plain 2900 charles.wei SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NTA2MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDItMjAgIENoYXJsZXMgV2VpICA8Y2hhcmxlcy53ZWlAdG9y Y2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEZpeCBodHRwczovL2J1Z3Mud2Via2lnLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzUy MDcKKyAgICAgICAgV2hlbiBYSFRNTE1QIGlzIGVuYWJsZWQsIGFsbCB4aHRtbCBkb2N1bWVudHMg ZmFpbCB0byByZW5kZXIgZm9yIHdlYmtpdCBwb3J0aW5ncyB3aWNoIHVzZSBsaWJ4bWwyIHRva2Vu aXplci4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgYWxsIHRoZSB4aHRtbCB0ZXN0IGNhc2Vz IGluIExheW91dFRlc3RzL2RvbS94aHRtbCBmYWlscyB3aXRob3V0IHRoaXMgZml4IHdoZW4gWEhU TUxNUCBpcyBlbmFibGVkLgorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkRvY3VtZW50Ojppc1hIVE1MTVBEb2N1bWVudCk6CisgICAgICAgICogZG9tL1hN TFRva2VuaXplckxpYnhtbDIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6WE1MVG9rZW5pemVyOjpp bnRlcm5hbFN1YnNldCk6CisgICAgICAgIChXZWJDb3JlOjpleHRlcm5hbFN1YnNldEhhbmRsZXIp OgorCiAyMDEwLTAyLTIwICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IE1hY2llaiBTdGFjaG93aWFrLgpJbmRleDogV2ViQ29yZS9kb20v RG9jdW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkocmV2 aXNpb24gNTUwNjEpCisrKyBXZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTQ3ODgsOCArNDc4OCw5IEBAIGJvb2wgRG9jdW1lbnQ6OmlzWEhUTUxNUERvY3VtZW50KCkg Y29uc3QKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIC8vIEFzIHBlciBzZWN0aW9uIDcuMiBv ZiBPTUEtV0FQLVhIVE1MTVAtVjFfMS0yMDA2MTAyMC1BLnBkZiwgYSBjb25mb3JtaW5nIHVzZXIg YWdlbnQKICAgICAvLyBNVVNUIGFjY2VwdCBYSFRNTE1QIGRvY3VtZW50IGlkZW50aWZpZWQgYXMg ImFwcGxpY2F0aW9uL3ZuZC53YXAueGh0bWwreG1sIgotICAgIC8vIGFuZCBTSE9VTEQgYWNjZXB0 IGl0IGlkZW50aWZpZWQgYXMgImFwcGxpY2F0aW9uL3hodG1sK3htbCIKLSAgICByZXR1cm4gZnJh bWUoKS0+bG9hZGVyKCktPnJlc3BvbnNlTUlNRVR5cGUoKSA9PSAiYXBwbGljYXRpb24vdm5kLndh cC54aHRtbCt4bWwiIHx8IGZyYW1lKCktPmxvYWRlcigpLT5yZXNwb25zZU1JTUVUeXBlKCkgPT0g ImFwcGxpY2F0aW9uL3hodG1sK3htbCI7CisgICAgLy8gYW5kIFNIT1VMRCBhY2NlcHQgaXQgaWRl bnRpZmllZCBhcyAiYXBwbGljYXRpb24veGh0bWwreG1sIiAsICJhcHBsaWNhdGlvbi94aHRtbCt4 bWwiIGlzIGEgCisgICAgLy8gZ2VuZXJhbCBNSU1FIHR5cGUgZm9yIGFsbCBYSFRNTCBkb2N1bWVu dHMsIG5vdCBvbmx5IGZvciBYSFRNTE1QCisgICAgcmV0dXJuIGZyYW1lKCktPmxvYWRlcigpLT5y ZXNwb25zZU1JTUVUeXBlKCkgPT0gImFwcGxpY2F0aW9uL3ZuZC53YXAueGh0bWwreG1sIjsKIH0K ICNlbmRpZgogCkluZGV4OiBXZWJDb3JlL2RvbS9YTUxUb2tlbml6ZXJMaWJ4bWwyLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9YTUxUb2tlbml6ZXJMaWJ4bWwyLmNwcAkocmV2aXNpb24g NTUwNjEpCisrKyBXZWJDb3JlL2RvbS9YTUxUb2tlbml6ZXJMaWJ4bWwyLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTA1OSwxMyArMTA1OSw3IEBAIHZvaWQgWE1MVG9rZW5pemVyOjppbnRlcm5hbFN1 YnNldChjb25zdAogICAgICAgICB9CiAjZW5kaWYKIAotI2lmIEVOQUJMRShYSFRNTE1QKQotICAg ICAgICBtX2RvYy0+YWRkQ2hpbGQoRG9jdW1lbnRUeXBlOjpjcmVhdGUobV9kb2MsIGR0ZE5hbWUs IGV4dElkLCB0b1N0cmluZyhzeXN0ZW1JRCkpKTsKLSNlbGlmIEVOQUJMRShXTUwpCi0gICAgICAg IG1fZG9jLT5hZGRDaGlsZChEb2N1bWVudFR5cGU6OmNyZWF0ZShtX2RvYywgdG9TdHJpbmcobmFt ZSksIGV4dElkLCB0b1N0cmluZyhzeXN0ZW1JRCkpKTsKLSNlbHNlCiAgICAgICAgIG1fZG9jLT5h ZGRDaGlsZChEb2N1bWVudFR5cGU6OmNyZWF0ZShtX2RvYywgdG9TdHJpbmcobmFtZSksIHRvU3Ry aW5nKGV4dGVybmFsSUQpLCB0b1N0cmluZyhzeXN0ZW1JRCkpKTsKLSNlbmRpZgogICAgIH0KIH0K IApAQCAtMTI1Miw3ICsxMjQ2LDcgQEAgc3RhdGljIHZvaWQgZXh0ZXJuYWxTdWJzZXRIYW5kbGVy KHZvaWQqCiAgICAgICAgIHx8IChleHRJZCA9PSAiLS8vVzNDLy9EVEQgWEhUTUwgQmFzaWMgMS4w Ly9FTiIpCiAgICAgICAgIHx8IChleHRJZCA9PSAiLS8vVzNDLy9EVEQgWEhUTUwgMS4xIHBsdXMg TWF0aE1MIDIuMC8vRU4iKQogICAgICAgICB8fCAoZXh0SWQgPT0gIi0vL1czQy8vRFREIFhIVE1M IDEuMSBwbHVzIE1hdGhNTCAyLjAgcGx1cyBTVkcgMS4xLy9FTiIpCi0jaWYgIUVOQUJMRShYSFRN TE1QKQorI2lmIEVOQUJMRShYSFRNTE1QKQogICAgICAgICB8fCAoZXh0SWQgPT0gIi0vL1dBUEZP UlVNLy9EVEQgWEhUTUwgTW9iaWxlIDEuMC8vRU4iKQogI2VuZGlmCiAgICAgICAgKQo=