35192 2010-02-20 06:30:38 -0800 Web Inspector: re-creating view in ResourcesPanel confuses ScriptsPanel's visibleView logic. 2010-02-20 07:40:13 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein commit-queue joepeck rik timothy oldest_to_newest 192164 0 pfeldman 2010-02-20 06:30:38 -0800 1. Visit http://v8.googlecode.com/svn/data/benchmarks/v5/run.html 2. Set breakpoint in richards.js, line ~50 3. Reload the page When you stop on a breakpoint, one in two times you will see two files (base.js and richards.js) rendered on top of each other. The reason is that when resource panel is re-creating a view from Other to Scripts, it manually hides last one, shows new one and that fools the ScriptsPanel's visibleView logic. I will provide a small fix right now, but I think we should get rid of view re-creation. Now that we have two tabs in resourceView we can make its contents pluggable. 192165 1 49124 pfeldman 2010-02-20 06:37:30 -0800 Created attachment 49124 [PATCH] Proposed fix. 192166 2 49124 timothy 2010-02-20 06:49:00 -0800 Comment on attachment 49124 [PATCH] Proposed fix. Pluggable sounds good. Might this fix bug 28799? 192167 3 pfeldman 2010-02-20 06:52:24 -0800 (In reply to comment #2) > (From update of attachment 49124 [details]) > Pluggable sounds good. Might this fix bug 28799? Does not address 28799. 192173 4 49124 commit-queue 2010-02-20 07:40:08 -0800 Comment on attachment 49124 [PATCH] Proposed fix. Clearing flags on attachment: 49124 Committed r55052: <http://trac.webkit.org/changeset/55052> 192174 5 commit-queue 2010-02-20 07:40:13 -0800 All reviewed patches have been landed. Closing bug. 49124 2010-02-20 06:37:30 -0800 2010-02-20 07:40:08 -0800 [PATCH] Proposed fix. recreate_view text/plain 1940 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODcyZjhiNC4uZDEyMGNlOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wMi0yMCAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiByZS1jcmVhdGluZyB2aWV3IGluIFJl c291cmNlc1BhbmVsIGNvbmZ1c2VzIFNjcmlwdHNQYW5lbCdzIHZpc2libGVWaWV3IGxvZ2ljLgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTE5Mgor CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qczoKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZXNQYW5lbC5wcm90b3R5cGUucmVjcmVhdGVWaWV3Rm9y UmVzb3VyY2VJZk5lZWRlZCk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRz UGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2NyaXB0c1BhbmVsLnByb3RvdHlwZS5z aG93KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TY3JpcHRzUGFuZWwucHJvdG90eXBlLnZpZXdS ZWNyZWF0ZWQpOgorCiAyMDEwLTAyLTE5ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIE5vdCByZXZpZXdlZC4gQ2hyb21pdW0gYnVpbGQgZml4OiByZXZl cnRpbmcgcjU0OTk3IGFuZCByNTQ5OTguCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvUmVzb3VyY2VzUGFuZWwuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv UmVzb3VyY2VzUGFuZWwuanMKaW5kZXggMTkzMjViYi4uOWE0NGM1NyAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlc1BhbmVsLmpzCisrKyBiL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qcwpAQCAtNDUwLDYgKzQ1MCw4IEBA IFdlYkluc3BlY3Rvci5SZXNvdXJjZXNQYW5lbC5wcm90b3R5cGUgPSB7CiAKICAgICAgICAgaWYg KG9sZFZpZXdQYXJlbnROb2RlKQogICAgICAgICAgICAgbmV3Vmlldy5zaG93KG9sZFZpZXdQYXJl bnROb2RlKTsKKworICAgICAgICBXZWJJbnNwZWN0b3IucGFuZWxzLnNjcmlwdHMudmlld1JlY3Jl YXRlZChvbGRWaWV3LCBuZXdWaWV3KTsKICAgICB9LAogCiAgICAgY2FuU2hvd1NvdXJjZUxpbmVG b3JVUkw6IGZ1bmN0aW9uKHVybCkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9TY3JpcHRzUGFuZWwuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0 c1BhbmVsLmpzCmluZGV4IGRhMjRlZDIuLmVkMWFkNmUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcwpAQCAtNTA4LDYgKzUwOCwxMiBAQCBXZWJJbnNwZWN0 b3IuU2NyaXB0c1BhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHguc2hvdyh0aGlzLnZp ZXdzQ29udGFpbmVyRWxlbWVudCk7CiAgICAgfSwKIAorICAgIHZpZXdSZWNyZWF0ZWQ6IGZ1bmN0 aW9uKG9sZFZpZXcsIG5ld1ZpZXcpCisgICAgeworICAgICAgICBpZiAodGhpcy5fdmlzaWJsZVZp ZXcgPT09IG9sZFZpZXcpCisgICAgICAgICAgICB0aGlzLl92aXNpYmxlVmlldyA9IG5ld1ZpZXc7 CisgICAgfSwKKwogICAgIGNhblNob3dTb3VyY2VMaW5lRm9yVVJMOiBmdW5jdGlvbih1cmwpCiAg ICAgewogICAgICAgICByZXR1cm4gSW5zcGVjdG9yQmFja2VuZC5kZWJ1Z2dlckVuYWJsZWQoKSAm Jgo=