35174 2010-02-19 13:46:15 -0800 [Chromium] Call WebViewClient::didAcceptAutoFillSuggestion when the user selects a suggestion from the AutoFill suggestions popup 2010-02-19 16:41:58 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 jhawkins webkit-unassigned commit-queue fishd oldest_to_newest 192037 0 jhawkins 2010-02-19 13:46:15 -0800 This is the final piece of glue in implementing form AutoFill. Patch will follow. 192038 1 49104 jhawkins 2010-02-19 13:47:54 -0800 Created attachment 49104 [Chromium] Call WebViewClient::didAcceptAutoFillSuggestion when the user selects a suggestion from the AutoFill suggestions popup 192040 2 jhawkins 2010-02-19 13:49:22 -0800 Update: I have a CL out for review [1] that adds this method to RenderView. We should probably wait on cq+ until the CL in question is committed. [1] http://codereview.chromium.org/651002 192111 3 49104 commit-queue 2010-02-19 16:41:53 -0800 Comment on attachment 49104 [Chromium] Call WebViewClient::didAcceptAutoFillSuggestion when the user selects a suggestion from the AutoFill suggestions popup Clearing flags on attachment: 49104 Committed r55037: <http://trac.webkit.org/changeset/55037> 192112 4 commit-queue 2010-02-19 16:41:58 -0800 All reviewed patches have been landed. Closing bug. 49104 2010-02-19 13:47:54 -0800 2010-02-19 16:41:53 -0800 [Chromium] Call WebViewClient::didAcceptAutoFillSuggestion when the user selects a suggestion from the AutoFill suggestions popup didaccept.diff text/plain 3632 jhawkins SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTUwMjkpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDItMTkgIEphbWVz IEhhd2tpbnMgIDxqaGF3a2luc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBDYWxsIFdlYlZpZXdDbGllbnQ6 OmRpZEFjY2VwdEF1dG9GaWxsU3VnZ2VzdGlvbiB3aGVuIHRoZQorICAgICAgICB1c2VyIHNlbGVj dHMgYSBzdWdnZXN0aW9uIGZyb20gdGhlIEF1dG9GaWxsIHN1Z2dlc3Rpb25zIHBvcHVwLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTE3NAorCisg ICAgICAgICogcHVibGljL1dlYlZpZXdDbGllbnQuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmll d0NsaWVudDo6ZGlkQWNjZXB0QXV0b0ZpbGxTdWdnZXN0aW9uKToKKyAgICAgICAgKiBzcmMvQXV0 b0ZpbGxQb3B1cE1lbnVDbGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpBdXRvRmlsbFBvcHVw TWVudUNsaWVudDo6dmFsdWVDaGFuZ2VkKToKKyAgICAgICAgKiBzcmMvQXV0b0ZpbGxQb3B1cE1l bnVDbGllbnQuaDoKKwogMjAxMC0wMi0xOCAgUGV0ZXIgS2FzdGluZyAgPHBrYXN0aW5nQGdvb2ds ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpJbmRleDogV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmgJKHJldmlzaW9uIDU1MDI3KQorKysgV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTI3OCw2 ICsyNzgsMTMgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCByZW1vdmVBdXRvZmlsbFN1Z2dl c3Rpb25zKGNvbnN0IFdlYlN0cmluZyYgbmFtZSwKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBjb25zdCBXZWJTdHJpbmcmIHZhbHVlKSB7IH0KIAorICAgIC8vIElu Zm9ybXMgdGhlIGJyb3dzZXIgdGhhdCB0aGUgdXNlciBoYXMgc2VsZWN0ZWQgYW4gQXV0b0ZpbGwg c3VnZ2VzdGlvbgorICAgIC8vIGZvciBhIFdlYk5vZGUuICB8bmFtZXwgYW5kIHxsYWJlbHwgZm9y bSBhIGtleSBpbnRvIHRoZSBzZXQgb2YgQXV0b0ZpbGwKKyAgICAvLyBwcm9maWxlcy4KKyAgICB2 aXJ0dWFsIHZvaWQgZGlkQWNjZXB0QXV0b0ZpbGxTdWdnZXN0aW9uKGNvbnN0IFdlYk5vZGUmLAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgV2ViU3Ry aW5nJiBuYW1lLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Y29uc3QgV2ViU3RyaW5nJiBsYWJlbCkgeyB9CisKICAgICAvLyBHZW9sb2NhdGlvbiAtLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIAogICAg IC8vIEFjY2VzcyB0aGUgZW1iZWRkZXIgQVBJIGZvciBnZW9sb2NhdGlvbiBzZXJ2aWNlcy4KSW5k ZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvQXV0b0ZpbGxQb3B1cE1lbnVDbGllbnQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvQXV0b0ZpbGxQb3B1cE1lbnVDbGllbnQuY3Bw CShyZXZpc2lvbiA1NTAyNykKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvQXV0b0ZpbGxQb3B1cE1l bnVDbGllbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw4ICszMiwxMSBAQAogI2luY2x1ZGUg IkF1dG9GaWxsUG9wdXBNZW51Q2xpZW50LmgiCiAKICNpbmNsdWRlICJIVE1MSW5wdXRFbGVtZW50 LmgiCisjaW5jbHVkZSAiV2ViTm9kZS5oIgogI2luY2x1ZGUgIldlYlN0cmluZy5oIgogI2luY2x1 ZGUgIldlYlZlY3Rvci5oIgorI2luY2x1ZGUgIldlYlZpZXdDbGllbnQuaCIKKyNpbmNsdWRlICJX ZWJWaWV3SW1wbC5oIgogCiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIApAQCAtNTksNiArNjIs MTkgQEAgdm9pZCBBdXRvRmlsbFBvcHVwTWVudUNsaWVudDo6cmVtb3ZlU3VnZwogICAgIG1fbGFi ZWxzLnJlbW92ZShsaXN0SW5kZXgpOwogfQogCit2b2lkIEF1dG9GaWxsUG9wdXBNZW51Q2xpZW50 Ojp2YWx1ZUNoYW5nZWQodW5zaWduZWQgbGlzdEluZGV4LCBib29sIGZpcmVFdmVudHMpCit7Cisg ICAgQVNTRVJUKGxpc3RJbmRleCA+PSAwICYmIGxpc3RJbmRleCA8IG1fbmFtZXMuc2l6ZSgpKTsK KworICAgIFdlYlZpZXdJbXBsKiB3ZWJWaWV3ID0gZ2V0V2ViVmlldygpOworICAgIGlmICghd2Vi VmlldykKKyAgICAgICAgcmV0dXJuOworCisgICAgd2ViVmlldy0+Y2xpZW50KCktPmRpZEFjY2Vw dEF1dG9GaWxsU3VnZ2VzdGlvbihXZWJOb2RlKGdldFRleHRGaWVsZCgpKSwKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1fbmFtZXNbbGlzdEluZGV4 XSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1f bGFiZWxzW2xpc3RJbmRleF0pOworfQorCiB2b2lkIEF1dG9GaWxsUG9wdXBNZW51Q2xpZW50Ojpp bml0aWFsaXplKAogICAgIEhUTUxJbnB1dEVsZW1lbnQqIHRleHRGaWVsZCwKICAgICBjb25zdCBX ZWJWZWN0b3I8V2ViU3RyaW5nPiYgbmFtZXMsCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL0F1 dG9GaWxsUG9wdXBNZW51Q2xpZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3Ny Yy9BdXRvRmlsbFBvcHVwTWVudUNsaWVudC5oCShyZXZpc2lvbiA1NTAyNykKKysrIFdlYktpdC9j aHJvbWl1bS9zcmMvQXV0b0ZpbGxQb3B1cE1lbnVDbGllbnQuaAkod29ya2luZyBjb3B5KQpAQCAt NTAsNiArNTAsOSBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBXZWJTdHJpbmcgZ2V0U3VnZ2VzdGlv bih1bnNpZ25lZCBsaXN0SW5kZXgpIGNvbnN0OwogICAgIHZpcnR1YWwgdm9pZCByZW1vdmVTdWdn ZXN0aW9uQXRJbmRleCh1bnNpZ25lZCBsaXN0SW5kZXgpOwogCisgICAgLy8gV2ViQ29yZTo6UG9w dXBNZW51Q2xpZW50IGltcGxlbWVudGF0aW9uOgorICAgIHZpcnR1YWwgdm9pZCB2YWx1ZUNoYW5n ZWQodW5zaWduZWQgbGlzdEluZGV4LCBib29sIGZpcmVFdmVudHMgPSB0cnVlKTsKKwogICAgIHZv aWQgaW5pdGlhbGl6ZShXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50KiwKICAgICAgICAgICAgICAg ICAgICAgY29uc3QgV2ViVmVjdG9yPFdlYlN0cmluZz4mIG5hbWVzLAogICAgICAgICAgICAgICAg ICAgICBjb25zdCBXZWJWZWN0b3I8V2ViU3RyaW5nPiYgbGFiZWxzLAo=