35172 2010-02-19 13:30:53 -0800 [Chromium] Use the m_suggestionsPopupClient pointer to refer to the popup client, as the Autocomplete popup might not be the current popup 2010-02-19 14:51:04 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 jhawkins webkit-unassigned commit-queue eric oldest_to_newest 192027 0 jhawkins 2010-02-19 13:30:53 -0800 This fixes a crash when the AutoFill suggestions popup is shown and the user deletes enough characters so that the popup hides itself. Patch will follow. 192029 1 49102 jhawkins 2010-02-19 13:32:11 -0800 Created attachment 49102 [Chromium] Use the m_suggestionsPopupClient pointer to refer to the popup client, as the Autocomplete popup might not be the current popup 192049 2 49102 eric 2010-02-19 14:17:12 -0800 Comment on attachment 49102 [Chromium] Use the m_suggestionsPopupClient pointer to refer to the popup client, as the Autocomplete popup might not be the current popup What other popups (non-autocomplete) are we using? Some sort of grammar/spelling? 192050 3 jhawkins 2010-02-19 14:18:46 -0800 The AutoFill popup is the other popup. It behaves a bit differently than the Autocomplete popup. 192068 4 49102 commit-queue 2010-02-19 14:51:00 -0800 Comment on attachment 49102 [Chromium] Use the m_suggestionsPopupClient pointer to refer to the popup client, as the Autocomplete popup might not be the current popup Clearing flags on attachment: 49102 Committed r55032: <http://trac.webkit.org/changeset/55032> 192069 5 commit-queue 2010-02-19 14:51:04 -0800 All reviewed patches have been landed. Closing bug. 49102 2010-02-19 13:32:11 -0800 2010-02-19 14:51:00 -0800 [Chromium] Use the m_suggestionsPopupClient pointer to refer to the popup client, as the Autocomplete popup might not be the current popup fixcrash.diff text/plain 2092 jhawkins SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTUwMjcpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDItMTkgIEphbWVz IEhhd2tpbnMgIDxqaGF3a2luc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBVc2UgdGhlIG1fc3VnZ2VzdGlv bnNQb3B1cENsaWVudCBwb2ludGVyIHRvIHJlZmVyIHRvIHRoZQorICAgICAgICBwb3B1cCBjbGll bnQsIGFzIHRoZSBBdXRvY29tcGxldGUgcG9wdXAgbWlnaHQgbm90IGJlIHRoZSBjdXJyZW50Cisg ICAgICAgIHBvcHVwLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zNTE3MgorCisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2ViVmlld0ltcGw6OmF1dG9jb21wbGV0ZUhhbmRsZUtleUV2ZW50KToKKyAgICAg ICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OnJlZnJlc2hTdWdnZXN0aW9uc1BvcHVwKToKKwogMjAx MC0wMi0xOSAgTWFyY3VzIEJ1bGFjaCAgPGJ1bGFjaEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgSmVyZW15IE9ybG93LgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJW aWV3SW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1w bC5jcHAJKHJldmlzaW9uIDU1MDI3KQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1w bC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU0MCwxMSArNTQwLDExIEBAIGJvb2wgV2ViVmlld0lt cGw6OmF1dG9jb21wbGV0ZUhhbmRsZUtleUUKICAgICAgICAgaW50IHNlbGVjdGVkSW5kZXggPSBt X3N1Z2dlc3Rpb25zUG9wdXAtPnNlbGVjdGVkSW5kZXgoKTsKICAgICAgICAgSFRNTElucHV0RWxl bWVudCogaW5wdXRFbGVtZW50ID0gc3RhdGljX2Nhc3Q8SFRNTElucHV0RWxlbWVudCo+KGVsZW1l bnQpOwogICAgICAgICBXZWJTdHJpbmcgbmFtZSA9IGlucHV0RWxlbWVudC0+bmFtZSgpOwotICAg ICAgICBXZWJTdHJpbmcgdmFsdWUgPSBtX2F1dG9jb21wbGV0ZVBvcHVwQ2xpZW50LT5pdGVtVGV4 dChzZWxlY3RlZEluZGV4KTsKKyAgICAgICAgV2ViU3RyaW5nIHZhbHVlID0gbV9zdWdnZXN0aW9u c1BvcHVwQ2xpZW50LT5pdGVtVGV4dChzZWxlY3RlZEluZGV4KTsKICAgICAgICAgbV9jbGllbnQt PnJlbW92ZUF1dG9maWxsU3VnZ2VzdGlvbnMobmFtZSwgdmFsdWUpOwogICAgICAgICAvLyBVcGRh dGUgdGhlIGVudHJpZXMgaW4gdGhlIGN1cnJlbnRseSBzaG93aW5nIHBvcHVwIHRvIHJlZmxlY3Qg dGhlCiAgICAgICAgIC8vIGRlbGV0aW9uLgotICAgICAgICBtX2F1dG9jb21wbGV0ZVBvcHVwQ2xp ZW50LT5yZW1vdmVTdWdnZXN0aW9uQXRJbmRleChzZWxlY3RlZEluZGV4KTsKKyAgICAgICAgbV9z dWdnZXN0aW9uc1BvcHVwQ2xpZW50LT5yZW1vdmVTdWdnZXN0aW9uQXRJbmRleChzZWxlY3RlZElu ZGV4KTsKICAgICAgICAgcmVmcmVzaFN1Z2dlc3Rpb25zUG9wdXAoKTsKICAgICAgICAgcmV0dXJu IGZhbHNlOwogICAgIH0KQEAgLTE4NzEsNyArMTg3MSw3IEBAIHZvaWQgV2ViVmlld0ltcGw6OnJl ZnJlc2hTdWdnZXN0aW9uc1BvcHUKICAgICBBU1NFUlQobV9zdWdnZXN0aW9uc1BvcHVwU2hvd2lu Zyk7CiAKICAgICAvLyBIaWRlIHRoZSBwb3B1cCBpZiBpdCBoYXMgYmVjb21lIGVtcHR5LgotICAg IGlmICghbV9hdXRvY29tcGxldGVQb3B1cENsaWVudC0+bGlzdFNpemUoKSkgeworICAgIGlmICgh bV9zdWdnZXN0aW9uc1BvcHVwQ2xpZW50LT5saXN0U2l6ZSgpKSB7CiAgICAgICAgIGhpZGVTdWdn ZXN0aW9uc1BvcHVwKCk7CiAgICAgICAgIHJldHVybjsKICAgICB9Cg==