35171 2010-02-19 13:24:33 -0800 [Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function 2010-02-19 14:35:05 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 jhawkins webkit-unassigned commit-queue dglazkov eric webkit.review.bot oldest_to_newest 192023 0 jhawkins 2010-02-19 13:24:33 -0800 Now that there are two Suggestion popup clients, AutoFill and Autocomplete, this method should be renamed to properly reflect the purpose of the function. Patch will follow. 192024 1 49100 jhawkins 2010-02-19 13:26:36 -0800 Created attachment 49100 [Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function 192025 2 webkit.review.bot 2010-02-19 13:29:56 -0800 Attachment 49100 did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/288835 192031 3 49103 jhawkins 2010-02-19 13:35:29 -0800 Created attachment 49103 [Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function [try2] It helps if you actually change the function declaration. 192048 4 49103 eric 2010-02-19 14:16:27 -0800 Comment on attachment 49103 [Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function [try2] OK. 192058 5 49103 commit-queue 2010-02-19 14:35:01 -0800 Comment on attachment 49103 [Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function [try2] Clearing flags on attachment: 49103 Committed r55031: <http://trac.webkit.org/changeset/55031> 192059 6 commit-queue 2010-02-19 14:35:05 -0800 All reviewed patches have been landed. Closing bug. 49100 2010-02-19 13:26:36 -0800 2010-02-19 13:35:29 -0800 [Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function rename.diff text/plain 2927 jhawkins SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTUwMjcpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDItMTkgIEphbWVz IEhhd2tpbnMgIDxqaGF3a2luc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBSZW5hbWUgRWRpdG9yQ2xpZW50 SW1wbDo6b25BdXRvZmlsbFN1Z2dlc3Rpb25BY2NlcHRlZCB0bworICAgICAgICBvbkF1dG9jb21w bGV0ZVN1Z2dlc3Rpb25BY2NlcHRlZCB0byBiZXR0ZXIgbWF0Y2ggdGhlIHB1cnBvc2Ugb2YgdGhl CisgICAgICAgIGZ1bmN0aW9uLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zNTE3MQorCisgICAgICAgICogc3JjL0VkaXRvckNsaWVudEltcGwuY3Bw OgorICAgICAgICAoV2ViS2l0OjpFZGl0b3JDbGllbnRJbXBsOjpvbkF1dG9jb21wbGV0ZVN1Z2dl c3Rpb25BY2NlcHRlZCk6CisgICAgICAgICogc3JjL0VkaXRvckNsaWVudEltcGwuaDoKKyAgICAg ICAgKiBzcmMvU3VnZ2VzdGlvbnNQb3B1cE1lbnVDbGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0 OjpTdWdnZXN0aW9uc1BvcHVwTWVudUNsaWVudDo6dmFsdWVDaGFuZ2VkKToKKwogMjAxMC0wMi0x OSAgTWFyY3VzIEJ1bGFjaCAgPGJ1bGFjaEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgSmVyZW15IE9ybG93LgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9FZGl0b3JDbGll bnRJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL0VkaXRvckNsaWVu dEltcGwuY3BwCShyZXZpc2lvbiA1NTAyNykKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvRWRpdG9y Q2xpZW50SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc4NCw3ICs3ODQsNyBAQCB2b2lkIEVk aXRvckNsaWVudEltcGw6OmNhbmNlbFBlbmRpbmdBdXRvCiAgICAgbV9hdXRvZmlsbFRpbWVyLnN0 b3AoKTsKIH0KIAotdm9pZCBFZGl0b3JDbGllbnRJbXBsOjpvbkF1dG9maWxsU3VnZ2VzdGlvbkFj Y2VwdGVkKEhUTUxJbnB1dEVsZW1lbnQqIHRleHRGaWVsZCkKK3ZvaWQgRWRpdG9yQ2xpZW50SW1w bDo6b25BdXRvY29tcGxldGVTdWdnZXN0aW9uQWNjZXB0ZWQoSFRNTElucHV0RWxlbWVudCogdGV4 dEZpZWxkKQogewogICAgIFdlYkZyYW1lSW1wbCogd2ViZnJhbWUgPSBXZWJGcmFtZUltcGw6OmZy b21GcmFtZSh0ZXh0RmllbGQtPmRvY3VtZW50KCktPmZyYW1lKCkpOwogICAgIGlmICghd2ViZnJh bWUpCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL0VkaXRvckNsaWVudEltcGwuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL0VkaXRvckNsaWVudEltcGwuaAkocmV2aXNpb24g NTUwMjcpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL0VkaXRvckNsaWVudEltcGwuaAkod29ya2lu ZyBjb3B5KQpAQCAtMTE4LDggKzExOCw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgc2hv d0Zvcm1BdXRvZmlsbEZvck5vZGUoV2ViQ29yZTo6Tm9kZSopOwogCiAgICAgLy8gTm90aWZpY2F0 aW9uIHRoYXQgdGhlIHRleHQgY2hhbmdlZCBkdWUgdG8gYWNjZXB0YW5jZSBvZiBhIHN1Z2dlc3Rp b24KLSAgICAvLyBwcm92aWRlZCBieSBhbiBhdXRvZmlsbCBwb3B1cC4gIEhhdmluZyBhIHNlcGFy YXRlIGNhbGxiYWNrIGluIHRoaXMgY2FzZQotICAgIC8vIGlzIGEgc2ltcGxlIHdheSB0byBicmVh ayB0aGUgY3ljbGUgdGhhdCB3b3VsZCBvdGhlcndpc2Ugb2NjdXIgaWYKKyAgICAvLyBwcm92aWRl ZCBieSBhbiBBdXRvY29tcGxldGUgcG9wdXAuICBIYXZpbmcgYSBzZXBhcmF0ZSBjYWxsYmFjayBp biB0aGlzCisgICAgLy8gY2FzZSBpcyBhIHNpbXBsZSB3YXkgdG8gYnJlYWsgdGhlIGN5Y2xlIHRo YXQgd291bGQgb3RoZXJ3aXNlIG9jY3VyIGlmCiAgICAgLy8gdGV4dERpZENoYW5nZUluVGV4dEZp ZWxkIHdhcyBjYWxsZWQuCiAgICAgdmlydHVhbCB2b2lkIG9uQXV0b2ZpbGxTdWdnZXN0aW9uQWNj ZXB0ZWQoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudCopOwogCkluZGV4OiBXZWJLaXQvY2hyb21p dW0vc3JjL1N1Z2dlc3Rpb25zUG9wdXBNZW51Q2xpZW50LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXQvY2hyb21pdW0vc3JjL1N1Z2dlc3Rpb25zUG9wdXBNZW51Q2xpZW50LmNwcAkocmV2aXNpb24g NTUwMjcpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1N1Z2dlc3Rpb25zUG9wdXBNZW51Q2xpZW50 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjUsNyArNjUsNyBAQCB2b2lkIFN1Z2dlc3Rpb25zUG9w dXBNZW51Q2xpZW50Ojp2YWx1ZUNoCiAgICAgRWRpdG9yQ2xpZW50SW1wbCogZWRpdG9yID0KICAg ICAgICAgc3RhdGljX2Nhc3Q8RWRpdG9yQ2xpZW50SW1wbCo+KHdlYlZpZXctPnBhZ2UoKS0+ZWRp dG9yQ2xpZW50KCkpOwogICAgIEFTU0VSVChlZGl0b3IpOwotICAgIGVkaXRvci0+b25BdXRvZmls bFN1Z2dlc3Rpb25BY2NlcHRlZCgKKyAgICBlZGl0b3ItPm9uQXV0b2NvbXBsZXRlU3VnZ2VzdGlv bkFjY2VwdGVkKAogICAgICAgICBzdGF0aWNfY2FzdDxIVE1MSW5wdXRFbGVtZW50Kj4obV90ZXh0 RmllbGQuZ2V0KCkpKTsKIH0KIAo= 49103 2010-02-19 13:35:29 -0800 2010-02-19 14:35:01 -0800 [Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function [try2] rename2.diff text/plain 3088 jhawkins SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTUwMjgpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDItMTkgIEphbWVz IEhhd2tpbnMgIDxqaGF3a2luc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBSZW5hbWUgRWRpdG9yQ2xpZW50 SW1wbDo6b25BdXRvZmlsbFN1Z2dlc3Rpb25BY2NlcHRlZCB0bworICAgICAgICBvbkF1dG9jb21w bGV0ZVN1Z2dlc3Rpb25BY2NlcHRlZCB0byBiZXR0ZXIgbWF0Y2ggdGhlIHB1cnBvc2Ugb2YgdGhl CisgICAgICAgIGZ1bmN0aW9uLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zNTE3MQorCisgICAgICAgICogc3JjL0VkaXRvckNsaWVudEltcGwuY3Bw OgorICAgICAgICAoV2ViS2l0OjpFZGl0b3JDbGllbnRJbXBsOjpvbkF1dG9jb21wbGV0ZVN1Z2dl c3Rpb25BY2NlcHRlZCk6CisgICAgICAgICogc3JjL0VkaXRvckNsaWVudEltcGwuaDoKKyAgICAg ICAgKiBzcmMvU3VnZ2VzdGlvbnNQb3B1cE1lbnVDbGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0 OjpTdWdnZXN0aW9uc1BvcHVwTWVudUNsaWVudDo6dmFsdWVDaGFuZ2VkKToKKwogMjAxMC0wMi0x OSAgTWFyY3VzIEJ1bGFjaCAgPGJ1bGFjaEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgSmVyZW15IE9ybG93LgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9FZGl0b3JDbGll bnRJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL0VkaXRvckNsaWVu dEltcGwuY3BwCShyZXZpc2lvbiA1NTAyNykKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvRWRpdG9y Q2xpZW50SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc4NCw3ICs3ODQsNyBAQCB2b2lkIEVk aXRvckNsaWVudEltcGw6OmNhbmNlbFBlbmRpbmdBdXRvCiAgICAgbV9hdXRvZmlsbFRpbWVyLnN0 b3AoKTsKIH0KIAotdm9pZCBFZGl0b3JDbGllbnRJbXBsOjpvbkF1dG9maWxsU3VnZ2VzdGlvbkFj Y2VwdGVkKEhUTUxJbnB1dEVsZW1lbnQqIHRleHRGaWVsZCkKK3ZvaWQgRWRpdG9yQ2xpZW50SW1w bDo6b25BdXRvY29tcGxldGVTdWdnZXN0aW9uQWNjZXB0ZWQoSFRNTElucHV0RWxlbWVudCogdGV4 dEZpZWxkKQogewogICAgIFdlYkZyYW1lSW1wbCogd2ViZnJhbWUgPSBXZWJGcmFtZUltcGw6OmZy b21GcmFtZSh0ZXh0RmllbGQtPmRvY3VtZW50KCktPmZyYW1lKCkpOwogICAgIGlmICghd2ViZnJh bWUpCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL0VkaXRvckNsaWVudEltcGwuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL0VkaXRvckNsaWVudEltcGwuaAkocmV2aXNpb24g NTUwMjcpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL0VkaXRvckNsaWVudEltcGwuaAkod29ya2lu ZyBjb3B5KQpAQCAtMTE4LDEwICsxMTgsMTAgQEAgcHVibGljOgogICAgIHZpcnR1YWwgYm9vbCBz aG93Rm9ybUF1dG9maWxsRm9yTm9kZShXZWJDb3JlOjpOb2RlKik7CiAKICAgICAvLyBOb3RpZmlj YXRpb24gdGhhdCB0aGUgdGV4dCBjaGFuZ2VkIGR1ZSB0byBhY2NlcHRhbmNlIG9mIGEgc3VnZ2Vz dGlvbgotICAgIC8vIHByb3ZpZGVkIGJ5IGFuIGF1dG9maWxsIHBvcHVwLiAgSGF2aW5nIGEgc2Vw YXJhdGUgY2FsbGJhY2sgaW4gdGhpcyBjYXNlCi0gICAgLy8gaXMgYSBzaW1wbGUgd2F5IHRvIGJy ZWFrIHRoZSBjeWNsZSB0aGF0IHdvdWxkIG90aGVyd2lzZSBvY2N1ciBpZgorICAgIC8vIHByb3Zp ZGVkIGJ5IGFuIEF1dG9jb21wbGV0ZSBwb3B1cC4gIEhhdmluZyBhIHNlcGFyYXRlIGNhbGxiYWNr IGluIHRoaXMKKyAgICAvLyBjYXNlIGlzIGEgc2ltcGxlIHdheSB0byBicmVhayB0aGUgY3ljbGUg dGhhdCB3b3VsZCBvdGhlcndpc2Ugb2NjdXIgaWYKICAgICAvLyB0ZXh0RGlkQ2hhbmdlSW5UZXh0 RmllbGQgd2FzIGNhbGxlZC4KLSAgICB2aXJ0dWFsIHZvaWQgb25BdXRvZmlsbFN1Z2dlc3Rpb25B Y2NlcHRlZChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50Kik7CisgICAgdmlydHVhbCB2b2lkIG9u QXV0b2NvbXBsZXRlU3VnZ2VzdGlvbkFjY2VwdGVkKFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQq KTsKIAogcHJpdmF0ZToKICAgICB2b2lkIG1vZGlmeVNlbGVjdGlvbihXZWJDb3JlOjpGcmFtZSos IFdlYkNvcmU6OktleWJvYXJkRXZlbnQqKTsKSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvU3Vn Z2VzdGlvbnNQb3B1cE1lbnVDbGllbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1 bS9zcmMvU3VnZ2VzdGlvbnNQb3B1cE1lbnVDbGllbnQuY3BwCShyZXZpc2lvbiA1NTAyNykKKysr IFdlYktpdC9jaHJvbWl1bS9zcmMvU3VnZ2VzdGlvbnNQb3B1cE1lbnVDbGllbnQuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC02NSw3ICs2NSw3IEBAIHZvaWQgU3VnZ2VzdGlvbnNQb3B1cE1lbnVDbGll bnQ6OnZhbHVlQ2gKICAgICBFZGl0b3JDbGllbnRJbXBsKiBlZGl0b3IgPQogICAgICAgICBzdGF0 aWNfY2FzdDxFZGl0b3JDbGllbnRJbXBsKj4od2ViVmlldy0+cGFnZSgpLT5lZGl0b3JDbGllbnQo KSk7CiAgICAgQVNTRVJUKGVkaXRvcik7Ci0gICAgZWRpdG9yLT5vbkF1dG9maWxsU3VnZ2VzdGlv bkFjY2VwdGVkKAorICAgIGVkaXRvci0+b25BdXRvY29tcGxldGVTdWdnZXN0aW9uQWNjZXB0ZWQo CiAgICAgICAgIHN0YXRpY19jYXN0PEhUTUxJbnB1dEVsZW1lbnQqPihtX3RleHRGaWVsZC5nZXQo KSkpOwogfQogCg==