35165 2010-02-19 10:27:56 -0800 plugins/set-status.html fails on Windows bot 2010-02-19 11:00:04 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 ap ap oldest_to_newest 191961 0 ap 2010-02-19 10:27:56 -0800 http://build.webkit.org/results/Windows%20Release%20%28Tests%29/r55012%20%289239%29/plugins/set-status-pretty-diff.html This is a pre-existing difference between Mac and Windows that's uncovered by this new test - Mac ignores null messages in NPN_SetMessage, while Windows treats them as empty ones. Mac Firefox sets status to "Done" when message is null - and since we don't say "Done" after finishing the load, the closest equivalent is an empty status. 191980 1 49095 ap 2010-02-19 10:56:44 -0800 Created attachment 49095 proposed fix 191983 2 ap 2010-02-19 11:00:04 -0800 Committed <http://trac.webkit.org/changeset/55021>. 49095 2010-02-19 10:56:44 -0800 2010-02-19 10:58:10 -0800 proposed fix NullStatus2.txt text/plain 3308 ap SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA1NTAyMCkKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDItMTkgIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1MTY1Cisg ICAgICAgIHBsdWdpbnMvc2V0LXN0YXR1cy5odG1sIGZhaWxzIG9uIFdpbmRvd3MgYm90CisKKyAg ICAgICAgKiBQbHVnaW5zL0hvc3RlZC9OZXRzY2FwZVBsdWdpbkluc3RhbmNlUHJveHkubW06Cisg ICAgICAgIChXZWJLaXQ6Ok5ldHNjYXBlUGx1Z2luSW5zdGFuY2VQcm94eTo6c3RhdHVzKToKKyAg ICAgICAgKiBQbHVnaW5zL1dlYk5ldHNjYXBlUGx1Z2luVmlldy5tbToKKyAgICAgICAgKC1bV2Vi TmV0c2NhcGVQbHVnaW5WaWV3IHN0YXR1czpdKToKKyAgICAgICAgTWF0Y2ggV2luZG93cyBwb3J0 IGJlaGF2aW9yIChhbmQgYWxzbyBGaXJlZm94IG9uZSwgaW4gYSB3YXkpIC0gcGFzcyBudWxsIHN0 YXR1cyBtZXNzYWdlcyBhcworICAgICAgICBlbXB0eSBvbmVzIHRvIGNocm9tZS4KKwogMjAxMC0w Mi0xOCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpJbmRleDogV2ViS2l0L21hYy9QbHVnaW5zL1dlYk5l dHNjYXBlUGx1Z2luVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvbWFjL1BsdWdpbnMvV2Vi TmV0c2NhcGVQbHVnaW5WaWV3Lm1tCShyZXZpc2lvbiA1NTAyMCkKKysrIFdlYktpdC9tYWMvUGx1 Z2lucy9XZWJOZXRzY2FwZVBsdWdpblZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTE5MDQsMTIg KzE5MDQsNyBAQCBzdGF0aWMgaW5saW5lIHZvaWQgZ2V0TlBSZWN0KGNvbnN0IE5TUmVjCiAKIC0o dm9pZClzdGF0dXM6KGNvbnN0IGNoYXIgKiltZXNzYWdlCiB7ICAgIAotICAgIGlmICghbWVzc2Fn ZSkgewotICAgICAgICBMT0dfRVJST1IoIk5QTl9TdGF0dXMgcGFzc2VkIGEgTlVMTCBzdGF0dXMg bWVzc2FnZSIpOwotICAgICAgICByZXR1cm47Ci0gICAgfQotCi0gICAgQ0ZTdHJpbmdSZWYgc3Rh dHVzID0gQ0ZTdHJpbmdDcmVhdGVXaXRoQ1N0cmluZyhOVUxMLCBtZXNzYWdlLCBrQ0ZTdHJpbmdF bmNvZGluZ1VURjgpOworICAgIENGU3RyaW5nUmVmIHN0YXR1cyA9IENGU3RyaW5nQ3JlYXRlV2l0 aENTdHJpbmcoTlVMTCwgbWVzc2FnZSA/IG1lc3NhZ2UgOiAiIiwga0NGU3RyaW5nRW5jb2RpbmdV VEY4KTsKICAgICBpZiAoIXN0YXR1cykgewogICAgICAgICBMT0dfRVJST1IoIk5QTl9TdGF0dXM6 IHRoZSBtZXNzYWdlIHdhcyBub3QgdmFsaWQgVVRGLTgiKTsKICAgICAgICAgcmV0dXJuOwpJbmRl eDogV2ViS2l0L21hYy9QbHVnaW5zL0hvc3RlZC9OZXRzY2FwZVBsdWdpbkluc3RhbmNlUHJveHku bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0L21hYy9QbHVnaW5zL0hvc3RlZC9OZXRzY2FwZVBsdWdp bkluc3RhbmNlUHJveHkubW0JKHJldmlzaW9uIDU1MDIwKQorKysgV2ViS2l0L21hYy9QbHVnaW5z L0hvc3RlZC9OZXRzY2FwZVBsdWdpbkluc3RhbmNlUHJveHkubW0JKHdvcmtpbmcgY29weSkKQEAg LTUwNCw5ICs1MDQsNyBAQCB2b2lkIE5ldHNjYXBlUGx1Z2luSW5zdGFuY2VQcm94eTo6c3RvcFRp CiAKIHZvaWQgTmV0c2NhcGVQbHVnaW5JbnN0YW5jZVByb3h5OjpzdGF0dXMoY29uc3QgY2hhciog bWVzc2FnZSkKIHsKLSAgICBpZiAoIW1lc3NhZ2UpCi0gICAgICAgIHJldHVybjsKLSAgICBSZXRh aW5QdHI8Q0ZTdHJpbmdSZWY+IHN0YXR1cyhBZG9wdENGLCBDRlN0cmluZ0NyZWF0ZVdpdGhDU3Ry aW5nKDAsIG1lc3NhZ2UsIGtDRlN0cmluZ0VuY29kaW5nVVRGOCkpOworICAgIFJldGFpblB0cjxD RlN0cmluZ1JlZj4gc3RhdHVzKEFkb3B0Q0YsIENGU3RyaW5nQ3JlYXRlV2l0aENTdHJpbmcoMCwg bWVzc2FnZSA/IG1lc3NhZ2UgOiAiIiwga0NGU3RyaW5nRW5jb2RpbmdVVEY4KSk7CiAgICAgaWYg KCFzdGF0dXMpCiAgICAgICAgIHJldHVybjsKIApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNTUwMjApCisr KyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAor MjAxMC0wMi0xOSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzUxNjUKKyAgICAgICAgcGx1Z2lucy9zZXQtc3RhdHVz Lmh0bWwgZmFpbHMgb24gV2luZG93cyBib3QKKworICAgICAgICAqIHBsdWdpbnMvc2V0LXN0YXR1 cy1leHBlY3RlZC50eHQ6IFRoZSBiZWhhdmlvciBvZiBXaW5kb3dzIHBvcnQgd2FzIGJldHRlciwg Y2hhbmdlZCBleHBlY3RhdGlvbnMuCisKIDIwMTAtMDItMTkgIEFuZHJhcyBCZWNzaSAgPGFiZWNz aUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0 aWFuc2VuLgpJbmRleDogTGF5b3V0VGVzdHMvcGx1Z2lucy9zZXQtc3RhdHVzLWV4cGVjdGVkLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbHVnaW5zL3NldC1zdGF0dXMtZXhwZWN0ZWQu dHh0CShyZXZpc2lvbiA1NTAyMCkKKysrIExheW91dFRlc3RzL3BsdWdpbnMvc2V0LXN0YXR1cy1l eHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSw0IEBACitVSSBERUxFR0FURSBT VEFUVVMgQ0FMTEJBQ0s6IHNldFN0YXR1c1RleHQ6CiBVSSBERUxFR0FURSBTVEFUVVMgQ0FMTEJB Q0s6IHNldFN0YXR1c1RleHQ6UNCQU1MKIAogUEFTUyBpZiBzdGF0dXMgYmFyIHNheXMgIlBBU1Mi Lgo=