35143 2010-02-19 03:46:36 -0800 check-webkit-style ignores JavaScriptCore/qt/api directory 2010-11-02 13:53:53 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED DUPLICATE 48322 P2 Normal --- 1 jedrzej.nowacki webkit-unassigned levin oldest_to_newest 191859 0 jedrzej.nowacki 2010-02-19 03:46:36 -0800 check-webkit-style ignores *.cpp and *.h files inside the JavaScriptCore/qt/ subdirectory which I believe is wrong. Message posted by WebKit Review Bot: Ignoring "JavaScriptCore/qt/api/qscriptstring.cpp": this file is exempt from the style guide. An use case can be found in bug 34843. 303623 1 levin 2010-11-02 13:47:22 -0700 Is this a bug? In WebKitTools/Scripts/webkitpy/style/checker.py, _SKIPPED_FILES_WITH_WARNING it sounds like this is because these are part of the qt api and it doesn't follow WebKit style. If just a few rules should be omitted, this can be done in the section: _PATH_RULES_SPECIFIER 303629 2 levin 2010-11-02 13:53:53 -0700 I'll resolve this of a dup of a later bug since it has a patch attached. *** This bug has been marked as a duplicate of bug 48322 ***