35134 2010-02-18 16:19:01 -0800 Crash when a plugin calls NPN_SetStatus(0) 2010-02-18 17:22:08 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 1 ap ap oldest_to_newest 191776 0 ap 2010-02-18 16:19:01 -0800 Patch forthcoming. 191777 1 49048 ap 2010-02-18 16:22:19 -0800 Created attachment 49048 proposed fix 191778 2 ap 2010-02-18 16:22:50 -0800 <rdar://problem/7246280> 191779 3 49048 mitz 2010-02-18 16:24:46 -0800 Comment on attachment 49048 proposed fix > + if (!postData) > + return NPERR_INVALID_PARAM; > RetainPtr<CFStringRef> bufString(AdoptCF, CFStringCreateWithCString(kCFAllocatorDefault, postData, kCFStringEncodingWindowsLatin1)); > - if (!bufString) > + if (!postData) Why this change? 191780 4 ap 2010-02-18 16:26:12 -0800 Oops, copy/paste mistake. 191783 5 ap 2010-02-18 16:38:47 -0800 Committed <http://trac.webkit.org/changeset/54993>. 191784 6 49049 ap 2010-02-18 17:16:42 -0800 Created attachment 49049 ...and WebKitTools part 191785 7 49049 mitz 2010-02-18 17:18:41 -0800 Comment on attachment 49049 ...and WebKitTools part > + } else if (name == pluginMethodIdentifiers[ID_SET_STATUS]) { > + return testSetStatus(plugin, args, argCount, result); > } No braces around one-line clause. 191786 8 ap 2010-02-18 17:22:08 -0800 Committed WebKitTools part as <http://trac.webkit.org/changeset/54996>. 49048 2010-02-18 16:22:19 -0800 2010-02-18 16:28:11 -0800 proposed fix NullCString.txt text/plain 3964 ap SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA1NDk5MSkKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDItMTggIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1MTM0Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MjQ2MjgwPiBDcmFzaCB3aGVuIGEgcGx1Z2luIGNhbGxz IE5QTl9TZXRTdGF0dXMoMCkKKworICAgICAgICBUZXN0OiBwbHVnaW5zL3NldC1zdGF0dXMuaHRt bAorCisgICAgICAgICogUGx1Z2lucy9Ib3N0ZWQvTmV0c2NhcGVQbHVnaW5JbnN0YW5jZVByb3h5 Lm1tOgorICAgICAgICAoV2ViS2l0OjpOZXRzY2FwZVBsdWdpbkluc3RhbmNlUHJveHk6OnN0YXR1 cyk6CisgICAgICAgIChXZWJLaXQ6Ok5ldHNjYXBlUGx1Z2luSW5zdGFuY2VQcm94eTo6bG9hZFVS TCk6CisgICAgICAgIEFkZGVkIG51bGwgY2hlY2tzIGZvciBDRlN0cmluZ0NyZWF0ZVdpdGhDU3Ry aW5nIGFyZ3VtZW50cy4KKwogMjAxMC0wMi0xNyAgRG1pdHJ5IFRpdG92ICA8ZGltaWNoQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbiwgRGFyaW4gRmlzaGVy LCBTaW1vbiBIYXVzbWFubi4KSW5kZXg6IFdlYktpdC9tYWMvUGx1Z2lucy9Ib3N0ZWQvTmV0c2Nh cGVQbHVnaW5JbnN0YW5jZVByb3h5Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvUGx1Z2lu cy9Ib3N0ZWQvTmV0c2NhcGVQbHVnaW5JbnN0YW5jZVByb3h5Lm1tCShyZXZpc2lvbiA1NDk3MCkK KysrIFdlYktpdC9tYWMvUGx1Z2lucy9Ib3N0ZWQvTmV0c2NhcGVQbHVnaW5JbnN0YW5jZVByb3h5 Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC01MDQsMTEgKzUwNCwxMiBAQCB2b2lkIE5ldHNjYXBlUGx1 Z2luSW5zdGFuY2VQcm94eTo6c3RvcFRpCiAKIHZvaWQgTmV0c2NhcGVQbHVnaW5JbnN0YW5jZVBy b3h5OjpzdGF0dXMoY29uc3QgY2hhciogbWVzc2FnZSkKIHsKLSAgICBSZXRhaW5QdHI8Q0ZTdHJp bmdSZWY+IHN0YXR1cyhBZG9wdENGLCBDRlN0cmluZ0NyZWF0ZVdpdGhDU3RyaW5nKE5VTEwsIG1l c3NhZ2UsIGtDRlN0cmluZ0VuY29kaW5nVVRGOCkpOwotICAgIAorICAgIGlmICghbWVzc2FnZSkK KyAgICAgICAgcmV0dXJuOworICAgIFJldGFpblB0cjxDRlN0cmluZ1JlZj4gc3RhdHVzKEFkb3B0 Q0YsIENGU3RyaW5nQ3JlYXRlV2l0aENTdHJpbmcoMCwgbWVzc2FnZSwga0NGU3RyaW5nRW5jb2Rp bmdVVEY4KSk7CiAgICAgaWYgKCFzdGF0dXMpCiAgICAgICAgIHJldHVybjsKLSAgICAKKwogICAg IFdlYlZpZXcgKnd2ID0gW21fcGx1Z2luVmlldyB3ZWJWaWV3XTsKICAgICBbW3d2IF9VSURlbGVn YXRlRm9yd2FyZGVyXSB3ZWJWaWV3Ond2IHNldFN0YXR1c1RleHQ6KE5TU3RyaW5nICopc3RhdHVz LmdldCgpXTsKIH0KQEAgLTUyNSw4ICs1MjYsMTAgQEAgTlBFcnJvciBOZXRzY2FwZVBsdWdpbklu c3RhbmNlUHJveHk6OmxvYQogCiAgICAgICAgIGlmIChmbGFncyAmIFBvc3REYXRhSXNGaWxlKSB7 CiAgICAgICAgICAgICAvLyBJZiB3ZSdyZSBwb3N0aW5nIGEgZmlsZSwgYnVmIGlzIGVpdGhlciBh IGZpbGUgVVJMIG9yIGEgcGF0aCB0byB0aGUgZmlsZS4KKyAgICAgICAgICAgIGlmICghcG9zdERh dGEpCisgICAgICAgICAgICAgICAgcmV0dXJuIE5QRVJSX0lOVkFMSURfUEFSQU07CiAgICAgICAg ICAgICBSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+IGJ1ZlN0cmluZyhBZG9wdENGLCBDRlN0cmluZ0Ny ZWF0ZVdpdGhDU3RyaW5nKGtDRkFsbG9jYXRvckRlZmF1bHQsIHBvc3REYXRhLCBrQ0ZTdHJpbmdF bmNvZGluZ1dpbmRvd3NMYXRpbjEpKTsKLSAgICAgICAgICAgIGlmICghYnVmU3RyaW5nKQorICAg ICAgICAgICAgaWYgKCFwb3N0RGF0YSkKICAgICAgICAgICAgICAgICByZXR1cm4gTlBFUlJfSU5W QUxJRF9QQVJBTTsKICAgICAgICAgICAgIAogICAgICAgICAgICAgTlNVUkwgKmZpbGVVUkwgPSBb TlNVUkwgX3dlYl9VUkxXaXRoRGF0YUFzU3RyaW5nOihOU1N0cmluZyAqKWJ1ZlN0cmluZy5nZXQo KV07CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA1NDk5MSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEwLTAyLTE4ICBBbGV4ZXkgUHJvc2t1 cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z NTEzNAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzI0NjI4MD4gQ3Jhc2ggd2hlbiBhIHBsdWdp biBjYWxscyBOUE5fU2V0U3RhdHVzKDApCisKKyAgICAgICAgKiBwbHVnaW5zL3NldC1zdGF0dXMt ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBwbHVnaW5zL3NldC1zdGF0dXMuaHRtbDog QWRkZWQuCisgICAgICAgIFdoaWxlIGF0IGl0LCBhbHNvIHRlc3QgdGhhdCB3ZSBwcm9jZXNzIFVU Ri04LgorCiAyMDEwLTAyLTE4ICBEaXJrIFNjaHVsemUgIDxrcml0QHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgTmlrb2xhcyBaaW1tZXJtYW5uLgpJbmRleDogTGF5b3V0VGVzdHMv cGx1Z2lucy9zZXQtc3RhdHVzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9wbHVnaW5zL3NldC1zdGF0dXMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0 VGVzdHMvcGx1Z2lucy9zZXQtc3RhdHVzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAs MCArMSwzIEBACitVSSBERUxFR0FURSBTVEFUVVMgQ0FMTEJBQ0s6IHNldFN0YXR1c1RleHQ6UNCQ U1MKKworUEFTUyBpZiBzdGF0dXMgYmFyIHNheXMgIlBBU1MiLgpJbmRleDogTGF5b3V0VGVzdHMv cGx1Z2lucy9zZXQtc3RhdHVzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGx1Z2lu cy9zZXQtc3RhdHVzLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbHVnaW5zL3Nl dC1zdGF0dXMuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxNSBAQAorPGh0bWw+Cis8bWV0 YSBjaGFyc2V0PSJ1dGYtOCI+Cis8Ym9keT4KKzxlbWJlZCBuYW1lPSJwbGciIHR5cGU9ImFwcGxp Y2F0aW9uL3gtd2Via2l0LXRlc3QtbmV0c2NhcGUiPjwvZW1iZWQ+Cis8cD5QQVNTIGlmIHN0YXR1 cyBiYXIgc2F5cyAiUEFTUyIuPC9wPgorPHNjcmlwdD4KKyAgICBpZiAod2luZG93LmxheW91dFRl c3RDb250cm9sbGVyKSB7CisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBTdGF0dXND YWxsYmFja3MoKTsKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwor ICAgIH0KKworICAgIHBsZy5zZXRTdGF0dXMoKTsgLy8gVHJ5IHNlbmRpbmcgYSBudWxsIHN0cmlu Zywgd2hpY2ggdXNlZCB0byBjYXVzZSBhIGNyYXNoLgorICAgIHBsZy5zZXRTdGF0dXMoIlDQkFNT Iik7CisKKzwvc2NyaXB0PjwvYm9keT48L2h0bWw+Cg== 49049 2010-02-18 17:16:42 -0800 2010-02-18 17:18:41 -0800 ...and WebKitTools part NullCStringTest.txt text/plain 2430 ap SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU0OTk1KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDItMTggIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1MTM0 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MjQ2MjgwPiBDcmFzaCB3aGVuIGEgcGx1Z2luIGNh bGxzIE5QTl9TZXRTdGF0dXMoMCkKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL1Rlc3ROZXRz Y2FwZVBsdWdJbi5zdWJwcm9qL1BsdWdpbk9iamVjdC5jcHA6CisgICAgICAgICh0ZXN0U2V0U3Rh dHVzKToKKyAgICAgICAgKHBsdWdpbkludm9rZSk6CisgICAgICAgIEFkZGVkIGEgc2V0U3RhdHVz KCkgbWV0aG9kLgorCiAyMDEwLTAyLTE4ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogV2ViS2l0VG9vbHMv RHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luLnN1YnByb2ovUGx1Z2luT2JqZWN0LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQ bHVnSW4uc3VicHJvai9QbHVnaW5PYmplY3QuY3BwCShyZXZpc2lvbiA1NDk5NSkKKysrIFdlYktp dFRvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi5zdWJwcm9qL1BsdWdpbk9i amVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE4MCw2ICsxODAsNyBAQCBlbnVtIHsKICAgICBJ RF9HRVRfUkVNRU1CRVJFRF9PQkpFQ1QsCiAgICAgSURfR0VUX0FORF9GT1JHRVRfUkVNRU1CRVJF RF9PQkpFQ1QsCiAgICAgSURfUkVGX0NPVU5ULAorICAgIElEX1NFVF9TVEFUVVMsCiAgICAgTlVN X01FVEhPRF9JREVOVElGSUVSUwogfTsKIApAQCAtMjEzLDcgKzIxNCw4IEBAIHN0YXRpYyBjb25z dCBOUFVURjggKnBsdWdpbk1ldGhvZElkZW50aWYKICAgICAicmVtZW1iZXIiLAogICAgICJnZXRS ZW1lbWJlcmVkT2JqZWN0IiwKICAgICAiZ2V0QW5kRm9yZ2V0UmVtZW1iZXJlZE9iamVjdCIsCi0g ICAgInJlZkNvdW50IgorICAgICJyZWZDb3VudCIsCisgICAgInNldFN0YXR1cyIKIH07CiAKIHN0 YXRpYyBOUFVURjgqIGNyZWF0ZUNTdHJpbmdGcm9tTlBWYXJpYW50KGNvbnN0IE5QVmFyaWFudCog dmFyaWFudCkKQEAgLTc1NSw2ICs3NTcsMjAgQEAgYm9vbCB0ZXN0V2luZG93T3BlbihOUFAgbnBw KQogICAgIHJldHVybiBmYWxzZTsKIH0KIAorc3RhdGljIGJvb2wgdGVzdFNldFN0YXR1cyhQbHVn aW5PYmplY3QqIG9iaiwgY29uc3QgTlBWYXJpYW50KiBhcmdzLCB1aW50MzJfdCBhcmdDb3VudCwg TlBWYXJpYW50KiByZXN1bHQpCit7CisgICAgY2hhciogbWVzc2FnZSA9IDA7CisgICAgaWYgKGFy Z0NvdW50ICYmIE5QVkFSSUFOVF9JU19TVFJJTkcoYXJnc1swXSkpIHsKKyAgICAgICAgTlBTdHJp bmcgc3RhdHVzU3RyaW5nID0gTlBWQVJJQU5UX1RPX1NUUklORyhhcmdzWzBdKTsKKyAgICAgICAg bWVzc2FnZSA9IHRvQ1N0cmluZyhzdGF0dXNTdHJpbmcpOworICAgIH0KKyAgICAKKyAgICBicm93 c2VyLT5zdGF0dXMob2JqLT5ucHAsIG1lc3NhZ2UpOworCisgICAgZnJlZShtZXNzYWdlKTsKKyAg ICByZXR1cm4gdHJ1ZTsKK30KKwogc3RhdGljIE5QT2JqZWN0KiByZW1lbWJlcmVkT2JqZWN0Owog CiBzdGF0aWMgYm9vbCBwbHVnaW5JbnZva2UoTlBPYmplY3QqIGhlYWRlciwgTlBJZGVudGlmaWVy IG5hbWUsIGNvbnN0IE5QVmFyaWFudCogYXJncywgdWludDMyX3QgYXJnQ291bnQsIE5QVmFyaWFu dCogcmVzdWx0KQpAQCAtODM4LDYgKzg1NCw4IEBAIHN0YXRpYyBib29sIHBsdWdpbkludm9rZShO UE9iamVjdCogaGVhZGUKICAgICAgICAgdWludDMyX3QgcmVmQ291bnQgPSBOUFZBUklBTlRfVE9f T0JKRUNUKGFyZ3NbMF0pLT5yZWZlcmVuY2VDb3VudDsKICAgICAgICAgSU5UMzJfVE9fTlBWQVJJ QU5UKHJlZkNvdW50LCAqcmVzdWx0KTsKICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgfSBlbHNl IGlmIChuYW1lID09IHBsdWdpbk1ldGhvZElkZW50aWZpZXJzW0lEX1NFVF9TVEFUVVNdKSB7Cisg ICAgICAgIHJldHVybiB0ZXN0U2V0U3RhdHVzKHBsdWdpbiwgYXJncywgYXJnQ291bnQsIHJlc3Vs dCk7CiAgICAgfQogICAgIAogICAgIHJldHVybiBmYWxzZTsK