35133 2010-02-18 15:25:53 -0800 check-webkit-style should check for // namespace WebCore at end of namespace blocks 2010-11-02 14:47:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED INVALID P2 Normal --- 33214 1 eric webkit-unassigned ap cjerdonek darin hamaji levin zimmermann oldest_to_newest 191760 0 eric 2010-02-18 15:25:53 -0800 check-webkit-style should check for // namespace WebCore at end of namespace blocks As well as // #define FOO at end of #if FOO blocks. Per numerous examples in the guidelines: https://webkit.org/coding/coding-style.html As well as discussion here: https://lists.webkit.org/pipermail/webkit-dev/2009-September/009807.html 191765 1 zimmermann 2010-02-18 15:28:08 -0800 I think the rule needs to be removed. check-webkit-style should check that this is not present. Please see the webkit-dev archive: http://article.gmane.org/gmane.os.opendarwin.webkit.devel/10563/match=visual+noise Has there been any outcome? CC'ing the people from the old discussion 191767 2 eric 2010-02-18 15:31:04 -0800 Either way, we need to make our guidelines and our tools agree. Right now there is only confusion. 191768 3 zimmermann 2010-02-18 15:35:16 -0800 (In reply to comment #2) > Either way, we need to make our guidelines and our tools agree. Right now > there is only confusion. Agreed. Consistency is all. 191788 4 levin 2010-02-18 17:27:48 -0800 (In reply to comment #3) > (In reply to comment #2) > > Either way, we need to make our guidelines and our tools agree. Right now > > there is only confusion. > > Agreed. Consistency is all. Actually, the check for the comment at the end of ifdef blocks was added and then removed per discussion: http://old.nabble.com/-endif----Foo_h-td27021241.html (I really need to get to updating the style guide as a result of my email but this part of it, regarding ifdef comments, will not go in per the emails above.) 303616 5 levin 2010-11-02 13:36:35 -0700 This is not a suggested style but some may find it helpful in some circumstances. 303680 6 eric 2010-11-02 14:43:26 -0700 Sigh. I'm sad that this is left ambiguous. 303690 7 levin 2010-11-02 14:47:33 -0700 (In reply to comment #6) > Sigh. I'm sad that this is left ambiguous. fwiw, it sounds like in general it is recommended not to put it in and that seems to be the general consensus. (I'm not sure that the consensus was strong enough to put into a check-webkit-style rule.)