35104 2010-02-18 09:26:52 -0800 Web Inspector: REGRESSION (Safari 4.0.5-TOT): Copying from the Content tab in Resources includes line numbers 2010-03-30 10:43:19 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED InRadar, Regression P1 Normal --- 1 rik pfeldman bweinstein joepeck keishi mitz pfeldman pmuellr rik squidinc timothy oldest_to_newest 191632 0 rik 2010-02-18 09:26:52 -0800 If you copy the content of a resource in the Resources panel, you'll get the line numbers with it and that's not useful. 191639 1 timothy 2010-02-18 09:37:40 -0800 Not only does it include the numbers, but any non-visible 50 line chunk shows an empty 49 rows then all the content is on the 50th row. 191640 2 timothy 2010-02-18 09:38:48 -0800 We can use css counters to generate the content. Generated content is not copied. 205824 3 mitz 2010-03-29 20:36:46 -0700 <rdar://problem/7807274> 205859 4 pfeldman 2010-03-29 22:57:22 -0700 CSS did not work due to bucketing. I'll just introduce a separate table for line numbers and use absolute positioning for both: line and content tables. We are only using text viewer in absolute positioning since there are headers / content tabs in resources panel anyways. 206053 5 52050 pfeldman 2010-03-30 10:11:27 -0700 Created attachment 52050 [PATCH] Proposed change. It turned out to be more problematic than I thought: - I can't make a separate column for line numbers since row height might be defined by the messages in the right column - I can't make text transparent to the clipboard So I am re-using model's ability to copy its content... 206070 6 pfeldman 2010-03-30 10:43:19 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/TextViewer.js Committed r56799 52050 2010-03-30 10:11:27 -0700 2010-03-30 10:28:58 -0700 [PATCH] Proposed change. copy_no_lines text/plain 1782 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2E5MGNjZS4uOTg4YzlkNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMy0zMCAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBDb3B5aW5nIGZyb20gdGhlIENvbnRl bnQgdGFiIGluIFJlc291cmNlcyBpbmNsdWRlcyBsaW5lIG51bWJlcnMuCisKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1MTA0CisKKyAgICAgICAgKiBp bnNwZWN0b3IvZnJvbnQtZW5kL1RleHRWaWV3ZXIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu VGV4dFZpZXdlcik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGV4dFZpZXdlci5wcm90b3R5cGUu X2JlZm9yZUNvcHkpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRWaWV3ZXIucHJvdG90eXBl Ll9jb3B5KToKKwogMjAxMC0wMy0zMCAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCmRpZmYgLS1naXQg YS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dFZpZXdlci5qcyBiL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9UZXh0Vmlld2VyLmpzCmluZGV4IDUwNzJjMjQuLjAxNzViMTQgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0Vmlld2VyLmpzCisrKyBi L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0Vmlld2VyLmpzCkBAIC00MSw2ICs0MSw4 IEBAIFdlYkluc3BlY3Rvci5UZXh0Vmlld2VyID0gZnVuY3Rpb24odGV4dE1vZGVsLCBwbGF0Zm9y bSwgdXJsKQogCiAgICAgdGhpcy5lbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoInNjcm9sbCIsIHRo aXMuX3Njcm9sbC5iaW5kKHRoaXMpLCBmYWxzZSk7CiAgICAgdGhpcy5lbGVtZW50LmFkZEV2ZW50 TGlzdGVuZXIoImtleWRvd24iLCB0aGlzLl9oYW5kbGVLZXlEb3duLmJpbmQodGhpcyksIGZhbHNl KTsKKyAgICB0aGlzLmVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiYmVmb3JlY29weSIsIHRoaXMu X2JlZm9yZUNvcHkuYmluZCh0aGlzKSwgZmFsc2UpOworICAgIHRoaXMuZWxlbWVudC5hZGRFdmVu dExpc3RlbmVyKCJjb3B5IiwgdGhpcy5fY29weS5iaW5kKHRoaXMpLCBmYWxzZSk7CiAKICAgICB0 aGlzLl91cmwgPSB1cmw7CiAKQEAgLTIzNiw2ICsyMzgsMTkgQEAgV2ViSW5zcGVjdG9yLlRleHRW aWV3ZXIucHJvdG90eXBlID0gewogICAgICAgICB9CiAgICAgfSwKIAorICAgIF9iZWZvcmVDb3B5 OiBmdW5jdGlvbihlKQorICAgIHsKKyAgICAgICAgZS5wcmV2ZW50RGVmYXVsdCgpOworICAgIH0s CisKKyAgICBfY29weTogZnVuY3Rpb24oZSkKKyAgICB7CisgICAgICAgIHZhciByYW5nZSA9IHRo aXMuX2dldFNlbGVjdGlvbigpOworICAgICAgICB2YXIgdGV4dCA9IHRoaXMuX3RleHRNb2RlbC5j b3B5UmFuZ2UocmFuZ2UpOworICAgICAgICBJbnNwZWN0b3JGcm9udGVuZEhvc3QuY29weVRleHQo dGV4dCk7CisgICAgICAgIGUucHJldmVudERlZmF1bHQoKTsKKyAgICB9LAorCiAgICAgYmVnaW5V cGRhdGVzOiBmdW5jdGlvbihlbmFibGVkKQogICAgIHsKICAgICAgICAgdGhpcy5fcGFpbnRDb2Fs ZXNjaW5nTGV2ZWwrKzsK