35100 2010-02-18 07:31:11 -0800 [Qt] ENABLE_3D_RENDERING should be optional 2010-02-20 12:30:36 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 1 noam webkit-unassigned laszlo.gombos oldest_to_newest 191593 0 noam 2010-02-18 07:31:11 -0800 for example, building webkit with --minimal should disable them. 191622 1 49020 noam 2010-02-18 08:51:34 -0800 Created attachment 49020 ENABLE_3D_RENDERING moved to be a normal feature This seems to rectify the problem for ENABLE_3D_RENDERING (moved to be a normal feature, rather than a forced define). However, I'm not sure how to do that for WTF_ENABLE_ACCELERATED_COMPOSITING, which doesn't appear as a "feature". Help would be appreciated. 192014 2 laszlo.gombos 2010-02-19 12:19:45 -0800 The patch looks good to me, if we only try to restrict it to ENABLE_3D_RENDERING. Noam, can you change the bug title and ChangeLog accordingly ? I think we should open another bug for ACCELERATED_COMPOSITING as it will likely involve changes to other ports as well, not just for QtWebKit. In general USE(xx) flags are not meant to be turn on/off optionally at build time within a given WebKit port. 192206 3 49020 laszlo.gombos 2010-02-20 12:10:23 -0800 Comment on attachment 49020 ENABLE_3D_RENDERING moved to be a normal feature LGTM, r+. I will update the title in the ChangeLogs as well during a manual commit. 192208 4 49020 laszlo.gombos 2010-02-20 12:30:24 -0800 Comment on attachment 49020 ENABLE_3D_RENDERING moved to be a normal feature Committed as http://trac.webkit.org/changeset/55056. 49020 2010-02-18 08:51:34 -0800 2010-02-20 12:30:24 -0800 ENABLE_3D_RENDERING moved to be a normal feature patch-35100-1.diff text/plain 2225 noam SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDU0OTYy KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDIt MTggIE5vYW0gUm9zZW50aGFsICA8bm9hbS5yb3NlbnRoYWxAbm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRU5BQkxFXzNEX1JF TkRFUklORyBhbmQgQUNDRUxFUkFURURfQ09NUE9TSVRJTkcgc2hvdWxkIGJlIG9wdGlvbmFsCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTEwMAorCisg ICAgICAgICogV2ViS2l0LnByaTogRU5BQkxFXzNEX1JFTkRFUklORyBtb3ZlZCB0byBhIHByb3Bl ciBmZWF0dXJlIHRlc3QKKwogMjAxMC0wMi0xOCAgVG9yIEFybmUgVmVzdGLDuCAgPHRvci5hcm5l LnZlc3Rib0Bub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCklu ZGV4OiBXZWJLaXQucHJpCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC5wcmkJKHJldmlzaW9uIDU0OTYy KQorKysgV2ViS2l0LnByaQkod29ya2luZyBjb3B5KQpAQCAtNTAsNyArNTAsNiBAQCBidWlsZGlu Zy1saWJzIHsKICAgICBERVBFTkRQQVRIICs9ICQkUFdEL1dlYktpdC9xdC9BcGkKIH0KIGdyZWF0 ZXJUaGFuKFFUX01JTk9SX1ZFUlNJT04sIDUpOkRFRklORVMgKz0gV1RGX1VTRV9BQ0NFTEVSQVRF RF9DT01QT1NJVElORwotZ3JlYXRlclRoYW4oUVRfTUlOT1JfVkVSU0lPTiwgNSk6REVGSU5FUyAr PSBFTkFCTEVfM0RfUkVOREVSSU5HPTEKIAogIW1hYzohdW5peHxzeW1iaWFuIHsKICAgICBERUZJ TkVTICs9IFVTRV9TWVNURU1fTUFMTE9DCkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNTQ5NjIpCisrKyBXZWJDb3JlL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEwLTAyLTE4ICBOb2Ft IFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEVOQUJMRV8zRF9SRU5ERVJJTkcg YW5kIEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HIHNob3VsZCBiZSBvcHRpb25hbAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzUxMDAKKworICAgICAgICBO byBuZXcgdGVzdHM6IHRoaXMgaXMgYSBidWlsZCBmaXguCisKKyAgICAgICAgKiBXZWJDb3JlLnBy aTogRU5BQkxFXzNEX1JFTkRFUklORyBpcyBub3cgYSBwcm9wZXIgZmVhdHVyZSB0ZXN0CisKIDIw MTAtMDItMTggIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgpJbmRleDogV2ViQ29yZS9XZWJDb3JlLnBy aQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL1dlYkNvcmUucHJpCShyZXZpc2lvbiA1NDk2MikKKysr IFdlYkNvcmUvV2ViQ29yZS5wcmkJKHdvcmtpbmcgY29weSkKQEAgLTU0LDYgKzU0LDEwIEBAIGNv bnRhaW5zKERFRklORVMsIEVOQUJMRV9TSU5HTEVfVEhSRUFERUQKICFjb250YWlucyhERUZJTkVT LCBFTkFCTEVfVklERU89Lik6IERFRklORVMgKz0gRU5BQkxFX1ZJREVPPTEKICFjb250YWlucyhE RUZJTkVTLCBFTkFCTEVfUlVCWT0uKTogREVGSU5FUyArPSBFTkFCTEVfUlVCWT0xCiAKK2dyZWF0 ZXJUaGFuKFFUX01JTk9SX1ZFUlNJT04sIDUpIHsKKyAgICAhY29udGFpbnMoREVGSU5FUywgRU5B QkxFXzNEX1JFTkRFUklORz0uKTogREVGSU5FUyArPSBFTkFCTEVfM0RfUkVOREVSSU5HPTEKK30K KwogIyBTVkcgc3VwcG9ydAogIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV9TVkc9MCkgewogICAg ICFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfU1ZHPS4pOiBERUZJTkVTICs9IEVOQUJMRV9TVkc9 MQo=