35098 2010-02-18 07:06:30 -0800 Debugging WebKit on Windows should mention WebKit.sln as an alternative to running debug-safari 2010-02-23 14:09:45 -0800 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) PC Windows 7 RESOLVED FIXED http://webkit.org/building/debug.html P2 Enhancement --- 1 jberlin jberlin aroben eric jberlin sfalken oldest_to_newest 191582 0 jberlin 2010-02-18 07:06:30 -0800 I find it much easier to debug and work on WebKit for Windows inside Visual Studio by opening the WebKit.sln file inside of Visual Studio instead of running debug-safari, as is currently suggested on the Debugging WebKit page, and have been suggesting that approach when I help others get setup on Windows. We should add this suggestion to the Debugging WebKit page. 192211 1 49133 jberlin 2010-02-20 13:40:23 -0800 Created attachment 49133 Add information to the webkit.org debugging page about using WebKit.sln with Visual Studio 192616 2 49133 eric 2010-02-22 14:08:15 -0800 Comment on attachment 49133 Add information to the webkit.org debugging page about using WebKit.sln with Visual Studio OK. Looks about right. rs=me. 192624 3 49133 aroben 2010-02-22 14:17:58 -0800 Comment on attachment 49133 Add information to the webkit.org debugging page about using WebKit.sln with Visual Studio I believe these steps will only work if you've set the WEBKITOUTPUTDIR and WEBKITLIBRARIESDIR environment variables, as mentioned at <http://trac.webkit.org/wiki/BuildingOnWindows#BuildingfromwithinVisualStudio>. Seems like we need to mention that. 192662 4 jberlin 2010-02-22 15:12:26 -0800 (In reply to comment #3) > (From update of attachment 49133 [details]) > I believe these steps will only work if you've set the WEBKITOUTPUTDIR and > WEBKITLIBRARIESDIR environment variables, as mentioned at > <http://trac.webkit.org/wiki/BuildingOnWindows#BuildingfromwithinVisualStudio>. > Seems like we need to mention that. Even though they are now set automatically when you run update-webkit? (http://trac.webkit.org/changeset/519328) 192667 5 aroben 2010-02-22 15:19:31 -0800 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 49133 [details] [details]) > > I believe these steps will only work if you've set the WEBKITOUTPUTDIR and > > WEBKITLIBRARIESDIR environment variables, as mentioned at > > <http://trac.webkit.org/wiki/BuildingOnWindows#BuildingfromwithinVisualStudio>. > > Seems like we need to mention that. > > Even though they are now set automatically when you run update-webkit? > (http://trac.webkit.org/changeset/519328) I had forgotten about that! I guess I'm stuck in the past. (I think you meant <http://trac.webkit.org/changeset/51932>.) Someone should update the wiki page. 193113 6 jberlin 2010-02-23 13:51:21 -0800 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > (From update of attachment 49133 [details] [details] [details]) > > > I believe these steps will only work if you've set the WEBKITOUTPUTDIR and > > > WEBKITLIBRARIESDIR environment variables, as mentioned at > > > <http://trac.webkit.org/wiki/BuildingOnWindows#BuildingfromwithinVisualStudio>. > > > Seems like we need to mention that. > > > > Even though they are now set automatically when you run update-webkit? > > (http://trac.webkit.org/changeset/519328) > > I had forgotten about that! I guess I'm stuck in the past. (I think you meant > <http://trac.webkit.org/changeset/51932>.) > > Someone should update the wiki page. Which wiki page? The BuildingOnWindows page already has this comment: "Building from within Visual Studio WebKit can be built from within Visual Studio by setting two environment variables: WEBKITOUTPUTDIR - An absolute Windows-style path pointing to the directory where you want the build products to go. WEBKITLIBRARIESDIR - An absolute Windows-style path pointing to the WebKitLibraries/win folder in your WebKit checkout. These environment variables should be set for you the first time you run update-webkit." 193116 7 aroben 2010-02-23 13:58:39 -0800 (In reply to comment #6) > (In reply to comment #5) > > Someone should update the wiki page. > > Which wiki page? The BuildingOnWindows page already has this comment: > > "Building from within Visual Studio > > WebKit can be built from within Visual Studio by setting two environment > variables: > > WEBKITOUTPUTDIR - An absolute Windows-style path pointing to the directory > where you want the build products to go. > WEBKITLIBRARIESDIR - An absolute Windows-style path pointing to the > WebKitLibraries/win folder in your WebKit checkout. > > These environment variables should be set for you the first time you run > update-webkit." Yeah, I updated it after writing comment 5. Sorry for not saying so. 193121 8 jberlin 2010-02-23 14:09:45 -0800 Committed in r55170 (http://trac.webkit.org/changeset/55170) 49133 2010-02-20 13:40:23 -0800 2010-02-22 15:19:41 -0800 Add information to the webkit.org debugging page about using WebKit.sln with Visual Studio addWebKitSlnInfoToDebuggingPage.patch text/plain 2368 jberlin SW5kZXg6IFdlYktpdFNpdGUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFNpdGUvQ2hh bmdlTG9nCShyZXZpc2lvbiA1NTA1NykKKysrIFdlYktpdFNpdGUvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDItMjAgIEplc3NpZSBCZXJsaW4gIDxqYmVy bGluQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRGVidWdnaW5nIFdlYktpdCBvbiBXaW5kb3dzIHNob3VsZCBtZW50aW9uIFdlYktp dC5zbG4gYXMgYW4gYWx0ZXJuYXRpdmUgdG8gcnVubmluZyBkZWJ1Zy1zYWZhcmkuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTA5OAorCisgICAgICAg ICogYnVpbGRpbmcvZGVidWcuaHRtbDoKKyAgICAgICAgQWRkIGluc3RydWN0aW9ucyBvbiBob3cg dG8gYnVpbGQgYW5kIHJ1biBXZWJLaXQgZnJvbSB3aXRoaW4gVmlzdWFsIFN0dWRpby4KKwogMjAx MC0wMi0xNyAgTWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUuY29tPgogCiAgICAgICAgIE5v dCByZXZpZXdlZCAtIGRlbW8uCkluZGV4OiBXZWJLaXRTaXRlL2J1aWxkaW5nL2RlYnVnLmh0bWwK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0U2l0ZS9idWlsZGluZy9kZWJ1Zy5odG1sCShyZXZpc2lvbiA1 NTA1NSkKKysrIFdlYktpdFNpdGUvYnVpbGRpbmcvZGVidWcuaHRtbAkod29ya2luZyBjb3B5KQpA QCAtNDgsNiArNDgsMTUgQEAKIDxwPllvdSBzaG91bGQgY29uc2lkZXIgaW5jbHVkaW5nIHRoZSBj b21tYW5kLWxpbmUgc3dpdGNoICc8c3BhbiBjbGFzcz0iY29kZSI+L2NvbnNvbGU8L3NwYW4+Jy4g IFRoaXMgY2F1c2VzIFNhZmFyaSB0byBydW4gd2l0aCBhbiBvcGVuIERPUyBzaGVsbCBpbiB3aGlj aCBvdXRwdXQgbWVzc2FnZXMsIGNyZWF0ZWQgd2l0aCB0aGUgPHNwYW4gY2xhc3M9ImNvZGUiPkxP Rzwvc3Bhbj4gbWFjcm8sIGFwcGVhci48L3A+CiA8aW1nIHNyYz0iY29uc29sZV92czIwMDUuanBn Ij48L2xpPgogPC91bD48L3A+Cis8cD5BbHRlcm5hdGl2ZWx5LCB5b3UgY2FuIGJ1aWxkLCBydW4s IGFuZCBkZWJ1ZyBXZWJLaXQgZnJvbSBpbnNpZGUgVmlzdWFsIFN0dWRpbyBieSBvcGVuaW5nIHRo ZSBzb2x1dGlvbiBmaWxlOgorPG9sPgorPGxpPkxhdW5jaCBWaXN1YWwgU3R1ZGlvLjwvbGk+Cis8 bGk+U2VsZWN0IHRoZSAnRmlsZScgbWVudSwgdGhlbiAnT3BlbicgPiAnUHJvamVjdCAvIFNvbHV0 aW9uLi4uJy4gU2VsZWN0IHRoZSBXZWJLaXQvd2luL1dlYktpdC52Y3Byb2ovV2ViS2l0LnNsbiBm aWxlIGFuZCBjbGljayAnT3BlbicuPC9saT4KKzxsaT5SaWdodC1jbGljayBvbiAnU29sdXRpb24g IldlYktpdCInIGluIHRoZSBTb2x1dGlvbiBFeHBsb3JlciBhbmQgc2VsZWN0ICdQcm9wZXJ0aWVz Jy4gVW5kZXIgJ0NvbW1vbiBQcm9wZXJ0aWVzJyA+ICdTdGFydHVwIFByb2plY3QnLCAnU2luZ2xl IFN0YXJ0dXAgUHJvamVjdCcgc2hvdWxkIGJlIHNldCB0byAnV2ViS2l0Jy48L2xpPgorPGxpPlJp Z2h0LWNsaWNrIG9uIHRoZSAnV2ViS2l0JyBwcm9qZWN0IGluIHRoZSBTb2x1dGlvbiBFeHBsb3Jl ciBhbmQgc2VsZWN0ICdQcm9wZXJ0aWVzJy4gVW5kZXIgJ0NvbmZpZ3VyYXRpb24gUHJvcGVydGll cycgPiAnRGVidWdnaW5nJywgbWFrZSBzdXJlICdDb21tYW5kJyBhbmQgJ1dvcmtpbmcgRGlyZWN0 b3J5JyBhcmUgc2V0IGFzIHNob3duIGFib3ZlLjwvbGk+Cis8bGk+VG8gYnVpbGQsIHNlbGVjdCB0 aGUgJ0J1aWxkJyBtZW51LCB0aGVuICdCdWlsZCBTb2x1dGlvbicuIFRvIHJ1biwgc2VsZWN0IHRo ZSAnRGVidWcnIG1lbnUsIHRoZW4gJ1N0YXJ0IERlYnVnZ2luZycuPC9saT4KKzwvb2w+Cis8L3A+ CiA8cD5JdCBpcyBhbHNvIHJlY29tbWVuZGVkIHRoYXQgeW91IGZvbGxvdyA8YSBocmVmPSJodHRw Oi8vZGV2ZWxvcGVyLmFwcGxlLmNvbS9pbnRlcm5ldC9zYWZhcmkvd2luZG93c19zeW1ib2xzX2Fn cmVlLmh0bWwiPnRoZSBpbnN0cnVjdGlvbnMgdG8gY29uZmlndXJlIFZpc3VhbCBTdHVkaW8gdG8g dXNlIEFwcGxlJ3MgU2FmYXJpIGZvciBXaW5kb3dzIHN5bWJvbCBzZXJ2ZXI8L2E+LiBUaGlzIHdp bGwgZ2l2ZSBWaXN1YWwgU3R1ZGlvIHRoZSBpbmZvcm1hdGlvbiBpdCBuZWVkcyB0byBwcm92aWRl IHJlbGlhYmxlIGJhY2t0cmFjZXMgd2hlbiBwYXVzaW5nIGluIHRoZSBkZWJ1Z2dlciBvciB3aGVu IGEgY3Jhc2ggb2NjdXJzLjwvcD4KIDwvZGl2PgogCg==