35095 2010-02-18 06:59:49 -0800 [V8] Default values of V8 runtime enabler flags should match behavior of JSC 2010-02-23 03:44:36 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 steveblock webkit-unassigned android-webkit-unforking bulach commit-queue joth steveblock oldest_to_newest 191579 0 steveblock 2010-02-18 06:59:49 -0800 The V8 bindings use runtime enabler flags to enable certain optional features. Currently, the default values of these flags vary from feature to feature. The default values should be chosen to match the behavior of JSC, which does not use runtime enabler flags. This will give consistent behavior on platforms such as Android which use both V8 and JSC, without the need to explicitly set the values of the flags. In particular, appcache, geolocation and database should default to 'on'. Such a change should make no difference to Chromium, as Chromium always explicitly sets a value for these flags. 191586 1 49011 steveblock 2010-02-18 07:16:59 -0800 Created attachment 49011 Patch 191936 2 49011 commit-queue 2010-02-19 09:13:58 -0800 Comment on attachment 49011 Patch Clearing flags on attachment: 49011 Committed r55020: <http://trac.webkit.org/changeset/55020> 191937 3 commit-queue 2010-02-19 09:14:02 -0800 All reviewed patches have been landed. Closing bug. 192494 4 steveblock 2010-02-22 09:51:32 -0800 This change caused crashes in the following layout tests on Chromium ... - window-properties.html - navigator-detached-no-crash.html It was rolled back in http://trac.webkit.org/changeset/55022 192869 5 steveblock 2010-02-23 03:44:36 -0800 The crashes in the Chromium layout tests were due to a bug in the Chromium test shell. This has now been fixed with http://codereview.chromium.org/652052 Re-landed original patch as http://trac.webkit.org/changeset/55140 Closing bug as resolved fixed. 49011 2010-02-18 07:16:59 -0800 2010-02-19 09:13:58 -0800 Patch bug-35095-20100218151657.patch text/plain 2005 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDk1OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDItMTggIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFNldHMgZGVmYXVsdCB2YWx1ZXMgb2YgVjggcnVudGltZSBlbmFibGVyIGZsYWdzIHRvIG1hdGNo IGJlaGF2aW9yIHdpdGggSlNDCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zNTA5NQorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbW9kaWZpZXMgYSBDaHJv bWl1bSBmZWF0dXJlIG9ubHkuCisKKyAgICAgICAgKiBiaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVF bmFibGVkRmVhdHVyZXMuY3BwOiBNb2RpZmllZC4gU2V0cyBhcHBjYWNoZSBhbmQgZ2VvbG9jYXRp b24gZmxhZyBkZWZhdWx0cyB0byAnb24nCisgICAgICAgICogc3RvcmFnZS9EYXRhYmFzZS5jcHA6 IE1vZGlmaWVkLiBTZXRzIGRhdGFiYXNlIGZsYWcgZGVmYXVsdCB0byAnb24nLgorCiAyMDEwLTAy LTE4ICBCZW4gTXVyZG9jaCAgPGJlbm1AZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBKZXJlbXkgT3Jsb3cuCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvUnVudGltZUVu YWJsZWRGZWF0dXJlcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmlj L1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuY3BwCShyZXZpc2lvbiA1NDk1OSkKKysrIFdlYkNvcmUv YmluZGluZ3MvZ2VuZXJpYy9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNDEsOCArNDEsOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBib29sIFJ1bnRpbWVFbmFi bGVkRmVhdHVyZXM6OmlzTG9jYWxTdG9yYWdlRW5hYmxlZCA9IHRydWU7CiBib29sIFJ1bnRpbWVF bmFibGVkRmVhdHVyZXM6OmlzU2Vzc2lvblN0b3JhZ2VFbmFibGVkID0gdHJ1ZTsKIGJvb2wgUnVu dGltZUVuYWJsZWRGZWF0dXJlczo6aXNXZWJraXROb3RpZmljYXRpb25zRW5hYmxlZCA9IGZhbHNl OwotYm9vbCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjppc0FwcGxpY2F0aW9uQ2FjaGVFbmFibGVk ID0gZmFsc2U7Ci1ib29sIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmlzR2VvbG9jYXRpb25FbmFi bGVkID0gZmFsc2U7Citib29sIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmlzQXBwbGljYXRpb25D YWNoZUVuYWJsZWQgPSB0cnVlOworYm9vbCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjppc0dlb2xv Y2F0aW9uRW5hYmxlZCA9IHRydWU7CiBib29sIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmlzSW5k ZXhlZERCRW5hYmxlZCA9IGZhbHNlOwogCiAjaWYgRU5BQkxFKFZJREVPKQpJbmRleDogV2ViQ29y ZS9zdG9yYWdlL0RhdGFiYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3N0b3JhZ2UvRGF0 YWJhc2UuY3BwCShyZXZpc2lvbiA1NDk1OSkKKysrIFdlYkNvcmUvc3RvcmFnZS9EYXRhYmFzZS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTczLDcgKzczLDcgQEAgY29uc3QgU3RyaW5nJiBEYXRhYmFz ZTo6ZGF0YWJhc2VJbmZvVGFibAogCiAjaWYgRU5BQkxFKERBVEFCQVNFKQogCi1zdGF0aWMgYm9v bCBpc0RhdGFiYXNlQXZhaWxhYmxlID0gZmFsc2U7CitzdGF0aWMgYm9vbCBpc0RhdGFiYXNlQXZh aWxhYmxlID0gdHJ1ZTsKIAogdm9pZCBEYXRhYmFzZTo6c2V0SXNBdmFpbGFibGUoYm9vbCBhdmFp bGFibGUpCiB7Cg==