35091 2010-02-18 05:13:47 -0800 style-queue should not complain about identifier names with underscores under WebKit/efl/ewk/ 2010-02-19 18:08:49 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 leandro webkit-unassigned commit-queue gyuyoung hamaji rakuco oldest_to_newest 191541 0 leandro 2010-02-18 05:13:47 -0800 Our APIs use EFL style naming, so we need to use lower-cased, _-separated names there. An example of this happenning: https://webkit-commit-queue.appspot.com/results/283368 191543 1 49000 leandro 2010-02-18 05:14:56 -0800 Created attachment 49000 Proposed patch 191571 2 49000 hamaji 2010-02-18 06:31:43 -0800 Comment on attachment 49000 Proposed patch Looks good, but could you write a test case for this? The comment above _PATH_RULES_SPECIFIER points where you should modify. # Each string appearing in this nested list should have at least # one associated unit test assertion. These assertions are located, # for example, in the test_path_rules_specifier() unit test method of # checker_unittest.py. _PATH_RULES_SPECIFIER = [ r- for this reason. 191592 3 49012 leandro 2010-02-18 07:30:52 -0800 Created attachment 49012 Proposed patch, with requested test case Requested changes. Note that this test will fail until WebKit/efl exists. 191804 4 hamaji 2010-02-18 18:38:35 -0800 Thanks for adding the test case! > Note that this test will fail until WebKit/efl exists. Hmm... I thought this test doesn't check if the path exists. Also, the test seems to be passing. Will the test really fail? Otherwise, I'd like to land this patch as is. Thanks, 191835 5 49012 hamaji 2010-02-18 23:32:02 -0800 Comment on attachment 49012 Proposed patch, with requested test case Looks good, but setting cq- until it turns out this won't break the test. 192018 6 leandro 2010-02-19 12:42:11 -0800 (In reply to comment #4) > Thanks for adding the test case! > > > Note that this test will fail until WebKit/efl exists. > > Hmm... I thought this test doesn't check if the path exists. Also, the test > seems to be passing. Will the test really fail? Otherwise, I'd like to land > this patch as is. > Tested it here, it seems to pass. Sorry for the false alarm. 192126 7 49012 hamaji 2010-02-19 17:49:06 -0800 Comment on attachment 49012 Proposed patch, with requested test case Thanks for checking! 192128 8 49012 commit-queue 2010-02-19 18:08:44 -0800 Comment on attachment 49012 Proposed patch, with requested test case Clearing flags on attachment: 49012 Committed r55042: <http://trac.webkit.org/changeset/55042> 192129 9 commit-queue 2010-02-19 18:08:49 -0800 All reviewed patches have been landed. Closing bug. 49000 2010-02-18 05:14:56 -0800 2010-02-18 07:30:52 -0800 Proposed patch check-webkit-style-efl.diff text/plain 1541 leandro SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU0OTU0KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDItMTggIExlYW5kcm8gUGVyZWlyYSAg PGxlYW5kcm9AcHJvZnVzaW9uLm1vYmk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW3N0eWxlLXF1ZXVlXSBzaG91bGQgbm90IGNvbXBsYWluIGFib3V0 IGlkZW50aWZpZXIgbmFtZXMgd2l0aCB1bmRlcnNjb3JlcyB1bmRlciBXZWJLaXQvZWZsL2V3ay8K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1MDkxCisK KyAgICAgICAgV2hpdGUgbGlzdCB1bml4X2hhY2tlcl9zdHlsZSBuYW1lcyBpbiBXZWJLaXQvZWZs L2V3ayBiZWNhdXNlIHRoZXNlCisgICAgICAgIGFyZSB1c2VkIGluIHRoZSBFRkwgQVBJLgorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5OgorICAgICAgICAgLSBG aWx0ZXIgb3V0IHJlYWRhYmlsaXR5L25hbWluZyBvbiBXZWJLaXQvZWZsL2V3ay4KKwogMjAxMC0w Mi0xOCAgU2hpbmljaGlybyBIYW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXIucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CShyZXZpc2lvbiA1NDk1NCkKKysrIFdlYktpdFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQkod29ya2luZyBjb3B5KQpAQCAtMTA5 LDYgKzEwOSwxMCBAQCBfUEFUSF9SVUxFU19TUEVDSUZJRVIgPSBbCiAgICAgKFsjIFRoZSBHVEsr IEFQSXMgdXNlIEdUSysgbmFtaW5nIHN0eWxlLCB3aGljaCBpbmNsdWRlcwogICAgICAgIyBsb3dl ci1jYXNlZCwgdW5kZXJzY29yZS1zZXBhcmF0ZWQgdmFsdWVzLgogICAgICAgIldlYktpdC9ndGsv d2Via2l0LyIsCisgICAgICAjIFRoZSBFRkwgQVBJcyB1c2UgRUZMIG5hbWluZyBzdHlsZSwgd2hp Y2ggaW5jbHVkZXMKKyAgICAgICMgYm90aCBsb3dlci1jYXNlZCBhbmQgY2FtZWwtY2FzZWQsIHVu ZGVyc2NvcmUtc3BhcmF0ZWQKKyAgICAgICMgdmFsdWVzLgorICAgICAgIldlYktpdC9lZmwvZXdr LyIsCiAgICAgICAjIFRoZXJlIGlzIG5vIGNsZWFuIHdheSB0byBhdm9pZCAieXlfKiIgbmFtZXMg dXNlZCBieSBmbGV4LgogICAgICAgIldlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAiLAogICAgICAg IyBUaGVyZSBpcyBubyBjbGVhbiB3YXkgdG8gYXZvaWQgInh4eF9kYXRhIiBtZXRob2RzIGluc2lk ZQo= 49012 2010-02-18 07:30:52 -0800 2010-02-19 18:08:44 -0800 Proposed patch, with requested test case check-webkit-style-v2.diff text/plain 2224 leandro SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU0OTU0KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDItMTggIExlYW5kcm8gUGVyZWlyYSAg PGxlYW5kcm9AcHJvZnVzaW9uLm1vYmk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW3N0eWxlLXF1ZXVlXSBzaG91bGQgbm90IGNvbXBsYWluIGFib3V0 IGlkZW50aWZpZXIgbmFtZXMgd2l0aCB1bmRlcnNjb3JlcyB1bmRlciBXZWJLaXQvZWZsL2V3ay8K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1MDkxCisK KyAgICAgICAgV2hpdGUgbGlzdCB1bml4X2hhY2tlcl9zdHlsZSBuYW1lcyBpbiBXZWJLaXQvZWZs L2V3ayBiZWNhdXNlIHRoZXNlCisgICAgICAgIGFyZSB1c2VkIGluIHRoZSBFRkwgQVBJLgorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5OgorICAgICAgICAgLSBG aWx0ZXIgb3V0IHJlYWRhYmlsaXR5L25hbWluZyBvbiBXZWJLaXQvZWZsL2V3ay4KKwogMjAxMC0w Mi0xOCAgU2hpbmljaGlybyBIYW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXIucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CShyZXZpc2lvbiA1NDk1NCkKKysrIFdlYktpdFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQkod29ya2luZyBjb3B5KQpAQCAtMTA5 LDYgKzEwOSwxMCBAQAogICAgIChbIyBUaGUgR1RLKyBBUElzIHVzZSBHVEsrIG5hbWluZyBzdHls ZSwgd2hpY2ggaW5jbHVkZXMKICAgICAgICMgbG93ZXItY2FzZWQsIHVuZGVyc2NvcmUtc2VwYXJh dGVkIHZhbHVlcy4KICAgICAgICJXZWJLaXQvZ3RrL3dlYmtpdC8iLAorICAgICAgIyBUaGUgRUZM IEFQSXMgdXNlIEVGTCBuYW1pbmcgc3R5bGUsIHdoaWNoIGluY2x1ZGVzCisgICAgICAjIGJvdGgg bG93ZXItY2FzZWQgYW5kIGNhbWVsLWNhc2VkLCB1bmRlcnNjb3JlLXNwYXJhdGVkCisgICAgICAj IHZhbHVlcy4KKyAgICAgICJXZWJLaXQvZWZsL2V3ay8iLAogICAgICAgIyBUaGVyZSBpcyBubyBj bGVhbiB3YXkgdG8gYXZvaWQgInl5XyoiIG5hbWVzIHVzZWQgYnkgZmxleC4KICAgICAgICJXZWJD b3JlL2Nzcy9DU1NQYXJzZXIuY3BwIiwKICAgICAgICMgVGhlcmUgaXMgbm8gY2xlYW4gd2F5IHRv IGF2b2lkICJ4eHhfZGF0YSIgbWV0aG9kcyBpbnNpZGUKSW5kZXg6IFdlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcl91bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJfdW5pdHRlc3QucHkJKHJldmlz aW9uIDU0OTU0KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy X3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xODMsNiArMTgzLDggQEAKICAgICAgICAg ICAgICAgICAgICAgInJlYWRhYmlsaXR5L25hbWluZyIpCiAgICAgICAgIGFzc2VydE5vQ2hlY2so IldlYktpdC9ndGsvd2Via2l0L3dlYmtpdC5oIiwKICAgICAgICAgICAgICAgICAgICAgICAicmVh ZGFiaWxpdHkvbmFtaW5nIikKKyAgICAgICAgYXNzZXJ0Tm9DaGVjaygiV2ViS2l0L2VmbC9ld2sv ZXdrX3ZpZXcuaCIsCisgICAgICAgICAgICAgICAgICAgICAgInJlYWRhYmlsaXR5L25hbWluZyIp CiAgICAgICAgIGFzc2VydE5vQ2hlY2soIldlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAiLAogICAg ICAgICAgICAgICAgICAgICAgICJyZWFkYWJpbGl0eS9uYW1pbmciKQogICAgICAgICBhc3NlcnRO b0NoZWNrKCJXZWJLaXQvcXQvdGVzdHMvcXdlYmVsZW1lbnQvdHN0X3F3ZWJlbGVtZW50LmNwcCIs Cg==