35086 2010-02-18 03:27:13 -0800 [Qt][GTK] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails (DRT sideeffect) 2011-04-19 10:41:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC All RESOLVED FIXED Gtk, LayoutTestFailure, Qt, QtTriaged P3 Normal --- 1 ossy webkit-unassigned abarth commit-queue eric gustavo kent.hansen kkristof laszlo.gombos pnormand webkit.review.bot oldest_to_newest 191513 0 ossy 2010-02-18 03:27:13 -0800 fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails on Qt buildbot from http://trac.webkit.org/changeset/54944 . result: http://build.webkit.org/results/Qt%20Linux%20Release/r54948%20(7523)/results.html fast/xmlhttprequest/xmlhttprequest-no-file-access.html is a new test introduced in r54944, which cause that fail. Both of them pass if we run them in separated DRT, so it must be a DRT sideeffect problem. You can reproduce it easily: $ WebKitTools/Scripts/run-webkit-tests fast/xmlhttprequest/xmlhttprequest-no-file-access.html fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html 191530 1 ossy 2010-02-18 04:01:50 -0800 fast/xmlhttprequest/xmlhttprequest-no-file-access.html skipped by http://trac.webkit.org/changeset/54954 until fix. 191708 2 gustavo 2010-02-18 13:06:32 -0800 Yep, we seem to also suffer from this. 381315 3 pnormand 2011-04-07 07:15:17 -0700 fast/xmlhttprequest/xmlhttprequest-no-file-access.html passes locally on GTK. I'll unskip it. 383948 4 ossy 2011-04-12 05:34:54 -0700 I checked, the bug is still valid for Qt. 388469 5 90194 kkristof 2011-04-19 06:43:42 -0700 Created attachment 90194 proposed fix 388474 6 laszlo.gombos 2011-04-19 06:46:15 -0700 Should the change include the Skipped file change as well ? 388476 7 90194 ossy 2011-04-19 06:46:39 -0700 Comment on attachment 90194 proposed fix LGTM, r=me. 388479 8 ossy 2011-04-19 06:48:39 -0700 (In reply to comment #6) > Should the change include the Skipped file change as well ? Ooops, yes. 388480 9 90194 ossy 2011-04-19 06:49:06 -0700 Comment on attachment 90194 proposed fix We need to unskip the tests too. 388494 10 90199 kkristof 2011-04-19 07:22:54 -0700 Created attachment 90199 proposed fix 388496 11 90199 kling 2011-04-19 07:24:54 -0700 Comment on attachment 90199 proposed fix Nice catch, r=me 388531 12 90199 commit-queue 2011-04-19 09:01:32 -0700 Comment on attachment 90199 proposed fix Clearing flags on attachment: 90199 Committed r84256: <http://trac.webkit.org/changeset/84256> 388533 13 commit-queue 2011-04-19 09:01:36 -0700 All reviewed patches have been landed. Closing bug. 388589 14 webkit.review.bot 2011-04-19 10:41:55 -0700 http://trac.webkit.org/changeset/84256 might have broken Windows 7 Release (Tests) 90194 2011-04-19 06:43:42 -0700 2011-04-19 06:49:06 -0700 proposed fix 1.patch text/plain 1596 kkristof ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwOGM3 NTg3Li5mYzUxMWJmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDQtMTkgIEtyaXN0w7NmIEtvc3p0ecOzICA8 S29zenR5by5LcmlzdG9mQHN0dWQudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBmYXN0L3htbGh0dHByZXF1ZXN0L3htbGh0 dHByZXF1ZXN0LW5vbmV4aXN0ZW50LWZpbGUuaHRtbCBmYWlscyAoRFJUIHNpZGVlZmZlY3QpCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTA4NgorCisg ICAgICAgIGZhc3QveG1saHR0cHJlcXVlc3QveG1saHR0cHJlcXVlc3Qtbm8tZmlsZS1hY2Nlc3Mu aHRtbCBjYXVzZWQKKyAgICAgICAgYSBEUlQgc2lkZWVmZmVjdCBwcm9ibGVtLCBiZWNhdXNlIHRo ZSByZXNldFNldHRpbmdzIGRpZG4ndCBzZXQgCisgICAgICAgIHRoZSBkZWZhdWx0IHZhbHVlIG9m IExvY2FsQ29udGVudENhbkFjY2Vzc0ZpbGVVcmxzLgorCisgICAgICAgICogRHVtcFJlbmRlclRy ZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJQYWdlOjpy ZXNldFNldHRpbmdzKToKKwogMjAxMS0wNC0xOCAgWmFuIERvYmVyc2VrICA8emFuZG9iZXJzZWtA Z21haWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KZGlmZiAt LWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlUXQuY3BwIGIvVG9v bHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHAKaW5kZXggZGI0ZjQ2YS4u MWE2YzgzMyAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRy ZWVRdC5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5j cHAKQEAgLTE5MCw2ICsxOTAsNyBAQCB2b2lkIFdlYlBhZ2U6OnJlc2V0U2V0dGluZ3MoKQogICAg IHNldHRpbmdzKCktPnJlc2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6TGlua3NJbmNsdWRlZElu Rm9jdXNDaGFpbik7CiAgICAgc2V0dGluZ3MoKS0+cmVzZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdz OjpPZmZsaW5lV2ViQXBwbGljYXRpb25DYWNoZUVuYWJsZWQpOwogICAgIHNldHRpbmdzKCktPnJl c2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6TG9jYWxDb250ZW50Q2FuQWNjZXNzUmVtb3RlVXJs cyk7CisgICAgc2V0dGluZ3MoKS0+cmVzZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpMb2NhbENv bnRlbnRDYW5BY2Nlc3NGaWxlVXJscyk7CiAgICAgc2V0dGluZ3MoKS0+cmVzZXRBdHRyaWJ1dGUo UVdlYlNldHRpbmdzOjpQbHVnaW5zRW5hYmxlZCk7CiAgICAgc2V0dGluZ3MoKS0+cmVzZXRBdHRy aWJ1dGUoUVdlYlNldHRpbmdzOjpKYXZhc2NyaXB0Q2FuQWNjZXNzQ2xpcGJvYXJkKTsKICAgICBz ZXR0aW5ncygpLT5yZXNldEF0dHJpYnV0ZShRV2ViU2V0dGluZ3M6OkF1dG9Mb2FkSW1hZ2VzKTsK 90199 2011-04-19 07:22:54 -0700 2011-04-19 09:01:32 -0700 proposed fix 1.patch text/plain 2928 kkristof ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzNWVhYmZkLi44M2VhMzFjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDQt MTkgIEtyaXN0w7NmIEtvc3p0ecOzICA8S29zenR5by5LcmlzdG9mQHN0dWQudS1zemVnZWQuaHU+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBm YXN0L3htbGh0dHByZXF1ZXN0L3htbGh0dHByZXF1ZXN0LW5vbmV4aXN0ZW50LWZpbGUuaHRtbCBm YWlscyAoRFJUIHNpZGVlZmZlY3QpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zNTA4NgorCisgICAgICAgICogcGxhdGZvcm0vcXQvU2tpcHBlZDogdW5z a2lwIGZhc3QveG1saHR0cHJlcXVlc3QveG1saHR0cHJlcXVlc3Qtbm9uZXhpc3RlbnQtZmlsZS5o dG1sCisKIDIwMTEtMDQtMTkgIEpvaG4gS25vdHRlbmJlbHQgIDxqa25vdHRlbkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL3F0L1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCmluZGV4IGFi ODIwM2UuLmVhMDM2YTYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBw ZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZApAQCAtMjg5LDEwICsyODks NiBAQCBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3JlLWxvZ2luLmh0bWwKICMgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyOTYxCiBodHRwL3Rlc3RzL3htbGh0dHBy ZXF1ZXN0L2ZhaWxlZC1hdXRoLmh0bWwKIAotIyBbUXRdIGZhc3QveG1saHR0cHJlcXVlc3QveG1s aHR0cHJlcXVlc3Qtbm9uZXhpc3RlbnQtZmlsZS5odG1sIGZhaWxzIChEUlQgc2lkZWVmZmVjdCkK LSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1MDg2Ci1mYXN0L3ht bGh0dHByZXF1ZXN0L3htbGh0dHByZXF1ZXN0LW5vLWZpbGUtYWNjZXNzLmh0bWwKLQogIyBUaGVz ZSBmYXN0IFhNTEh0dHBSZXF1ZXN0IHRlc3RzIGZhaWwgYmVjYXVzZSAzRF9DQU5WQVMgaXMgbm90 IGVuYWJsZWQuCiBmYXN0L3htbGh0dHByZXF1ZXN0L3htbGh0dHByZXF1ZXN0LXJlc3BvbnNldHlw ZS1hYm9ydC5odG1sCiBmYXN0L3htbGh0dHByZXF1ZXN0L3htbGh0dHByZXF1ZXN0LXJlc3BvbnNl dHlwZS1hcnJheWJ1ZmZlci5odG1sCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29s cy9DaGFuZ2VMb2cKaW5kZXggMDhjNzU4Ny4uNzYzOGY3MSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hh bmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDExLTA0LTE5 ICBLcmlzdMOzZiBLb3N6dHnDsyAgPEtvc3p0eW8uS3Jpc3RvZkBzdHVkLnUtc3plZ2VkLmh1Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gZmFz dC94bWxodHRwcmVxdWVzdC94bWxodHRwcmVxdWVzdC1ub25leGlzdGVudC1maWxlLmh0bWwgZmFp bHMgKERSVCBzaWRlZWZmZWN0KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzUwODYKKworICAgICAgICBmYXN0L3htbGh0dHByZXF1ZXN0L3htbGh0dHBy ZXF1ZXN0LW5vLWZpbGUtYWNjZXNzLmh0bWwgY2F1c2VkCisgICAgICAgIGEgRFJUIHNpZGVlZmZl Y3QgcHJvYmxlbSwgYmVjYXVzZSB0aGUgcmVzZXRTZXR0aW5ncyBkaWRuJ3Qgc2V0CisgICAgICAg IHRoZSBkZWZhdWx0IHZhbHVlIG9mIExvY2FsQ29udGVudENhbkFjY2Vzc0ZpbGVVcmxzLgorCisg ICAgICAgICogRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpXZWJQYWdlOjpyZXNldFNldHRpbmdzKToKKwogMjAxMS0wNC0xOCAgWmFuIERv YmVyc2VrICA8emFuZG9iZXJzZWtAZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1h cnRpbiBSb2JpbnNvbi4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBS ZW5kZXJUcmVlUXQuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWVR dC5jcHAKaW5kZXggZGI0ZjQ2YS4uMWE2YzgzMyAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRl clRyZWUvcXQvRHVtcFJlbmRlclRyZWVRdC5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUv cXQvRHVtcFJlbmRlclRyZWVRdC5jcHAKQEAgLTE5MCw2ICsxOTAsNyBAQCB2b2lkIFdlYlBhZ2U6 OnJlc2V0U2V0dGluZ3MoKQogICAgIHNldHRpbmdzKCktPnJlc2V0QXR0cmlidXRlKFFXZWJTZXR0 aW5nczo6TGlua3NJbmNsdWRlZEluRm9jdXNDaGFpbik7CiAgICAgc2V0dGluZ3MoKS0+cmVzZXRB dHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpPZmZsaW5lV2ViQXBwbGljYXRpb25DYWNoZUVuYWJsZWQp OwogICAgIHNldHRpbmdzKCktPnJlc2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6TG9jYWxDb250 ZW50Q2FuQWNjZXNzUmVtb3RlVXJscyk7CisgICAgc2V0dGluZ3MoKS0+cmVzZXRBdHRyaWJ1dGUo UVdlYlNldHRpbmdzOjpMb2NhbENvbnRlbnRDYW5BY2Nlc3NGaWxlVXJscyk7CiAgICAgc2V0dGlu Z3MoKS0+cmVzZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpQbHVnaW5zRW5hYmxlZCk7CiAgICAg c2V0dGluZ3MoKS0+cmVzZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpKYXZhc2NyaXB0Q2FuQWNj ZXNzQ2xpcGJvYXJkKTsKICAgICBzZXR0aW5ncygpLT5yZXNldEF0dHJpYnV0ZShRV2ViU2V0dGlu Z3M6OkF1dG9Mb2FkSW1hZ2VzKTsK