35082 2010-02-18 02:25:03 -0800 [Haiku] Fix conversion from BString to String for real. 2010-02-23 08:32:15 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 superstippi webkit-unassigned commit-queue simon.maxime oldest_to_newest 191500 0 superstippi 2010-02-18 02:25:03 -0800 The previous patch to this file was broken (sorry). First of all, the conversion from UTF8 was accidentally removed. Second, for empty strings, we need to point the implementation at StringImpl::empty(). 191501 1 48988 superstippi 2010-02-18 02:27:58 -0800 Created attachment 48988 Fixes conversion from BString to String This patch fixes the conversion for real. Patch is again r54932 and does not depend on any other patches. 191502 2 superstippi 2010-02-18 02:29:47 -0800 BTW, the include sorting is correct, the style bot doesn't handle this case. 192611 3 48988 eric 2010-02-22 14:04:09 -0800 Comment on attachment 48988 Fixes conversion from BString to String Changing bstring to string makes this more confusing to my eyes. Otherwise this looks sane. 192966 4 48988 commit-queue 2010-02-23 08:32:11 -0800 Comment on attachment 48988 Fixes conversion from BString to String Clearing flags on attachment: 48988 Committed r55154: <http://trac.webkit.org/changeset/55154> 192967 5 commit-queue 2010-02-23 08:32:15 -0800 All reviewed patches have been landed. Closing bug. 48988 2010-02-18 02:27:58 -0800 2010-02-23 08:32:11 -0800 Fixes conversion from BString to String string.diff text/plain 2071 superstippi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDk0OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDItMTggIE1pY2hhZWwgTG90eiA8bW1sckBtbG90ei5jaD4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbSGFpa3Vd IEZpeCBjb252ZXJzaW9uIGZyb20gQlN0cmluZyB0byBTdHJpbmcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1MDgyCisKKyAgICAgICAgVGhlIHByZXZp b3VzIHBhdGNoIHRvIHRoaXMgZmlsZSB3YXMgYnJva2VuIChzb3JyeSkuIEZpcnN0IG9mIGFsbCwK KyAgICAgICAgdGhlIGNvbnZlcnNpb24gZnJvbSBVVEY4IHdhcyBhY2NpZGVudGFsbHkgcmVtb3Zl ZC4gU2Vjb25kLCBmb3IKKyAgICAgICAgZW1wdHkgc3RyaW5ncywgd2UgbmVlZCB0byBwb2ludCB0 aGUgaW1wbGVtZW50YXRpb24gYXQgU3RyaW5nSW1wbDo6ZW1wdHkoKS4KKworICAgICAgICBDb3Zl cmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vdGV4dC9oYWlrdS9T dHJpbmdIYWlrdS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHJpbmc6OlN0cmluZyk6CisKIDIw MTAtMDItMTggIFdpbGxpYW0gQ2hhbiAgPHdpbGxjaGFuQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2hh aWt1L1N0cmluZ0hhaWt1LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL3RleHQv aGFpa3UvU3RyaW5nSGFpa3UuY3BwCShyZXZpc2lvbiA1NDkzMikKKysrIFdlYkNvcmUvcGxhdGZv cm0vdGV4dC9oYWlrdS9TdHJpbmdIYWlrdS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIwLDcgKzIw LDcgQEAKICAqIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVT RUQgQU5EIE9OIEFOWSBUSEVPUlkKICAqIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFD VCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAogICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9S IE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCi0gKiBPRiBUSElT IFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFN QUdFLiAKKyAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lC SUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAgKi8KIAogI2luY2x1ZGUgImNvbmZpZy5oIgpAQCAtMzIs MTggKzMyLDEyIEBACiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIC8vIFN0cmluZyBjb252ZXJzaW9u cwotU3RyaW5nOjpTdHJpbmcoY29uc3QgQlN0cmluZyYgYnN0cmluZykKK1N0cmluZzo6U3RyaW5n KGNvbnN0IEJTdHJpbmcmIHN0cmluZykKIHsKLSAgICBjb25zdCBVQ2hhciogc3RyID0gcmVpbnRl cnByZXRfY2FzdDxjb25zdCBVQ2hhcio+KGJzdHJpbmcuU3RyaW5nKCkpOwotICAgIGNvbnN0IHNp emVfdCBzaXplID0gYnN0cmluZy5MZW5ndGgoKTsKLQotICAgIGlmICghc3RyKQotICAgICAgICBy ZXR1cm47Ci0KLSAgICBpZiAoIXNpemUpCi0gICAgICAgIG1faW1wbCA9IFN0cmluZ0ltcGw6OmVt cHR5KCk7CisgICAgaWYgKHN0cmluZy5MZW5ndGgoKSkKKyAgICAgICAgbV9pbXBsID0gU3RyaW5n Ojpmcm9tVVRGOChzdHJpbmcuU3RyaW5nKCksIHN0cmluZy5MZW5ndGgoKSkuaW1wbCgpOwogICAg IGVsc2UKLSAgICAgICAgbV9pbXBsID0gU3RyaW5nSW1wbDo6Y3JlYXRlKHN0ciwgc2l6ZSk7Cisg ICAgICAgIG1faW1wbCA9IFN0cmluZ0ltcGw6OmVtcHR5KCk7CiB9CiAKIFN0cmluZzo6b3BlcmF0 b3IgQlN0cmluZygpIGNvbnN0Cg==