35081 2010-02-18 02:24:42 -0800 fast/frames/iframe-reparenting.html crashing on GTK Debug bots 2010-02-18 07:18:40 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned gustavo oldest_to_newest 191499 0 pnormand 2010-02-18 02:24:42 -0800 ASSERTION FAILED: !m_deletionHasBegun (../../JavaScriptCore/wtf/RefCounted.h:36 void WTF::RefCountedBase::ref()) Program received signal SIGSEGV, Segmentation fault. 0x00007ffff5e61fce in WTF::RefCountedBase::ref (this=0x7fffffffbf78) at ../../JavaScriptCore/wtf/RefCounted.h:36 36 ASSERT(!m_deletionHasBegun); (gdb) bt #0 0x00007ffff5e61fce in WTF::RefCountedBase::ref (this=0x7fffffffbf78) at ../../JavaScriptCore/wtf/RefCounted.h:36 #1 0x00007ffff624dc3c in WTF::refIfNotNull<WebCore::ResourceLoader> (ptr=0x7fffffffbf70) at ../../JavaScriptCore/wtf/PassRefPtr.h:43 #2 0x00007ffff624c737 in RefPtr (this=0x7fffffffbc50, ptr=0x7fffffffbf70) at ../../JavaScriptCore/wtf/RefPtr.h:41 #3 0x00007ffff673b142 in parseDataUrl (callback_data=0x7fffffffbfa0) at ../../WebCore/platform/network/soup/ResourceHandleSoup.cpp:364 #4 0x00007ffff1e5cee0 in g_main_dispatch (context=0x683860) at gmain.c:1960 #5 IA__g_main_context_dispatch (context=0x683860) at gmain.c:2513 #6 0x00007ffff1e60d18 in g_main_context_iterate (context=0x683860, block=<value optimized out>, dispatch=<value optimized out>, self=<value optimized out>) at gmain.c:2591 #7 0x00007ffff1e6125d in IA__g_main_loop_run (loop=0xd73b10) at gmain.c:2799 #8 0x00007ffff6739e53 in WebCore::WebCoreSynchronousLoader::run (this=0x7fffffffbf70) at ../../WebCore/platform/network/soup/ResourceHandleSoup.cpp:120 #9 0x00007ffff673c669 in WebCore::ResourceHandle::loadResourceSynchronously (request=..., error=..., response=..., data=..., frame=0x6f4100) at ../../WebCore/platform/network/soup/ResourceHandleSoup.cpp:674 #10 0x00007ffff626cb4a in WebCore::FrameLoader::loadResourceSynchronously (this=0x6f4150, request=..., storedCredentials=WebCore::AllowStoredCredentials, error=..., response=..., data=...) at ../../WebCore/loader/FrameLoader.cpp:3358 #11 0x00007ffff625415e in WebCore::DocumentThreadableLoader::loadRequest (this=0xdfd790, request=..., securityCheck=WebCore::DoSecurityCheck) at ../../WebCore/loader/DocumentThreadableLoader.cpp:314 #12 0x00007ffff6252887 in DocumentThreadableLoader (this=0xdfd790, document=0x6b8b40, client=0xdf5730, blockingBehavior=WebCore::DocumentThreadableLoader::LoadSynchronously, request=..., options=...) at ../../WebCore/loader/DocumentThreadableLoader.cpp:73 #13 0x00007ffff625216c in WebCore::DocumentThreadableLoader::loadResourceSynchronously (document=0x6b8b40, request=..., client=..., options=...) at ../../WebCore/loader/DocumentThreadableLoader.cpp:50 #14 0x00007ffff628f4e5 in WebCore::ThreadableLoader::loadResourceSynchronously (context=0x6b8b98, request=..., client=..., options=...) at ../../WebCore/loader/ThreadableLoader.cpp:69 #15 0x00007ffff6504718 in WebCore::XMLHttpRequest::createRequest (this=0xdf5720, ec=@0x7fffffffc8dc) at ../../WebCore/xml/XMLHttpRequest.cpp:521 #16 0x00007ffff6503f65 in WebCore::XMLHttpRequest::send (this=0xdf5720, body=..., ec=@0x7fffffffc8dc) at ../../WebCore/xml/XMLHttpRequest.cpp:435 #17 0x00007ffff6503a31 in WebCore::XMLHttpRequest::send (this=0xdf5720, ec=@0x7fffffffc8dc) at ../../WebCore/xml/XMLHttpRequest.cpp:378 #18 0x00007ffff5ef0c44 in WebCore::JSXMLHttpRequest::send (this=0x7fffe81d52c0, exec=0x7fffe82340b0, args=...) at ../../WebCore/bindings/js/JSXMLHttpRequestCustom.cpp:109 #19 0x00007ffff6a63327 in WebCore::jsXMLHttpRequestPrototypeFunctionSend (exec=0x7fffe82340b0, thisValue=..., args=...) at DerivedSources/JSXMLHttpRequest.cpp:382 #20 0x00007ffff7e0c1b4 in ?? () #21 0x00007fffe8234068 in ?? () #22 0x0000000000000001 in ?? () #23 0x00007fffffffc9a0 in ?? () #24 0x00007fffe81d5380 in ?? () #25 0x00007ffff7e0a0cb in ?? () #26 0x00007fff00000002 in ?? () #27 0x00007fffe81d5280 in ?? () #28 0x0000000000000004 in ?? () #29 0x00007fffffffc9c0 in ?? () #30 0x00007ffff684cc4d in WTF::Vector<JSC::Instruction, 0ul>::clear (this=0x7ffff7ddebf0) at ../../JavaScriptCore/wtf/Vector.h:545 #31 0x00007ffff683170c in JSC::JITCode::execute (this=0xd49c88, registerFile=0x75e4b8, callFrame=0x7fffe8234048, globalData=0x75b420, exception=0x75c6f0) at ../../JavaScriptCore/jit/JITCode.h:79 #32 0x00007ffff6823cd9 in JSC::Interpreter::execute (this=0x75e4a0, functionExecutable=0xd49c70, callFrame=0xd84088, function=0x7fffe81c2f00, thisObj=0x7fffe81cf040, args=..., scopeChain=0xd49cf0, exception=0x75c6f0) at ../../JavaScriptCore/interpreter/Interpreter.cpp:686 #33 0x00007ffff68f772f in JSC::JSFunction::call (this=0x7fffe81c2f00, exec=0xd84088, thisValue=..., args=...) at ../../JavaScriptCore/runtime/JSFunction.cpp:122 #34 0x00007ffff68d85b7 in JSC::call (exec=0xd84088, functionObject=..., callType=JSC::CallTypeJS, callData=..., thisValue=..., args=...) at ../../JavaScriptCore/runtime/CallData.cpp:39 #35 0x00007ffff5ef8827 in WebCore::ScheduledAction::executeFunctionInContext (this=0xdd23c0, globalObject=0x7fffe81cf0c0, thisValue=...) at ../../WebCore/bindings/js/ScheduledAction.cpp:106 #36 0x00007ffff5ef89b5 in WebCore::ScheduledAction::execute (this=0xdd23c0, document=0xdd8ea0) at ../../WebCore/bindings/js/ScheduledAction.cpp:126 ---Type <return> to continue, or q <return> to quit--- #37 0x00007ffff5ef8608 in WebCore::ScheduledAction::execute (this=0xdd23c0, context=0xdd8ef8) at ../../WebCore/bindings/js/ScheduledAction.cpp:77 #38 0x00007ffff62abf24 in WebCore::DOMTimer::fired (this=0xddc3a0) at ../../WebCore/page/DOMTimer.cpp:149 #39 0x00007ffff63517b8 in WebCore::ThreadTimers::sharedTimerFiredInternal (this=0x653500) at ../../WebCore/platform/ThreadTimers.cpp:112 #40 0x00007ffff63516eb in WebCore::ThreadTimers::sharedTimerFired () at ../../WebCore/platform/ThreadTimers.cpp:90 #41 0x00007ffff6720e3e in timeout_cb () at ../../WebCore/platform/gtk/SharedTimerGtk.cpp:48 #42 0x00007ffff1e5cee0 in g_main_dispatch (context=0xffff000000000002) at gmain.c:1960 #43 IA__g_main_context_dispatch (context=0xffff000000000002) at gmain.c:2513 #44 0x00007ffff1e60d18 in g_main_context_iterate (context=0x683860, block=<value optimized out>, dispatch=<value optimized out>, self=<value optimized out>) at gmain.c:2591 #45 0x00007ffff1e6125d in IA__g_main_loop_run (loop=0x6fb900) at gmain.c:2799 #46 0x00007ffff3d3b287 in IA__gtk_main () at gtkmain.c:1219 #47 0x0000000000412d30 in runTest (testPathOrURL=...) at ../../WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp:503 #48 0x0000000000414023 in main (argc=2, argv=0x7fffffffdb08) at ../../WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp:869 191537 1 48998 gustavo 2010-02-18 04:52:24 -0800 Created attachment 48998 simpler fix for the data URL download crash, that also fixes this 191545 2 gustavo 2010-02-18 05:27:46 -0800 Landed as r54955, after getting it reviewed by xan on IRC. 191588 3 48998 aroben 2010-02-18 07:18:40 -0800 Comment on attachment 48998 simpler fix for the data URL download crash, that also fixes this Clearing review flag, since this has been landed. 48998 2010-02-18 04:52:24 -0800 2010-02-18 07:18:40 -0800 simpler fix for the data URL download crash, that also fixes this 0001-2010-02-18-Gustavo-Noronha-Silva-gustavo.noronha-col.patch text/plain 3331 gustavo RnJvbSA0OWIzZGM1OWIzYmRjYTQ4ZTMyODIyODEyMGQyYzUzZTRkYjhmZDE1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IFRodSwgMTggRmViIDIwMTAgMTA6NTE6MDYgLTAyMDAKU3ViamVjdDogW1BBVENIXSAy MDEwLTAyLTE4ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFi b3JhLmNvLnVrPgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAg ZmFzdC9mcmFtZXMvaWZyYW1lLXJlcGFyZW50aW5nLmh0bWwgY3Jhc2hpbmcgb24gR1RLIERlYnVn IGJvdHMKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzUw ODEKCiAgICAgICAgVGVzdDogZmFzdC9mcmFtZXMvaWZyYW1lLXJlcGFyZW50aW5nLmh0bWwKCiAg ICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcDoKICAg ICAgICAoV2ViQ29yZTo6cGFyc2VEYXRhVXJsKToKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiAuLi4vcGxh dGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAgICB8ICAgMTMgKysrLS0t LS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmlu ZGV4IDY2MTlhZmIuLmEyOTZhZWMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDItMTggIEd1c3Rhdm8g Tm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZmFzdC9mcmFtZXMvaWZy YW1lLXJlcGFyZW50aW5nLmh0bWwgY3Jhc2hpbmcgb24gR1RLIERlYnVnIGJvdHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1MDgxCisKKyAgICAgICAg VGVzdDogZmFzdC9mcmFtZXMvaWZyYW1lLXJlcGFyZW50aW5nLmh0bWwKKworICAgICAgICAqIHBs YXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6cGFyc2VEYXRhVXJsKToKKwogMjAxMC0wMi0xOCAgQmVuIE11cmRvY2ggIDxiZW5tQGdv b2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTmF0ZSBDaGFwaW4uCmRpZmYgLS1naXQg YS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwIGIv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcAppbmRl eCBjYTY5MjFjLi4yMDVjNjhmIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv c291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKQEAgLTQzLDcgKzQzLDYgQEAKICNpbmNsdWRl ICJSZXNvdXJjZUVycm9yLmgiCiAjaW5jbHVkZSAiUmVzb3VyY2VIYW5kbGVDbGllbnQuaCIKICNp bmNsdWRlICJSZXNvdXJjZUhhbmRsZUludGVybmFsLmgiCi0jaW5jbHVkZSAiUmVzb3VyY2VMb2Fk ZXIuaCIKICNpbmNsdWRlICJSZXNvdXJjZVJlc3BvbnNlLmgiCiAjaW5jbHVkZSAiVGV4dEVuY29k aW5nLmgiCiAKQEAgLTM1OCwxMSArMzU3LDYgQEAgc3RhdGljIGdib29sZWFuIHBhcnNlRGF0YVVy bChncG9pbnRlciBjYWxsYmFja19kYXRhKQogICAgIGlmICghY2xpZW50KQogICAgICAgICByZXR1 cm4gZmFsc2U7CiAKLSAgICAvLyBVZ2x5IGhhY2sgdG8gYXZvaWQgY3Jhc2hpbmcgaW4gdGhpcyBm dW5jdGlvbiwgYnkgaGF2aW5nCi0gICAgLy8gZGlkUmVjZWl2ZVJlc3BvbnNlIGRlc3Ryb3kgdGhl IGxvYWRlci4gVGhpcyBjb25kaXRpb24gaXMKLSAgICAvLyBpbXBvc3NpYmxlIHRvIGRldGVjdCB0 aGUgd2F5IGRhdGE6IFVSTHMgYXJlIGhhbmRsZWQsIGN1cnJlbnRseS4KLSAgICBSZWZQdHI8UmVz b3VyY2VMb2FkZXI+IHJlc291cmNlTG9hZGVyKHJlaW50ZXJwcmV0X2Nhc3Q8UmVzb3VyY2VMb2Fk ZXIqPihjbGllbnQpKTsKLQogICAgIFN0cmluZyB1cmwgPSBoYW5kbGUtPnJlcXVlc3QoKS51cmwo KS5zdHJpbmcoKTsKICAgICBBU1NFUlQodXJsLnN0YXJ0c1dpdGgoImRhdGE6IiwgZmFsc2UpKTsK IApAQCAtMzk0LDcgKzM4OCw3IEBAIHN0YXRpYyBnYm9vbGVhbiBwYXJzZURhdGFVcmwoZ3BvaW50 ZXIgY2FsbGJhY2tfZGF0YSkKICAgICAgICAgcmVzcG9uc2Uuc2V0VGV4dEVuY29kaW5nTmFtZShj aGFyc2V0KTsKICAgICAgICAgY2xpZW50LT5kaWRSZWNlaXZlUmVzcG9uc2UoaGFuZGxlLCByZXNw b25zZSk7CiAKLSAgICAgICAgaWYgKGQtPm1fY2FuY2VsbGVkKQorICAgICAgICBpZiAoIWhhbmRs ZS0+Y2xpZW50KCkgfHwgZC0+bV9jYW5jZWxsZWQpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7 CiAKICAgICAgICAgLy8gVXNlIHRoZSBHTGliIEJhc2U2NCwgc2luY2UgV2ViQ29yZSdzIGRlY29k ZXIgaXNuJ3QKQEAgLTQxMSwxNSArNDA1LDE0IEBAIHN0YXRpYyBnYm9vbGVhbiBwYXJzZURhdGFV cmwoZ3BvaW50ZXIgY2FsbGJhY2tfZGF0YSkKICAgICAgICAgcmVzcG9uc2Uuc2V0VGV4dEVuY29k aW5nTmFtZSgiVVRGLTE2Iik7CiAgICAgICAgIGNsaWVudC0+ZGlkUmVjZWl2ZVJlc3BvbnNlKGhh bmRsZSwgcmVzcG9uc2UpOwogCi0gICAgICAgIGlmIChkLT5tX2NhbmNlbGxlZCkKKyAgICAgICAg aWYgKCFoYW5kbGUtPmNsaWVudCgpIHx8IGQtPm1fY2FuY2VsbGVkKQogICAgICAgICAgICAgcmV0 dXJuIGZhbHNlOwogCiAgICAgICAgIGlmIChkYXRhLmxlbmd0aCgpID4gMCkKICAgICAgICAgICAg IGNsaWVudC0+ZGlkUmVjZWl2ZURhdGEoaGFuZGxlLCByZWludGVycHJldF9jYXN0PGNvbnN0IGNo YXIqPihkYXRhLmNoYXJhY3RlcnMoKSksIGRhdGEubGVuZ3RoKCkgKiBzaXplb2YoVUNoYXIpLCAw KTsKICAgICB9CiAKLQotICAgIGlmIChkLT5tX2NhbmNlbGxlZCB8fCAhcmVzb3VyY2VMb2FkZXIt PmZyYW1lTG9hZGVyKCkpCisgICAgaWYgKCFoYW5kbGUtPmNsaWVudCgpIHx8IGQtPm1fY2FuY2Vs bGVkKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBjbGllbnQtPmRpZEZpbmlzaExvYWRp bmcoaGFuZGxlKTsKLS0gCjEuNi42LjIKCg==