35071 2010-02-17 20:38:20 -0800 Disable loader limiting of requests per host for chromium port 2010-02-18 11:21:07 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 willchan webkit-unassigned commit-queue eric webkit.review.bot oldest_to_newest 191377 0 willchan 2010-02-17 20:38:20 -0800 Chromium's network stack already limits the number of requests per host. It's unnecessary to do it here. We're starting to play around with SPDY where we want to have many more requests per host than just 6, so we need to remove this limit. 191381 1 48964 willchan 2010-02-17 21:01:08 -0800 Created attachment 48964 Disable loader limiting of requests per host for the chromium port. WebCore/ChangeLog | 12 ++++++++++++ .../platform/network/chromium/ResourceRequest.cpp | 5 +++-- 2 files changed, 15 insertions(+), 2 deletions(-) 191382 2 48965 willchan 2010-02-17 21:03:08 -0800 Created attachment 48965 Disable webkit loader throttling of requests per host for the chromium port. .../platform/network/chromium/ResourceRequest.cpp | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) 191383 3 48966 willchan 2010-02-17 21:07:36 -0800 Created attachment 48966 Disable webkit loader limiting of requests per host for the chromium port. WebCore/ChangeLog | 12 ++++++++++++ .../platform/network/chromium/ResourceRequest.cpp | 5 ++++- 2 files changed, 16 insertions(+), 1 deletions(-) 191386 4 willchan 2010-02-17 21:13:11 -0800 Apologies for the few retries on patch submission. It's my first time making a webkit change and I couldn't find / figure out git-send-bugzilla at first. Let me know if I'm doing anything else silly. 191391 5 webkit.review.bot 2010-02-17 21:17:35 -0800 Attachment 48966 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/ChangeLog:5: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 191392 6 48968 willchan 2010-02-17 21:29:38 -0800 Created attachment 48968 Disable loader limiting of requests per host for the chromium port. WebCore/ChangeLog | 12 ++++++++++++ .../platform/network/chromium/ResourceRequest.cpp | 5 ++++- 2 files changed, 16 insertions(+), 1 deletions(-) 191393 7 48966 willchan 2010-02-17 21:32:04 -0800 Comment on attachment 48966 Disable webkit loader limiting of requests per host for the chromium port. > fbdbcc22020afdbf0d706ce1ecf1a4220931f436 > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > index 8f6b450..b3b6281 100644 > --- a/WebCore/ChangeLog > +++ b/WebCore/ChangeLog > @@ -1,3 +1,15 @@ > +2010-02-17 William Chan <willchan@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + https://bugs.webkit.org/show_bug.cgi?id=35071 > + Disable loader limiting of requests per host for the chromium port. Bleaugh, used tabs on accident. I'll fix this. Do I need to R- this patch? Or should I just let a reviewer do that for me? > + > + No tests because we're only changing a constant. > + > + * platform/network/chromium/ResourceRequest.cpp: > + (WebCore::initializeMaximumHTTPConnectionCountPerHost): > + > 2010-02-16 Simon Fraser <simon.fraser@apple.com> > > Reviewed by Dan Bernstein. > diff --git a/WebCore/platform/network/chromium/ResourceRequest.cpp b/WebCore/platform/network/chromium/ResourceRequest.cpp > index 5b27c1b..016bd34 100644 > --- a/WebCore/platform/network/chromium/ResourceRequest.cpp > +++ b/WebCore/platform/network/chromium/ResourceRequest.cpp > @@ -31,7 +31,10 @@ namespace WebCore { > // This is used by the loader to control the number of issued parallel load requests. > unsigned initializeMaximumHTTPConnectionCountPerHost() > { > - return 6; > + // The chromium network stack already handles limiting the number of > + // parallel requests per host, so there's no need to do it here. Therefore, > + // this is set to a high value that should never be hit in practice. > + return 10000; > } > > } // namespace WebCore 191446 8 48966 abarth 2010-02-18 00:08:21 -0800 Comment on attachment 48966 Disable webkit loader limiting of requests per host for the chromium port. As noted above, this patch as tabs and there's a non-tab version attached. In the future, you should feel free to mark your old patches obsolete when uploading new versions. You might be interested in trying the WebKitTools/Scripts/webkit-patch upload command, which will do that automagically for you. 191448 9 48968 abarth 2010-02-18 00:09:15 -0800 Comment on attachment 48968 Disable loader limiting of requests per host for the chromium port. We often add tests when changing constants. However, in this case, I don't believe this change is testable. Thanks for the patch. 191478 10 48968 commit-queue 2010-02-18 01:10:59 -0800 Comment on attachment 48968 Disable loader limiting of requests per host for the chromium port. Clearing flags on attachment: 48968 Committed r54946: <http://trac.webkit.org/changeset/54946> 191479 11 commit-queue 2010-02-18 01:11:03 -0800 All reviewed patches have been landed. Closing bug. 191626 12 willchan 2010-02-18 09:08:22 -0800 Thanks for the review Adam. And sorry for the newbie mistakes. Perhaps this is the wrong place to ask it, but how do I mark the patch as obsolete? It's not clear to me from the interface. Or is that the same thing setting the review flag to '-'? Also, does webkit-patch work with git? I didn't see webkit-patch mentioned at all in http://webkit.org/coding/contributing.html. Is that page out of date? Anyway, I'll try out webkit-patch on my next patch. Thanks for the advice. 191676 13 eric 2010-02-18 11:21:07 -0800 Yes, that page is somewhat out of date given how many people use webkit-patch these days. You should look at webkit-patch help for more information and feel free to post patches to the contributing.html page if you see fit. 48964 2010-02-17 21:01:08 -0800 2010-02-17 21:02:30 -0800 Disable loader limiting of requests per host for the chromium port. ChangeLog.-Edit-comments-too..patch text/plain 1413 willchan ZGI2NWFmZTdhODM5NWEzMmJlMDIwYWNkMWQ4ZDdiODUyODEzZGQ1MApkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4ZjZiNDUwLi5iM2I2Mjgx IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEwLTAyLTE3ICBXaWxsaWFtIENoYW4gIDx3aWxsY2hhbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKwlodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzUwNzEKKwlEaXNhYmxlIGxvYWRl ciBsaW1pdGluZyBvZiByZXF1ZXN0cyBwZXIgaG9zdCBmb3IgdGhlIGNocm9taXVtIHBvcnQuCisK KyAgICAgICAgTm8gdGVzdHMgYmVjYXVzZSB3ZSdyZSBvbmx5IGNoYW5naW5nIGEgY29uc3RhbnQu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2Nocm9taXVtL1Jlc291cmNlUmVxdWVzdC5j cHA6CisgICAgICAgIChXZWJDb3JlOjppbml0aWFsaXplTWF4aW11bUhUVFBDb25uZWN0aW9uQ291 bnRQZXJIb3N0KToKKwogMjAxMC0wMi0xNiAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2Nocm9taXVtL1Jlc291cmNlUmVxdWVzdC5jcHAg Yi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2hyb21pdW0vUmVzb3VyY2VSZXF1ZXN0LmNwcApp bmRleCBlNjAyODg1Li4wMTZiZDM0IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY2hyb21pdW0vUmVzb3VyY2VSZXF1ZXN0LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvY2hyb21pdW0vUmVzb3VyY2VSZXF1ZXN0LmNwcApAQCAtMzIsOCArMzIsOSBAQCBuYW1l c3BhY2UgV2ViQ29yZSB7CiB1bnNpZ25lZCBpbml0aWFsaXplTWF4aW11bUhUVFBDb25uZWN0aW9u Q291bnRQZXJIb3N0KCkKIHsKICAgICAvLyBUaGUgY2hyb21pdW0gbmV0d29yayBzdGFjayBhbHJl YWR5IGhhbmRsZXMgbGltaXRpbmcgdGhlIG51bWJlciBvZgotICAgIC8vIHBhcmFsbGVsIHJlcXVl c3RzIHBlciBob3N0LCBzbyB0aGVyZSdzIG5vIG5lZWQgdG8gZG8gaXQgaGVyZS4KLSAgICByZXR1 cm4gMSA8PCAzMDsKKyAgICAvLyBwYXJhbGxlbCByZXF1ZXN0cyBwZXIgaG9zdCwgc28gdGhlcmUn cyBubyBuZWVkIHRvIGRvIGl0IGhlcmUuICBUaGVyZWZvcmUsCisgICAgLy8gdGhpcyBpcyBzZXQg dG8gYSBoaWdoIHZhbHVlIHRoYXQgc2hvdWxkIG5ldmVyIGJlIGhpdCBpbiBwcmFjdGljZS4KKyAg ICByZXR1cm4gMTAwMDA7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK 48965 2010-02-17 21:03:08 -0800 2010-02-17 21:03:08 -0800 Disable webkit loader throttling of requests per host for the chromium port. Disable-webkit-loader-throttling-of-requests-per-host-for-the-chromium-port..patch text/plain 708 willchan N2EyNDA5NzAzMjE1ZWNkYTE2YjBiNGNlOGNjMjQ3MTlmNzEzZjI0NQpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL2Nocm9taXVtL1Jlc291cmNlUmVxdWVzdC5jcHAgYi9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvY2hyb21pdW0vUmVzb3VyY2VSZXF1ZXN0LmNwcAppbmRleCA1 YjI3YzFiLi5lNjAyODg1IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2hy b21pdW0vUmVzb3VyY2VSZXF1ZXN0LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv Y2hyb21pdW0vUmVzb3VyY2VSZXF1ZXN0LmNwcApAQCAtMzEsNyArMzEsOSBAQCBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAvLyBUaGlzIGlzIHVzZWQgYnkgdGhlIGxvYWRlciB0byBjb250cm9sIHRoZSBu dW1iZXIgb2YgaXNzdWVkIHBhcmFsbGVsIGxvYWQgcmVxdWVzdHMuIAogdW5zaWduZWQgaW5pdGlh bGl6ZU1heGltdW1IVFRQQ29ubmVjdGlvbkNvdW50UGVySG9zdCgpCiB7Ci0gICAgcmV0dXJuIDY7 CisgICAgLy8gVGhlIGNocm9taXVtIG5ldHdvcmsgc3RhY2sgYWxyZWFkeSBoYW5kbGVzIGxpbWl0 aW5nIHRoZSBudW1iZXIgb2YKKyAgICAvLyBwYXJhbGxlbCByZXF1ZXN0cyBwZXIgaG9zdCwgc28g dGhlcmUncyBubyBuZWVkIHRvIGRvIGl0IGhlcmUuCisgICAgcmV0dXJuIDEgPDwgMzA7CiB9CiAK IH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK 48966 2010-02-17 21:07:36 -0800 2010-02-18 00:08:21 -0800 Disable webkit loader limiting of requests per host for the chromium port. Disable-webkit-loader-throttling-of-requests-per-host-for-the-chromium-port..patch text/plain 1426 willchan ZmJkYmNjMjIwMjBhZmRiZjBkNzA2Y2UxZWNmMWE0MjIwOTMxZjQzNgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4ZjZiNDUwLi5iM2I2Mjgx IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEwLTAyLTE3ICBXaWxsaWFtIENoYW4gIDx3aWxsY2hhbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKwlodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzUwNzEKKwlEaXNhYmxlIGxvYWRl ciBsaW1pdGluZyBvZiByZXF1ZXN0cyBwZXIgaG9zdCBmb3IgdGhlIGNocm9taXVtIHBvcnQuCisK KyAgICAgICAgTm8gdGVzdHMgYmVjYXVzZSB3ZSdyZSBvbmx5IGNoYW5naW5nIGEgY29uc3RhbnQu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2Nocm9taXVtL1Jlc291cmNlUmVxdWVzdC5j cHA6CisgICAgICAgIChXZWJDb3JlOjppbml0aWFsaXplTWF4aW11bUhUVFBDb25uZWN0aW9uQ291 bnRQZXJIb3N0KToKKwogMjAxMC0wMi0xNiAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2Nocm9taXVtL1Jlc291cmNlUmVxdWVzdC5jcHAg Yi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2hyb21pdW0vUmVzb3VyY2VSZXF1ZXN0LmNwcApp bmRleCA1YjI3YzFiLi4wMTZiZDM0IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY2hyb21pdW0vUmVzb3VyY2VSZXF1ZXN0LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvY2hyb21pdW0vUmVzb3VyY2VSZXF1ZXN0LmNwcApAQCAtMzEsNyArMzEsMTAgQEAgbmFt ZXNwYWNlIFdlYkNvcmUgewogLy8gVGhpcyBpcyB1c2VkIGJ5IHRoZSBsb2FkZXIgdG8gY29udHJv bCB0aGUgbnVtYmVyIG9mIGlzc3VlZCBwYXJhbGxlbCBsb2FkIHJlcXVlc3RzLiAKIHVuc2lnbmVk IGluaXRpYWxpemVNYXhpbXVtSFRUUENvbm5lY3Rpb25Db3VudFBlckhvc3QoKQogewotICAgIHJl dHVybiA2OworICAgIC8vIFRoZSBjaHJvbWl1bSBuZXR3b3JrIHN0YWNrIGFscmVhZHkgaGFuZGxl cyBsaW1pdGluZyB0aGUgbnVtYmVyIG9mCisgICAgLy8gcGFyYWxsZWwgcmVxdWVzdHMgcGVyIGhv c3QsIHNvIHRoZXJlJ3Mgbm8gbmVlZCB0byBkbyBpdCBoZXJlLiAgVGhlcmVmb3JlLAorICAgIC8v IHRoaXMgaXMgc2V0IHRvIGEgaGlnaCB2YWx1ZSB0aGF0IHNob3VsZCBuZXZlciBiZSBoaXQgaW4g cHJhY3RpY2UuCisgICAgcmV0dXJuIDEwMDAwOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl Cg== 48968 2010-02-17 21:29:38 -0800 2010-02-18 01:10:58 -0800 Disable loader limiting of requests per host for the chromium port. Disable-loader-limiting-of-requests-per-host-for-the-chromium-port..patch text/plain 1440 willchan NzRmYWYwMjQzMThjOWVlYzAwMTdiYzhkNDY1MmVhY2RjZmVhNWU5OQpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4ZjZiNDUwLi5iNTVhMDA5 IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEwLTAyLTE3ICBXaWxsaWFtIENoYW4gIDx3aWxsY2hhbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1MDcxCisgICAgICAg IERpc2FibGUgbG9hZGVyIGxpbWl0aW5nIG9mIHJlcXVlc3RzIHBlciBob3N0IGZvciB0aGUgY2hy b21pdW0gcG9ydC4KKworICAgICAgICBObyB0ZXN0cyBiZWNhdXNlIHdlJ3JlIG9ubHkgY2hhbmdp bmcgYSBjb25zdGFudC4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY2hyb21pdW0vUmVz b3VyY2VSZXF1ZXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmluaXRpYWxpemVNYXhpbXVtSFRU UENvbm5lY3Rpb25Db3VudFBlckhvc3QpOgorCiAyMDEwLTAyLTE2ICBTaW1vbiBGcmFzZXIgIDxz aW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3Rl aW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2hyb21pdW0vUmVzb3Vy Y2VSZXF1ZXN0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jaHJvbWl1bS9SZXNvdXJj ZVJlcXVlc3QuY3BwCmluZGV4IDViMjdjMWIuLjAxNmJkMzQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9jaHJvbWl1bS9SZXNvdXJjZVJlcXVlc3QuY3BwCisrKyBiL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9jaHJvbWl1bS9SZXNvdXJjZVJlcXVlc3QuY3BwCkBAIC0zMSw3 ICszMSwxMCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAvLyBUaGlzIGlzIHVzZWQgYnkgdGhlIGxv YWRlciB0byBjb250cm9sIHRoZSBudW1iZXIgb2YgaXNzdWVkIHBhcmFsbGVsIGxvYWQgcmVxdWVz dHMuIAogdW5zaWduZWQgaW5pdGlhbGl6ZU1heGltdW1IVFRQQ29ubmVjdGlvbkNvdW50UGVySG9z dCgpCiB7Ci0gICAgcmV0dXJuIDY7CisgICAgLy8gVGhlIGNocm9taXVtIG5ldHdvcmsgc3RhY2sg YWxyZWFkeSBoYW5kbGVzIGxpbWl0aW5nIHRoZSBudW1iZXIgb2YKKyAgICAvLyBwYXJhbGxlbCBy ZXF1ZXN0cyBwZXIgaG9zdCwgc28gdGhlcmUncyBubyBuZWVkIHRvIGRvIGl0IGhlcmUuICBUaGVy ZWZvcmUsCisgICAgLy8gdGhpcyBpcyBzZXQgdG8gYSBoaWdoIHZhbHVlIHRoYXQgc2hvdWxkIG5l dmVyIGJlIGhpdCBpbiBwcmFjdGljZS4KKyAgICByZXR1cm4gMTAwMDA7CiB9CiAKIH0gLy8gbmFt ZXNwYWNlIFdlYkNvcmUK