35069 2010-02-17 19:21:20 -0800 Forward declaration of TimingFunction as a class in GraphicsLayer.h results in compile warnings 2010-02-18 14:08:31 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P3 Normal --- 0 vangelis webkit-unassigned cmarrin commit-queue simon.fraser webkit.review.bot oldest_to_newest 191362 0 vangelis 2010-02-17 19:21:20 -0800 GraphicsLayer.h contains a forward declaration of TimingFunction as: class TimingFunction However, TimingFunction is defined as a struct in: WebCore\Platform\animation\TimingFunction.h The MSVC compiler issues a warning about this. Proposed change: Change the forward declaration to read: struct TimingFunction 191365 1 48961 vangelis 2010-02-17 19:28:35 -0800 Created attachment 48961 Proposed patch 191366 2 webkit.review.bot 2010-02-17 19:29:09 -0800 Attachment 48961 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:13: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 191373 3 48961 simon.fraser 2010-02-17 20:16:13 -0800 Comment on attachment 48961 Proposed patch Remove the tabs in the Changelog, and the OOPS line. r=me 191633 4 49024 vangelis 2010-02-18 09:30:43 -0800 Created attachment 49024 Patch #2: Removed tabs from changelog and OOPS line 191637 5 49024 simon.fraser 2010-02-18 09:35:35 -0800 Comment on attachment 49024 Patch #2: Removed tabs from changelog and OOPS line r=me 191725 6 49024 commit-queue 2010-02-18 14:08:26 -0800 Comment on attachment 49024 Patch #2: Removed tabs from changelog and OOPS line Clearing flags on attachment: 49024 Committed r54987: <http://trac.webkit.org/changeset/54987> 191726 7 commit-queue 2010-02-18 14:08:31 -0800 All reviewed patches have been landed. Closing bug. 48961 2010-02-17 19:28:35 -0800 2010-02-18 09:30:43 -0800 Proposed patch forward_declaration_patch.txt text/plain 1263 vangelis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDkyMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDItMTcgIFZhbmdlbGlzIEtva2tldmlzICA8dmFuZ2VsaXNA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIENoYW5naW5nIGZvcndhcmQgZGVjbGFyYXRpb24gb2YgVGltaW5nRnVuY3Rpb24gaW4g R3JhcGhpY3NMYXllci5oIGZyb20gY2xhc3MgdG8gc3RydWN0CisgICAgICAgIHRvIG1hdGNoIGl0 cyBhY3R1YWwgZGVmaW5pdGlvbiBpbiBUaW1pbmdGdW5jdGlvbi5oCisKKwlodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzUwNjkKKworICAgICAgICBObyBuZXcgdGVzdHMu IChPT1BTISkKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuaDoK KwlDaGFuZ2UgZm9yd2FyZCBkZWNsYXJhdGlvbiBmcm9tOiBjbGFzcyBUaW1pbmdGdW5jdGlvbiB0 byBzdHJ1Y3QgVGltaW5nRnVuY3Rpb24KKwogMjAxMC0wMi0xNyAgTWFyayBSb3dlICA8bXJvd2VA YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmgJKHJldmlzaW9uIDU0OTExKQor KysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmgJKHdvcmtpbmcgY29w eSkKQEAgLTc0LDcgKzc0LDcgQEAgY2xhc3MgRmxvYXRQb2ludDNEOwogY2xhc3MgR3JhcGhpY3ND b250ZXh0OwogY2xhc3MgSW1hZ2U7CiBjbGFzcyBUZXh0U3RyZWFtOwotY2xhc3MgVGltaW5nRnVu Y3Rpb247CitzdHJ1Y3QgVGltaW5nRnVuY3Rpb247CiAKIC8vIEJhc2UgY2xhc3MgZm9yIGFuaW1h dGlvbiB2YWx1ZXMgKGFsc28gdXNlZCBmb3IgdHJhbnNpdGlvbnMpLiBIZXJlIHRvCiAvLyByZXBy ZXNlbnQgdmFsdWVzIGZvciBwcm9wZXJ0aWVzIGJlaW5nIGFuaW1hdGVkIHZpYSB0aGUgR3JhcGhp Y3NMYXllciwK 49024 2010-02-18 09:30:43 -0800 2010-02-18 14:08:26 -0800 Patch #2: Removed tabs from changelog and OOPS line forward_declaration_patch_2.txt text/plain 1262 vangelis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NDkyMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDItMTcgIFZhbmdlbGlzIEtva2tldmlzICA8dmFuZ2VsaXNA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIENoYW5naW5nIGZvcndhcmQgZGVjbGFyYXRpb24gb2YgVGltaW5nRnVuY3Rpb24gaW4g R3JhcGhpY3NMYXllci5oIGZyb20KKyAgICAgICAgY2xhc3MgdG8gc3RydWN0IHRvIG1hdGNoIGl0 cyBhY3R1YWwgZGVmaW5pdGlvbiBpbiBUaW1pbmdGdW5jdGlvbi5oCisKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1MDY5CisKKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuaDoKKyAgICAgICAgICAgQ2hhbmdlIGZvcndh cmQgZGVjbGFyYXRpb24gZnJvbTogY2xhc3MgVGltaW5nRnVuY3Rpb24gdG86CisgICAgICAgICAg IHN0cnVjdCBUaW1pbmdGdW5jdGlvbgorCiAyMDEwLTAyLTE3ICBNYXJrIFJvd2UgIDxtcm93ZUBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuaAkocmV2aXNpb24gNTQ5MTEpCisr KyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuaAkod29ya2luZyBjb3B5 KQpAQCAtNzQsNyArNzQsNyBAQCBjbGFzcyBGbG9hdFBvaW50M0Q7CiBjbGFzcyBHcmFwaGljc0Nv bnRleHQ7CiBjbGFzcyBJbWFnZTsKIGNsYXNzIFRleHRTdHJlYW07Ci1jbGFzcyBUaW1pbmdGdW5j dGlvbjsKK3N0cnVjdCBUaW1pbmdGdW5jdGlvbjsKIAogLy8gQmFzZSBjbGFzcyBmb3IgYW5pbWF0 aW9uIHZhbHVlcyAoYWxzbyB1c2VkIGZvciB0cmFuc2l0aW9ucykuIEhlcmUgdG8KIC8vIHJlcHJl c2VudCB2YWx1ZXMgZm9yIHByb3BlcnRpZXMgYmVpbmcgYW5pbWF0ZWQgdmlhIHRoZSBHcmFwaGlj c0xheWVyLAo=