35064 2010-02-17 17:45:38 -0800 windowless plugins don't get button press events for right mouse button 2010-02-19 16:56:19 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED DUPLICATE 29177 P2 Normal --- 0 bjt23 webkit-unassigned oldest_to_newest 191328 0 bjt23 2010-02-17 17:45:38 -0800 I'm not getting any button press events for right clicks in my windowless plugin. Interestingly, I do get button *release* for the right button, just no press. I'm digging around, but I'm not sure if I'm looking in the right place. The behavior seems weird: I added some printfs to PlatformMouseEvent's constructor, and I see that for a right press, *two* PlatformMouseEvents get generated (whereas for left or middle press, only one gets generated). Looking at dom/MouseEvent, it looks like initMouseEvent() never gets called (for *any* button press), so I think I'm not understanding how this works. Any ideas as for the right place to look would be appreciated. I've looked around in page/gtk/EventHandlerGtk.cpp, but nothing is jumping out at me there. 191356 1 48958 bjt23 2010-02-17 18:45:20 -0800 Created attachment 48958 don't drop right mouse press events if the frame doesn't handle them Ok, I think I figured it out. The gtk WebKitWebView button-press-event handler was dropping the right press if EventHandler::sendContextMenuEvent() chose not to handle the event (which is the case when you right-click over a windowless plugin). I *think* the correct behavior is that the button-press-event handler should handle the event as usual if webkit_web_view_forward_context_menu_event() returns FALSE. This patch does just that. 191357 2 48959 bjt23 2010-02-17 18:47:12 -0800 Created attachment 48959 previous patch + style fix Of course I notice the style issue *right* after I click submit. Fixed. 191560 3 48959 gustavo 2010-02-18 06:10:10 -0800 Comment on attachment 48959 previous patch + style fix hmm, so, this is related to this other patch: https://bugs.webkit.org/show_bug.cgi?id=29177 Can you test if that patch fixes the issue for you? It would be good to add layout testing to this. 191696 4 bjt23 2010-02-18 12:20:33 -0800 Yes, that patch works as well, and from my reading of it appears to be more correct too. *** This bug has been marked as a duplicate of bug 29177 *** 48958 2010-02-17 18:45:20 -0800 2010-02-17 18:47:12 -0800 don't drop right mouse press events if the frame doesn't handle them fix-right-press-event-windowless.diff text/plain 1620 bjt23 ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggNDE3YTEwYS4uMDg1NThkYiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wMi0xNyAg QnJpYW4gVGFycmljb25lICA8YnJpYW5Aa2FrYWkuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtndGtdIGZpeCByaWdodCBtb3VzZSBwcmVzcyBi ZWluZyBkcm9wcGVkIHdoZW4gbm8gY29udGV4dCBtZW51CisKKyAgICAgICAgVGhpcyBicm9rZSBl dmVudCBmb3J3YXJkaW5nIGZvciB3aW5kb3dsZXNzIHBsdWdpbnMsIHNvIHRoZQorICAgICAgICBw bHVnaW4gd291bGQgZ2V0IGEgcmlnaHQgbW91c2UgcmVsZWFzZSBidXQgbm8gcmlnaHQgbW91c2UK KyAgICAgICAgcHJlc3MgYmVmb3JlIGl0LiAgVGhlIGZpeCBpcyB0byBhbGxvdyByaWdodCBtb3Vz ZSBwcmVzcyBldmVudHMKKyAgICAgICAgdG8gYmUgcHJvY2Vzc2VkIGFzIG5vcm1hbCBpZiB0aGUg Y29udGV4dCBtZW51IGhhbmRsZXIgZG9lc24ndAorICAgICAgICBoYW5kbGUgdGhlIGV2ZW50cy4K KworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzUwNjQK KworICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdF93 ZWJfdmlld19idXR0b25fcHJlc3NfZXZlbnQpOgorCiAyMDEwLTAyLTE3ICBYYW4gTG9wZXogIDx4 bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHdXN0YXZvIE5vcm9uaGEu CmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCBiL1dlYktp dC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCmluZGV4IGQ2YThiODMuLjEzNzQ1ZTkgMTAw NjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisrKyBiL1dlYktp dC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCkBAIC01MzAsOCArNTMwLDEwIEBAIHN0YXRp YyBnYm9vbGVhbiB3ZWJraXRfd2ViX3ZpZXdfYnV0dG9uX3ByZXNzX2V2ZW50KEd0a1dpZGdldCog d2lkZ2V0LCBHZGtFdmVudEJ1CiAgICAgLy8gRklYTUU6IG5lZWQgdG8ga2VlcCB0cmFjayBvZiBz dWJmcmFtZSBmb2N1cyBmb3Iga2V5IGV2ZW50cwogICAgIGd0a193aWRnZXRfZ3JhYl9mb2N1cyh3 aWRnZXQpOwogCi0gICAgaWYgKGV2ZW50LT5idXR0b24gPT0gMykKLSAgICAgICAgcmV0dXJuIHdl YmtpdF93ZWJfdmlld19mb3J3YXJkX2NvbnRleHRfbWVudV9ldmVudCh3ZWJWaWV3LCBQbGF0Zm9y bU1vdXNlRXZlbnQoZXZlbnQpKTsKKyAgICBpZiAoZXZlbnQtPmJ1dHRvbiA9PSAzKSB7CisgICAg ICAgIGlmKHdlYmtpdF93ZWJfdmlld19mb3J3YXJkX2NvbnRleHRfbWVudV9ldmVudCh3ZWJWaWV3 LCBQbGF0Zm9ybU1vdXNlRXZlbnQoZXZlbnQpKSkKKyAgICAgICAgICAgIHJldHVybiBUUlVFOwor ICAgIH0KIAogICAgIEZyYW1lKiBmcmFtZSA9IGNvcmUod2ViVmlldyktPm1haW5GcmFtZSgpOwog ICAgIGlmICghZnJhbWUtPnZpZXcoKSkK 48959 2010-02-17 18:47:12 -0800 2010-02-19 16:56:19 -0800 previous patch + style fix fix-right-press-event-windowless-v2.diff text/plain 1621 bjt23 ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggNDE3YTEwYS4uMDg1NThkYiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wMi0xNyAg QnJpYW4gVGFycmljb25lICA8YnJpYW5Aa2FrYWkuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtndGtdIGZpeCByaWdodCBtb3VzZSBwcmVzcyBi ZWluZyBkcm9wcGVkIHdoZW4gbm8gY29udGV4dCBtZW51CisKKyAgICAgICAgVGhpcyBicm9rZSBl dmVudCBmb3J3YXJkaW5nIGZvciB3aW5kb3dsZXNzIHBsdWdpbnMsIHNvIHRoZQorICAgICAgICBw bHVnaW4gd291bGQgZ2V0IGEgcmlnaHQgbW91c2UgcmVsZWFzZSBidXQgbm8gcmlnaHQgbW91c2UK KyAgICAgICAgcHJlc3MgYmVmb3JlIGl0LiAgVGhlIGZpeCBpcyB0byBhbGxvdyByaWdodCBtb3Vz ZSBwcmVzcyBldmVudHMKKyAgICAgICAgdG8gYmUgcHJvY2Vzc2VkIGFzIG5vcm1hbCBpZiB0aGUg Y29udGV4dCBtZW51IGhhbmRsZXIgZG9lc24ndAorICAgICAgICBoYW5kbGUgdGhlIGV2ZW50cy4K KworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzUwNjQK KworICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdF93 ZWJfdmlld19idXR0b25fcHJlc3NfZXZlbnQpOgorCiAyMDEwLTAyLTE3ICBYYW4gTG9wZXogIDx4 bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHdXN0YXZvIE5vcm9uaGEu CmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCBiL1dlYktp dC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCmluZGV4IGQ2YThiODMuLmQ2ZDYyOTAgMTAw NjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisrKyBiL1dlYktp dC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCkBAIC01MzAsOCArNTMwLDEwIEBAIHN0YXRp YyBnYm9vbGVhbiB3ZWJraXRfd2ViX3ZpZXdfYnV0dG9uX3ByZXNzX2V2ZW50KEd0a1dpZGdldCog d2lkZ2V0LCBHZGtFdmVudEJ1CiAgICAgLy8gRklYTUU6IG5lZWQgdG8ga2VlcCB0cmFjayBvZiBz dWJmcmFtZSBmb2N1cyBmb3Iga2V5IGV2ZW50cwogICAgIGd0a193aWRnZXRfZ3JhYl9mb2N1cyh3 aWRnZXQpOwogCi0gICAgaWYgKGV2ZW50LT5idXR0b24gPT0gMykKLSAgICAgICAgcmV0dXJuIHdl YmtpdF93ZWJfdmlld19mb3J3YXJkX2NvbnRleHRfbWVudV9ldmVudCh3ZWJWaWV3LCBQbGF0Zm9y bU1vdXNlRXZlbnQoZXZlbnQpKTsKKyAgICBpZiAoZXZlbnQtPmJ1dHRvbiA9PSAzKSB7CisgICAg ICAgIGlmICh3ZWJraXRfd2ViX3ZpZXdfZm9yd2FyZF9jb250ZXh0X21lbnVfZXZlbnQod2ViVmll dywgUGxhdGZvcm1Nb3VzZUV2ZW50KGV2ZW50KSkpCisgICAgICAgICAgICByZXR1cm4gVFJVRTsK KyAgICB9CiAKICAgICBGcmFtZSogZnJhbWUgPSBjb3JlKHdlYlZpZXcpLT5tYWluRnJhbWUoKTsK ICAgICBpZiAoIWZyYW1lLT52aWV3KCkpCg==