35058 2010-02-17 14:29:40 -0800 Chromium: WebDocument should provide access to the title. 2010-02-18 01:27:14 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jcampan jcampan commit-queue fishd oldest_to_newest 191217 0 jcampan 2010-02-17 14:29:40 -0800 WebDocument should have a title() method that returns the document title. 191223 1 48939 jcampan 2010-02-17 14:35:51 -0800 Created attachment 48939 Exposing the title in WebDocument. 191296 2 48939 ariya.hidayat 2010-02-17 16:43:22 -0800 Comment on attachment 48939 Exposing the title in WebDocument. LGTM. 191298 3 48939 fishd 2010-02-17 16:53:18 -0800 Comment on attachment 48939 Exposing the title in WebDocument. > Index: WebKit/chromium/ChangeLog > + Reviewed by NOBODY (OOPS!). > + > + Exposing the title in WebDocument. > + ^^^ The ChangeLog should have a bug link. Otherwise, LGTM. Please upload a revised patch for the commit queue :) -Darin 191301 4 48948 jcampan 2010-02-17 17:02:57 -0800 Created attachment 48948 Adding bug to ChangeLog 191453 5 48948 abarth 2010-02-18 00:18:24 -0800 Comment on attachment 48948 Adding bug to ChangeLog Forwarding fishd's R+. 191484 6 48948 commit-queue 2010-02-18 01:27:09 -0800 Comment on attachment 48948 Adding bug to ChangeLog Clearing flags on attachment: 48948 Committed r54948: <http://trac.webkit.org/changeset/54948> 191485 7 commit-queue 2010-02-18 01:27:14 -0800 All reviewed patches have been landed. Closing bug. 48939 2010-02-17 14:35:51 -0800 2010-02-17 17:02:57 -0800 Exposing the title in WebDocument. title.patch text/plain 1662 jcampan SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA1NDkxMCkKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMi0xNyAgSmF5 IENhbXBhbiAgPGpjYW1wYW5AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBFeHBvc2luZyB0aGUgdGl0bGUgaW4gV2ViRG9jdW1lbnQu CisKKyAgICAgICAgKiBwdWJsaWMvV2ViRG9jdW1lbnQuaDoKKyAgICAgICAgKiBzcmMvV2ViRG9j dW1lbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJEb2N1bWVudDo6dGl0bGUpOgorCiAyMDEw LTAyLTE3ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBPbGl2ZXIgSHVudC4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRG9j dW1lbnQuaA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRG9jdW1l bnQuaAkocmV2aXNpb24gNTQ5MDQpCisrKyBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRvY3Vt ZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTY1LDYgKzY1LDcgQEAgcHVibGljOgogICAgIFdFQktJ VF9BUEkgV2ViRWxlbWVudCBkb2N1bWVudEVsZW1lbnQoKSBjb25zdDsKICAgICBXRUJLSVRfQVBJ IFdlYkVsZW1lbnQgYm9keSgpIGNvbnN0OwogICAgIFdFQktJVF9BUEkgV2ViRWxlbWVudCBoZWFk KCk7CisgICAgV0VCS0lUX0FQSSBXZWJTdHJpbmcgdGl0bGUoKSBjb25zdDsKICAgICBXRUJLSVRf QVBJIFdlYk5vZGVDb2xsZWN0aW9uIGFsbCgpOwogICAgIFdFQktJVF9BUEkgV2ViVVJMIGNvbXBs ZXRlVVJMKGNvbnN0IFdlYlN0cmluZyYpIGNvbnN0OwogICAgIFdFQktJVF9BUEkgV2ViRWxlbWVu dCBnZXRFbGVtZW50QnlJZChjb25zdCBXZWJTdHJpbmcmIGlkKSBjb25zdDsKSW5kZXg6IFdlYktp dC9jaHJvbWl1bS9zcmMvV2ViRG9jdW1lbnQuY3BwDQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViS2l0L2No cm9taXVtL3NyYy9XZWJEb2N1bWVudC5jcHAJKHJldmlzaW9uIDU0OTA0KQorKysgV2ViS2l0L2No cm9taXVtL3NyYy9XZWJEb2N1bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk4LDYgKzk4LDEx IEBAIFdlYkVsZW1lbnQgV2ViRG9jdW1lbnQ6OmhlYWQoKQogICAgIHJldHVybiBXZWJFbGVtZW50 KHVud3JhcDxEb2N1bWVudD4oKS0+aGVhZCgpKTsKIH0KIAorV2ViU3RyaW5nIFdlYkRvY3VtZW50 Ojp0aXRsZSgpIGNvbnN0Cit7CisgICAgcmV0dXJuIFdlYlN0cmluZyhjb25zdFVud3JhcDxEb2N1 bWVudD4oKS0+dGl0bGUoKSk7Cit9CisKIFdlYk5vZGVDb2xsZWN0aW9uIFdlYkRvY3VtZW50Ojph bGwoKQogewogICAgIHJldHVybiBXZWJOb2RlQ29sbGVjdGlvbih1bndyYXA8RG9jdW1lbnQ+KCkt PmFsbCgpKTsK 48948 2010-02-17 17:02:57 -0800 2010-02-18 01:27:09 -0800 Adding bug to ChangeLog title.patch text/plain 1727 jcampan SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA1NDkxMCkKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMi0xNyAgSmF5 IENhbXBhbiAgPGpjYW1wYW5AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBFeHBvc2luZyB0aGUgdGl0bGUgaW4gV2ViRG9jdW1lbnQu CisgICAgICAgIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzUwNTgKKworICAgICAgICAqIHB1YmxpYy9XZWJEb2N1bWVudC5oOgorICAgICAgICAqIHNy Yy9XZWJEb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkRvY3VtZW50Ojp0aXRsZSk6 CisKIDIwMTAtMDItMTcgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJEb2N1bWVudC5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJEb2N1bWVudC5oCShyZXZpc2lvbiA1NDkwNCkKKysrIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViRG9jdW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtNjUsNiArNjUsNyBAQCBwdWJsaWM6CiAg ICAgV0VCS0lUX0FQSSBXZWJFbGVtZW50IGRvY3VtZW50RWxlbWVudCgpIGNvbnN0OwogICAgIFdF QktJVF9BUEkgV2ViRWxlbWVudCBib2R5KCkgY29uc3Q7CiAgICAgV0VCS0lUX0FQSSBXZWJFbGVt ZW50IGhlYWQoKTsKKyAgICBXRUJLSVRfQVBJIFdlYlN0cmluZyB0aXRsZSgpIGNvbnN0OwogICAg IFdFQktJVF9BUEkgV2ViTm9kZUNvbGxlY3Rpb24gYWxsKCk7CiAgICAgV0VCS0lUX0FQSSBXZWJV UkwgY29tcGxldGVVUkwoY29uc3QgV2ViU3RyaW5nJikgY29uc3Q7CiAgICAgV0VCS0lUX0FQSSBX ZWJFbGVtZW50IGdldEVsZW1lbnRCeUlkKGNvbnN0IFdlYlN0cmluZyYgaWQpIGNvbnN0OwpJbmRl eDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEb2N1bWVudC5jcHANCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBX ZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRvY3VtZW50LmNwcAkocmV2aXNpb24gNTQ5MDQpCisrKyBX ZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRvY3VtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTgs NiArOTgsMTEgQEAgV2ViRWxlbWVudCBXZWJEb2N1bWVudDo6aGVhZCgpCiAgICAgcmV0dXJuIFdl YkVsZW1lbnQodW53cmFwPERvY3VtZW50PigpLT5oZWFkKCkpOwogfQogCitXZWJTdHJpbmcgV2Vi RG9jdW1lbnQ6OnRpdGxlKCkgY29uc3QKK3sKKyAgICByZXR1cm4gV2ViU3RyaW5nKGNvbnN0VW53 cmFwPERvY3VtZW50PigpLT50aXRsZSgpKTsKK30KKwogV2ViTm9kZUNvbGxlY3Rpb24gV2ViRG9j dW1lbnQ6OmFsbCgpCiB7CiAgICAgcmV0dXJuIFdlYk5vZGVDb2xsZWN0aW9uKHVud3JhcDxEb2N1 bWVudD4oKS0+YWxsKCkpOwo=